From 2b5e2c6a408ddc0d5cf1c7ed626c1162b508c008 Mon Sep 17 00:00:00 2001 From: Kamal Mostafa Date: Mon, 24 Aug 2015 13:35:03 -0700 Subject: [PATCH] Do not enable tx-carrier for non-interactive --file sessions The logic that determined whether to 'block_input' was backwards with respect to non-interactive --file sessions, such that using --file *enabled* the tx-carrier behavior when it should have disabled it. This went unnoticed because on reasonably fast systems, reading the input data from the file never induce the timeout anyway -- only very slow machines reveal the problem: long gaps of 'mark' between each frame, as if each input character was slowly typed interactively. Fixes: ecebf01 Add ability to output a carrier while waiting for data --- src/minimodem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/minimodem.c b/src/minimodem.c index 0251d03..7cc8c46 100644 --- a/src/minimodem.c +++ b/src/minimodem.c @@ -142,7 +142,7 @@ static void fsk_transmit_stdin( {0, 0} // it_value }; - int block_input = !( tx_interactive && txcarrier ); + int block_input = tx_interactive && !txcarrier; if ( block_input ) signal(SIGALRM, tx_stop_transmit_sighandler);