From f86e207ba2d191ca937ae024ae92d9490d0a6f2d Mon Sep 17 00:00:00 2001 From: Steven Siloti Date: Sat, 15 Apr 2017 10:06:50 -0700 Subject: [PATCH] fix typo in natpmp::start Calling update_mapping() on a mapping with protocol set to none is a no-op so I'm pretty sure this check was meant to skip over such mappings. --- src/natpmp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/natpmp.cpp b/src/natpmp.cpp index 2a795d3e9..dad1a5934 100644 --- a/src/natpmp.cpp +++ b/src/natpmp.cpp @@ -135,7 +135,7 @@ void natpmp::start() for (std::vector::iterator i = m_mappings.begin() , end(m_mappings.end()); i != end; ++i) { - if (i->protocol != none + if (i->protocol == none || i->action != mapping_t::action_none) continue; i->action = mapping_t::action_add;