diff --git a/docs/todo.html b/docs/todo.html
index f54fbf624..144312885 100644
--- a/docs/todo.html
+++ b/docs/todo.html
@@ -21,7 +21,7 @@
libtorrent todo-list
-9 important
+8 important
9 relevant
16 feasible
33 notes
@@ -304,54 +304,7 @@ namespace io = libtorrent::detail;
#ifdef TORRENT_DHT_VERBOSE_LOGGING
TORRENT_DEFINE_LOG(rpc)
-| relevance 3 | include/libtorrent/thread.hpp:61 | make this interface compatible with c++11 to allow for smooth transition for platforms with support |
make this interface compatible with c++11
-to allow for smooth transition for platforms with supportinclude/libtorrent/thread.hpp:61#endif
-
-#if defined TORRENT_BEOS
-#include <kernel/OS.h>
-#endif
-
-#include <memory> // for auto_ptr required by asio
-
-#include <boost/asio/detail/thread.hpp>
-#include <boost/asio/detail/mutex.hpp>
-#include <boost/asio/detail/event.hpp>
-
-namespace libtorrent
-{
- typedef boost::asio::detail::thread thread;
- typedef boost::asio::detail::mutex mutex;
- typedef boost::asio::detail::event event;
-
- TORRENT_EXPORT void sleep(int milliseconds);
-
- struct TORRENT_EXTRA_EXPORT condition
- {
- condition();
- ~condition();
- void wait(mutex::scoped_lock& l);
- void timed_wait(mutex::scoped_lock& l, int sleep_ms);
- void signal_all(mutex::scoped_lock& l);
- private:
-#ifdef BOOST_HAS_PTHREADS
- pthread_cond_t m_cond;
-#elif defined TORRENT_WINDOWS || defined TORRENT_CYGWIN
- HANDLE m_sem;
- mutex m_mutex;
- int m_num_waiters;
-#elif defined TORRENT_BEOS
- sem_id m_sem;
- mutex m_mutex;
- int m_num_waiters;
-#else
-#error not implemented
-#endif
- };
-}
-
-#endif
-
- | ||
| relevance 3 | include/libtorrent/kademlia/dht_tracker.hpp:79 | take a udp_socket_interface here instead. Move udp_socket_interface down into libtorrent core |
take a udp_socket_interface here instead. Move udp_socket_interface down into libtorrent coreinclude/libtorrent/kademlia/dht_tracker.hpp:79 struct lazy_entry;
+ | ||
| relevance 3 | include/libtorrent/kademlia/dht_tracker.hpp:79 | take a udp_socket_interface here instead. Move udp_socket_interface down into libtorrent core |
take a udp_socket_interface here instead. Move udp_socket_interface down into libtorrent coreinclude/libtorrent/kademlia/dht_tracker.hpp:79 struct lazy_entry;
}
namespace libtorrent { namespace dht
@@ -402,7 +355,7 @@ namespace libtorrent { namespace dht
void on_name_lookup(error_code const& e
, udp::resolver::iterator host);
- | ||
| relevance 3 | include/libtorrent/kademlia/find_data.hpp:60 | rename this class to find_peers, since that's what it does find_data is an unnecessarily generic name |
rename this class to find_peers, since that's what it does
+ | ||
| relevance 3 | include/libtorrent/kademlia/find_data.hpp:60 | rename this class to find_peers, since that's what it does find_data is an unnecessarily generic name |
rename this class to find_peers, since that's what it does
find_data is an unnecessarily generic nameinclude/libtorrent/kademlia/find_data.hpp:60#include <libtorrent/kademlia/node_id.hpp>
#include <libtorrent/kademlia/routing_table.hpp>
#include <libtorrent/kademlia/rpc_manager.hpp>
@@ -454,7 +407,7 @@ private:
nodes_callback m_nodes_callback;
std::map<node_id, std::string> m_write_tokens;
node_id const m_target;
- | ||
| relevance 2 | src/session_impl.cpp:5113 | if we still can't find the torrent, we should probably look for it by url here |
if we still can't find the torrent, we should probably look for it by url heresrc/session_impl.cpp:5113 }
+ | ||
| relevance 2 | src/session_impl.cpp:5113 | if we still can't find the torrent, we should probably look for it by url here |
if we still can't find the torrent, we should probably look for it by url heresrc/session_impl.cpp:5113 }
}
#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_LOGGING || defined TORRENT_ERROR_LOGGING
else
@@ -505,7 +458,7 @@ private:
torrent_ptr->start();
#ifndef TORRENT_DISABLE_EXTENSIONS
- | ||
| relevance 2 | src/torrent.cpp:5789 | pass in ec along with the alert |
pass in ec along with the alertsrc/torrent.cpp:5789
+ | ||
| relevance 2 | src/torrent.cpp:5789 | pass in ec along with the alert |
pass in ec along with the alertsrc/torrent.cpp:5789
if (info_hash != m_torrent_file->info_hash())
{
if (alerts().should_post<metadata_failed_alert>())
@@ -556,7 +509,7 @@ private:
{
std::set<peer_connection*>::iterator p = i++;
(*p)->disconnect_if_redundant();
- | ||
| relevance 2 | src/utp_stream.cpp:617 | support the option to turn it off |
support the option to turn it offsrc/utp_stream.cpp:617 UTP_STATE_ERROR_WAIT,
+ | ||
| relevance 2 | src/utp_stream.cpp:617 | support the option to turn it off |
support the option to turn it offsrc/utp_stream.cpp:617 UTP_STATE_ERROR_WAIT,
// there are no more references to this socket
// and we can delete it
@@ -607,7 +560,7 @@ private:
#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_LOGGING || defined TORRENT_ERROR_LOGGING
int socket_impl_size() { return sizeof(utp_socket_impl); }
#endif
- | ||
| relevance 2 | src/utp_stream.cpp:1848 | we might want to do something else here as well, to resend the packet immediately without it being an MTU probe |
we might want to do something else here
+ | ||
| relevance 2 | src/utp_stream.cpp:1848 | we might want to do something else here as well, to resend the packet immediately without it being an MTU probe |
we might want to do something else here
as well, to resend the packet immediately without
it being an MTU probesrc/utp_stream.cpp:1848 , boost::uint32_t(h->timestamp_difference_microseconds), int(p->mtu_probe)
, h->extension);
@@ -660,7 +613,7 @@ it being an MTU probesrc/utp_stream.cpp:1848| relevance 2 | src/kademlia/dht_tracker.cpp:641 | fix this stats logging. For instance, the stats counters could be factored out into its own class, and dht_tracker could take an optional reference to it ++m_replies_sent[e["r"]]; m_replies_bytes_sent[e["r"]] += int(m_send_buf.size()); |
|
fix this stats logging. For instance,
+ | ||
| relevance 2 | src/kademlia/dht_tracker.cpp:641 | fix this stats logging. For instance, the stats counters could be factored out into its own class, and dht_tracker could take an optional reference to it ++m_replies_sent[e["r"]]; m_replies_bytes_sent[e["r"]] += int(m_send_buf.size()); |
fix this stats logging. For instance,
the stats counters could be factored out into its own
class, and dht_tracker could take an optional reference to it
++m_replies_sent[e["r"]];
@@ -704,7 +657,7 @@ m_replies_bytes_sent[e["r"]] += int(m_send_buf.size());src/kademlia/dht
}}
- | ||
| relevance 2 | src/kademlia/node.cpp:63 | make this configurable in dht_settings |
make this configurable in dht_settingssrc/kademlia/node.cpp:63#include "libtorrent/alert.hpp"
+ | ||
| relevance 2 | src/kademlia/node.cpp:63 | make this configurable in dht_settings |
make this configurable in dht_settingssrc/kademlia/node.cpp:63#include "libtorrent/alert.hpp"
#include "libtorrent/socket.hpp"
#include "libtorrent/random.hpp"
#include "libtorrent/aux_/session_impl.hpp"
@@ -755,7 +708,7 @@ node_impl::node_impl(alert_dispatcher* alert_disp
, udp_socket_interface* sock
, dht_settings const& settings, node_id nid, address const& external_address
, dht_observer* observer)
- | ||
| relevance 2 | include/libtorrent/torrent.hpp:1038 | this should be a deque, since time critical pieces are expected to be popped in the same order as they are sorted. The expectation is that new items are pushed back and items are popped from the front |
this should be a deque, since time critical
+ | ||
| relevance 2 | include/libtorrent/torrent.hpp:1038 | this should be a deque, since time critical pieces are expected to be popped in the same order as they are sorted. The expectation is that new items are pushed back and items are popped from the front |
this should be a deque, since time critical
pieces are expected to be popped in the same order
as they are sorted. The expectation is that new items
are pushed back and items are popped from the frontinclude/libtorrent/torrent.hpp:1038
@@ -809,7 +762,7 @@ are pushed back and items are popped from the frontinclude/libtorrent/t
// each bit represents a piece. a set bit means
// the piece has had its hash verified. This
- | ||
| relevance 2 | include/libtorrent/torrent_info.hpp:455 | these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memory |
these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memoryinclude/libtorrent/torrent_info.hpp:455 std::vector<announce_entry> m_urls;
+ | ||
| relevance 2 | include/libtorrent/torrent_info.hpp:455 | these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memory |
these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memoryinclude/libtorrent/torrent_info.hpp:455 std::vector<announce_entry> m_urls;
std::vector<web_seed_entry> m_web_seeds;
nodes_t m_nodes;
@@ -860,7 +813,7 @@ are pushed back and items are popped from the frontinclude/libtorrent/t
// this is used when creating a torrent. If there's
// only one file there are cases where it's impossible
// to know if it should be written as a multifile torrent
- | ||
| relevance 2 | include/libtorrent/kademlia/node_entry.hpp:92 | replace with a union of address_v4 and address_v6 to not waste space. This struct is instantiated hundreds of times for the routing table |
replace with a union of address_v4 and address_v6
+ | ||
| relevance 2 | include/libtorrent/kademlia/node_entry.hpp:92 | replace with a union of address_v4 and address_v6 to not waste space. This struct is instantiated hundreds of times for the routing table |
replace with a union of address_v4 and address_v6
to not waste space. This struct is instantiated hundreds of times
for the routing tableinclude/libtorrent/kademlia/node_entry.hpp:92 , id(0)
{
@@ -899,7 +852,7 @@ for the routing tableinclude/libtorrent/kademlia/node_entry.hpp:92
#endif
- | ||
| relevance 1 | src/http_seed_connection.cpp:120 | in chunked encoding mode, this assert won't hold. the chunk headers should be subtracted from the receive_buffer_size |
in chunked encoding mode, this assert won't hold.
+ | ||
| relevance 1 | src/http_seed_connection.cpp:120 | in chunked encoding mode, this assert won't hold. the chunk headers should be subtracted from the receive_buffer_size |
in chunked encoding mode, this assert won't hold.
the chunk headers should be subtracted from the receive_buffer_sizesrc/http_seed_connection.cpp:120 boost::optional<piece_block_progress>
http_seed_connection::downloading_piece_progress() const
{
@@ -951,7 +904,7 @@ the chunk headers should be subtracted from the receive_buffer_sizesrc/
std::string request;
request.reserve(400);
- | ||
| relevance 1 | src/peer_connection.cpp:2488 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
+ | ||
| relevance 1 | src/peer_connection.cpp:2488 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
all completed disk operationssrc/peer_connection.cpp:2488 }
if (is_disconnecting()) return;
@@ -1003,7 +956,7 @@ all completed disk operationssrc/peer_connection.cpp:2488 | ||
| relevance 1 | src/session_impl.cpp:5471 | report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address |
report the proper address of the router as the source IP of
+ | ||
| relevance 1 | src/session_impl.cpp:5471 | report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address |
report the proper address of the router as the source IP of
this understanding of our external address, instead of the empty addresssrc/session_impl.cpp:5471 void session_impl::on_port_mapping(int mapping, address const& ip, int port
, error_code const& ec, int map_transport)
{
@@ -1055,7 +1008,7 @@ this understanding of our external address, instead of the empty address | ||
| relevance 1 | src/session_impl.cpp:5676 | report errors as alerts |
report errors as alertssrc/session_impl.cpp:5676 }
+ | ||
| relevance 1 | src/session_impl.cpp:5676 | report errors as alerts |
report errors as alertssrc/session_impl.cpp:5676 }
void session_impl::add_dht_router(std::pair<std::string, int> const& node)
{
@@ -1106,7 +1059,7 @@ this understanding of our external address, instead of the empty address | ||
| relevance 1 | src/session_impl.cpp:6138 | we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily |
we only need to do this if our global IPv4 address has changed
+ | ||
| relevance 1 | src/session_impl.cpp:6138 | we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily |
we only need to do this if our global IPv4 address has changed
since the DHT (currently) only supports IPv4. Since restarting the DHT
is kind of expensive, it would be nice to not do it unnecessarilysrc/session_impl.cpp:6138 void session_impl::set_external_address(address const& ip
, int source_type, address const& source)
@@ -1159,7 +1112,7 @@ is kind of expensive, it would be nice to not do it unnecessarilysrc/se
#ifdef TORRENT_DISK_STATS
TORRENT_ASSERT(m_buffer_allocations >= 0);
- | ||
| relevance 1 | src/torrent.cpp:1112 | make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file |
make this depend on the error and on the filesystem the
+ | ||
| relevance 1 | src/torrent.cpp:1112 | make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file |
make this depend on the error and on the filesystem the
files are being downloaded to. If the error is no_space_left_on_device
and the filesystem doesn't support sparse files, only zero the priorities
of the pieces that are at the tails of all files, leaving everything
@@ -1214,7 +1167,7 @@ up to the highest written piece in each filesrc/torrent.cpp:1112 | ||
| relevance 1 | src/torrent.cpp:5292 | save the send_stats state instead of throwing them away it may pose an issue when downgrading though |
save the send_stats state instead of throwing them away
+ | ||
| relevance 1 | src/torrent.cpp:5292 | save the send_stats state instead of throwing them away it may pose an issue when downgrading though |
save the send_stats state instead of throwing them away
it may pose an issue when downgrading thoughsrc/torrent.cpp:5292 ? (1 << k) : 0;
bitmask.append(1, v);
TORRENT_ASSERT(bits == 8 || j == num_bitmask_bytes - 1);
@@ -1266,7 +1219,7 @@ it may pose an issue when downgrading thoughsrc/torrent.cpp:5292 | ||
| relevance 1 | src/torrent.cpp:5930 | ideally, we would disconnect the oldest connection i.e. the one that has waited the longest to connect. |
ideally, we would disconnect the oldest connection
+ | ||
| relevance 1 | src/torrent.cpp:5930 | ideally, we would disconnect the oldest connection i.e. the one that has waited the longest to connect. |
ideally, we would disconnect the oldest connection
i.e. the one that has waited the longest to connect.src/torrent.cpp:5930 if (m_ses.is_aborted())
{
p->disconnect(errors::session_closing);
@@ -1318,7 +1271,7 @@ i.e. the one that has waited the longest to connect.src/torrent.cpp:593
{
boost::shared_ptr<peer_plugin> pp((*i)->new_connection(p));
if (pp) p->add_extension(pp);
- | ||
| relevance 1 | src/torrent.cpp:6179 | should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though |
should disconnect all peers that have the pieces we have
+ | ||
| relevance 1 | src/torrent.cpp:6179 | should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though |
should disconnect all peers that have the pieces we have
not just seeds. It would be pretty expensive to check all pieces
for all peers thoughsrc/torrent.cpp:6179 }
#if defined TORRENT_DEBUG || TORRENT_RELEASE_ASSERTS
@@ -1371,7 +1324,7 @@ for all peers thoughsrc/torrent.cpp:6179| relevance 1 | src/torrent_info.cpp:187 | we might save constructing a std::String if this would take a char const* instead |
|
we might save constructing a std::String if this would take a char const* insteadsrc/torrent_info.cpp:187 {
+ | ||
| relevance 1 | src/torrent_info.cpp:187 | we might save constructing a std::String if this would take a char const* instead |
we might save constructing a std::String if this would take a char const* insteadsrc/torrent_info.cpp:187 {
tmp_path += i[0];
tmp_path += i[1];
tmp_path += i[2];
@@ -1422,7 +1375,7 @@ for all peers thoughsrc/torrent.cpp:6179| relevance 1 | src/torrent_info.cpp:366 | this logic should be a separate step done once the torrent is loaded, and the original filenames should be preserved! |
|
this logic should be a separate step
+ | ||
| relevance 1 | src/torrent_info.cpp:366 | this logic should be a separate step done once the torrent is loaded, and the original filenames should be preserved! |
this logic should be a separate step
done once the torrent is loaded, and the original
filenames should be preserved!src/torrent_info.cpp:366 }
return false;
@@ -1462,7 +1415,7 @@ filenames should be preserved!src/torrent_info.cpp:366| relevance 1 | src/torrent_info.cpp:387 | once the filename renaming is removed from here this check can be removed as well |
|
once the filename renaming is removed from here
+ | ||
| relevance 1 | src/torrent_info.cpp:387 | once the filename renaming is removed from here this check can be removed as well |
once the filename renaming is removed from here
this check can be removed as wellsrc/torrent_info.cpp:387 return false;
int cnt = 0;
@@ -1514,7 +1467,7 @@ this check can be removed as wellsrc/torrent_info.cpp:387 | ||
| relevance 1 | src/kademlia/node.cpp:690 | find_node should write directly to the response entry |
find_node should write directly to the response entrysrc/kademlia/node.cpp:690 {
+ | ||
| relevance 1 | src/kademlia/node.cpp:690 | find_node should write directly to the response entry |
find_node should write directly to the response entrysrc/kademlia/node.cpp:690 {
TORRENT_LOG(node) << " values: " << reply["values"].list().size();
}
#endif
@@ -1565,7 +1518,7 @@ this check can be removed as wellsrc/torrent_info.cpp:387 | ||
| relevance 1 | include/libtorrent/ip_voter.hpp:100 | instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc. |
instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.include/libtorrent/ip_voter.hpp:100 bloom_filter<32> m_external_address_voters;
+ | ||
| relevance 1 | include/libtorrent/ip_voter.hpp:100 | instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc. |
instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.include/libtorrent/ip_voter.hpp:100 bloom_filter<32> m_external_address_voters;
std::vector<external_ip_t> m_external_addresses;
address m_external_address;
};
@@ -1592,7 +1545,7 @@ this check can be removed as wellsrc/torrent_info.cpp:387 | ||
| relevance 1 | include/libtorrent/utp_stream.hpp:350 | implement blocking write. Low priority since it's not used (yet) |
implement blocking write. Low priority since it's not used (yet)include/libtorrent/utp_stream.hpp:350 for (typename Mutable_Buffers::const_iterator i = buffers.begin()
+ | ||
| relevance 1 | include/libtorrent/utp_stream.hpp:350 | implement blocking write. Low priority since it's not used (yet) |
implement blocking write. Low priority since it's not used (yet)include/libtorrent/utp_stream.hpp:350 for (typename Mutable_Buffers::const_iterator i = buffers.begin()
, end(buffers.end()); i != end; ++i)
{
using asio::buffer_cast;
@@ -1643,7 +1596,7 @@ this check can be removed as wellsrc/torrent_info.cpp:387 | ||
| relevance 1 | include/libtorrent/web_peer_connection.hpp:127 | if we make this be a disk_buffer_holder instead we would save a copy sometimes use allocate_disk_receive_buffer and release_disk_receive_buffer |
if we make this be a disk_buffer_holder instead
+ | ||
| relevance 1 | include/libtorrent/web_peer_connection.hpp:127 | if we make this be a disk_buffer_holder instead we would save a copy sometimes use allocate_disk_receive_buffer and release_disk_receive_buffer |
if we make this be a disk_buffer_holder instead
we would save a copy sometimes
use allocate_disk_receive_buffer and release_disk_receive_bufferinclude/libtorrent/web_peer_connection.hpp:127
private:
@@ -1694,7 +1647,7 @@ use allocate_disk_receive_buffer and release_disk_receive_bufferinclude
#endif // TORRENT_WEB_PEER_CONNECTION_HPP_INCLUDED
- | ||
| relevance 0 | src/bt_peer_connection.cpp:660 | this could be optimized using knuth morris pratt |
this could be optimized using knuth morris prattsrc/bt_peer_connection.cpp:660 if (m_encrypted && m_rc4_encrypted)
+ | ||
| relevance 0 | src/bt_peer_connection.cpp:660 | this could be optimized using knuth morris pratt |
this could be optimized using knuth morris prattsrc/bt_peer_connection.cpp:660 if (m_encrypted && m_rc4_encrypted)
{
fun = encrypt;
userdata = m_enc_handler.get();
@@ -1745,7 +1698,7 @@ use allocate_disk_receive_buffer and release_disk_receive_bufferinclude
// }
// no complete sync
- | ||
| relevance 0 | src/bt_peer_connection.cpp:1755 | don't trust this blindly |
don't trust this blindlysrc/bt_peer_connection.cpp:1755 // but where do we put that info?
+ | ||
| relevance 0 | src/bt_peer_connection.cpp:1755 | don't trust this blindly |
don't trust this blindlysrc/bt_peer_connection.cpp:1755 // but where do we put that info?
int last_seen_complete = boost::uint8_t(root.dict_find_int_value("complete_ago", -1));
if (last_seen_complete >= 0) set_last_seen_complete(last_seen_complete);
@@ -1796,7 +1749,7 @@ use allocate_disk_receive_buffer and release_disk_receive_bufferinclude
disconnect(errors::upload_upload_connection);
}
- | ||
| relevance 0 | src/bt_peer_connection.cpp:2069 | if we're finished, send upload_only message |
if we're finished, send upload_only messagesrc/bt_peer_connection.cpp:2069 if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
+ | ||
| relevance 0 | src/bt_peer_connection.cpp:2069 | if we're finished, send upload_only message |
if we're finished, send upload_only messagesrc/bt_peer_connection.cpp:2069 if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
else bitfield_string[k] = '0';
}
peer_log("==> BITFIELD [ %s ]", bitfield_string.c_str());
@@ -1847,7 +1800,7 @@ use allocate_disk_receive_buffer and release_disk_receive_bufferinclude
detail::write_address(remote().address(), out);
handshake["yourip"] = remote_address;
handshake["reqq"] = m_ses.settings().max_allowed_in_request_queue;
- | ||
| relevance 0 | src/bt_peer_connection.cpp:3308 | move the erasing into the loop above remove all payload ranges that has been sent |
move the erasing into the loop above
+ | ||
| relevance 0 | src/bt_peer_connection.cpp:3308 | move the erasing into the loop above remove all payload ranges that has been sent |
move the erasing into the loop above
remove all payload ranges that has been sentsrc/bt_peer_connection.cpp:3308 for (std::vector<range>::iterator i = m_payloads.begin();
i != m_payloads.end(); ++i)
{
@@ -1899,7 +1852,7 @@ remove all payload ranges that has been sentsrc/bt_peer_connection.cpp:
TORRENT_ASSERT(m_sent_handshake);
}
- | ||
| relevance 0 | src/file.cpp:1205 | is there any way to pre-fetch data from a file on windows? |
is there any way to pre-fetch data from a file on windows?src/file.cpp:1205
+ | ||
| relevance 0 | src/file.cpp:1205 | is there any way to pre-fetch data from a file on windows? |
is there any way to pre-fetch data from a file on windows?src/file.cpp:1205
void file::init_file()
{
if (m_page_size != 0) return;
@@ -1950,7 +1903,7 @@ remove all payload ranges that has been sentsrc/bt_peer_connection.cpp:
#ifdef TORRENT_DEBUG
if (m_open_mode & no_buffer)
{
- | ||
| relevance 0 | src/http_tracker_connection.cpp:99 | support authentication (i.e. user name and password) in the URL |
support authentication (i.e. user name and password) in the URLsrc/http_tracker_connection.cpp:99 , aux::session_impl const& ses
+ | ||
| relevance 0 | src/http_tracker_connection.cpp:99 | support authentication (i.e. user name and password) in the URL |
support authentication (i.e. user name and password) in the URLsrc/http_tracker_connection.cpp:99 , aux::session_impl const& ses
, proxy_settings const& ps
, std::string const& auth
#if TORRENT_USE_I2P
@@ -2001,7 +1954,7 @@ remove all payload ranges that has been sentsrc/bt_peer_connection.cpp:
size_t arguments_start = url.find('?');
if (arguments_start != std::string::npos)
url += "&";
- | ||
| relevance 0 | src/i2p_stream.cpp:172 | move this to proxy_base and use it in all proxies |
move this to proxy_base and use it in all proxiessrc/i2p_stream.cpp:172 {
+ | ||
| relevance 0 | src/i2p_stream.cpp:172 | move this to proxy_base and use it in all proxies |
move this to proxy_base and use it in all proxiessrc/i2p_stream.cpp:172 {
m_state = sam_idle;
std::string name = m_sam_socket->name_lookup();
@@ -2052,7 +2005,7 @@ remove all payload ranges that has been sentsrc/bt_peer_connection.cpp:
// send hello command
m_state = read_hello_response;
- | ||
| relevance 0 | src/packet_buffer.cpp:176 | use compare_less_wrap for this comparison as well |
use compare_less_wrap for this comparison as wellsrc/packet_buffer.cpp:176 while (new_size < size)
+ | ||
| relevance 0 | src/packet_buffer.cpp:176 | use compare_less_wrap for this comparison as well |
use compare_less_wrap for this comparison as wellsrc/packet_buffer.cpp:176 while (new_size < size)
new_size <<= 1;
void** new_storage = (void**)malloc(sizeof(void*) * new_size);
@@ -2103,7 +2056,7 @@ remove all payload ranges that has been sentsrc/bt_peer_connection.cpp:
if (m_storage[m_last & mask]) break;
++m_last;
m_last &= 0xffff;
- | ||
| relevance 0 | src/peer_connection.cpp:2651 | this might need something more so that once we have the metadata we can construct a full bitfield |
this might need something more
+ | ||
| relevance 0 | src/peer_connection.cpp:2651 | this might need something more so that once we have the metadata we can construct a full bitfield |
this might need something more
so that once we have the metadata
we can construct a full bitfieldsrc/peer_connection.cpp:2651
#ifdef TORRENT_VERBOSE_LOGGING
@@ -2156,7 +2109,7 @@ we can construct a full bitfieldsrc/peer_connection.cpp:2651 | ||
| relevance 0 | src/peer_connection.cpp:2782 | sort the allowed fast set in priority order |
sort the allowed fast set in priority ordersrc/peer_connection.cpp:2782 // this piece index later
+ | ||
| relevance 0 | src/peer_connection.cpp:2782 | sort the allowed fast set in priority order |
sort the allowed fast set in priority ordersrc/peer_connection.cpp:2782 // this piece index later
m_allowed_fast.push_back(index);
// if the peer has the piece and we want
@@ -2207,7 +2160,7 @@ we can construct a full bitfieldsrc/peer_connection.cpp:2651 | ||
| relevance 0 | src/peer_connection.cpp:3892 | we should probably just send a HAVE_ALL here |
we should probably just send a HAVE_ALL heresrc/peer_connection.cpp:3892 std::fill(m_recv_buffer.begin() + m_recv_pos, m_recv_buffer.end(), 0);
+ | ||
| relevance 0 | src/peer_connection.cpp:3892 | we should probably just send a HAVE_ALL here |
we should probably just send a HAVE_ALL heresrc/peer_connection.cpp:3892 std::fill(m_recv_buffer.begin() + m_recv_pos, m_recv_buffer.end(), 0);
#endif
m_packet_size = packet_size;
@@ -2258,7 +2211,7 @@ we can construct a full bitfieldsrc/peer_connection.cpp:2651 | ||
| relevance 0 | src/peer_connection.cpp:4475 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
+ | ||
| relevance 0 | src/peer_connection.cpp:4475 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
all completed disk operationssrc/peer_connection.cpp:4475 // this means we're in seed mode and we haven't yet
// verified this piece (r.piece)
t->filesystem().async_read_and_hash(r, boost::bind(&peer_connection::on_disk_read_complete
@@ -2310,7 +2263,7 @@ all completed disk operationssrc/peer_connection.cpp:4475 | ||
| relevance 0 | src/policy.cpp:857 | only allow _one_ connection to use this override at a time |
only allow _one_ connection to use this
+ | ||
| relevance 0 | src/policy.cpp:857 | only allow _one_ connection to use this override at a time |
only allow _one_ connection to use this
override at a timesrc/policy.cpp:857 " external: " << external.external_address(m_peers[candidate]->address()) <<
" t: " << (session_time - m_peers[candidate]->last_connected) <<
" ]\n";
@@ -2362,7 +2315,7 @@ override at a timesrc/policy.cpp:857| relevance 0 | src/policy.cpp:1889 | how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy |
|
how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policysrc/policy.cpp:1889#endif
+ | ||
| relevance 0 | src/policy.cpp:1889 | how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy |
how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policysrc/policy.cpp:1889#endif
, on_parole(false)
, banned(false)
#ifndef TORRENT_DISABLE_DHT
@@ -2413,7 +2366,7 @@ override at a timesrc/policy.cpp:857| relevance 0 | src/session_impl.cpp:1887 | recalculate all connect candidates for all torrents |
|
recalculate all connect candidates for all torrentssrc/session_impl.cpp:1887 m_upload_rate.close();
+ | ||
| relevance 0 | src/session_impl.cpp:1887 | recalculate all connect candidates for all torrents |
recalculate all connect candidates for all torrentssrc/session_impl.cpp:1887 m_upload_rate.close();
// #error closing the udp socket here means that
// the uTP connections cannot be closed gracefully
@@ -2464,7 +2417,7 @@ override at a timesrc/policy.cpp:857| relevance 0 | src/session_impl.cpp:4267 | allow extensions to sort torrents for queuing |
|
allow extensions to sort torrents for queuingsrc/session_impl.cpp:4267 else if (!t->is_paused())
+ | ||
| relevance 0 | src/session_impl.cpp:4267 | allow extensions to sort torrents for queuing |
allow extensions to sort torrents for queuingsrc/session_impl.cpp:4267 else if (!t->is_paused())
{
TORRENT_ASSERT(t->m_resume_data_loaded || !t->valid_metadata());
--hard_limit;
@@ -2515,7 +2468,7 @@ override at a timesrc/policy.cpp:857| relevance 0 | src/session_impl.cpp:4423 | use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections |
|
use a lower limit than m_settings.connections_limit
+ | ||
| relevance 0 | src/session_impl.cpp:4423 | use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections |
use a lower limit than m_settings.connections_limit
to allocate the to 10% or so of connection slots for incoming
connectionssrc/session_impl.cpp:4423 {
if (m_boost_connections > max_connections)
@@ -2568,7 +2521,7 @@ connectionssrc/session_impl.cpp:4423| relevance 0 | src/session_impl.cpp:4457 | make this bias configurable |
|
make this bias configurablesrc/session_impl.cpp:4457 | ||
| relevance 0 | src/session_impl.cpp:4458 | also take average_peers into account, to create a bias for downloading torrents with < average peers |
also take average_peers into account, to create a bias for downloading torrents with < average peerssrc/session_impl.cpp:4458 average_peers = num_downloads_peers / num_downloads;
+ | ||
| relevance 0 | src/session_impl.cpp:4457 | make this bias configurable |
make this bias configurablesrc/session_impl.cpp:4457 | ||
| relevance 0 | src/session_impl.cpp:4458 | also take average_peers into account, to create a bias for downloading torrents with < average peers |
also take average_peers into account, to create a bias for downloading torrents with < average peerssrc/session_impl.cpp:4458 average_peers = num_downloads_peers / num_downloads;
if (m_next_connect_torrent == m_torrents.end())
m_next_connect_torrent = m_torrents.begin();
@@ -2619,7 +2572,7 @@ connectionssrc/session_impl.cpp:4423| relevance 0 | src/session_impl.cpp:4602 | make configurable |
|
make configurablesrc/session_impl.cpp:4602
+ | ||
| relevance 0 | src/session_impl.cpp:4602 | make configurable |
make configurablesrc/session_impl.cpp:4602
#ifdef TORRENT_DEBUG
for (std::vector<peer_connection*>::const_iterator i = peers.begin()
, end(peers.end()), prev(peers.end()); i != end; ++i)
@@ -2652,7 +2605,7 @@ connectionssrc/session_impl.cpp:4423| relevance 0 | src/session_impl.cpp:4616 | make configurable |
|
make configurablesrc/session_impl.cpp:4616 >= (*i)->uploaded_since_unchoke() * 1000
+ | ||
| relevance 0 | src/session_impl.cpp:4616 | make configurable |
make configurablesrc/session_impl.cpp:4616 >= (*i)->uploaded_since_unchoke() * 1000
* (1 + t2->priority()) / total_milliseconds(unchoke_interval));
}
prev = i;
@@ -2703,7 +2656,7 @@ connectionssrc/session_impl.cpp:4423 | ||
| relevance 0 | src/storage.cpp:325 | if the read fails, set error and exit immediately |
if the read fails, set error and exit immediatelysrc/storage.cpp:325 int block_size = 16 * 1024;
+ | ||
| relevance 0 | src/storage.cpp:325 | if the read fails, set error and exit immediately |
if the read fails, set error and exit immediatelysrc/storage.cpp:325 int block_size = 16 * 1024;
if (m_storage->disk_pool()) block_size = m_storage->disk_pool()->block_size();
int size = slot_size;
int num_blocks = (size + block_size - 1) / block_size;
@@ -2754,7 +2707,7 @@ connectionssrc/session_impl.cpp:4423| relevance 0 | src/storage.cpp:358 | if the read fails, set error and exit immediately |
|
if the read fails, set error and exit immediatelysrc/storage.cpp:358 else
+ | ||
| relevance 0 | src/storage.cpp:358 | if the read fails, set error and exit immediately |
if the read fails, set error and exit immediatelysrc/storage.cpp:358 else
{
ph.h.update((char const*)bufs[i].iov_base, bufs[i].iov_len);
small_piece_size -= bufs[i].iov_len;
@@ -2805,7 +2758,7 @@ connectionssrc/session_impl.cpp:4423| relevance 0 | src/storage.cpp:623 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info |
|
make this more generic to not just work if files have been
+ | ||
| relevance 0 | src/storage.cpp:623 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance
maybe use the same format as .torrent files and reuse some code from torrent_infosrc/storage.cpp:623 for (file_iter = files().begin();;)
{
@@ -2858,7 +2811,7 @@ maybe use the same format as .torrent files and reuse some code from torrent_inf
for (int i = 0; i < file_sizes_ent->list_size(); ++i)
{
- | ||
| relevance 0 | src/storage.cpp:1192 | what if file_base is used to merge several virtual files into a single physical file? We should probably disable this if file_base is used. This is not a widely used feature though |
what if file_base is used to merge several virtual files
+ | ||
| relevance 0 | src/storage.cpp:1192 | what if file_base is used to merge several virtual files into a single physical file? We should probably disable this if file_base is used. This is not a widely used feature though |
what if file_base is used to merge several virtual files
into a single physical file? We should probably disable this
if file_base is used. This is not a widely used feature thoughsrc/storage.cpp:1192 int bytes_transferred = 0;
// if the file is opened in no_buffer mode, and the
@@ -2911,7 +2864,7 @@ if file_base is used. This is not a widely used feature thoughsrc/stora
// makes unaligned requests (and the disk cache is disabled or fully utilized
// for write cache).
- | ||
| relevance 0 | src/torrent.cpp:5025 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync |
make this more generic to not just work if files have been
+ | ||
| relevance 0 | src/torrent.cpp:5025 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance
maybe use the same format as .torrent files and reuse some code from torrent_info
The mapped_files needs to be read both in the network thread
@@ -2967,7 +2920,7 @@ which are kept in syncsrc/torrent.cpp:5025| relevance 0 | src/torrent.cpp:5161 | if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents |
|
if this is a merkle torrent and we can't
+ | ||
| relevance 0 | src/torrent.cpp:5161 | if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents |
if this is a merkle torrent and we can't
restore the tree, we need to wipe all the
bits in the have array, but not necessarily
we might want to do a full check to see if we have
@@ -3023,7 +2976,7 @@ no one uses merkle torrentssrc/torrent.cpp:5161 | ||
| relevance 0 | src/torrent.cpp:5349 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base |
make this more generic to not just work if files have been
+ | ||
| relevance 0 | src/torrent.cpp:5349 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance.
using file_basesrc/torrent.cpp:5349 entry::string_type& pieces = ret["pieces"].string();
pieces.resize(m_torrent_file->num_pieces());
@@ -3076,10 +3029,10 @@ using file_basesrc/torrent.cpp:5349| relevance 0 | src/torrent.cpp:7820 | go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece |
|
go through the pieces we have and count the total number
+ | ||
| relevance 0 | src/torrent.cpp:7823 | go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece |
go through the pieces we have and count the total number
of downloaders we have. Only count peers that are interested in us
since some peers might not send have messages for pieces we have
-it num_interested == 0, we need to pick a new piecesrc/torrent.cpp:7820 }
+it num_interested == 0, we need to pick a new piecesrc/torrent.cpp:7823 }
rarest_pieces.clear();
rarest_rarity = pp.peer_count;
@@ -3130,10 +3083,10 @@ it num_interested == 0, we need to pick a new piecesrc/torrent.cpp:7820
{
// we don't keep track of availability, do it the expensive way
// do a linear search from the first piece
- | ||
| relevance 0 | src/torrent.cpp:8047 | if there's been long enough since we requested something from this piece, request one of the backup blocks (the one with the least number of requests to it) and update the last request timestamp |
if there's been long enough since we requested something
+ | ||
| relevance 0 | src/torrent.cpp:8050 | if there's been long enough since we requested something from this piece, request one of the backup blocks (the one with the least number of requests to it) and update the last request timestamp |
if there's been long enough since we requested something
from this piece, request one of the backup blocks (the one with
the least number of requests to it) and update the last request
-timestampsrc/torrent.cpp:8047 std::vector<pending_block> const& rq = c.request_queue();
+timestampsrc/torrent.cpp:8050 std::vector<pending_block> const& rq = c.request_queue();
bool added_request = false;
@@ -3184,7 +3137,7 @@ timestampsrc/torrent.cpp:8047| relevance 0 | src/udp_tracker_connection.cpp:548 | it would be more efficient to not use a string here. however, the problem is that some trackers will respond with actual strings. For example i2p trackers |
|
it would be more efficient to not use a string here.
+ | ||
| relevance 0 | src/udp_tracker_connection.cpp:548 | it would be more efficient to not use a string here. however, the problem is that some trackers will respond with actual strings. For example i2p trackers |
it would be more efficient to not use a string here.
however, the problem is that some trackers will respond
with actual strings. For example i2p trackerssrc/udp_tracker_connection.cpp:548 }
@@ -3237,7 +3190,7 @@ with actual strings. For example i2p trackerssrc/udp_tracker_connection
{
restart_read_timeout();
int action = detail::read_int32(buf);
- | ||
| relevance 0 | include/libtorrent/config.hpp:283 | Make this count Unicode characters instead of bytes on windows |
Make this count Unicode characters instead of bytes on windowsinclude/libtorrent/config.hpp:283
+ | ||
| relevance 0 | include/libtorrent/config.hpp:283 | Make this count Unicode characters instead of bytes on windows |
Make this count Unicode characters instead of bytes on windowsinclude/libtorrent/config.hpp:283
// ==== eCS(OS/2) ===
#elif defined __OS2__
#define TORRENT_OS2
@@ -3288,7 +3241,7 @@ with actual strings. For example i2p trackerssrc/udp_tracker_connection
#include <stdarg.h>
inline int snprintf(char* buf, int len, char const* fmt, ...)
- | ||
| relevance 0 | include/libtorrent/proxy_base.hpp:152 | it would be nice to remember the bind port and bind once we know where the proxy is m_sock.bind(endpoint, ec); |
it would be nice to remember the bind port and bind once we know where the proxy is
+ | ||
| relevance 0 | include/libtorrent/proxy_base.hpp:152 | it would be nice to remember the bind port and bind once we know where the proxy is m_sock.bind(endpoint, ec); |
it would be nice to remember the bind port and bind once we know where the proxy is
m_sock.bind(endpoint, ec);include/libtorrent/proxy_base.hpp:152 {
return m_sock.set_option(opt, ec);
}
| ||