| relevance 4 | ../src/session_impl.cpp:667 | in order to support SSL over uTP, the utp_socket manager either needs to be able to receive packets on multiple ports, or we need to peek into the first few bytes the payload stream of a socket to determine whether or not it's an SSL connection. (The former is simpler but won't do as well with NATs) |
in order to support SSL over uTP, the utp_socket manager either
needs to be able to receive packets on multiple ports, or we need to
peek into the first few bytes the payload stream of a socket to determine
whether or not it's an SSL connection. (The former is simpler but won't
-do as well with NATs)../src/session_impl.cpp:663 , m_disconnect_time_scaler(90)
+do as well with NATs)../src/session_impl.cpp:667 , m_disconnect_time_scaler(90)
, m_auto_scrape_time_scaler(180)
, m_next_explicit_cache_torrent(0)
, m_cache_rotation_timer(0)
@@ -80,60 +80,7 @@ do as well with NATs)../src/session_impl.cpp:663| relevance 4 | ../src/utp_stream.cpp:2230 | There's currently no limit on how many packets we save. In the case of the client setting a download rate limit, we may store incoming packets indefinitely! Right now, we rely on the other end honoring the advertised receive window. |
|
There's currently no limit on how many packets we save. In the case of the
-client setting a download rate limit, we may store incoming packets indefinitely!
-Right now, we rely on the other end honoring the advertised receive window.../src/utp_stream.cpp:2230
- if (size == 0)
- {
- TORRENT_ASSERT(p == 0 || p->header_size == p->size);
- free(p);
- return;
- }
- }
-
- TORRENT_ASSERT(m_read_buffer_size == 0);
-
- if (!p)
- {
- TORRENT_ASSERT(buf);
- p = (packet*)malloc(sizeof(packet) + size);
- p->size = size;
- p->header_size = 0;
- memcpy(p->buf, buf, size);
- }
- // save this packet until the client issues another read
- m_receive_buffer.push_back(p);
- m_receive_buffer_size += p->size - p->header_size;
-
- check_receive_buffers();
-}
-
-bool utp_socket_impl::cancel_handlers(error_code const& ec, bool kill)
-{
- INVARIANT_CHECK;
-
- TORRENT_ASSERT(ec);
- bool ret = m_read_handler || m_write_handler || m_connect_handler;
-
- // calling the callbacks with m_userdata being 0 will just crash
- TORRENT_ASSERT((ret && bool(m_userdata)) || !ret);
-
- if (m_read_handler) m_read_handler(m_userdata, 0, ec, kill);
- m_read_handler = 0;
- if (m_write_handler) m_write_handler(m_userdata, 0, ec, kill);
- m_write_handler = 0;
- if (m_connect_handler) m_connect_handler(m_userdata, ec, kill);
- m_connect_handler = 0;
- return ret;
-}
-
-bool utp_socket_impl::consume_incoming_data(
- utp_header const* ph, boost::uint8_t const* ptr, int payload_size
- , ptime now)
-{
- INVARIANT_CHECK;
-
- | ||
| relevance 3 | ../src/torrent.cpp:6172 | if peer is a really good peer, maybe we shouldn't disconnect it |
if peer is a really good peer, maybe we shouldn't disconnect it../src/torrent.cpp:6172 return false;
+ | ||
| relevance 3 | ../src/torrent.cpp:6177 | if peer is a really good peer, maybe we shouldn't disconnect it |
if peer is a really good peer, maybe we shouldn't disconnect it../src/torrent.cpp:6177 return false;
}
TORRENT_ASSERT(m_connections.find(p) == m_connections.end());
m_connections.insert(p);
@@ -184,7 +131,7 @@ bool utp_socket_impl::consume_incoming_data(
return m_connections.size() < m_max_connections
&& !is_paused()
&& ((m_state != torrent_status::checking_files
- | ||
| relevance 3 | ../include/libtorrent/kademlia/find_data.hpp:60 | rename this class to find_peers, since that's what it does find_data is an unnecessarily generic name |
rename this class to find_peers, since that's what it does
+ | ||
| relevance 3 | ../include/libtorrent/kademlia/find_data.hpp:60 | rename this class to find_peers, since that's what it does find_data is an unnecessarily generic name |
rename this class to find_peers, since that's what it does
find_data is an unnecessarily generic name../include/libtorrent/kademlia/find_data.hpp:60#include <libtorrent/kademlia/node_id.hpp>
#include <libtorrent/kademlia/routing_table.hpp>
#include <libtorrent/kademlia/rpc_manager.hpp>
@@ -236,7 +183,7 @@ protected:
nodes_callback m_nodes_callback;
std::map<node_id, std::string> m_write_tokens;
node_id const m_target;
- | ||
| relevance 2 | ../src/torrent.cpp:8342 | will pick_pieces ever return an empty set? |
will pick_pieces ever return an empty set?../src/torrent.cpp:8342 if (added_request)
+ | ||
| relevance 2 | ../src/torrent.cpp:8347 | will pick_pieces ever return an empty set? |
will pick_pieces ever return an empty set?../src/torrent.cpp:8347 if (added_request)
{
peers_with_requests.insert(peers_with_requests.begin(), &c);
if (i->first_requested == min_time()) i->first_requested = now;
@@ -287,7 +234,7 @@ protected:
void torrent::remove_web_seed(std::string const& url, web_seed_entry::type_t type)
{
std::list<web_seed_entry>::iterator i = std::find_if(m_web_seeds.begin(), m_web_seeds.end()
- | ||
| relevance 2 | ../src/utp_stream.cpp:1862 | we might want to do something else here as well, to resend the packet immediately without it being an MTU probe |
we might want to do something else here
+ | ||
| relevance 2 | ../src/utp_stream.cpp:1862 | we might want to do something else here as well, to resend the packet immediately without it being an MTU probe |
we might want to do something else here
as well, to resend the packet immediately without
it being an MTU probe../src/utp_stream.cpp:1862// if ((rand() % 100) > 0)
#endif
@@ -340,8 +287,8 @@ it being an MTU probe../src/utp_stream.cpp:1862| relevance 2 | ../src/utp_stream.cpp:2496 | sequence number, source IP and connection ID should be verified before accepting a reset packet |
|
sequence number, source IP and connection ID should be
-verified before accepting a reset packet../src/utp_stream.cpp:2496 m_reply_micro = boost::uint32_t(total_microseconds(receive_time - min_time()))
+ | ||
| relevance 2 | ../src/utp_stream.cpp:2505 | sequence number, source IP and connection ID should be verified before accepting a reset packet |
sequence number, source IP and connection ID should be
+verified before accepting a reset packet../src/utp_stream.cpp:2505 m_reply_micro = boost::uint32_t(total_microseconds(receive_time - min_time()))
- ph->timestamp_microseconds;
boost::uint32_t prev_base = m_their_delay_hist.initialized() ? m_their_delay_hist.base() : 0;
their_delay = m_their_delay_hist.add_sample(m_reply_micro, step);
@@ -392,7 +339,7 @@ verified before accepting a reset packet../src/utp_stream.cpp:2496
, this, int(ph->ack_nr), m_seq_nr);
m_sm->inc_stats_counter(utp_socket_manager::redundant_pkts_in);
return true;
- | ||
| relevance 2 | ../src/kademlia/node.cpp:64 | make this configurable in dht_settings |
make this configurable in dht_settings../src/kademlia/node.cpp:64#include "libtorrent/socket.hpp"
+ | ||
| relevance 2 | ../src/kademlia/node.cpp:64 | make this configurable in dht_settings |
make this configurable in dht_settings../src/kademlia/node.cpp:64#include "libtorrent/socket.hpp"
#include "libtorrent/random.hpp"
#include "libtorrent/aux_/session_impl.hpp"
#include "libtorrent/kademlia/node_id.hpp"
@@ -443,7 +390,7 @@ void purge_peers(std::set<peer_entry>& peers)
void nop() {}
- | ||
| relevance 1 | ../src/http_seed_connection.cpp:120 | in chunked encoding mode, this assert won't hold. the chunk headers should be subtracted from the receive_buffer_size |
in chunked encoding mode, this assert won't hold.
+ | ||
| relevance 1 | ../src/http_seed_connection.cpp:120 | in chunked encoding mode, this assert won't hold. the chunk headers should be subtracted from the receive_buffer_size |
in chunked encoding mode, this assert won't hold.
the chunk headers should be subtracted from the receive_buffer_size../src/http_seed_connection.cpp:120 boost::optional<piece_block_progress>
http_seed_connection::downloading_piece_progress() const
{
@@ -495,7 +442,7 @@ the chunk headers should be subtracted from the receive_buffer_size../s
std::string request;
request.reserve(400);
- | ||
| relevance 1 | ../src/peer_connection.cpp:2568 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
+ | ||
| relevance 1 | ../src/peer_connection.cpp:2568 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
all completed disk operations../src/peer_connection.cpp:2568 }
if (is_disconnecting()) return;
@@ -547,8 +494,8 @@ all completed disk operations../src/peer_connection.cpp:2568 | ||
| relevance 1 | ../src/session_impl.cpp:5669 | report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address |
report the proper address of the router as the source IP of
-this understanding of our external address, instead of the empty address../src/session_impl.cpp:5669 void session_impl::on_port_mapping(int mapping, address const& ip, int port
+ | ||
| relevance 1 | ../src/session_impl.cpp:5694 | report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address |
report the proper address of the router as the source IP of
+this understanding of our external address, instead of the empty address../src/session_impl.cpp:5694 void session_impl::on_port_mapping(int mapping, address const& ip, int port
, error_code const& ec, int map_transport)
{
TORRENT_ASSERT(is_network_thread());
@@ -599,7 +546,7 @@ this understanding of our external address, instead of the empty address | ||
| relevance 1 | ../src/session_impl.cpp:5879 | report errors as alerts |
report errors as alerts../src/session_impl.cpp:5879 }
+ | ||
| relevance 1 | ../src/session_impl.cpp:5904 | report errors as alerts |
report errors as alerts../src/session_impl.cpp:5904 }
void session_impl::add_dht_router(std::pair<std::string, int> const& node)
{
@@ -650,9 +597,9 @@ this understanding of our external address, instead of the empty address | ||
| relevance 1 | ../src/session_impl.cpp:6348 | we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily |
we only need to do this if our global IPv4 address has changed
+ | ||
| relevance 1 | ../src/session_impl.cpp:6375 | we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily |
we only need to do this if our global IPv4 address has changed
since the DHT (currently) only supports IPv4. Since restarting the DHT
-is kind of expensive, it would be nice to not do it unnecessarily../src/session_impl.cpp:6348 void session_impl::set_external_address(address const& ip
+is kind of expensive, it would be nice to not do it unnecessarily../src/session_impl.cpp:6375 void session_impl::set_external_address(address const& ip
, int source_type, address const& source)
{
#if defined TORRENT_VERBOSE_LOGGING
@@ -703,7 +650,7 @@ is kind of expensive, it would be nice to not do it unnecessarily../src
#ifdef TORRENT_DISK_STATS
TORRENT_ASSERT(m_buffer_allocations >= 0);
- | ||
| relevance 1 | ../src/torrent.cpp:1161 | make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file |
make this depend on the error and on the filesystem the
+ | ||
| relevance 1 | ../src/torrent.cpp:1161 | make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file |
make this depend on the error and on the filesystem the
files are being downloaded to. If the error is no_space_left_on_device
and the filesystem doesn't support sparse files, only zero the priorities
of the pieces that are at the tails of all files, leaving everything
@@ -758,8 +705,8 @@ up to the highest written piece in each file../src/torrent.cpp:1161 | ||
| relevance 1 | ../src/torrent.cpp:5434 | save the send_stats state instead of throwing them away it may pose an issue when downgrading though |
save the send_stats state instead of throwing them away
-it may pose an issue when downgrading though../src/torrent.cpp:5434 ? (1 << k) : 0;
+ | ||
| relevance 1 | ../src/torrent.cpp:5439 | save the send_stats state instead of throwing them away it may pose an issue when downgrading though |
save the send_stats state instead of throwing them away
+it may pose an issue when downgrading though../src/torrent.cpp:5439 ? (1 << k) : 0;
bitmask.append(1, v);
TORRENT_ASSERT(bits == 8 || j == num_bitmask_bytes - 1);
}
@@ -810,9 +757,9 @@ it may pose an issue when downgrading though../src/torrent.cpp:5434 | ||
| relevance 1 | ../src/torrent.cpp:6339 | should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though |
should disconnect all peers that have the pieces we have
+ | ||
| relevance 1 | ../src/torrent.cpp:6344 | should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though |
should disconnect all peers that have the pieces we have
not just seeds. It would be pretty expensive to check all pieces
-for all peers though../src/torrent.cpp:6339 TORRENT_ASSERT(is_finished());
+for all peers though../src/torrent.cpp:6344 TORRENT_ASSERT(is_finished());
TORRENT_ASSERT(m_state != torrent_status::finished && m_state != torrent_status::seeding);
set_state(torrent_status::finished);
@@ -863,7 +810,7 @@ for all peers though../src/torrent.cpp:6339| relevance 1 | ../src/torrent_info.cpp:181 | we might save constructing a std::string if this would take a char const* instead |
|
we might save constructing a std::string if this would take a char const* instead../src/torrent_info.cpp:181 {
+ | ||
| relevance 1 | ../src/torrent_info.cpp:181 | we might save constructing a std::string if this would take a char const* instead |
we might save constructing a std::string if this would take a char const* instead../src/torrent_info.cpp:181 {
tmp_path += i[0];
tmp_path += i[1];
tmp_path += i[2];
@@ -914,7 +861,7 @@ for all peers though../src/torrent.cpp:6339| relevance 1 | ../src/torrent_info.cpp:385 | this logic should be a separate step done once the torrent is loaded, and the original filenames should be preserved! |
|
this logic should be a separate step
+ | ||
| relevance 1 | ../src/torrent_info.cpp:385 | this logic should be a separate step done once the torrent is loaded, and the original filenames should be preserved! |
this logic should be a separate step
done once the torrent is loaded, and the original
filenames should be preserved!../src/torrent_info.cpp:385
while (*s1 != 0 || *s2 != 0)
@@ -964,7 +911,7 @@ filenames should be preserved!../src/torrent_info.cpp:385 | ||
| relevance 1 | ../src/torrent_info.cpp:416 | once the filename renaming is removed from here this check can be removed as well |
once the filename renaming is removed from here
+ | ||
| relevance 1 | ../src/torrent_info.cpp:416 | once the filename renaming is removed from here this check can be removed as well |
once the filename renaming is removed from here
this check can be removed as well../src/torrent_info.cpp:416 if (!extract_single_file(*list.list_at(i), e, root_dir
, &file_hash, &fee, &mtime))
return false;
@@ -1016,7 +963,7 @@ this check can be removed as well../src/torrent_info.cpp:416 | ||
| relevance 1 | ../src/kademlia/node.cpp:739 | find_node should write directly to the response entry |
find_node should write directly to the response entry../src/kademlia/node.cpp:739 {
+ | ||
| relevance 1 | ../src/kademlia/node.cpp:739 | find_node should write directly to the response entry |
find_node should write directly to the response entry../src/kademlia/node.cpp:739 {
TORRENT_LOG(node) << " values: " << reply["values"].list().size();
}
#endif
@@ -1067,7 +1014,7 @@ this check can be removed as well../src/torrent_info.cpp:416 | ||
| relevance 1 | ../include/libtorrent/ip_voter.hpp:100 | instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc. |
instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.../include/libtorrent/ip_voter.hpp:100 bloom_filter<32> m_external_address_voters;
+ | ||
| relevance 1 | ../include/libtorrent/ip_voter.hpp:100 | instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc. |
instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.../include/libtorrent/ip_voter.hpp:100 bloom_filter<32> m_external_address_voters;
std::vector<external_ip_t> m_external_addresses;
address m_external_address;
};
@@ -1094,7 +1041,7 @@ this check can be removed as well../src/torrent_info.cpp:416 | ||
| relevance 1 | ../include/libtorrent/utp_stream.hpp:376 | implement blocking write. Low priority since it's not used (yet) |
implement blocking write. Low priority since it's not used (yet)../include/libtorrent/utp_stream.hpp:376 for (typename Mutable_Buffers::const_iterator i = buffers.begin()
+ | ||
| relevance 1 | ../include/libtorrent/utp_stream.hpp:376 | implement blocking write. Low priority since it's not used (yet) |
implement blocking write. Low priority since it's not used (yet)../include/libtorrent/utp_stream.hpp:376 for (typename Mutable_Buffers::const_iterator i = buffers.begin()
, end(buffers.end()); i != end; ++i)
{
using asio::buffer_cast;
@@ -1145,7 +1092,7 @@ this check can be removed as well../src/torrent_info.cpp:416 | ||
| relevance 1 | ../include/libtorrent/web_peer_connection.hpp:127 | if we make this be a disk_buffer_holder instead we would save a copy sometimes use allocate_disk_receive_buffer and release_disk_receive_buffer |
if we make this be a disk_buffer_holder instead
+ | ||
| relevance 1 | ../include/libtorrent/web_peer_connection.hpp:127 | if we make this be a disk_buffer_holder instead we would save a copy sometimes use allocate_disk_receive_buffer and release_disk_receive_buffer |
if we make this be a disk_buffer_holder instead
we would save a copy sometimes
use allocate_disk_receive_buffer and release_disk_receive_buffer../include/libtorrent/web_peer_connection.hpp:127
private:
@@ -1196,7 +1143,7 @@ use allocate_disk_receive_buffer and release_disk_receive_buffer../incl
#endif // TORRENT_WEB_PEER_CONNECTION_HPP_INCLUDED
- | ||
| relevance 0 | ../src/bt_peer_connection.cpp:655 | this could be optimized using knuth morris pratt |
this could be optimized using knuth morris pratt../src/bt_peer_connection.cpp:655 if (m_encrypted && m_rc4_encrypted)
+ | ||
| relevance 0 | ../src/bt_peer_connection.cpp:655 | this could be optimized using knuth morris pratt |
this could be optimized using knuth morris pratt../src/bt_peer_connection.cpp:655 if (m_encrypted && m_rc4_encrypted)
{
fun = encrypt;
userdata = m_enc_handler.get();
@@ -1247,7 +1194,7 @@ use allocate_disk_receive_buffer and release_disk_receive_buffer../incl
// }
// no complete sync
- | ||
| relevance 0 | ../src/bt_peer_connection.cpp:2074 | if we're finished, send upload_only message |
if we're finished, send upload_only message../src/bt_peer_connection.cpp:2074 if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
+ | ||
| relevance 0 | ../src/bt_peer_connection.cpp:2074 | if we're finished, send upload_only message |
if we're finished, send upload_only message../src/bt_peer_connection.cpp:2074 if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
else bitfield_string[k] = '0';
}
peer_log("==> BITFIELD [ %s ]", bitfield_string.c_str());
@@ -1298,7 +1245,7 @@ use allocate_disk_receive_buffer and release_disk_receive_buffer../incl
std::back_insert_iterator<std::string> out(remote_address);
detail::write_address(remote().address(), out);
handshake["yourip"] = remote_address;
- | ||
| relevance 0 | ../src/bt_peer_connection.cpp:3316 | move the erasing into the loop above remove all payload ranges that has been sent |
move the erasing into the loop above
+ | ||
| relevance 0 | ../src/bt_peer_connection.cpp:3316 | move the erasing into the loop above remove all payload ranges that has been sent |
move the erasing into the loop above
remove all payload ranges that has been sent../src/bt_peer_connection.cpp:3316 for (std::vector<range>::iterator i = m_payloads.begin();
i != m_payloads.end(); ++i)
{
@@ -1350,7 +1297,7 @@ remove all payload ranges that has been sent../src/bt_peer_connection.c
TORRENT_ASSERT(m_sent_handshake);
}
- | ||
| relevance 0 | ../src/file.cpp:1327 | is there any way to pre-fetch data from a file on windows? |
is there any way to pre-fetch data from a file on windows?../src/file.cpp:1327
+ | ||
| relevance 0 | ../src/file.cpp:1327 | is there any way to pre-fetch data from a file on windows? |
is there any way to pre-fetch data from a file on windows?../src/file.cpp:1327
void file::init_file()
{
if (m_page_size != 0) return;
@@ -1401,7 +1348,7 @@ remove all payload ranges that has been sent../src/bt_peer_connection.c
#ifdef TORRENT_DEBUG
if (m_open_mode & no_buffer)
{
- | ||
| relevance 0 | ../src/http_tracker_connection.cpp:99 | support authentication (i.e. user name and password) in the URL |
support authentication (i.e. user name and password) in the URL../src/http_tracker_connection.cpp:99 , aux::session_impl const& ses
+ | ||
| relevance 0 | ../src/http_tracker_connection.cpp:99 | support authentication (i.e. user name and password) in the URL |
support authentication (i.e. user name and password) in the URL../src/http_tracker_connection.cpp:99 , aux::session_impl const& ses
, proxy_settings const& ps
, std::string const& auth
#if TORRENT_USE_I2P
@@ -1452,7 +1399,7 @@ remove all payload ranges that has been sent../src/bt_peer_connection.c
size_t arguments_start = url.find('?');
if (arguments_start != std::string::npos)
url += "&";
- | ||
| relevance 0 | ../src/i2p_stream.cpp:181 | move this to proxy_base and use it in all proxies |
move this to proxy_base and use it in all proxies../src/i2p_stream.cpp:181 {
+ | ||
| relevance 0 | ../src/i2p_stream.cpp:181 | move this to proxy_base and use it in all proxies |
move this to proxy_base and use it in all proxies../src/i2p_stream.cpp:181 {
m_state = sam_idle;
std::string name = m_sam_socket->name_lookup();
@@ -1503,7 +1450,7 @@ remove all payload ranges that has been sent../src/bt_peer_connection.c
void i2p_stream::connected(error_code const& e, boost::shared_ptr<handler_type> h)
{
#if defined TORRENT_ASIO_DEBUGGING
- | ||
| relevance 0 | ../src/packet_buffer.cpp:176 | use compare_less_wrap for this comparison as well |
use compare_less_wrap for this comparison as well../src/packet_buffer.cpp:176 while (new_size < size)
+ | ||
| relevance 0 | ../src/packet_buffer.cpp:176 | use compare_less_wrap for this comparison as well |
use compare_less_wrap for this comparison as well../src/packet_buffer.cpp:176 while (new_size < size)
new_size <<= 1;
void** new_storage = (void**)malloc(sizeof(void*) * new_size);
@@ -1554,7 +1501,7 @@ remove all payload ranges that has been sent../src/bt_peer_connection.c
if (m_storage[m_last & mask]) break;
++m_last;
m_last &= 0xffff;
- | ||
| relevance 0 | ../src/peer_connection.cpp:2731 | this might need something more so that once we have the metadata we can construct a full bitfield |
this might need something more
+ | ||
| relevance 0 | ../src/peer_connection.cpp:2731 | this might need something more so that once we have the metadata we can construct a full bitfield |
this might need something more
so that once we have the metadata
we can construct a full bitfield../src/peer_connection.cpp:2731
#ifdef TORRENT_VERBOSE_LOGGING
@@ -1607,7 +1554,7 @@ we can construct a full bitfield../src/peer_connection.cpp:2731 | ||
| relevance 0 | ../src/peer_connection.cpp:2862 | sort the allowed fast set in priority order |
sort the allowed fast set in priority order../src/peer_connection.cpp:2862 // this piece index later
+ | ||
| relevance 0 | ../src/peer_connection.cpp:2862 | sort the allowed fast set in priority order |
sort the allowed fast set in priority order../src/peer_connection.cpp:2862 // this piece index later
m_allowed_fast.push_back(index);
// if the peer has the piece and we want
@@ -1658,7 +1605,7 @@ we can construct a full bitfield../src/peer_connection.cpp:2731 | ||
| relevance 0 | ../src/peer_connection.cpp:4575 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
+ | ||
| relevance 0 | ../src/peer_connection.cpp:4575 | peers should really be corked/uncorked outside of all completed disk operations |
peers should really be corked/uncorked outside of
all completed disk operations../src/peer_connection.cpp:4575 // this means we're in seed mode and we haven't yet
// verified this piece (r.piece)
t->filesystem().async_read_and_hash(r, boost::bind(&peer_connection::on_disk_read_complete
@@ -1710,7 +1657,7 @@ all completed disk operations../src/peer_connection.cpp:4575 | ||
| relevance 0 | ../src/policy.cpp:857 | only allow _one_ connection to use this override at a time |
only allow _one_ connection to use this
+ | ||
| relevance 0 | ../src/policy.cpp:857 | only allow _one_ connection to use this override at a time |
only allow _one_ connection to use this
override at a time../src/policy.cpp:857 " external: " << external.external_address(m_peers[candidate]->address()) <<
" t: " << (session_time - m_peers[candidate]->last_connected) <<
" ]\n";
@@ -1762,7 +1709,7 @@ override at a time../src/policy.cpp:857| relevance 0 | ../src/policy.cpp:1897 | how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy |
|
how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy../src/policy.cpp:1897#endif
+ | ||
| relevance 0 | ../src/policy.cpp:1897 | how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy |
how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy../src/policy.cpp:1897#endif
, on_parole(false)
, banned(false)
#ifndef TORRENT_DISABLE_DHT
@@ -1813,7 +1760,7 @@ override at a time../src/policy.cpp:857| relevance 0 | ../src/session_impl.cpp:1938 | recalculate all connect candidates for all torrents |
|
recalculate all connect candidates for all torrents../src/session_impl.cpp:1938 m_upload_rate.close();
+ | ||
| relevance 0 | ../src/session_impl.cpp:1942 | recalculate all connect candidates for all torrents |
recalculate all connect candidates for all torrents../src/session_impl.cpp:1942 m_upload_rate.close();
// #error closing the udp socket here means that
// the uTP connections cannot be closed gracefully
@@ -1864,7 +1811,7 @@ override at a time../src/policy.cpp:857| relevance 0 | ../src/session_impl.cpp:3362 | have a separate list for these connections, instead of having to loop through all of them |
|
have a separate list for these connections, instead of having to loop through all of them../src/session_impl.cpp:3362 // --------------------------------------------------------------
+ | ||
| relevance 0 | ../src/session_impl.cpp:3372 | have a separate list for these connections, instead of having to loop through all of them |
have a separate list for these connections, instead of having to loop through all of them../src/session_impl.cpp:3372 // --------------------------------------------------------------
if (!m_paused) m_auto_manage_time_scaler--;
if (m_auto_manage_time_scaler < 0)
{
@@ -1915,7 +1862,7 @@ override at a time../src/policy.cpp:857| relevance 0 | ../src/session_impl.cpp:4435 | allow extensions to sort torrents for queuing |
|
allow extensions to sort torrents for queuing../src/session_impl.cpp:4435 else if (!t->is_paused())
+ | ||
| relevance 0 | ../src/session_impl.cpp:4459 | allow extensions to sort torrents for queuing |
allow extensions to sort torrents for queuing../src/session_impl.cpp:4459 else if (!t->is_paused())
{
TORRENT_ASSERT(t->m_resume_data_loaded || !t->valid_metadata());
--hard_limit;
@@ -1966,9 +1913,9 @@ override at a time../src/policy.cpp:857| relevance 0 | ../src/session_impl.cpp:4591 | use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections |
|
use a lower limit than m_settings.connections_limit
+ | ||
| relevance 0 | ../src/session_impl.cpp:4615 | use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections |
use a lower limit than m_settings.connections_limit
to allocate the to 10% or so of connection slots for incoming
-connections../src/session_impl.cpp:4591 {
+connections../src/session_impl.cpp:4615 {
if (m_boost_connections > max_connections)
{
m_boost_connections -= max_connections;
@@ -2019,7 +1966,7 @@ connections../src/session_impl.cpp:4591| relevance 0 | ../src/session_impl.cpp:4625 | make this bias configurable |
|
make this bias configurable../src/session_impl.cpp:4625 | ||
| relevance 0 | ../src/session_impl.cpp:4626 | also take average_peers into account, to create a bias for downloading torrents with < average peers |
also take average_peers into account, to create a bias for downloading torrents with < average peers../src/session_impl.cpp:4626 average_peers = num_downloads_peers / num_downloads;
+ | ||
| relevance 0 | ../src/session_impl.cpp:4649 | make this bias configurable |
make this bias configurable../src/session_impl.cpp:4649 | ||
| relevance 0 | ../src/session_impl.cpp:4650 | also take average_peers into account, to create a bias for downloading torrents with < average peers |
also take average_peers into account, to create a bias for downloading torrents with < average peers../src/session_impl.cpp:4650 average_peers = num_downloads_peers / num_downloads;
if (m_next_connect_torrent == m_torrents.end())
m_next_connect_torrent = m_torrents.begin();
@@ -2070,7 +2017,7 @@ connections../src/session_impl.cpp:4591| relevance 0 | ../src/session_impl.cpp:4770 | make configurable |
|
make configurable../src/session_impl.cpp:4770
+ | ||
| relevance 0 | ../src/session_impl.cpp:4794 | make configurable |
make configurable../src/session_impl.cpp:4794
#ifdef TORRENT_DEBUG
for (std::vector<peer_connection*>::const_iterator i = peers.begin()
, end(peers.end()), prev(peers.end()); i != end; ++i)
@@ -2103,7 +2050,7 @@ connections../src/session_impl.cpp:4591| relevance 0 | ../src/session_impl.cpp:4784 | make configurable |
|
make configurable../src/session_impl.cpp:4784 >= (*i)->uploaded_in_last_round() * 1000
+ | ||
| relevance 0 | ../src/session_impl.cpp:4808 | make configurable |
make configurable../src/session_impl.cpp:4808 >= (*i)->uploaded_in_last_round() * 1000
* (1 + t2->priority()) / total_milliseconds(unchoke_interval));
}
prev = i;
@@ -2154,7 +2101,7 @@ connections../src/session_impl.cpp:4591 | ||
| relevance 0 | ../src/storage.cpp:324 | if the read fails, set error and exit immediately |
if the read fails, set error and exit immediately../src/storage.cpp:324 if (m_storage->disk_pool()) block_size = m_storage->disk_pool()->block_size();
+ | ||
| relevance 0 | ../src/storage.cpp:324 | if the read fails, set error and exit immediately |
if the read fails, set error and exit immediately../src/storage.cpp:324 if (m_storage->disk_pool()) block_size = m_storage->disk_pool()->block_size();
int size = slot_size;
int num_blocks = (size + block_size - 1) / block_size;
@@ -2205,7 +2152,7 @@ connections../src/session_impl.cpp:4591| relevance 0 | ../src/storage.cpp:358 | if the read fails, set error and exit immediately |
|
if the read fails, set error and exit immediately../src/storage.cpp:358 {
+ | ||
| relevance 0 | ../src/storage.cpp:358 | if the read fails, set error and exit immediately |
if the read fails, set error and exit immediately../src/storage.cpp:358 {
ph.h.update((char const*)bufs[i].iov_base, bufs[i].iov_len);
small_piece_size -= bufs[i].iov_len;
}
@@ -2256,7 +2203,7 @@ connections../src/session_impl.cpp:4591| relevance 0 | ../src/storage.cpp:629 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info |
|
make this more generic to not just work if files have been
+ | ||
| relevance 0 | ../src/storage.cpp:629 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance
maybe use the same format as .torrent files and reuse some code from torrent_info../src/storage.cpp:629 for (;;)
{
@@ -2309,7 +2256,7 @@ maybe use the same format as .torrent files and reuse some code from torrent_inf
for (int i = 0; i < file_sizes_ent->list_size(); ++i)
{
- | ||
| relevance 0 | ../src/storage.cpp:1238 | what if file_base is used to merge several virtual files into a single physical file? We should probably disable this if file_base is used. This is not a widely used feature though |
what if file_base is used to merge several virtual files
+ | ||
| relevance 0 | ../src/storage.cpp:1238 | what if file_base is used to merge several virtual files into a single physical file? We should probably disable this if file_base is used. This is not a widely used feature though |
what if file_base is used to merge several virtual files
into a single physical file? We should probably disable this
if file_base is used. This is not a widely used feature though../src/storage.cpp:1238 int bytes_transferred = 0;
// if the file is opened in no_buffer mode, and the
@@ -2362,7 +2309,7 @@ if file_base is used. This is not a widely used feature though../src/st
// makes unaligned requests (and the disk cache is disabled or fully utilized
// for write cache).
- | ||
| relevance 0 | ../src/torrent.cpp:1362 | is verify_peer_cert called once per certificate in the chain, and this function just tells us which depth we're at right now? If so, the comment makes sense. any certificate that isn't the leaf (i.e. the one presented by the peer) should be accepted automatically, given preverified is true. The leaf certificate need to be verified to make sure its DN matches the info-hash |
is verify_peer_cert called once per certificate in the chain, and
+ | ||
| relevance 0 | ../src/torrent.cpp:1362 | is verify_peer_cert called once per certificate in the chain, and this function just tells us which depth we're at right now? If so, the comment makes sense. any certificate that isn't the leaf (i.e. the one presented by the peer) should be accepted automatically, given preverified is true. The leaf certificate need to be verified to make sure its DN matches the info-hash |
is verify_peer_cert called once per certificate in the chain, and
this function just tells us which depth we're at right now? If so, the comment
makes sense.
any certificate that isn't the leaf (i.e. the one presented by the peer)
@@ -2418,12 +2365,12 @@ need to be verified to make sure its DN matches the info-hash../src/tor
{
#if defined(TORRENT_VERBOSE_LOGGING) || defined(TORRENT_LOGGING)
match = true;
- | ||
| relevance 0 | ../src/torrent.cpp:5167 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync |
make this more generic to not just work if files have been
+ | ||
| relevance 0 | ../src/torrent.cpp:5172 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance
maybe use the same format as .torrent files and reuse some code from torrent_info
The mapped_files needs to be read both in the network thread
and in the disk thread, since they both have their own mapped files structures
-which are kept in sync../src/torrent.cpp:5167 if (m_seed_mode) m_verified.resize(m_torrent_file->num_pieces(), false);
+which are kept in sync../src/torrent.cpp:5172 if (m_seed_mode) m_verified.resize(m_torrent_file->num_pieces(), false);
super_seeding(rd.dict_find_int_value("super_seeding", 0));
m_last_scrape = rd.dict_find_int_value("last_scrape", 0);
@@ -2474,12 +2421,12 @@ which are kept in sync../src/torrent.cpp:5167| relevance 0 | ../src/torrent.cpp:5303 | if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents |
|
if this is a merkle torrent and we can't
+ | ||
| relevance 0 | ../src/torrent.cpp:5308 | if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents |
if this is a merkle torrent and we can't
restore the tree, we need to wipe all the
bits in the have array, but not necessarily
we might want to do a full check to see if we have
all the pieces. This is low priority since almost
-no one uses merkle torrents../src/torrent.cpp:5303 add_web_seed(url, web_seed_entry::http_seed);
+no one uses merkle torrents../src/torrent.cpp:5308 add_web_seed(url, web_seed_entry::http_seed);
}
}
@@ -2530,9 +2477,9 @@ no one uses merkle torrents../src/torrent.cpp:5303 | ||
| relevance 0 | ../src/torrent.cpp:5491 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base |
make this more generic to not just work if files have been
+ | ||
| relevance 0 | ../src/torrent.cpp:5496 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance.
-using file_base../src/torrent.cpp:5491 entry::string_type& pieces = ret["pieces"].string();
+using file_base../src/torrent.cpp:5496 entry::string_type& pieces = ret["pieces"].string();
pieces.resize(m_torrent_file->num_pieces());
if (is_seed())
{
@@ -2583,10 +2530,10 @@ using file_base../src/torrent.cpp:5491| relevance 0 | ../src/torrent.cpp:8021 | go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece |
|
go through the pieces we have and count the total number
+ | ||
| relevance 0 | ../src/torrent.cpp:8026 | go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece |
go through the pieces we have and count the total number
of downloaders we have. Only count peers that are interested in us
since some peers might not send have messages for pieces we have
-it num_interested == 0, we need to pick a new piece../src/torrent.cpp:8021 }
+it num_interested == 0, we need to pick a new piece../src/torrent.cpp:8026 }
rarest_pieces.clear();
rarest_rarity = pp.peer_count;
@@ -2637,7 +2584,7 @@ it num_interested == 0, we need to pick a new piece../src/torrent.cpp:8
{
m_picker->get_availability(avail_vec);
}
- | ||
| relevance 0 | ../src/udp_tracker_connection.cpp:552 | it would be more efficient to not use a string here. however, the problem is that some trackers will respond with actual strings. For example i2p trackers |
it would be more efficient to not use a string here.
+ | ||
| relevance 0 | ../src/udp_tracker_connection.cpp:552 | it would be more efficient to not use a string here. however, the problem is that some trackers will respond with actual strings. For example i2p trackers |
it would be more efficient to not use a string here.
however, the problem is that some trackers will respond
with actual strings. For example i2p trackers../src/udp_tracker_connection.cpp:552 }
@@ -2690,7 +2637,7 @@ with actual strings. For example i2p trackers../src/udp_tracker_connect
{
restart_read_timeout();
int action = detail::read_int32(buf);
- | ||
| relevance 0 | ../src/utp_stream.cpp:1573 | this loop may not be very efficient |
this loop may not be very efficient../src/utp_stream.cpp:1573 TORRENT_ASSERT(p->header_size >= sizeof(utp_header) + sack_size + 2);
+ | ||
| relevance 0 | ../src/utp_stream.cpp:1573 | this loop may not be very efficient |
this loop may not be very efficient../src/utp_stream.cpp:1573 TORRENT_ASSERT(p->header_size >= sizeof(utp_header) + sack_size + 2);
memmove(ptr, ptr + sack_size + 2, p->size - p->header_size);
p->header_size -= sack_size + 2;
p->size -= sack_size + 2;
@@ -2741,7 +2688,7 @@ bool utp_socket_impl::send_pkt(int flags)
if (sack > 32) sack = 32;
}
- | ||
| relevance 0 | ../src/kademlia/routing_table.cpp:265 | instad of refreshing a bucket by using find_nodes, ping each node periodically |
instad of refreshing a bucket by using find_nodes,
+ | ||
| relevance 0 | ../src/kademlia/routing_table.cpp:265 | instad of refreshing a bucket by using find_nodes, ping each node periodically |
instad of refreshing a bucket by using find_nodes,
ping each node periodically../src/kademlia/routing_table.cpp:265 os << "]\n";
}
}
@@ -2793,7 +2740,7 @@ bool compare_bucket_refresh(routing_table_node const& lhs, routing_table_nod
// target = (target & ~mask) | (root & mask)
node_id root = m_id;
- | ||
| relevance 0 | ../include/libtorrent/config.hpp:305 | Make this count Unicode characters instead of bytes on windows |
Make this count Unicode characters instead of bytes on windows../include/libtorrent/config.hpp:305
+ | ||
| relevance 0 | ../include/libtorrent/config.hpp:305 | Make this count Unicode characters instead of bytes on windows |
Make this count Unicode characters instead of bytes on windows../include/libtorrent/config.hpp:305
// ==== eCS(OS/2) ===
#elif defined __OS2__
#define TORRENT_OS2
@@ -2844,7 +2791,7 @@ bool compare_bucket_refresh(routing_table_node const& lhs, routing_table_nod
#include <stdarg.h>
// internal
- | ||
| relevance 0 | ../include/libtorrent/proxy_base.hpp:166 | it would be nice to remember the bind port and bind once we know where the proxy is m_sock.bind(endpoint, ec); |
it would be nice to remember the bind port and bind once we know where the proxy is
+ | ||
| relevance 0 | ../include/libtorrent/proxy_base.hpp:166 | it would be nice to remember the bind port and bind once we know where the proxy is m_sock.bind(endpoint, ec); |
it would be nice to remember the bind port and bind once we know where the proxy is
m_sock.bind(endpoint, ec);../include/libtorrent/proxy_base.hpp:166 {
return m_sock.get_option(opt, ec);
}
@@ -2896,7 +2843,7 @@ m_sock.bind(endpoint, ec);../include/libtorrent/proxy_base.hpp:166
m_sock.close(ec);
m_resolver.cancel();
}
- | ||
| relevance 0 | ../include/libtorrent/torrent_info.hpp:123 | include the number of peers received from this tracker, at last announce |
include the number of peers received from this tracker, at last announce../include/libtorrent/torrent_info.hpp:123
+ | ||
| relevance 0 | ../include/libtorrent/torrent_info.hpp:123 | include the number of peers received from this tracker, at last announce |
include the number of peers received from this tracker, at last announce../include/libtorrent/torrent_info.hpp:123
// if this tracker failed the last time it was contacted
// this error code specifies what error occurred
error_code last_error;
@@ -2947,10 +2894,10 @@ m_sock.bind(endpoint, ec);../include/libtorrent/proxy_base.hpp:166
// flags for the source bitmask, each indicating where
// we heard about this tracker
enum tracker_source
- | ||
| relevance 0 | ../include/libtorrent/upnp.hpp:121 | support using the windows API for UPnP operations as well |
support using the windows API for UPnP operations as well../include/libtorrent/upnp.hpp:121 {
- virtual const char* name() const;
- virtual std::string message(int ev) const;
- virtual boost::system::error_condition default_error_condition(int ev) const
+ | ||
| relevance 0 | ../include/libtorrent/upnp.hpp:121 | support using the windows API for UPnP operations as well |
support using the windows API for UPnP operations as well../include/libtorrent/upnp.hpp:121 {
+ virtual const char* name() const BOOST_SYSTEM_NOEXCEPT;
+ virtual std::string message(int ev) const BOOST_SYSTEM_NOEXCEPT;
+ virtual boost::system::error_condition default_error_condition(int ev) const BOOST_SYSTEM_NOEXCEPT
{ return boost::system::error_condition(ev, *this); }
};
| ||
