| relevance 4 | ../src/peer_connection.cpp:4841 | use a deadline_timer for timeouts. Don't rely on second_tick()! Hook this up to connect timeout as well |
use a deadline_timer for timeouts. Don't rely on second_tick()!
+Hook this up to connect timeout as well../src/peer_connection.cpp:4841 if (is_i2p(*m_socket))
+ connect_timeout += 20;
+#endif
+
+ if (d > seconds(connect_timeout)
+ && can_disconnect(error_code(errors::timed_out, get_libtorrent_category())))
+ {
+#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_ERROR_LOGGING
+ peer_log("*** CONNECT FAILED [ waited %d seconds ] ***", int(total_seconds(d)));
+#endif
+ connect_failed(errors::timed_out);
+ return;
+ }
}
- lazy_entry const* warning = e.dict_find_string("warning message");
- if (warning)
- resp.warning_message = warning->string_value();
+ // if we can't read, it means we're blocked on the rate-limiter
+ // or the disk, not the peer itself. In this case, don't blame
+ // the peer and disconnect it
+ bool may_timeout = (m_channel_state[download_channel] & peer_info::bw_network) != 0;
- if (scrape_request)
+ if (may_timeout && d > seconds(timeout()) && !m_connecting && m_reading_bytes == 0
+ && can_disconnect(error_code(errors::timed_out_inactivity, get_libtorrent_category())))
{
- lazy_entry const* files = e.dict_find_dict("files");
- if (files == 0)
- {
- ec.assign(errors::invalid_files_entry, get_libtorrent_category());
- return resp;
- }
-
- lazy_entry const* scrape_data = files->dict_find_dict(
- scrape_ih.to_string().c_str());
-
- if (scrape_data == 0)
- {
- ec.assign(errors::invalid_hash_entry, get_libtorrent_category());
- return resp;
- }
-
- resp.complete = int(scrape_data->dict_find_int_value("complete", -1));
- resp.incomplete = int(scrape_data->dict_find_int_value("incomplete", -1));
- resp.downloaded = int(scrape_data->dict_find_int_value("downloaded", -1));
- resp.downloaders = int(scrape_data->dict_find_int_value("downloaders", -1));
-
- return resp;
+#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_ERROR_LOGGING
+ peer_log("*** LAST ACTIVITY [ %d seconds ago ] ***", int(total_seconds(d)));
+#endif
+ disconnect(errors::timed_out_inactivity, op_bittorrent);
+ return;
}
- // look for optional scrape info
- resp.complete = int(e.dict_find_int_value("complete", -1));
- resp.incomplete = int(e.dict_find_int_value("incomplete", -1));
- resp.downloaded = int(e.dict_find_int_value("downloaded", -1));
-
- lazy_entry const* peers_ent = e.dict_find("peers");
- if (peers_ent && peers_ent->type() == lazy_entry::string_t)
+ // do not stall waiting for a handshake
+ if (may_timeout
+ && !m_connecting
+ && in_handshake()
+ && d > seconds(m_settings.get_int(settings_pack::handshake_timeout)))
{
- char const* peers = peers_ent->string_ptr();
- int len = peers_ent->string_length();
- resp.peers4.reserve(len / 6);
- for (int i = 0; i < len; i += 6)
- {
- if (len - i < 6) break;
- | ||
| relevance 4 | ../src/session_impl.cpp:479 | in order to support SSL over uTP, the utp_socket manager either needs to be able to receive packets on multiple ports, or we need to peek into the first few bytes the payload stream of a socket to determine whether or not it's an SSL connection. (The former is simpler but won't do as well with NATs) |
in order to support SSL over uTP, the utp_socket manager either
+#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_ERROR_LOGGING
+ peer_log("*** NO HANDSHAKE [ waited %d seconds ] ***", int(total_seconds(d)));
+#endif
+ disconnect(errors::timed_out_no_handshake, op_bittorrent);
+ return;
+ }
+
+ // disconnect peers that we unchoked, but
+ // they didn't send a request within 60 seconds.
+ // but only if we're a seed
+ d = now - (std::max)(m_last_unchoke, m_last_incoming_request);
+ if (may_timeout
+ && !m_connecting
+ && m_requests.empty()
+ && m_reading_bytes == 0
+ | ||
| relevance 4 | ../src/session_impl.cpp:482 | in order to support SSL over uTP, the utp_socket manager either needs to be able to receive packets on multiple ports, or we need to peek into the first few bytes the payload stream of a socket to determine whether or not it's an SSL connection. (The former is simpler but won't do as well with NATs) |
in order to support SSL over uTP, the utp_socket manager either
needs to be able to receive packets on multiple ports, or we need to
peek into the first few bytes the payload stream of a socket to determine
whether or not it's an SSL connection. (The former is simpler but won't
-do as well with NATs)../src/session_impl.cpp:479 , m_optimistic_unchoke_time_scaler(0)
+do as well with NATs)../src/session_impl.cpp:482 , m_optimistic_unchoke_time_scaler(0)
, m_disconnect_time_scaler(90)
, m_auto_scrape_time_scaler(180)
, m_next_explicit_cache_torrent(0)
@@ -101,7 +101,7 @@ do as well with NATs)../src/session_impl.cpp:479 , m_utp_socket_manager(m_settings, m_udp_socket, m_stats_counters
, boost::bind(&session_impl::incoming_connection, this, _1))
, m_boost_connections(0)
@@ -133,7 +133,7 @@ do as well with NATs)../src/session_impl.cpp:479| relevance 4 | ../src/torrent.cpp:9647 | this logic doesn't work for seeding torrents that are not ticked |
|
this logic doesn't work for seeding torrents that are not ticked../src/torrent.cpp:9647 {
+ | ||
| relevance 4 | ../src/torrent.cpp:9624 | this logic doesn't work for seeding torrents that are not ticked |
this logic doesn't work for seeding torrents that are not ticked../src/torrent.cpp:9624 {
i = m_connections.begin() + idx;
--idx;
}
@@ -380,8 +380,8 @@ bool get_item_cb(dht::item& i)
m_threads.resize(m_num_threads);
}
}
- | ||
| relevance 3 | ../src/peer_connection.cpp:1796 | we should probably use ses.m_allowed_upload_slots here instead to work with auto-unchoke logic |
we should probably use ses.m_allowed_upload_slots here instead
-to work with auto-unchoke logic../src/peer_connection.cpp:1796#endif
+ | ||
| relevance 3 | ../src/peer_connection.cpp:1850 | we should probably use ses.m_allowed_upload_slots here instead to work with auto-unchoke logic |
we should probably use ses.m_allowed_upload_slots here instead
+to work with auto-unchoke logic../src/peer_connection.cpp:1850#endif
write_unchoke();
return;
}
@@ -432,11 +432,11 @@ to work with auto-unchoke logic../src/peer_connection.cpp:1796 | ||
| relevance 3 | ../src/peer_connection.cpp:3133 | since we throw away the queue entry once we issue the disk job, this may happen. Instead, we should keep the queue entry around, mark it as having been requested from disk and once the disk job comes back, discard it if it has been cancelled. Maybe even be able to cancel disk jobs? |
since we throw away the queue entry once we issue
+ | ||
| relevance 3 | ../src/peer_connection.cpp:3187 | since we throw away the queue entry once we issue the disk job, this may happen. Instead, we should keep the queue entry around, mark it as having been requested from disk and once the disk job comes back, discard it if it has been cancelled. Maybe even be able to cancel disk jobs? |
since we throw away the queue entry once we issue
the disk job, this may happen. Instead, we should keep the
queue entry around, mark it as having been requested from
disk and once the disk job comes back, discard it if it has
-been cancelled. Maybe even be able to cancel disk jobs?../src/peer_connection.cpp:3133
+been cancelled. Maybe even be able to cancel disk jobs?../src/peer_connection.cpp:3187
std::vector<peer_request>::iterator i
= std::find(m_requests.begin(), m_requests.end(), r);
@@ -487,9 +487,9 @@ been cancelled. Maybe even be able to cancel disk jobs?../src/peer_conn
void peer_connection::incoming_have_all()
{
TORRENT_ASSERT(is_single_thread());
- | ||
| relevance 3 | ../src/peer_connection.cpp:4867 | instead of using settings_pack::request_timeout, use m_rtt.mean() + m_rtt.avg_deviation() * 2 or something like that. the configuration option could hopefully be removed |
instead of using settings_pack::request_timeout, use
+ | ||
| relevance 3 | ../src/peer_connection.cpp:4917 | instead of using settings_pack::request_timeout, use m_rtt.mean() + m_rtt.avg_deviation() * 2 or something like that. the configuration option could hopefully be removed |
instead of using settings_pack::request_timeout, use
m_rtt.mean() + m_rtt.avg_deviation() * 2 or something like that.
-the configuration option could hopefully be removed../src/peer_connection.cpp:4867 // don't bother disconnect peers we haven't been interested
+the configuration option could hopefully be removed../src/peer_connection.cpp:4917 // don't bother disconnect peers we haven't been interested
// in (and that hasn't been interested in us) for a while
// unless we have used up all our connection slots
if (may_timeout
@@ -646,9 +646,9 @@ namespace libtorrent
}
h(ec, ce.addresses);
- | ||
| relevance 3 | ../src/session_impl.cpp:5535 | it would be really nice to update these counters as they are incremented. This depends on the session being ticked, which has a fairly coarse grained resolution |
it would be really nice to update these counters
+ | ||
| relevance 3 | ../src/session_impl.cpp:5439 | it would be really nice to update these counters as they are incremented. This depends on the session being ticked, which has a fairly coarse grained resolution |
it would be really nice to update these counters
as they are incremented. This depends on the session
-being ticked, which has a fairly coarse grained resolution../src/session_impl.cpp:5535 t->status(&alert->status.back(), ~torrent_handle::query_accurate_download_counters);
+being ticked, which has a fairly coarse grained resolution../src/session_impl.cpp:5439 t->status(&alert->status.back(), ~torrent_handle::query_accurate_download_counters);
t->clear_in_state_update();
}
state_updates.clear();
@@ -699,8 +699,8 @@ being ticked, which has a fairly coarse grained resolution../src/sessio
for (int i = 0; i < counters::num_counters; ++i)
values[i] = m_stats_counters[i];
- | ||
| relevance 3 | ../src/session_impl.cpp:7002 | If socket jobs could be higher level, to include RC4 encryption and decryption, we would offload the main thread even more |
If socket jobs could be higher level, to include RC4 encryption and decryption,
-we would offload the main thread even more../src/session_impl.cpp:7002 {
+ | ||
| relevance 3 | ../src/session_impl.cpp:6892 | If socket jobs could be higher level, to include RC4 encryption and decryption, we would offload the main thread even more |
If socket jobs could be higher level, to include RC4 encryption and decryption,
+we would offload the main thread even more../src/session_impl.cpp:6892 {
int num_threads = m_settings.get_int(settings_pack::network_threads);
int num_pools = num_threads > 0 ? num_threads : 1;
while (num_pools > m_net_thread_pool.size())
@@ -802,7 +802,7 @@ we would offload the main thread even more../src/session_impl.cpp:7002<
alerts().post_alert(file_error_alert(j->error.ec
, resolve_filename(j->error.file), j->error.operation_str(), get_handle()));
if (c) c->disconnect(errors::no_memory, peer_connection_interface::op_file);
- | ||
| relevance 3 | ../src/torrent.cpp:7686 | if peer is a really good peer, maybe we shouldn't disconnect it |
if peer is a really good peer, maybe we shouldn't disconnect it../src/torrent.cpp:7686#if defined TORRENT_LOGGING || defined TORRENT_ERROR_LOGGING
+ | ||
| relevance 3 | ../src/torrent.cpp:7662 | if peer is a really good peer, maybe we shouldn't disconnect it |
if peer is a really good peer, maybe we shouldn't disconnect it../src/torrent.cpp:7662#if defined TORRENT_LOGGING || defined TORRENT_ERROR_LOGGING
debug_log("incoming peer (%d)", int(m_connections.size()));
#endif
@@ -1324,7 +1324,7 @@ should not include internal state.../include/libtorrent/torrent_info.hp
// issue a single write operation instead of using a vector
// operation
int buf_size = 0;
- | ||
| relevance 2 | ../src/session_impl.cpp:2422 | use bind_to_device in udp_socket |
use bind_to_device in udp_socket../src/session_impl.cpp:2422 if (m_listen_sockets.empty() && ec)
+ | ||
| relevance 2 | ../src/session_impl.cpp:2337 | use bind_to_device in udp_socket |
use bind_to_device in udp_socket../src/session_impl.cpp:2337 if (m_listen_sockets.empty() && ec)
{
#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_LOGGING || defined TORRENT_ERROR_LOGGING
char msg[200];
@@ -1375,8 +1375,8 @@ should not include internal state.../include/libtorrent/torrent_info.hp
}
if (m_settings.get_int(settings_pack::peer_tos) != 0) {
- | ||
| relevance 2 | ../src/session_impl.cpp:4435 | make a list for torrents that want to be announced on the DHT so we don't have to loop over all torrents, just to find the ones that want to announce |
make a list for torrents that want to be announced on the DHT so we
-don't have to loop over all torrents, just to find the ones that want to announce../src/session_impl.cpp:4435 if (!m_dht_torrents.empty())
+ | ||
| relevance 2 | ../src/session_impl.cpp:4347 | make a list for torrents that want to be announced on the DHT so we don't have to loop over all torrents, just to find the ones that want to announce |
make a list for torrents that want to be announced on the DHT so we
+don't have to loop over all torrents, just to find the ones that want to announce../src/session_impl.cpp:4347 if (!m_dht_torrents.empty())
{
boost::shared_ptr<torrent> t;
do
@@ -1478,8 +1478,8 @@ don't have to loop over all torrents, just to find the ones that want to announc
TORRENT_ASSERT(piece >= 0);
TORRENT_ASSERT(m_verified.get_bit(piece) == false);
++m_num_verified;
- | ||
| relevance 2 | ../src/torrent.cpp:4693 | abort lookups this torrent has made via the session host resolver interface |
abort lookups this torrent has made via the
-session host resolver interface../src/torrent.cpp:4693 // files belonging to the torrents
+ | ||
| relevance 2 | ../src/torrent.cpp:4692 | abort lookups this torrent has made via the session host resolver interface |
abort lookups this torrent has made via the
+session host resolver interface../src/torrent.cpp:4692 // files belonging to the torrents
disconnect_all(errors::torrent_aborted, peer_connection_interface::op_bittorrent);
// post a message to the main thread to destruct
@@ -1552,7 +1552,6 @@ namespace libtorrent
udp_tracker_connection::udp_tracker_connection(
io_service& ios
- , connection_queue& cc
, tracker_manager& man
, tracker_request const& req
, boost::weak_ptr<request_callback> c
@@ -1581,6 +1580,7 @@ namespace libtorrent
if (port == -1) port = protocol == "http" ? 80 : 443;
if (ec)
+ {
| ||
| relevance 2 | ../src/web_peer_connection.cpp:655 | create a mapping of file-index to redirection URLs. Use that to form URLs instead. Support to reconnect to a new server without destructing this peer_connection |
create a mapping of file-index to redirection URLs. Use that to form
URLs instead. Support to reconnect to a new server without destructing this
peer_connection../src/web_peer_connection.cpp:655 == dl_target);
@@ -1634,7 +1634,7 @@ peer_connection../src/web_peer_connection.cpp:655| relevance 2 | ../src/kademlia/dos_blocker.cpp:68 | make these limits configurable |
|
make these limits configurable../src/kademlia/dos_blocker.cpp:68 bool dos_blocker::incoming(address addr, ptime now)
+ | ||
| relevance 2 | ../src/kademlia/dos_blocker.cpp:75 | make these limits configurable |
make these limits configurable../src/kademlia/dos_blocker.cpp:75 bool dos_blocker::incoming(address addr, ptime now)
{
node_ban_entry* match = 0;
node_ban_entry* min = m_ban_nodes;
@@ -2072,8 +2072,8 @@ specifically to turn some std::string and std::vector into pointers../i
#ifndef BOOST_NO_EXCEPTIONS
torrent_info(lazy_entry const& torrent_file, int flags = 0);
torrent_info(char const* buffer, int size, int flags = 0);
- | ||
| relevance 2 | ../include/libtorrent/aux_/session_interface.hpp:108 | the IP voting mechanism should be factored out to its own class, not part of the session |
the IP voting mechanism should be factored out
-to its own class, not part of the session../include/libtorrent/aux_/session_interface.hpp:108 class port_filter;
+ | ||
| relevance 2 | ../include/libtorrent/aux_/session_interface.hpp:107 | the IP voting mechanism should be factored out to its own class, not part of the session |
the IP voting mechanism should be factored out
+to its own class, not part of the session../include/libtorrent/aux_/session_interface.hpp:107 class port_filter;
struct settings_pack;
struct torrent_peer_allocator_interface;
struct counters;
@@ -2176,8 +2176,8 @@ the chunk headers should be subtracted from the receive_buffer_size../s
std::string request;
request.reserve(400);
- | ||
| relevance 1 | ../src/session_impl.cpp:6353 | report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address |
report the proper address of the router as the source IP of
-this understanding of our external address, instead of the empty address../src/session_impl.cpp:6353 void session_impl::on_port_mapping(int mapping, address const& ip, int port
+ | ||
| relevance 1 | ../src/session_impl.cpp:6257 | report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address |
report the proper address of the router as the source IP of
+this understanding of our external address, instead of the empty address../src/session_impl.cpp:6257 void session_impl::on_port_mapping(int mapping, address const& ip, int port
, error_code const& ec, int map_transport)
{
TORRENT_ASSERT(is_single_thread());
@@ -2228,9 +2228,9 @@ this understanding of our external address, instead of the empty address | ||
| relevance 1 | ../src/session_impl.cpp:7514 | we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily |
we only need to do this if our global IPv4 address has changed
+ | ||
| relevance 1 | ../src/session_impl.cpp:7396 | we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily |
we only need to do this if our global IPv4 address has changed
since the DHT (currently) only supports IPv4. Since restarting the DHT
-is kind of expensive, it would be nice to not do it unnecessarily../src/session_impl.cpp:7514#endif
+is kind of expensive, it would be nice to not do it unnecessarily../src/session_impl.cpp:7396#endif
if (!m_external_ip.cast_vote(ip, source_type, source)) return;
@@ -2336,8 +2336,8 @@ up to the highest written piece in each file../src/torrent.cpp:1143 | ||
| relevance 1 | ../src/torrent.cpp:6845 | save the send_stats state instead of throwing them away it may pose an issue when downgrading though |
save the send_stats state instead of throwing them away
-it may pose an issue when downgrading though../src/torrent.cpp:6845 for (int k = 0; k < bits; ++k)
+ | ||
| relevance 1 | ../src/torrent.cpp:6839 | save the send_stats state instead of throwing them away it may pose an issue when downgrading though |
save the send_stats state instead of throwing them away
+it may pose an issue when downgrading though../src/torrent.cpp:6839 for (int k = 0; k < bits; ++k)
v |= (i->info[j*8+k].state == piece_picker::block_info::state_finished)
? (1 << k) : 0;
bitmask.append(1, v);
@@ -2388,9 +2388,9 @@ it may pose an issue when downgrading though../src/torrent.cpp:6845 | ||
| relevance 1 | ../src/torrent.cpp:7934 | should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though |
should disconnect all peers that have the pieces we have
+ | ||
| relevance 1 | ../src/torrent.cpp:7910 | should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though |
should disconnect all peers that have the pieces we have
not just seeds. It would be pretty expensive to check all pieces
-for all peers though../src/torrent.cpp:7934 set_state(torrent_status::finished);
+for all peers though../src/torrent.cpp:7910 set_state(torrent_status::finished);
set_queue_position(-1);
m_became_finished = m_ses.session_time();
@@ -2441,7 +2441,7 @@ for all peers though../src/torrent.cpp:7934| relevance 1 | ../src/kademlia/node.cpp:835 | find_node should write directly to the response entry |
|
find_node should write directly to the response entry../src/kademlia/node.cpp:835 TORRENT_LOG(node) << " values: " << reply["values"].list().size();
+ | ||
| relevance 1 | ../src/kademlia/node.cpp:813 | find_node should write directly to the response entry |
find_node should write directly to the response entry../src/kademlia/node.cpp:813 TORRENT_LOG(node) << " values: " << reply["values"].list().size();
}
#endif
}
@@ -3001,7 +3001,9 @@ int test_main()
lt::session* s = new lt::session(fingerprint("LT", 0, 1, 0, 0), std::make_pair(48875, 49800), "0.0.0.0", 0, alert_mask);
settings_pack pack;
+#ifndef TORRENT_NO_DEPRECATE
pack.set_int(settings_pack::half_open_limit, 1);
+#endif
pack.set_bool(settings_pack::announce_to_all_trackers, true);
pack.set_bool(settings_pack::announce_to_all_tiers, true);
s->apply_settings(pack);
@@ -3017,9 +3019,7 @@ int test_main()
snprintf(tracker_url, sizeof(tracker_url), "http://127.0.0.1:%d/announce", http_port);
t->add_tracker(tracker_url, 0);
- snprintf(tracker_url, sizeof(tracker_url), "udp://127.0.0.1:%d/announce", udp_port);
- t->add_tracker(tracker_url, 1);
- | ||
| relevance 0 | ../test/test_upnp.cpp:101 | store the log and verify that some key messages are there |
store the log and verify that some key messages are there../test/test_upnp.cpp:101 "USN:uuid:000f-66d6-7296000099dc::upnp:rootdevice\r\n"
+ | ||
| relevance 0 | ../test/test_upnp.cpp:100 | store the log and verify that some key messages are there |
store the log and verify that some key messages are there../test/test_upnp.cpp:100 "USN:uuid:000f-66d6-7296000099dc::upnp:rootdevice\r\n"
"Location: http://127.0.0.1:%d/upnp.xml\r\n"
"Server: Custom/1.0 UPnP/1.0 Proc/Ver\r\n"
"EXT:\r\n"
@@ -3277,7 +3277,7 @@ bool block_cache::maybe_free_piece(cached_piece_entry* pe)
boost::shared_ptr<piece_manager> s = pe->storage;
- | ||
| relevance 0 | ../src/bt_peer_connection.cpp:646 | this could be optimized using knuth morris pratt |
this could be optimized using knuth morris pratt../src/bt_peer_connection.cpp:646 {
+ | ||
| relevance 0 | ../src/bt_peer_connection.cpp:645 | this could be optimized using knuth morris pratt |
this could be optimized using knuth morris pratt../src/bt_peer_connection.cpp:645 {
disconnect(errors::no_memory, op_encryption);
return;
}
@@ -3328,7 +3328,7 @@ bool block_cache::maybe_free_piece(cached_piece_entry* pe)
// }
// no complete sync
- | ||
| relevance 0 | ../src/bt_peer_connection.cpp:2210 | if we're finished, send upload_only message |
if we're finished, send upload_only message../src/bt_peer_connection.cpp:2210 if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
+ | ||
| relevance 0 | ../src/bt_peer_connection.cpp:2209 | if we're finished, send upload_only message |
if we're finished, send upload_only message../src/bt_peer_connection.cpp:2209 if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
else bitfield_string[k] = '0';
}
peer_log("==> BITFIELD [ %s ]", bitfield_string.c_str());
@@ -3818,7 +3818,8 @@ turn through this loop../src/disk_io_thread.cpp:2692| relevance 0 | ../src/http_tracker_connection.cpp:96 | support authentication (i.e. user name and password) in the URL |
|
support authentication (i.e. user name and password) in the URL../src/http_tracker_connection.cpp:96 , tracker_request const& req
+ | ||
| relevance 0 | ../src/http_tracker_connection.cpp:94 | support authentication (i.e. user name and password) in the URL |
support authentication (i.e. user name and password) in the URL../src/http_tracker_connection.cpp:94 , tracker_manager& man
+ , tracker_request const& req
, boost::weak_ptr<request_callback> c
, aux::session_impl& ses
, std::string const& auth
@@ -3829,7 +3830,6 @@ turn through this loop../src/disk_io_thread.cpp:2692| relevance 0 | ../src/peer_connection.cpp:1140 | this should be the global download rate |
|
this should be the global download rate../src/peer_connection.cpp:1140
+ | ||
| relevance 0 | ../src/peer_connection.cpp:1194 | this should be the global download rate |
this should be the global download rate../src/peer_connection.cpp:1194
int rate = 0;
// if we haven't received any data recently, the current download rate
@@ -4129,7 +4129,7 @@ and flushing it, update the slot entries as we go../src/part_file.cpp:3
if (m_ignore_stats) return;
boost::shared_ptr<torrent> t = m_torrent.lock();
if (!t) return;
- | ||
| relevance 0 | ../src/peer_connection.cpp:3373 | sort the allowed fast set in priority order |
sort the allowed fast set in priority order../src/peer_connection.cpp:3373
+ | ||
| relevance 0 | ../src/peer_connection.cpp:3427 | sort the allowed fast set in priority order |
sort the allowed fast set in priority order../src/peer_connection.cpp:3427
// if the peer has the piece and we want
// to download it, request it
if (int(m_have_piece.size()) > index
@@ -4232,8 +4232,8 @@ the !downloading condition doesn't make much sense../src/piece_picker.c
// the second bool is true if this is the only active peer that is requesting
// and downloading blocks from this piece. Active means having a connection.
boost::tuple<bool, bool> requested_from(piece_picker::downloading_piece const& p
- | ||
| relevance 0 | ../src/session_impl.cpp:673 | there's no rule here to make uTP connections not have the global or local rate limits apply to it. This used to be the default. |
there's no rule here to make uTP connections not have the global or
-local rate limits apply to it. This used to be the default.../src/session_impl.cpp:673 m_global_class = m_classes.new_peer_class("global");
+ | ||
| relevance 0 | ../src/session_impl.cpp:603 | there's no rule here to make uTP connections not have the global or local rate limits apply to it. This used to be the default. |
there's no rule here to make uTP connections not have the global or
+local rate limits apply to it. This used to be the default.../src/session_impl.cpp:603 m_global_class = m_classes.new_peer_class("global");
m_tcp_peer_class = m_classes.new_peer_class("tcp");
m_local_peer_class = m_classes.new_peer_class("local");
// local peers are always unchoked
@@ -4284,9 +4284,9 @@ local rate limits apply to it. This used to be the default.../src/sessi
get_thread_cpu_usage(&m_network_thread_cpu_usage);
- | ||
| relevance 0 | ../src/session_impl.cpp:2238 | instead of having a special case for this, just make the default listen interfaces be "0.0.0.0:6881,[::1]:6881" and use the generic path. That would even allow for not listening at all. |
instead of having a special case for this, just make the
+ | ||
| relevance 0 | ../src/session_impl.cpp:2153 | instead of having a special case for this, just make the default listen interfaces be "0.0.0.0:6881,[::1]:6881" and use the generic path. That would even allow for not listening at all. |
instead of having a special case for this, just make the
default listen interfaces be "0.0.0.0:6881,[::1]:6881" and use
-the generic path. That would even allow for not listening at all.../src/session_impl.cpp:2238
+the generic path. That would even allow for not listening at all.../src/session_impl.cpp:2153
// reset the retry counter
m_listen_port_retries = m_settings.get_int(settings_pack::max_retry_port_bind);
@@ -4337,7 +4337,7 @@ retry:
if (s.sock)
{
- | ||
| relevance 0 | ../src/session_impl.cpp:3083 | should this function take a shared_ptr instead? |
should this function take a shared_ptr instead?../src/session_impl.cpp:3083 {
+ | ||
| relevance 0 | ../src/session_impl.cpp:2998 | should this function take a shared_ptr instead? |
should this function take a shared_ptr instead?../src/session_impl.cpp:2998 {
#if defined TORRENT_ASIO_DEBUGGING
complete_async("session_impl::on_socks_accept");
#endif
@@ -4358,13 +4358,11 @@ retry:
// currently expected to be scheduled for a connection
// with the connection queue, and should be cancelled
void session_impl::close_connection(peer_connection* p
- , error_code const& ec, bool cancel_with_cq)
+ , error_code const& ec)
{
TORRENT_ASSERT(is_single_thread());
boost::shared_ptr<peer_connection> sp(p->self());
- if (cancel_with_cq) m_half_open.cancel(p);
-
// someone else is holding a reference, it's important that
// it's destructed from the network thread. Make sure the
// last reference is held by the network thread.
@@ -4388,7 +4386,9 @@ retry:
TORRENT_ASSERT(p->is_disconnecting());
TORRENT_ASSERT(sp.use_count() > 0);
- | ||
| relevance 0 | ../src/session_impl.cpp:3439 | have a separate list for these connections, instead of having to loop through all of them |
have a separate list for these connections, instead of having to loop through all of them../src/session_impl.cpp:3439 if (m_auto_manage_time_scaler < 0)
+
+ connection_map::iterator i = m_connections.find(sp);
+ | ||
| relevance 0 | ../src/session_impl.cpp:3352 | have a separate list for these connections, instead of having to loop through all of them |
have a separate list for these connections, instead of having to loop through all of them../src/session_impl.cpp:3352 if (m_auto_manage_time_scaler < 0)
{
INVARIANT_CHECK;
m_auto_manage_time_scaler = settings().get_int(settings_pack::auto_manage_interval);
@@ -4439,7 +4439,7 @@ retry:
#ifndef TORRENT_DISABLE_DHT
if (m_dht)
- | ||
| relevance 0 | ../src/session_impl.cpp:3480 | this should apply to all bandwidth channels |
this should apply to all bandwidth channels../src/session_impl.cpp:3480 t.second_tick(tick_interval_ms, m_tick_residual / 1000);
+ | ||
| relevance 0 | ../src/session_impl.cpp:3393 | this should apply to all bandwidth channels |
this should apply to all bandwidth channels../src/session_impl.cpp:3393 t.second_tick(tick_interval_ms, m_tick_residual / 1000);
// if the call to second_tick caused the torrent
// to no longer want to be ticked (i.e. it was
@@ -4490,7 +4490,7 @@ retry:
&& m_stat.upload_ip_overhead() >= up_limit
&& m_alerts.should_post<performance_alert>())
{
- | ||
| relevance 0 | ../src/session_impl.cpp:4543 | these vectors could be copied from m_torrent_lists, if we would maintain them. That way the first pass over all torrents could be avoided. It would be especially efficient if most torrents are not auto-managed whenever we receive a scrape response (or anything that may change the rank of a torrent) that one torrent could re-sort itself in a list that's kept sorted at all times. That way, this pass over all torrents could be avoided alltogether. |
these vectors could be copied from m_torrent_lists,
+ | ||
| relevance 0 | ../src/session_impl.cpp:4455 | these vectors could be copied from m_torrent_lists, if we would maintain them. That way the first pass over all torrents could be avoided. It would be especially efficient if most torrents are not auto-managed whenever we receive a scrape response (or anything that may change the rank of a torrent) that one torrent could re-sort itself in a list that's kept sorted at all times. That way, this pass over all torrents could be avoided alltogether. |
these vectors could be copied from m_torrent_lists,
if we would maintain them. That way the first pass over
all torrents could be avoided. It would be especially
efficient if most torrents are not auto-managed
@@ -4498,7 +4498,7 @@ whenever we receive a scrape response (or anything
that may change the rank of a torrent) that one torrent
could re-sort itself in a list that's kept sorted at all
times. That way, this pass over all torrents could be
-avoided alltogether.../src/session_impl.cpp:4543#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_LOGGING
+avoided alltogether.../src/session_impl.cpp:4455#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_LOGGING
if (t->allows_peers())
t->log_to_all_peers("AUTO MANAGER PAUSING TORRENT");
#endif
@@ -4549,7 +4549,7 @@ avoided alltogether.../src/session_impl.cpp:4543| relevance 0 | ../src/session_impl.cpp:4618 | allow extensions to sort torrents for queuing |
|
allow extensions to sort torrents for queuing../src/session_impl.cpp:4618 if (t->is_finished())
+ | ||
| relevance 0 | ../src/session_impl.cpp:4530 | allow extensions to sort torrents for queuing |
allow extensions to sort torrents for queuing../src/session_impl.cpp:4530 if (t->is_finished())
seeds.push_back(t);
else
downloaders.push_back(t);
@@ -4600,10 +4600,10 @@ avoided alltogether.../src/session_impl.cpp:4543| relevance 0 | ../src/session_impl.cpp:4796 | use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections |
|
use a lower limit than m_settings.connections_limit
+ | ||
| relevance 0 | ../src/session_impl.cpp:4702 | use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections |
use a lower limit than m_settings.connections_limit
to allocate the to 10% or so of connection slots for incoming
-connections../src/session_impl.cpp:4796 // if we don't have any free slots, return
- if (free_slots <= -m_half_open.limit()) return;
+connections../src/session_impl.cpp:4702 // robin fashion, so that every torrent is equally likely to connect to a
+ // peer
// boost connections are connections made by torrent connection
// boost, which are done immediately on a tracker response. These
@@ -4622,8 +4622,8 @@ connections../src/session_impl.cpp:4796 int limit = (std::min)(m_settings.get_int(settings_pack::connections_limit)
- - num_connections(), free_slots);
+ int limit = m_settings.get_int(settings_pack::connections_limit)
+ - num_connections();
// this logic is here to smooth out the number of new connection
// attempts over time, to prevent connecting a large number of
@@ -4653,8 +4653,8 @@ connections../src/session_impl.cpp:4796| relevance 0 | ../src/session_impl.cpp:4959 | post a message to have this happen immediately instead of waiting for the next tick |
|
post a message to have this happen
-immediately instead of waiting for the next tick../src/session_impl.cpp:4959 // we've unchoked this peer, and it hasn't reciprocated
+ | ||
| relevance 0 | ../src/session_impl.cpp:4863 | post a message to have this happen immediately instead of waiting for the next tick |
post a message to have this happen
+immediately instead of waiting for the next tick../src/session_impl.cpp:4863 // we've unchoked this peer, and it hasn't reciprocated
// we may want to increase our estimated reciprocation rate
p->increase_est_reciprocation_rate();
}
@@ -4705,7 +4705,7 @@ immediately instead of waiting for the next tick../src/session_impl.cpp
prev = i;
}
#endif
- | ||
| relevance 0 | ../src/session_impl.cpp:4993 | make configurable |
make configurable../src/session_impl.cpp:4993
+ | ||
| relevance 0 | ../src/session_impl.cpp:4897 | make configurable |
make configurable../src/session_impl.cpp:4897
#ifdef TORRENT_DEBUG
for (std::vector<peer_connection*>::const_iterator i = peers.begin()
, end(peers.end()), prev(peers.end()); i != end; ++i)
@@ -4738,7 +4738,7 @@ immediately instead of waiting for the next tick../src/session_impl.cpp
++m_allowed_upload_slots;
- | ||
| relevance 0 | ../src/session_impl.cpp:5007 | make configurable |
make configurable../src/session_impl.cpp:5007 >= (*i)->uploaded_in_last_round() * 1000
+ | ||
| relevance 0 | ../src/session_impl.cpp:4911 | make configurable |
make configurable../src/session_impl.cpp:4911 >= (*i)->uploaded_in_last_round() * 1000
* (1 + t2->priority()) / total_milliseconds(unchoke_interval));
}
prev = i;
@@ -4789,7 +4789,7 @@ immediately instead of waiting for the next tick../src/session_impl.cpp
{
// if our current upload rate is less than 90% of our
// limit
- | ||
| relevance 0 | ../src/session_impl.cpp:5086 | this should be called for all peers! |
this should be called for all peers!../src/session_impl.cpp:5086 // we don't know at what rate we can upload. If we have a
+ | ||
| relevance 0 | ../src/session_impl.cpp:4990 | this should be called for all peers! |
this should be called for all peers!../src/session_impl.cpp:4990 // we don't know at what rate we can upload. If we have a
// measurement of the peak, use that + 10kB/s, otherwise
// assume 20 kB/s
upload_capacity_left = (std::max)(20000, m_peak_up_rate + 10000);
@@ -4840,10 +4840,10 @@ immediately instead of waiting for the next tick../src/session_impl.cpp
--unchoke_set_size;
TORRENT_ASSERT(p->peer_info_struct());
- | ||
| relevance 0 | ../src/session_impl.cpp:5501 | it might be a nice feature here to limit the number of torrents to send in a single update. By just posting the first n torrents, they would nicely be round-robined because the torrent lists are always pushed back |
it might be a nice feature here to limit the number of torrents
+ | ||
| relevance 0 | ../src/session_impl.cpp:5405 | it might be a nice feature here to limit the number of torrents to send in a single update. By just posting the first n torrents, they would nicely be round-robined because the torrent lists are always pushed back |
it might be a nice feature here to limit the number of torrents
to send in a single update. By just posting the first n torrents, they
would nicely be round-robined because the torrent lists are always
-pushed back../src/session_impl.cpp:5501 t->status(&*i, flags);
+pushed back../src/session_impl.cpp:5405 t->status(&*i, flags);
}
}
@@ -5318,7 +5318,7 @@ dedicated listen port../src/torrent.cpp:2708 | ||
| relevance 0 | ../src/torrent.cpp:3483 | add one peer per IP the hostname resolves to |
add one peer per IP the hostname resolves to../src/torrent.cpp:3483#endif
+ | ||
| relevance 0 | ../src/torrent.cpp:3482 | add one peer per IP the hostname resolves to |
add one peer per IP the hostname resolves to../src/torrent.cpp:3482#endif
void torrent::on_peer_name_lookup(error_code const& e
, std::vector<address> const& host_list, int port)
@@ -5369,7 +5369,7 @@ dedicated listen port../src/torrent.cpp:2708| relevance 0 | ../src/torrent.cpp:4474 | update suggest_piece? |
|
update suggest_piece?../src/torrent.cpp:4474
+ | ||
| relevance 0 | ../src/torrent.cpp:4473 | update suggest_piece? |
update suggest_piece?../src/torrent.cpp:4473
void torrent::peer_has_all(peer_connection const* peer)
{
if (has_picker())
@@ -5420,8 +5420,8 @@ dedicated listen port../src/torrent.cpp:2708| relevance 0 | ../src/torrent.cpp:4617 | really, we should just keep the picker around in this case to maintain the availability counters |
|
really, we should just keep the picker around
-in this case to maintain the availability counters../src/torrent.cpp:4617 pieces.reserve(cs.pieces.size());
+ | ||
| relevance 0 | ../src/torrent.cpp:4616 | really, we should just keep the picker around in this case to maintain the availability counters |
really, we should just keep the picker around
+in this case to maintain the availability counters../src/torrent.cpp:4616 pieces.reserve(cs.pieces.size());
// sort in ascending order, to get most recently used first
std::sort(cs.pieces.begin(), cs.pieces.end()
@@ -5472,12 +5472,12 @@ in this case to maintain the availability counters../src/torrent.cpp:46
}
void torrent::abort()
- | ||
| relevance 0 | ../src/torrent.cpp:6549 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync |
make this more generic to not just work if files have been
+ | ||
| relevance 0 | ../src/torrent.cpp:6543 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance
maybe use the same format as .torrent files and reuse some code from torrent_info
The mapped_files needs to be read both in the network thread
and in the disk thread, since they both have their own mapped files structures
-which are kept in sync../src/torrent.cpp:6549 super_seeding(rd.dict_find_int_value("super_seeding", 0));
+which are kept in sync../src/torrent.cpp:6543 super_seeding(rd.dict_find_int_value("super_seeding", 0));
if (!m_use_resume_save_path)
{
@@ -5528,12 +5528,12 @@ which are kept in sync../src/torrent.cpp:6549| relevance 0 | ../src/torrent.cpp:6712 | if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents |
|
if this is a merkle torrent and we can't
+ | ||
| relevance 0 | ../src/torrent.cpp:6706 | if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents |
if this is a merkle torrent and we can't
restore the tree, we need to wipe all the
bits in the have array, but not necessarily
we might want to do a full check to see if we have
all the pieces. This is low priority since almost
-no one uses merkle torrents../src/torrent.cpp:6712 add_web_seed(url, web_seed_entry::http_seed);
+no one uses merkle torrents../src/torrent.cpp:6706 add_web_seed(url, web_seed_entry::http_seed);
}
}
@@ -5584,9 +5584,9 @@ no one uses merkle torrents../src/torrent.cpp:6712 | ||
| relevance 0 | ../src/torrent.cpp:6902 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base |
make this more generic to not just work if files have been
+ | ||
| relevance 0 | ../src/torrent.cpp:6896 | make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base |
make this more generic to not just work if files have been
renamed, but also if they have been merged into a single file for instance.
-using file_base../src/torrent.cpp:6902 pieces.resize(m_torrent_file->num_pieces());
+using file_base../src/torrent.cpp:6896 pieces.resize(m_torrent_file->num_pieces());
if (!has_picker())
{
std::memset(&pieces[0], m_have_all, pieces.size());
@@ -5637,9 +5637,9 @@ using file_base../src/torrent.cpp:6902| relevance 0 | ../src/torrent.cpp:8888 | add a flag to ignore stats, and only care about resume data for content. For unchanged files, don't trigger a load of the metadata just to save an empty resume data file |
|
add a flag to ignore stats, and only care about resume data for
+ | ||
| relevance 0 | ../src/torrent.cpp:8864 | add a flag to ignore stats, and only care about resume data for content. For unchanged files, don't trigger a load of the metadata just to save an empty resume data file |
add a flag to ignore stats, and only care about resume data for
content. For unchanged files, don't trigger a load of the metadata
-just to save an empty resume data file../src/torrent.cpp:8888 if (m_complete != 0xffffff) seeds = m_complete;
+just to save an empty resume data file../src/torrent.cpp:8864 if (m_complete != 0xffffff) seeds = m_complete;
else seeds = m_policy ? m_policy->num_seeds() : 0;
if (m_incomplete != 0xffffff) downloaders = m_incomplete;
@@ -5690,10 +5690,10 @@ just to save an empty resume data file../src/torrent.cpp:8888 | ||
| relevance 0 | ../src/torrent.cpp:9855 | go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece |
go through the pieces we have and count the total number
+ | ||
| relevance 0 | ../src/torrent.cpp:9832 | go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece |
go through the pieces we have and count the total number
of downloaders we have. Only count peers that are interested in us
since some peers might not send have messages for pieces we have
-it num_interested == 0, we need to pick a new piece../src/torrent.cpp:9855 }
+it num_interested == 0, we need to pick a new piece../src/torrent.cpp:9832 }
rarest_pieces.clear();
rarest_rarity = pp.peer_count;
@@ -5744,8 +5744,8 @@ it num_interested == 0, we need to pick a new piece../src/torrent.cpp:9
if (num_cache_pieces > m_torrent_file->num_pieces())
num_cache_pieces = m_torrent_file->num_pieces();
- | ||
| relevance 0 | ../src/torrent.cpp:10501 | instead of resorting the whole list, insert the peers directly into the right place |
instead of resorting the whole list, insert the peers
-directly into the right place../src/torrent.cpp:10501 printf("timed out [average-piece-time: %d ms ]\n"
+ | ||
| relevance 0 | ../src/torrent.cpp:10478 | instead of resorting the whole list, insert the peers directly into the right place |
instead of resorting the whole list, insert the peers
+directly into the right place../src/torrent.cpp:10478 printf("timed out [average-piece-time: %d ms ]\n"
, m_average_piece_time);
#endif
}
@@ -5847,7 +5847,7 @@ directly into the right place../src/torrent.cpp:10501| relevance 0 | ../src/udp_socket.cpp:290 | it would be nice to detect this on posix systems also |
|
it would be nice to detect this on posix systems also../src/udp_socket.cpp:290 --m_v6_outstanding;
+ | ||
| relevance 0 | ../src/udp_socket.cpp:286 | it would be nice to detect this on posix systems also |
it would be nice to detect this on posix systems also../src/udp_socket.cpp:286 --m_v6_outstanding;
}
else
#endif
@@ -5898,7 +5898,7 @@ void udp_socket::call_handler(error_code const& ec, udp::endpoint const&
ret = (*i)->incoming_packet(ec, ep, buf, size);
} TORRENT_CATCH (std::exception&) {}
if (*i == NULL) i = m_observers.erase(i);
- | ||
| relevance 0 | ../src/upnp.cpp:72 | listen_interface is not used. It's meant to bind the broadcast socket |
listen_interface is not used. It's meant to bind the broadcast socket../src/upnp.cpp:72#include <asio/ip/multicast.hpp>
+ | ||
| relevance 0 | ../src/upnp.cpp:71 | listen_interface is not used. It's meant to bind the broadcast socket |
listen_interface is not used. It's meant to bind the broadcast socket../src/upnp.cpp:71#include <asio/ip/multicast.hpp>
#else
#include <boost/asio/ip/host_name.hpp>
#include <boost/asio/ip/multicast.hpp>
@@ -5918,7 +5918,7 @@ namespace upnp_errors
static error_code ec;
-upnp::upnp(io_service& ios, connection_queue& cc
+ upnp::upnp(io_service& ios
, address const& listen_interface, std::string const& user_agent
, portmap_callback_t const& cb, log_callback_t const& lcb
, bool ignore_nonrouters, void* state)
@@ -5936,7 +5936,6 @@ static error_code ec;
, m_disabled(false)
, m_closing(false)
, m_ignore_non_routers(ignore_nonrouters)
- , m_cc(cc)
, m_last_if_update(min_time())
{
TORRENT_ASSERT(cb);
@@ -5949,6 +5948,7 @@ static error_code ec;
upnp_state_t* s = (upnp_state_t*)state;
m_devices.swap(s->devices);
m_mappings.swap(s->mappings);
+ delete s;
| ||
| relevance 0 | ../src/ut_metadata.cpp:320 | we really need to increment the refcounter on the torrent while this buffer is still in the peer's send buffer |
we really need to increment the refcounter on the torrent
while this buffer is still in the peer's send buffer../src/ut_metadata.cpp:320 if (!m_tp.need_loaded()) return;
metadata = m_tp.metadata().begin + offset;
@@ -6463,10 +6463,10 @@ namespace libtorrent
// the pointer to the block of virtual address space
// making up the mmapped cache space
char* m_cache_pool;
- | ||
| relevance 0 | ../include/libtorrent/peer_connection.hpp:217 | make this a raw pointer (to save size in the first cache line) and make the constructor take a raw pointer. torrent objects should always outlive their peers |
make this a raw pointer (to save size in
+ | ||
| relevance 0 | ../include/libtorrent/peer_connection.hpp:216 | make this a raw pointer (to save size in the first cache line) and make the constructor take a raw pointer. torrent objects should always outlive their peers |
make this a raw pointer (to save size in
the first cache line) and make the constructor
take a raw pointer. torrent objects should always
-outlive their peers../include/libtorrent/peer_connection.hpp:217 , m_snubbed(false)
+outlive their peers../include/libtorrent/peer_connection.hpp:216 , m_snubbed(false)
, m_interesting(false)
, m_choked(true)
, m_corked(false)
@@ -6517,8 +6517,8 @@ outlive their peers../include/libtorrent/peer_connection.hpp:217 | ||
| relevance 0 | ../include/libtorrent/peer_connection.hpp:1144 | factor this out into its own class with a virtual interface torrent and session should implement this interface |
factor this out into its own class with a virtual interface
-torrent and session should implement this interface../include/libtorrent/peer_connection.hpp:1144
+ | ||
| relevance 0 | ../include/libtorrent/peer_connection.hpp:1123 | factor this out into its own class with a virtual interface torrent and session should implement this interface |
factor this out into its own class with a virtual interface
+torrent and session should implement this interface../include/libtorrent/peer_connection.hpp:1123
// the local endpoint for this peer, i.e. our address
// and our port. If this is set for outgoing connections
// before the connection completes, it means we want to
@@ -7094,7 +7094,7 @@ namespace libtorrent
// flags for the source bitmask, each indicating where
// we heard about this tracker
enum tracker_source
- | ||
| relevance 0 | ../include/libtorrent/upnp.hpp:113 | support using the windows API for UPnP operations as well |
support using the windows API for UPnP operations as well../include/libtorrent/upnp.hpp:113 // specific port
+ | ||
| relevance 0 | ../include/libtorrent/upnp.hpp:112 | support using the windows API for UPnP operations as well |
support using the windows API for UPnP operations as well../include/libtorrent/upnp.hpp:112 // specific port
external_port_must_be_wildcard = 727
};
@@ -7117,7 +7117,7 @@ typedef boost::function<void(char const*)> log_callback_t;
class TORRENT_EXTRA_EXPORT upnp : public intrusive_ptr_base<upnp>
{
public:
- upnp(io_service& ios, connection_queue& cc
+ upnp(io_service& ios
, address const& listen_interface, std::string const& user_agent
, portmap_callback_t const& cb, log_callback_t const& lcb
, bool ignore_nonrouters, void* state = 0);
@@ -7145,7 +7145,7 @@ public:
// is -1, which means failure. There will not be any error alert notification for
// mappings that fail with a -1 return value.
int add_mapping(protocol_type p, int external_port, int local_port);
- | ||
| relevance 0 | ../include/libtorrent/utp_stream.hpp:391 | implement blocking write. Low priority since it's not used (yet) |
implement blocking write. Low priority since it's not used (yet)../include/libtorrent/utp_stream.hpp:391 for (typename Mutable_Buffers::const_iterator i = buffers.begin()
+ | ||
| relevance 0 | ../include/libtorrent/utp_stream.hpp:390 | implement blocking write. Low priority since it's not used (yet) |
implement blocking write. Low priority since it's not used (yet)../include/libtorrent/utp_stream.hpp:390 for (typename Mutable_Buffers::const_iterator i = buffers.begin()
, end(buffers.end()); i != end; ++i)
{
using asio::buffer_cast;
@@ -7248,7 +7248,7 @@ public:
item(entry const& v
, std::pair<char const*, int> salt
, boost::uint64_t seq, char const* pk, char const* sk);
- | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:404 | move the login info into the tracker_request object |
move the login info into the tracker_request object../include/libtorrent/aux_/session_impl.hpp:404
+ | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:402 | move the login info into the tracker_request object |
move the login info into the tracker_request object../include/libtorrent/aux_/session_impl.hpp:402
void on_lsd_announce(error_code const& e);
// called when a port mapping is successful, or a router returns
@@ -7299,7 +7299,7 @@ public:
#ifndef TORRENT_DISABLE_EXTENSIONS
void add_extensions_to_torrent(
- | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:879 | should this be renamed m_outgoing_interfaces? |
should this be renamed m_outgoing_interfaces?../include/libtorrent/aux_/session_impl.hpp:879 // listen socket. For each retry the port number
+ | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:864 | should this be renamed m_outgoing_interfaces? |
should this be renamed m_outgoing_interfaces?../include/libtorrent/aux_/session_impl.hpp:864 // listen socket. For each retry the port number
// is incremented by one
int m_listen_port_retries;
@@ -7350,7 +7350,7 @@ public:
mutable boost::uint8_t m_interface_index;
void open_new_incoming_socks_connection();
- | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:928 | replace this by a proper asio timer |
replace this by a proper asio timer../include/libtorrent/aux_/session_impl.hpp:928 mutable boost::uint8_t m_interface_index;
+ | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:913 | replace this by a proper asio timer |
replace this by a proper asio timer../include/libtorrent/aux_/session_impl.hpp:913 mutable boost::uint8_t m_interface_index;
void open_new_incoming_socks_connection();
@@ -7374,7 +7374,7 @@ public:
// this is used to decide when to recalculate which
// torrents to keep queued and which to activate
- | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:933 | replace this by a proper asio timer |
replace this by a proper asio timer../include/libtorrent/aux_/session_impl.hpp:933 void setup_listener(listen_socket_t* s, std::string const& device
+ | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:918 | replace this by a proper asio timer |
replace this by a proper asio timer../include/libtorrent/aux_/session_impl.hpp:918 void setup_listener(listen_socket_t* s, std::string const& device
, bool ipv4, int port, int& retries, int flags, error_code& ec);
#ifndef TORRENT_DISABLE_DHT
@@ -7400,7 +7400,7 @@ public:
// is only decresed when the unchoke set
// is recomputed, and when it reaches zero,
// the optimistic unchoke is moved to another peer.
- | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:940 | replace this by a proper asio timer |
replace this by a proper asio timer../include/libtorrent/aux_/session_impl.hpp:940
+ | ||
| relevance 0 | ../include/libtorrent/aux_/session_impl.hpp:925 | replace this by a proper asio timer |
replace this by a proper asio timer../include/libtorrent/aux_/session_impl.hpp:925
// the number of unchoked peers as set by the auto-unchoker
// this should always be >= m_max_uploads
int m_allowed_upload_slots;
@@ -7451,7 +7451,7 @@ public:
int m_suggest_timer;
// statistics gathered from all torrents.
- | ||
| relevance 0 | ../include/libtorrent/aux_/session_interface.hpp:198 | it would be nice to not have this be part of session_interface |
it would be nice to not have this be part of session_interface../include/libtorrent/aux_/session_interface.hpp:198 virtual boost::uint16_t listen_port() const = 0;
+ | ||
| relevance 0 | ../include/libtorrent/aux_/session_interface.hpp:197 | it would be nice to not have this be part of session_interface |
it would be nice to not have this be part of session_interface../include/libtorrent/aux_/session_interface.hpp:197 virtual boost::uint16_t listen_port() const = 0;
virtual boost::uint16_t ssl_listen_port() const = 0;
// used to (potentially) issue socket write calls onto multiple threads
| ||