From b4b62076712080e29ccb4fbe497ba2ee7388e1f4 Mon Sep 17 00:00:00 2001 From: Christian Korneck Date: Sun, 13 Jan 2019 01:47:45 +0100 Subject: [PATCH] change highest allowed tcp port to 65535 --- http/http.go | 4 ++-- http/http_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/http/http.go b/http/http.go index 1635dfb..193920d 100644 --- a/http/http.go +++ b/http/http.go @@ -113,8 +113,8 @@ func (s *Server) newResponse(r *http.Request) (Response, error) { func (s *Server) newPortResponse(r *http.Request) (PortResponse, error) { lastElement := filepath.Base(r.URL.Path) port, err := strconv.ParseUint(lastElement, 10, 16) - if err != nil || port < 1 || port > 65355 { - return PortResponse{Port: port}, fmt.Errorf("invalid port: %d", port) + if err != nil || port < 1 || port > 65535 { + return PortResponse{Port: port}, fmt.Errorf("invalid port: %s", lastElement) } ip, err := ipFromRequest(s.IPHeaders, r) if err != nil { diff --git a/http/http_test.go b/http/http_test.go index 52cb2bf..68f1f3f 100644 --- a/http/http_test.go +++ b/http/http_test.go @@ -132,7 +132,7 @@ func TestJSONHandlers(t *testing.T) { {s.URL, `{"ip":"127.0.0.1","ip_decimal":2130706433,"country":"Elbonia","country_eu":false,"country_iso":"EB","city":"Bornyasherk","hostname":"localhost","latitude":63.416667,"longitude":10.416667}`, 200}, {s.URL + "/port/foo", `{"error":"Invalid port: 0"}`, 400}, {s.URL + "/port/0", `{"error":"Invalid port: 0"}`, 400}, - {s.URL + "/port/65356", `{"error":"Invalid port: 65356"}`, 400}, + {s.URL + "/port/65537", `{"error":"Invalid port: 65537"}`, 400}, {s.URL + "/port/31337", `{"ip":"127.0.0.1","port":31337,"reachable":true}`, 200}, {s.URL + "/foo", `{"error":"404 page not found"}`, 404}, {s.URL + "/health", `{"status":"OK"}`, 200},