From f3b4c74e3e3eff8086f8e40b2fc022bde379c888 Mon Sep 17 00:00:00 2001 From: Nat <56046513+NathaanTFM@users.noreply.github.com> Date: Tue, 17 Dec 2024 12:52:09 +0100 Subject: [PATCH] skyconv fix "buffer overflow detected" --- tools/skyconv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/skyconv.c b/tools/skyconv.c index 4c2245a1..237b00db 100644 --- a/tools/skyconv.c +++ b/tools/skyconv.c @@ -250,7 +250,7 @@ void write_tiles() { for (int i = 0; i < props.numRows * props.numCols; i++) { if (!tiles[i].useless) { *filename = 0; - snprintf(filename, PATH_MAX, ".%d.rgba16.png", tiles[i].pos); + snprintf(filename, PATH_MAX - dirLength, ".%d.rgba16.png", tiles[i].pos); rgba2png(buffer, tiles[i].px, props.tileWidth, props.tileHeight); } } @@ -284,7 +284,7 @@ static void write_skybox_c() { /* write c data to disc */ exit(EXIT_FAILURE); } - sprintf(fBuffer, "%s/%s_skybox.c", output, skyboxName); + snprintf(fBuffer, PATH_MAX, "%s/%s_skybox.c", output, skyboxName); cFile = fopen(fBuffer, "w"); /* reset file */ /* setup C file */