From 4f35711844eb5931833467fe15568aed7b38a381 Mon Sep 17 00:00:00 2001
From: Alexander Borsuk <alexander.borsuk@qnective.com>
Date: Fri, 17 Dec 2021 11:22:09 +0100
Subject: [PATCH] Clang-Tidy warning fixes.

* src/base/ftobjs.c (FT_Get_Paint): Operator has equivalent nested operands.
* src/bdf/bdflib.c (_bdf_add_property): Value stored to `fp` is never read.
* src/sdf/ftbsdf.c (bsdf_init_distance_map): Value stored to `pixel` is
never read.
* src/sdf/ftsdf.c (split_sdf_shape): Value stored to `error` is never read.
---
 src/base/ftobjs.c | 2 +-
 src/bdf/bdflib.c  | 1 -
 src/sdf/ftbsdf.c  | 2 --
 src/sdf/ftsdf.c   | 4 +++-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/base/ftobjs.c b/src/base/ftobjs.c
index 883f1a897..f5eee7878 100644
--- a/src/base/ftobjs.c
+++ b/src/base/ftobjs.c
@@ -5729,7 +5729,7 @@
     SFNT_Service  sfnt;
 
 
-    if ( !face || !paint || !paint )
+    if ( !face || !paint )
       return 0;
 
     if ( !FT_IS_SFNT( face ) )
diff --git a/src/bdf/bdflib.c b/src/bdf/bdflib.c
index e317bdddd..86ebe6096 100644
--- a/src/bdf/bdflib.c
+++ b/src/bdf/bdflib.c
@@ -1174,7 +1174,6 @@
                             font->props_size + 1 ) )
         goto Exit;
 
-      fp = font->props + font->props_size;
       font->props_size++;
     }
 
diff --git a/src/sdf/ftbsdf.c b/src/sdf/ftbsdf.c
index 8da5c9d9e..e1856e2f5 100644
--- a/src/sdf/ftbsdf.c
+++ b/src/sdf/ftbsdf.c
@@ -756,8 +756,6 @@
             byte  = (FT_Byte)( 1 << mod );
 
             t[t_index].alpha = pixel & byte ? 255 : 0;
-
-            pixel = 0;
           }
         }
       }
diff --git a/src/sdf/ftsdf.c b/src/sdf/ftsdf.c
index f69cf49b4..00e21fe0f 100644
--- a/src/sdf/ftsdf.c
+++ b/src/sdf/ftsdf.c
@@ -1277,9 +1277,11 @@
 
         default:
           error = FT_THROW( Invalid_Argument );
-          goto Exit;
         }
 
+        if ( error != FT_Err_Ok )
+          goto Exit;
+
         edges = edges->next;
       }