92f1937b97
fix typo in #if tests for TORRENT_DISABLE_ENCRYPTION
2018-07-29 09:04:16 +02:00
33685c6c85
merge RC_1_1 into master
2018-07-28 10:10:01 +02:00
c92f527b60
in torrent_handle::id(), only shift down the pointer by 10 bits
2018-07-28 10:03:30 +02:00
b3856d3027
narrow the scope affected by TORRENT_DISABLE_EXTENSIONS to only disable the user extensions, but always support the extension message and the built-in extensions, like lt_donthave and seed_mode
2018-07-26 09:31:49 +02:00
8f0cf7e1a9
some refactor to reduce duplicate code
2018-07-25 18:48:34 +02:00
4282dd072a
factor out generate_peer_id into its own file
2018-07-25 08:49:18 +02:00
a1f2995716
add piece index range checks on have_piece() and read_piece()
2018-07-25 00:20:18 +02:00
730ef15b08
minor cleanups
2018-07-24 16:34:46 +02:00
c2ebae7dbb
make metric_type_t an enum class, deprecate the in-class enum values
2018-07-24 15:29:56 +02:00
dcb8b816a3
only post alerts for newly opened listen sockets, and only attempt to map ports for newly opened sockets. track has_incoming_connections per listen socket
2018-07-23 15:04:23 +02:00
2f56fa6c3e
bump version to 1.1.9
2018-07-20 13:06:12 +02:00
f4b0dbf115
merged RC_1_1 into master
2018-07-20 09:28:21 +02:00
1ebc5f9ef2
remove special handling of uTP peers
2018-07-20 07:47:08 +02:00
e92cf18340
fix some warnings around unused variables, dead stores, potentially dereferencing nullptr and calling virtual functions from constructor
2018-07-20 01:03:16 +02:00
d8755066e8
give some magic numbers names
2018-07-20 00:58:34 +02:00
a7b7623f23
return values instead of using out-params
2018-07-19 23:58:36 +02:00
f89c27183b
remove unused function
2018-07-18 09:18:09 +02:00
4aa3c4573a
use the strong type for pause flags
2018-07-16 12:06:21 +02:00
4633258fbe
make the DHT announce flags a strong type
2018-07-16 12:04:16 +02:00
e5be30157f
set port in handshake based on source address ( #3172 )
2018-07-15 21:15:04 +02:00
37a6a47ea3
minor cleanups around saving resume data
2018-07-12 08:38:53 +02:00
961cf62cad
dht: announce with per-interface listen port
2018-07-12 08:36:57 +02:00
965ca9a565
avoid copy of arrays in dht alerts constructors
2018-07-09 19:53:35 +02:00
e317c72db3
merged RC_1_1 into master
2018-07-08 18:52:13 +02:00
3c2b076eb0
deprecated anonymous_mode_alert
2018-07-08 18:26:47 +02:00
b750b6cc2c
deprecate (and disable) the force-proxy setting. Instead, always use the proxy when set, never fall back on circumventing it
2018-07-08 18:26:47 +02:00
2ba0e5ae2c
move the file priority vector throught the disk_io_job, to avoid copies
2018-07-08 18:25:06 +02:00
d2d35b69fd
raise priority of cache_flushed_alert and post it unconditionally when triggered explicily by the client
2018-07-08 18:23:44 +02:00
e45df614fe
improve type safety of internal leave_seed_mode() function
2018-07-08 17:32:50 +02:00
6d2f804d9f
code refactor related to the use of index_range and end index
2018-07-08 17:32:30 +02:00
3fede4b223
merged RC_1_1 into master
2018-07-08 11:55:32 +02:00
efe3036879
clean up proxy_settings constructors
2018-07-07 18:02:43 +02:00
1c86e94de6
Fix deadlock when loading libtorrent Dll
...
Definition of `bool file::has_manage_volume_privs` involves a call to
`get_manage_volume_privs()`, causing restricted tasks to be performed
from within `DllMain` function. They introduce possibility that client
application deadlocks or crashes.
You should never perform the following tasks from within DllMain:
* Call `LoadLibrary` or `LoadLibraryEx` (either directly or indirectly).
This can cause a deadlock or a crash.
* Call the registry functions. These functions are implemented in
'Advapi32.dll'. If not initialized before your DLL, it can access
uninitialized memory and cause the process to crash.
2018-07-07 18:00:07 +02:00
d439c8729a
qualify some assignment operators to disallow assignment to temporaries
2018-07-01 17:29:50 +02:00
2c5da2778a
more lint oriented code refactor/cleanup
2018-06-29 13:27:29 +02:00
4576723090
bump version to 1.1.8
2018-06-25 12:25:11 +02:00
17300decb5
improve naming of deprecated settings enums
2018-06-24 16:50:18 +02:00
be78a43d05
more use of empty(), emplace_back, const and auto in disk_io_thread code
2018-06-24 07:02:17 +02:00
2cb29f88ac
merged RC_1_1 into master
2018-06-23 23:22:26 +02:00
f139afc1ad
minor code refactor, cleanup and typo in peer related code
2018-06-23 23:11:48 +02:00
b7f230316c
set the minimum number of checking jobs based on the number of hasher threads
...
To effectively mask the latency of generating more hash jobs there need to be
at least two jobs in-flight for each hasher thread.
2018-06-23 23:10:55 +02:00
f5a2015302
merge RC_1_1 into master
2018-06-19 22:26:01 +02:00
4ae262d2d4
fix race condition in part_file
2018-06-19 14:50:02 +02:00
81ce7aa4ab
Fix parts file i/o errors ( #3110 )
...
Since i/o operations are not synchronized, it is possible that one thread closes file handle, opened in another thread. With addition of `hidden` file attribute, an old bug in `part_file::open_file()` revealed both problems, causing a lot of random i/o errors in parts file. Fixing `open_file` bug should reduce the number of such errors back to 'normal'.
2018-06-18 14:34:39 +02:00
ca7313580e
merged RC_1_1 into master
2018-06-16 17:47:32 +02:00
5530793c75
improve the API for iterating over all files and pieces, with the new strong index types.
2018-06-12 11:44:29 +02:00
a2ea79de4e
minor code refactor in utp related code, more use of const
2018-06-12 11:41:32 +02:00
95b753778d
use TORRENT_ABI_VERSION for new error_code_enum deprecated values ( #3099 )
2018-06-12 00:46:22 +02:00
2364699292
clarify documentation for move_storage()
2018-06-11 00:05:36 +02:00
b26467c04e
deprecate network-threads setting
2018-06-10 19:34:07 +02:00
e8f971a54a
scrape_reply_alert should be high priority, since it's triggered by the client
2018-06-10 19:28:45 +02:00
6647b0988d
add support for multi-home NAT-PMP and PCP
2018-06-10 16:55:42 +02:00
247672820c
report transport version in NAT-PMP send/receive logs
2018-06-09 16:40:46 -07:00
a357e490ed
minor code refactor, more use of auto
2018-06-08 21:56:06 +02:00
fbaa1afd62
return a vector of mapping ids from add_port_mapping
2018-06-07 18:18:31 -07:00
e523566622
add support for the Port Control Protocol (PCP)
2018-06-07 18:18:31 -07:00
78be52112f
create a natpmp instance for each listen socket
2018-06-07 18:16:08 -07:00
e88339378c
merged RC_1_1 into master
2018-06-07 00:30:23 +02:00
2408200475
fix race condition in stat_cache
2018-06-05 19:07:33 +02:00
794ccf4f79
remove unused disk stats counters
2018-06-05 19:03:04 +02:00
95cfc16bca
fix integer overflow in alert_manager
2018-06-02 15:16:08 +02:00
267ca40b28
merged RC_1_1 into master
2018-06-02 13:15:13 +02:00
c55bc7dd42
improve error handling of failing to change file priority
2018-05-31 00:47:17 +02:00
8a0ac58658
some lint oriented refactor, more use of const
2018-05-30 23:52:28 +02:00
c56f6abf72
deliver notification of alerts being dropped via alerts_dropped_alert
2018-05-30 11:26:02 +02:00
6c4869f044
moved instantiate_connection to aux namespace
2018-05-29 09:25:25 +02:00
396c5dd3af
remove use of deprecated function readdir_r
...
Ports 140b8ace
2018-05-28 16:06:41 +02:00
3b0ce8d2e1
merged RC_1_1 into master
2018-05-28 15:56:22 +02:00
35d7672432
raise priority of fastresum_rejected_alert
2018-05-27 22:33:24 +02:00
d6cecee8c0
some code cleanup and minor refactor
2018-05-24 23:46:37 +02:00
534276e7a5
refactor to use the utility function for bind_socket_to_device() instead of using the bind_to_device socket option directly, to make it best effort. include operation enum in udp_error alert.
2018-05-23 12:11:04 +02:00
ff300ed224
some cleanup and refactor in torrent_info code ( #3054 )
2018-05-23 10:39:55 +02:00
1a66a8b285
merged RC_1_1 into master
2018-05-20 12:08:46 +02:00
a137bbfdd4
simplify some using statements to pull in the address types
2018-05-20 08:46:14 +02:00
5f74b6e353
Bump `file_error_alert` priority
...
This alert's priority must be higher than `block_downloading_alert`'s
to allow custom handling of file errors.
With progress notifications enabled, network thread might fully load
alerts queue, so file errors from disk thread won't have a chance to
be delivered.
2018-05-17 00:55:07 +02:00
a7b2026ef8
minor code refactor in ip_filter code
2018-05-14 23:58:01 +02:00
ccdfd7383e
move export.hpp into aux_ folder. put assert symbols in libtorrent namespace
2018-05-14 09:09:01 +02:00
fe612ca167
replace the TORRENT_CFG ABI check with inline namespaces around the symbol that can change ABI based on build configuration options
2018-05-13 19:25:17 +02:00
4523e05527
fix uTP and SOCKS5 simulations and update libsimulator
2018-05-13 12:10:34 +02:00
f052d1ca40
Fix bandwidth allocation ( #2810 )
...
Don't allow peer connection to ask quota from bandwidth manager if send buffer is empty.
Remove undefined member function
Update download rate multiplier
2018-05-12 13:53:03 +02:00
ddd1168296
don't attempt to make uTP connections if we don't have any outgoing UDP sockets
2018-05-12 13:34:58 +02:00
4d17e0132e
fix empty outgoing interfaces for UDP sockets
2018-05-12 13:34:58 +02:00
c98b700d4f
merged RC_1_1
2018-05-10 22:48:39 +02:00
8fdba2aa39
don't specialize standard type trait is_integral
...
Concerning type traits, the C++ standard states: "The behavior of a program
that adds specializations for any of the templates defined in this subclause is
undefined unless otherwise specified."
There is no exception for is_integral.
2018-05-10 19:06:18 +02:00
5f758b8531
remove redundant set_piece_hashes template. take a std::function instead
2018-05-10 12:10:33 +02:00
81fd09775c
Fix compilation with GCC 8
2018-05-07 13:33:18 +02:00
dc28c96559
Fix unit tests build
...
Export `recursive_mutex` because `emplace_alert` template injects
dependency on that type during instatiation.
2018-05-07 00:53:48 +02:00
894933e1f1
fix typo in comment
2018-05-06 20:59:32 +02:00
4b368e1cfc
merged RC_1_1 into master
2018-05-02 01:57:41 +02:00
8808eb7cdd
introduce a recursive mutex to protect the alert_manager, and hold the mutex while calling user callbacks and plugin hooks. This is required to ensure the underlying storage for alert allocations (in the stack allocators) is synchronized with the thread that may be accessing it
2018-05-01 23:17:51 +02:00
8da635d1f5
minor code cleanup, more use of const
2018-05-01 23:03:29 +02:00
26b0487f0b
merged RC_1_1 into master
2018-05-01 21:26:42 +02:00
785f173df3
Revise alert priorities / torrent::on_resume_data_checked issue ( #2962 )
...
Most status alerts should have priorities above normal level. Good reason for this is resume data verification case. For a large torrent(having lots of pieces) whole alert queue will be overflowed
with a `piece_finished_alert` right after resume data has been verified. Thus alerts like `torrent_checked_alert`, `torrent_finished`, `state_changed_alert` will not go the alerts queue.
* Introduce alert_priority enumeration
* Bump state_changed_alert's priority
* Set dht_direct_response_alert priority to `critical`
2018-05-01 12:26:37 +02:00
33bf3c827f
fix deprecation markups
2018-04-28 22:47:38 +02:00
8621477239
merged RC_1_1 into master
2018-04-28 14:36:24 +02:00
f5e33932d2
fix use after free in flush_range and flush_iovec
...
Calling blocks_flushed can cause the piece entry to be freed so its
callers need to be aware of that and avoid dereferencing the pointer if
the entry is freed.
2018-04-27 16:15:19 +02:00
2a97ec6e0e
Windows: Fix build Visual C++ ARM/ARM64
2018-04-25 16:07:47 -04:00
83dd6c9c53
cleanup and refactor in storage source code
2018-04-25 16:02:30 -04:00
6394e7ac02
Fix MSVC warning C4267 by casting to the correct type explictly
2018-04-24 23:16:54 -04:00
21d8e9e26b
Add missing header <cstdarg> for va_list.
...
* Fix building on OpenBSD.
2018-04-24 23:09:25 -04:00
Steven Siloti