81fd09775c
Fix compilation with GCC 8
2018-05-07 13:33:18 +02:00
4b368e1cfc
merged RC_1_1 into master
2018-05-02 01:57:41 +02:00
8808eb7cdd
introduce a recursive mutex to protect the alert_manager, and hold the mutex while calling user callbacks and plugin hooks. This is required to ensure the underlying storage for alert allocations (in the stack allocators) is synchronized with the thread that may be accessing it
2018-05-01 23:17:51 +02:00
8da635d1f5
minor code cleanup, more use of const
2018-05-01 23:03:29 +02:00
377e800e72
fixed conversion warnings in 32 bits
2018-04-30 23:09:00 +02:00
ec18742f8e
save the number of idle threads locally in disk_io_thread_pool::thread_active
...
This cuts down on the number of atomic loads while also being more correct.
Before it was possible for m_num_idle_threads to increase before its value
could be stored in m_min_idle_threads.
2018-04-29 16:31:18 +02:00
8621477239
merged RC_1_1 into master
2018-04-28 14:36:24 +02:00
f5e33932d2
fix use after free in flush_range and flush_iovec
...
Calling blocks_flushed can cause the piece entry to be freed so its
callers need to be aware of that and avoid dereferencing the pointer if
the entry is freed.
2018-04-27 16:15:19 +02:00
366b7983d1
fix typo with bind_outgoing_socket~
2018-04-26 19:50:25 -04:00
2a97ec6e0e
Windows: Fix build Visual C++ ARM/ARM64
2018-04-25 16:07:47 -04:00
0ec66e9024
fix disk_io_thread::do_check_fastresume storage initialize logic from RC_1_1 merge
2018-04-25 16:04:20 -04:00
83dd6c9c53
cleanup and refactor in storage source code
2018-04-25 16:02:30 -04:00
b4d2281e53
honor torrent abort even on file check error
2018-04-24 23:14:48 -04:00
21d8e9e26b
Add missing header <cstdarg> for va_list.
...
* Fix building on OpenBSD.
2018-04-24 23:09:25 -04:00
3ede0b9c20
fix last_upload, last_download and last_scrape to be reported accurately and saved/restored in resume data
2018-04-22 06:14:22 -04:00
d34973def9
minor code cleanup in disk buffer code
2018-04-21 23:48:40 -04:00
d8c022070f
merged RC_1_1 into master
2018-04-21 17:17:55 -04:00
bcb9e4546f
Use settings_pack::urlseed_wait_retry for default retry with http seeds. ( #2948 )
...
Update documentation
2018-04-21 18:36:56 +02:00
44479bcca3
Fix storage initialization ( #2944 )
...
If `default_storage::has_any_file` fails during fastresume data check, `piece_manager::check_no_fastresume` will skip storage initialization. In such case, any storage operation that require part file will cause an application crash.
2018-04-21 18:35:55 +02:00
52e1a7b6c9
merged RC_1_1 into master
2018-04-15 11:00:57 +02:00
9cd0ae67e7
another boost-1.67 build fix
2018-04-13 14:43:41 +02:00
791a1e8557
minor code refactor and a few const in torrent.cpp
2018-04-13 14:17:02 +02:00
f0227451a6
merged RC_1_1 into master
2018-04-13 01:47:41 +02:00
236e0e7699
pass default constructed boost::function instead of NULL
...
Clang 6 defines NULL as nullptr which breaks implicit construction
of boost::function from NULL.
2018-04-12 14:32:31 +02:00
9b1e79660f
removed unnecessary parentheses around min/max, added some const modifier ( #2926 )
2018-04-11 15:19:00 +02:00
aaf9304a3b
update year in copyright header
2018-04-09 09:04:33 +02:00
105934e578
bump version
2018-04-08 23:08:39 +02:00
c5a5e084dd
:strtoll() returns LLONG_MAX if the input overflows. Handle this case properly in the http parser
2018-04-08 18:34:25 +02:00
a7406de2b8
remove the global cache of the current time, just use clock::now() instead
2018-04-07 21:43:18 +02:00
c08a6bf430
Make SACK header to be able to take up the whole packet. Rename m_in_buf_size to m_receive_buffer_capacity
2018-04-07 18:55:14 +02:00
257f625e2e
Increase m_in_buf_size and max_packet_reorder to better handle links with high latency
2018-04-07 18:55:14 +02:00
bf2f0a9c55
Fix advertised window being counted twice in congestion check
2018-04-07 18:55:14 +02:00
9d83da110b
Delay hash_failed_alert until on_piece_sync()
...
Delay the hash_failed_alert until after synchronizing with the IO thread
so that it can be used to synchronize piece progress.
2018-04-07 15:59:40 +02:00
d6edf26e11
minor code tidy
2018-04-07 00:30:36 +02:00
2d9bff0877
make socket_entry buffer std::array
2018-04-06 10:04:32 +02:00
6efff919cd
deprecated alert::progress_notification alert category, split into finer grained categories
2018-04-05 16:27:28 +02:00
2a82bb5880
disk_io_thread abort_hash_jobs duplicate code refactor
2018-04-05 16:01:30 +02:00
357217326d
some cleanups
2018-04-05 12:59:35 +02:00
32b2de8f17
merged RC_1_1 into master
2018-04-04 20:48:07 +02:00
0d9862a8dd
fix wrong variable name
2018-04-04 19:41:03 +02:00
16f1deb3ec
merged RC_1_1 into master
2018-04-04 15:28:33 +02:00
a5e0578c88
fix part-file header allocation
2018-04-03 20:46:49 +02:00
77102102d6
simplify some for-loops in xml_parse
2018-04-03 18:45:04 +02:00
49ae7858a8
fix potential fd leak in enum_net_interfaces
2018-04-03 13:44:33 +02:00
98d5313598
don't perform DNS lookups for the DHT bootstrap unless DHT is enabled
2018-04-01 23:53:12 +02:00
5b922072e9
avoid calls to .address() when looking for endpoint protocol ( #2892 )
...
using is_v4 and is_v6 where possible
2018-04-01 13:48:17 +02:00
6a2df1034a
add some asserts and checks preventing IPv6 addresses to make it into libtorrent when IPv6 support is disabled
2018-03-31 14:17:06 +02:00
1f06a6684c
avoid calling address to test protocol, more consts and minor lint oriented code changes
2018-03-29 12:20:59 +02:00
f963f2c726
minor lint oriented code refactor
2018-03-28 15:55:05 +02:00
90e4cefa91
removed unnecessary loop in request_a_block
2018-03-28 15:54:50 +02:00
d080c6f532
merged RC_1_1 into master
2018-03-26 12:56:25 +02:00
1c867a5026
Changing file priorities while checking interrupts checking.
...
Also, if the last file has zero priority, checking is interrupted prematurely.
2018-03-26 02:59:10 +02:00
0fa24faec4
merged RC_1_1 into master
2018-03-25 22:06:41 +02:00
02a01fa22e
fix issue where the current tracker would be skipped for the next tracker in the same tier
2018-03-25 14:40:38 +02:00
67bbb82122
improve type-safety in piece picker, by introducing a type for download queue index, for pieces
2018-03-24 23:03:09 +01:00
3171245292
fix warnings
2018-03-24 23:01:19 +01:00
f94a8169fc
added some const in bandwidth_limit.cpp
2018-03-24 22:59:54 +01:00
9cab4d7d31
using move with bw_request and make sure it is movable
2018-03-24 10:48:16 +01:00
9df4d4b7f8
replace typedef with using. replace NULL with nullptr. cleanup page_aligned_allocator
2018-03-23 11:19:46 +01:00
7a477cd938
more use of move and code refactor in bandwidth related code
2018-03-22 18:01:01 +01:00
82f87b0655
remove redundant check in tracker announce. This is checked in http_tracker_connection
2018-03-21 23:38:10 +01:00
6b35ebb9ad
some code refactor and cleanup in broadcast_socket
2018-03-21 23:37:52 +01:00
4bfa920fe7
refactor in macro conditions for helper_getauxval to avoid unused function warning in android x86
2018-03-21 13:45:28 +01:00
3efb81e50c
add windows socket libraries in Makefile.am
2018-03-21 13:44:59 +01:00
8a85e1c01a
merged RC_1_1 into master
2018-03-21 12:17:11 +01:00
7dad0db4a5
fix warnings in bdecode and disk_io_job
2018-03-20 12:43:44 +01:00
09bf97b79e
minor fixes in utp_socket_impl
2018-03-18 17:03:05 +01:00
61ae2c834b
removed unused bt_peer_connection::on_keepalive
2018-03-16 17:32:20 +01:00
4b144ba451
merged RC_1_1 into master
2018-03-16 13:16:45 +01:00
0edb0f28c1
stat files in the disk thread, in default_storage::initialize() instead of the constructor
2018-03-15 14:54:49 +01:00
4f7b683eb0
fix if defined TORRENT_ANDROID
...
Fix malformed TORRENT_ANDROID macroprocessor tests, related to #2831
2018-03-14 09:32:18 +01:00
8658fb5f7c
deprecate the error_file_* constants whose underlying features have been deprecated
2018-03-13 19:39:55 +01:00
f8889858f6
dynamically load getauxval so as to support older android devices
2018-03-12 09:11:01 +01:00
5c1b65e9b8
merged RC_1_1 into master
2018-03-12 02:32:12 +01:00
a06e4f696b
track whether a file is eligible for using the partfile on a per-file basis. This is intended to improve backwards compatibility, to better support resuming files downloaded with older versions of libtorrent
2018-03-11 12:52:56 +01:00
2bc2f3af0f
Add missing define for old android sdk ( #2831 )
...
define NETLINK_NO_ENOBUFS and IFA_D_DADFAILED if they don't exist
2018-03-09 22:37:21 +01:00
05f7a95604
fix reporting &redundant= in tracker announces
2018-03-08 02:11:46 +01:00
1f86beb253
ask for protocol instead of copy address in ut_pex_peer_store::was_introduced_by
2018-03-07 09:44:45 +01:00
5478f57e43
fix windows build with UNC paths disabled
2018-03-06 08:48:19 +01:00
135e47c929
minimal optimization by using node_id::is_all_zero
2018-03-05 09:01:25 +01:00
448de4ca14
more use of emplace_back in chained_buffer
2018-03-04 11:34:24 +01:00
80f5edc500
added some static and const in node.cpp and minor cleanup in rpc_manager.cpp
2018-03-02 11:29:59 +01:00
9696082355
merged RC_1_1 into master
2018-02-25 09:36:12 +01:00
24dea1f845
fix tie-break in duplicate peer connection disconnect logic
2018-02-21 21:04:28 +01:00
e81eaf5935
minor cleanup in uTP code
2018-02-21 10:07:22 +01:00
2ac84ed5f5
minor code cleanup in http_tracker_connection code
2018-02-21 09:23:03 +01:00
53b4725da3
clean up noexcept specifiers to adapt to what the implementation provides
2018-02-20 08:43:52 +01:00
eec34e3ac3
fix issue with SSL tracker connections left in CLOSE_WAIT state ( #2797 )
2018-02-20 08:40:47 +01:00
f94b62acf7
CMake improvements
...
CMake build scripts improved to simplify configuring and building of
project and tests.
Better use of compile definitions by replacing add_definitions with
target_compile_definitions. Use INTERFACE, PUBLIC and PRIVATE keywords
to separate scope of TORRENT_BUILDING_SHARED and TORRENT_LINKING_SHARED
definitions.
* Move tests to the separate file - test/CmakeLists.txt
* Fix use of compile definitions
* Remove redundant tailqueue.cpp
2018-02-19 23:23:15 +01:00
421709f67f
added friendly_name and description to ip_interface ( #2799 )
2018-02-19 11:46:35 +01:00
1ede34da8a
undo the patch to restore incoming TCP connections over SOCKS5
2018-02-19 00:01:42 +01:00
f8fb5c2294
merged RC_1_1 into master
2018-02-10 22:52:12 +01:00
a1860426b8
defer truncating existing files until the first time we write to them
2018-02-10 18:33:41 +01:00
77181c1469
fix issue when receiving a torrent with 0-sized padfiles as magnet link
2018-02-09 17:41:30 +01:00
d2e874fca8
headers code cleanup, removed unused fields in torrent class ( #2775 )
2018-02-06 08:32:19 +01:00
15a8a17a6f
merged RC_1_1 into master
2018-02-05 08:55:15 +01:00
a0a63341c7
fix haiku build
2018-02-04 19:10:43 +01:00
3261eea63a
more use of emplace and minor code refactor in bt_peer_connection.cpp
2018-02-02 21:53:48 +01:00
fe9883ea27
avoid endianness test in peer_priority function
2018-01-31 22:49:25 +01:00
91e03c789c
fix issue resuming 1.0.x downloads with a file priority 0
2018-01-31 22:43:07 +01:00
5d230a69f2
minor code cleanup
2018-01-30 12:38:08 +01:00
01c41fadcf
fix torrent_status::next_announce
2018-01-29 15:08:18 +01:00
50a293730b
merged RC_1_1 into master
2018-01-29 10:20:45 +01:00
e126d7bce0
move socket_type into aux-namespace
2018-01-29 08:33:45 +01:00
9ac394f5b0
turn piece picker option flags into a proper type
2018-01-29 03:01:17 +01:00
a33c81ad33
shave down session_interface by one function, reduce the dependencies between torrent and session
2018-01-29 03:00:59 +01:00
ca3ea591df
fix pad-file scalability issue
2018-01-29 03:00:37 +01:00
720bfa54cd
merged RC_1_1 into master
2018-01-29 01:20:08 +01:00
b729021625
make coalesce-buffers work on windows and systemps with pwritev()/preadv()
2018-01-28 23:05:01 +01:00
a50579c651
merged RC_1_1 into master
2018-01-27 09:41:54 +01:00
084e980d52
avoid repeated calls to .address(), minor refactor
2018-01-27 09:22:38 +01:00
fa03cbea9b
Revise torrent state update
...
* Remove unused m_in_state_updates
* Update m_state_subscription comments
2018-01-27 09:17:40 +01:00
308cbfe097
merged RC_1_1 into master
2018-01-27 02:36:55 +01:00
bc4d53c71f
restore support for incoming connections over SOCKS5 (disabled by default)
2018-01-25 09:14:14 +01:00
4fef787212
merged RC_1_1 into master
2018-01-24 00:37:05 +01:00
efd096d879
use unique peer_ids per connection
2018-01-23 16:40:16 +01:00
89c6f0b4a8
merged RC_1_1 into master
2018-01-21 15:51:22 +01:00
ed7ef8fdd6
minor cleanups in some extensions
2018-01-19 20:02:17 +01:00
0ee6b7d142
build for iOS on travis
2018-01-18 22:37:37 +01:00
785fffd976
make url_random take a span
2018-01-15 01:49:42 -05:00
a01274ce2c
broadcast socket handler take a span
2018-01-14 20:21:42 -05:00
e829c1942a
merged RC_1_1 into master
2018-01-14 13:07:20 +01:00
a67eb2f059
fix tracker connection bind issue for IPv6 trackers
2018-01-14 06:47:13 -05:00
a9085db760
fix error handling of merkle torrents
2018-01-13 17:33:36 -05:00
f29bb69612
fix error handling of unsupported hard-links
2018-01-13 08:36:48 -05:00
65fef972a2
apply some c++11 modernization
2018-01-11 04:51:39 -05:00
263e01f5da
fix rp->blocks_left = blocks_in_piece;
2018-01-11 02:44:37 -05:00
5f25912694
remove unused infohash member in create_torrent
2018-01-11 02:43:09 -05:00
5a772325a0
redundant is_finished(block.block)
2018-01-09 03:20:28 -05:00
3f23ef59c6
small opt torrent::add_piece
2018-01-09 03:20:07 -05:00
a93429c5db
modernize piece-size selection in torrent creator and add a test
2018-01-09 03:19:44 -05:00
ad82be145b
merged RC_1_1 into master
2018-01-08 22:52:23 +01:00
1877724c17
raise auto piece size selection limit to 16 MB in create_torrent()
...
16 MB is chosen to have a bit more future proof
Also rewrite the auto piece size selection algorithm, so that it will scale with
torrent content size, suggested by @ssiloti.
2018-01-08 15:24:47 -05:00
3a9861e237
complete the error handling test and make it part of the default simulation test suite. It will run a file transfer between two clients repeatedly, each time cause another memory allocation fail, until every single memory allocation has failed once. Any invariant check failure, assertion or signal will cause the test to fail
2018-01-08 04:44:52 -05:00
97ceeab9e3
fix V821 Decreased performance. ( #2675 )
...
The 't' variable can be constructed in a lower level scope
2018-01-07 20:37:21 -05:00
3e29968a92
remove duplicate if (files.num_files() == 0)
2018-01-07 14:00:59 -05:00
39144201db
mark up performance counter operations as noexcept
2018-01-06 20:12:41 -05:00
88643dd121
fix m_in_constructor assert for peer_connection (if the peer connection is constructed, but bt_peer_connection constructor fails, it needs to be cleared). Fix an invariant in session on ungraceful shutdown. Make test framework a bit more robust
2018-01-06 14:29:20 -05:00
bad0f01e07
remove #include boost/multiprecision
2018-01-06 09:24:48 -05:00
fac9931eb6
fix noexcept marking on entry, and make move assignment
2018-01-04 19:34:42 -05:00
98ade28237
using make_address instead of deprecated from_string when boost>=1.66 ( #2659 )
...
using make_address instead of deprecated from_string when boost>=1.66
2018-01-04 04:48:22 -05:00
0731200149
block_size is a constant, no need in passing it around as a variable
2018-01-03 08:45:25 -05:00
c8bf782bd0
bump version number to 1.1.6
2017-12-29 15:53:51 +01:00
6047e42c16
fix torrent invariant when creating the piece picker fails
2017-12-28 21:02:50 +01:00
8b3624b25b
remove_peer() and attach_peer() error handling
2017-12-28 14:26:19 +01:00
aae12250ae
support forced shutdown/destruction of torrent objects
2017-12-28 14:11:55 +01:00
5f0c9a0c1d
improve error handling during session shutdown
2017-12-28 13:52:07 +01:00
c3bdc6f825
use an intrusive linked list for peer_cache_entry instead an unordered set, to avoid heap allocations and make cache operations not able to fail. This simplifies error handling
2017-12-28 00:52:09 +01:00
a9753d3bdc
merge RC_1_1 into master
2017-12-27 22:16:14 +01:00
c1abafc0cc
reserve space in the undead peers list up-front, to not have to allocate memory when disconnecting
2017-12-27 21:24:16 +01:00
5ebd05b047
handle serious errors in on_accept_connection handler
2017-12-27 21:23:25 +01:00
1884061418
revert redundant wrapping some function calls with error handlers. Error handling is already built into the handler allocator
2017-12-27 21:22:34 +01:00
6ba64a1bb3
reserve space for m_peers_to_disconnect up front, in order to make queing up a peer for disconnection noexcept
2017-12-27 21:22:08 +01:00
ab9fcdf029
reserve space in torrent lists up-front, to make transitioning list membership unable to fail
2017-12-27 15:42:46 +01:00
7ea5946305
remove some last lexical_cast residual
2017-12-27 12:44:36 +01:00
347555ea8f
handle errors in peer_connection
2017-12-26 10:39:54 +01:00
3971897c14
remove invalid assert
2017-12-24 11:28:02 +01:00
40292a1d51
don't heap-allocate handlers for incoming UDP packets
2017-12-24 11:22:30 +01:00
753826cbb8
merger RC_1_1 into master
2017-12-23 18:15:01 +01:00
43d7f980d0
make the chunk header parser properly fail at end of buffer, and not require zero terminated strings
2017-12-23 17:06:50 +01:00
b5d4bc5e62
back-port path fixup in file_storage add_file
2017-12-23 12:02:17 +01:00
47709244d3
back-port fixed assert in chunk parser
2017-12-23 12:01:40 +01:00
62bf524e75
disable DHT logging with the TORRENT_DISABLE_LOGGING macros as well
2017-12-23 12:01:18 +01:00
b7decd452e
add getters for peer_class_filter and peer_class_type_filter
2017-12-23 09:25:06 +01:00
67be35739c
:attempt to fix disconnections when torrents enter upload mode due to failures
2017-12-23 09:24:26 +01:00
94f4e88e05
Fix local network address mappings.
2017-12-20 11:28:36 +01:00
a54f76d5df
deprecate status_code from tracker_error_alert (it's already part of the error_code), simplify code a bit
2017-12-19 00:55:51 +01:00
d45de18ba7
merged RC_1_1 into master
2017-12-18 23:01:33 +01:00
178281e1c5
make torrent_handler::set_priority() to use peer_classes
2017-12-18 00:56:44 +01:00
87de08cb3d
improve type safety of plugin interface
2017-12-17 23:55:12 +01:00
bb945f5cf4
introduce a proper type for pex flags to improve type-safety
2017-12-17 23:17:12 +01:00
0848d9b7f5
change defaults for rate_limit_utp setting
2017-12-17 08:50:25 +01:00
96bf0ad5de
fix reopening of listen sockets when disabling force-proxy
2017-12-17 08:25:51 +01:00
d52763805c
back-port the tracker timeout test from master
2017-12-16 13:54:15 +01:00
55babc57e6
merged RC_1_1 into master
2017-12-15 17:18:27 +01:00
d1a63cd781
fix build against boost-1.66, specifically the boost.asio changes
2017-12-15 11:29:53 +01:00
ba224a1577
restore the parse_magnet_uri overload that amends an add_torrent_params object
2017-12-14 12:20:02 +01:00
9e0a3aead1
use info hash from params instead of passing it separately
2017-12-14 10:18:33 +01:00
7b06a5ee6e
merged RC_1_1 into master
2017-12-13 12:36:35 +01:00
86c83fe976
fix asio debugging
2017-12-12 10:11:09 -05:00
fe6473039c
fix rate limit utp feature
2017-12-11 08:40:35 -05:00
b00b3184c0
some minor i2p cleanups
2017-12-08 09:57:21 +01:00
a286b9da47
fix i2p support
2017-12-08 09:57:21 +01:00
c4cf7ebae6
Merge branch 'master' of https://github.com/arvidn/libtorrent
2017-12-07 18:31:26 +01:00
90ccd5180f
merged RC_1_1 into master
2017-12-07 18:31:16 +01:00
db61d9cc20
minor cleanup, refactor and typos ( #2593 )
2017-12-07 07:51:55 +01:00
f81a20a035
fix loading resume data when in seed mode
2017-12-03 23:43:55 +01:00
0fe2e85fee
fix part-file creation race condition (back-port from master)
2017-12-03 18:13:54 +01:00
c16eb32b94
merge RC_1_1 into master
2017-12-03 18:12:35 +01:00
c745d3f00d
fix incorrect use of make_tick_handler
2017-12-02 12:20:36 +01:00
4b467f82ac
fix issue with initializing settings on session construction
2017-12-02 12:20:36 +01:00
5ce798197c
merged RC_1_1 into master
2017-12-02 11:39:23 +01:00
163d13e1d2
implemented support magnet URI extension, select specific file indices for download, BEP53 ( #2578 )
2017-12-01 12:40:19 +01:00
28f096e94e
added const to static arrays, minor refactor in alert.cpp
2017-12-01 09:57:00 +01:00
af6b54ed78
more use of const, auto loop, cleanup in escape_string.cpp
2017-11-30 18:12:21 +01:00
7fe75dd1eb
trivial code refactor in entry and string_util related code
2017-11-29 20:08:15 +01:00
a6656aeb93
generate random keys for use in tracker announces. keys are unique for each torrent and the listen interface they announce via
2017-11-29 00:10:35 +01:00
f2681412e7
more use of const in peer_connection.cpp and minor code refactor
2017-11-28 09:45:40 +01:00
e0dee20f3e
more use of emplace_back in torrent_info.cpp and minor general refactor
2017-11-27 20:12:23 +01:00
e15f466137
fix issue with receiving interested before metadata ( #2557 )
2017-11-25 15:31:37 +01:00
Eugene Shalygin