28b6f64c4b
dht: don't set implied_port for SSL torrents
2018-07-12 08:36:57 +02:00
961cf62cad
dht: announce with per-interface listen port
2018-07-12 08:36:57 +02:00
e317c72db3
merged RC_1_1 into master
2018-07-08 18:52:13 +02:00
b750b6cc2c
deprecate (and disable) the force-proxy setting. Instead, always use the proxy when set, never fall back on circumventing it
2018-07-08 18:26:47 +02:00
2ba0e5ae2c
move the file priority vector throught the disk_io_job, to avoid copies
2018-07-08 18:25:06 +02:00
d2d35b69fd
raise priority of cache_flushed_alert and post it unconditionally when triggered explicily by the client
2018-07-08 18:23:44 +02:00
e45df614fe
improve type safety of internal leave_seed_mode() function
2018-07-08 17:32:50 +02:00
6d2f804d9f
code refactor related to the use of index_range and end index
2018-07-08 17:32:30 +02:00
b60912569f
back-port resume data validation fixes
2018-07-08 17:31:29 +02:00
3fede4b223
merged RC_1_1 into master
2018-07-08 11:55:32 +02:00
b5cd959dd1
bump the minimum number of hash jobs per thread from 2 to 4
2018-07-07 18:02:24 +02:00
c7e705e158
merged RC_1_1 into master
2018-07-07 13:33:15 +02:00
3249b70cbd
fix recent patch to support setting file priorities on torrents that don't have metadata yet
2018-07-07 11:34:11 +02:00
6d5a6f05ad
Fix torrent files prioritization ( #3133 )
...
After setting file priority, any subsequent attempt to set different priorities will fail if there is a `file_priority` job running in in disk thread. This happens because `torrent::m_file_priority` is being updated before adding disk thread job. The problem is gone if the file priority vector owned by the torrent object, is modified in the `torrent::on_file_priority` callback, when disk job finishes.
2018-07-04 08:16:33 +02:00
2cb29f88ac
merged RC_1_1 into master
2018-06-23 23:22:26 +02:00
b7f230316c
set the minimum number of checking jobs based on the number of hasher threads
...
To effectively mask the latency of generating more hash jobs there need to be
at least two jobs in-flight for each hasher thread.
2018-06-23 23:10:55 +02:00
5530793c75
improve the API for iterating over all files and pieces, with the new strong index types.
2018-06-12 11:44:29 +02:00
267ca40b28
merged RC_1_1 into master
2018-06-02 13:15:13 +02:00
c55bc7dd42
improve error handling of failing to change file priority
2018-05-31 00:47:17 +02:00
6c4869f044
moved instantiate_connection to aux namespace
2018-05-29 09:25:25 +02:00
1a66a8b285
merged RC_1_1 into master
2018-05-20 12:08:46 +02:00
c986d93913
fix properly ignoring failure to get local endpoint of a socket while printing an error
2018-05-20 10:47:46 +02:00
54f00ce09d
don't change state to downloading if the torrent is finished
...
Move the transition to downloading after the torrent has been checked
for being finished. This prevents a spurious state_changed_alert when
adding a torrent which is already completed.
Also move the posting of the torrent_checked_alert to maintain the
historical ordering of that alert with respect to the transition out of
checking_resume_data.
2018-05-20 08:45:24 +02:00
7621be6df1
fixed signed/unsigned warnings with latest version of Xcode clang ( #3032 )
2018-05-16 16:06:33 +02:00
a14d595eac
minor code cleanup in torrent.cpp
2018-05-16 16:05:15 +02:00
f4d7ff592e
merged RC_1_1 into master
2018-05-14 09:50:10 +02:00
243353a144
account for partially downloaded pieces when announcing as a seed
2018-05-13 22:35:04 +02:00
fe612ca167
replace the TORRENT_CFG ABI check with inline namespaces around the symbol that can change ABI based on build configuration options
2018-05-13 19:25:17 +02:00
ddd1168296
don't attempt to make uTP connections if we don't have any outgoing UDP sockets
2018-05-12 13:34:58 +02:00
8fdba2aa39
don't specialize standard type trait is_integral
...
Concerning type traits, the C++ standard states: "The behavior of a program
that adds specializations for any of the templates defined in this subclause is
undefined unless otherwise specified."
There is no exception for is_integral.
2018-05-10 19:06:18 +02:00
377e800e72
fixed conversion warnings in 32 bits
2018-04-30 23:09:00 +02:00
8621477239
merged RC_1_1 into master
2018-04-28 14:36:24 +02:00
b4d2281e53
honor torrent abort even on file check error
2018-04-24 23:14:48 -04:00
3ede0b9c20
fix last_upload, last_download and last_scrape to be reported accurately and saved/restored in resume data
2018-04-22 06:14:22 -04:00
791a1e8557
minor code refactor and a few const in torrent.cpp
2018-04-13 14:17:02 +02:00
f0227451a6
merged RC_1_1 into master
2018-04-13 01:47:41 +02:00
aaf9304a3b
update year in copyright header
2018-04-09 09:04:33 +02:00
9d83da110b
Delay hash_failed_alert until on_piece_sync()
...
Delay the hash_failed_alert until after synchronizing with the IO thread
so that it can be used to synchronize piece progress.
2018-04-07 15:59:40 +02:00
5b922072e9
avoid calls to .address() when looking for endpoint protocol ( #2892 )
...
using is_v4 and is_v6 where possible
2018-04-01 13:48:17 +02:00
d080c6f532
merged RC_1_1 into master
2018-03-26 12:56:25 +02:00
1c867a5026
Changing file priorities while checking interrupts checking.
...
Also, if the last file has zero priority, checking is interrupted prematurely.
2018-03-26 02:59:10 +02:00
0fa24faec4
merged RC_1_1 into master
2018-03-25 22:06:41 +02:00
02a01fa22e
fix issue where the current tracker would be skipped for the next tracker in the same tier
2018-03-25 14:40:38 +02:00
3171245292
fix warnings
2018-03-24 23:01:19 +01:00
82f87b0655
remove redundant check in tracker announce. This is checked in http_tracker_connection
2018-03-21 23:38:10 +01:00
8658fb5f7c
deprecate the error_file_* constants whose underlying features have been deprecated
2018-03-13 19:39:55 +01:00
5c1b65e9b8
merged RC_1_1 into master
2018-03-12 02:32:12 +01:00
a06e4f696b
track whether a file is eligible for using the partfile on a per-file basis. This is intended to improve backwards compatibility, to better support resuming files downloaded with older versions of libtorrent
2018-03-11 12:52:56 +01:00
05f7a95604
fix reporting &redundant= in tracker announces
2018-03-08 02:11:46 +01:00
f8fb5c2294
merged RC_1_1 into master
2018-02-10 22:52:12 +01:00
77181c1469
fix issue when receiving a torrent with 0-sized padfiles as magnet link
2018-02-09 17:41:30 +01:00
d2e874fca8
headers code cleanup, removed unused fields in torrent class ( #2775 )
2018-02-06 08:32:19 +01:00
15a8a17a6f
merged RC_1_1 into master
2018-02-05 08:55:15 +01:00
01c41fadcf
fix torrent_status::next_announce
2018-01-29 15:08:18 +01:00
50a293730b
merged RC_1_1 into master
2018-01-29 10:20:45 +01:00
e126d7bce0
move socket_type into aux-namespace
2018-01-29 08:33:45 +01:00
9ac394f5b0
turn piece picker option flags into a proper type
2018-01-29 03:01:17 +01:00
a33c81ad33
shave down session_interface by one function, reduce the dependencies between torrent and session
2018-01-29 03:00:59 +01:00
ca3ea591df
fix pad-file scalability issue
2018-01-29 03:00:37 +01:00
a50579c651
merged RC_1_1 into master
2018-01-27 09:41:54 +01:00
fa03cbea9b
Revise torrent state update
...
* Remove unused m_in_state_updates
* Update m_state_subscription comments
2018-01-27 09:17:40 +01:00
4fef787212
merged RC_1_1 into master
2018-01-24 00:37:05 +01:00
efd096d879
use unique peer_ids per connection
2018-01-23 16:40:16 +01:00
65fef972a2
apply some c++11 modernization
2018-01-11 04:51:39 -05:00
263e01f5da
fix rp->blocks_left = blocks_in_piece;
2018-01-11 02:44:37 -05:00
3f23ef59c6
small opt torrent::add_piece
2018-01-09 03:20:07 -05:00
3a9861e237
complete the error handling test and make it part of the default simulation test suite. It will run a file transfer between two clients repeatedly, each time cause another memory allocation fail, until every single memory allocation has failed once. Any invariant check failure, assertion or signal will cause the test to fail
2018-01-08 04:44:52 -05:00
98ade28237
using make_address instead of deprecated from_string when boost>=1.66 ( #2659 )
...
using make_address instead of deprecated from_string when boost>=1.66
2018-01-04 04:48:22 -05:00
0731200149
block_size is a constant, no need in passing it around as a variable
2018-01-03 08:45:25 -05:00
6047e42c16
fix torrent invariant when creating the piece picker fails
2017-12-28 21:02:50 +01:00
8b3624b25b
remove_peer() and attach_peer() error handling
2017-12-28 14:26:19 +01:00
aae12250ae
support forced shutdown/destruction of torrent objects
2017-12-28 14:11:55 +01:00
5f0c9a0c1d
improve error handling during session shutdown
2017-12-28 13:52:07 +01:00
6ba64a1bb3
reserve space for m_peers_to_disconnect up front, in order to make queing up a peer for disconnection noexcept
2017-12-27 21:22:08 +01:00
347555ea8f
handle errors in peer_connection
2017-12-26 10:39:54 +01:00
a54f76d5df
deprecate status_code from tracker_error_alert (it's already part of the error_code), simplify code a bit
2017-12-19 00:55:51 +01:00
d45de18ba7
merged RC_1_1 into master
2017-12-18 23:01:33 +01:00
178281e1c5
make torrent_handler::set_priority() to use peer_classes
2017-12-18 00:56:44 +01:00
87de08cb3d
improve type safety of plugin interface
2017-12-17 23:55:12 +01:00
bb945f5cf4
introduce a proper type for pex flags to improve type-safety
2017-12-17 23:17:12 +01:00
d52763805c
back-port the tracker timeout test from master
2017-12-16 13:54:15 +01:00
55babc57e6
merged RC_1_1 into master
2017-12-15 17:18:27 +01:00
d1a63cd781
fix build against boost-1.66, specifically the boost.asio changes
2017-12-15 11:29:53 +01:00
9e0a3aead1
use info hash from params instead of passing it separately
2017-12-14 10:18:33 +01:00
b00b3184c0
some minor i2p cleanups
2017-12-08 09:57:21 +01:00
90ccd5180f
merged RC_1_1 into master
2017-12-07 18:31:16 +01:00
f81a20a035
fix loading resume data when in seed mode
2017-12-03 23:43:55 +01:00
ee1f4aa129
more use of auto, const and minor refactor in torrent.cpp ( #2554 )
2017-11-25 01:22:52 +01:00
57ec82cb2e
fix indentation in torrent.cpp
2017-11-24 22:15:30 +01:00
4bc93cff38
merge RC_1_1 into master
2017-11-23 18:01:32 +01:00
5e7666526e
fix IPv6 tracker announce issue
2017-11-23 10:11:59 +01:00
f73473a6ec
don't early move shared_ptr plugin in torrent::add_extension_fun, added test for it
2017-11-23 08:00:08 +01:00
59fe15eb84
more use of emplace_back in torrent.cpp
2017-11-23 07:52:50 +01:00
c734f42ac3
make tracker announces happen even if there are no open listen sockets ( #2529 )
...
support announcing to IPv6 trackers and running an IPv6 DHT when not listening for incoming connections
2017-11-20 23:42:22 +01:00
30a7b52855
use a proper optional value instead of a sentiel value for bytes_left()
2017-11-19 21:25:06 +01:00
f262bbdcea
use seconds32 as the retry-time for web seeds
2017-11-19 16:20:36 +01:00
b6a73eeaaa
simplify trigger_unchoke and trigger_optimistic_unchoke on session_impl, abd make them noexcept
2017-11-12 15:48:46 +01:00
d00451994b
stop posting alerts when the session is shutting down. Nobody will be able to see them anyway. It also solves some issues around destruction order where posting alerts require certain things to still be around in the session_impl object
2017-11-12 09:12:59 +01:00
254f813626
factor out handler allocator and reuse it for posting deferred peer removals on torrents
2017-11-11 10:41:39 +01:00
21eb9f782c
opt call is_finished()
2017-11-09 20:52:48 +01:00
6785046c2f
introduce a download_priority_t type, for uniform an type-safe piece- and file priorities
2017-11-02 08:20:21 +01:00
f57b90b500
introduce type for torrent queue_position
2017-11-01 10:52:45 +01:00
dc612b6423
keep updating aux::time_now() while there are announces
...
This fixes an infinite loop when an announce during shutown fails and
aux::time_now() has fallen behind clock_type::now() by more than the
delay calculated in announce_entry::failed(). If this happens,
announce_entry::can_announce() can forever return true when called from
torrent::announce_with_tracker() because that function uses
clock_type::now().
Also change torrent::announce_with_tracker() to use aux::time_now() just
for consistency with the reset of the announce related functions.
2017-10-26 23:42:35 +02:00
50bef25786
make the piece-picker less two-phase initialized
2017-10-26 23:39:15 +02:00
80ac90727b
remove some questionable code from disk_io_thread when deleting files for a torrent and extend transfer test to cover deleting files while seeding
2017-10-25 19:00:54 +02:00
9e69bf3618
introduce a type to refer to a torrent-list-index, to improve type safety
2017-10-25 13:39:37 +02:00
f0bac4cac7
merged RC_1_1 into master
2017-10-14 15:22:22 +02:00
2b72a7321a
send one last state update when a paused torrent's rates reach zero ( #2436 )
2017-10-11 23:10:40 +02:00
1d15e6bfb4
merge RC_1_1 into master
2017-10-08 18:21:25 +02:00
cdd9f91999
fix leak of torrent_peer objecs (entries in peer_list)
2017-10-07 11:43:42 +02:00
4e1c5738a2
back-port openssl API compat patch from master
2017-10-07 01:10:41 +02:00
7f3c38025f
making use of openssl API 1.1 compatible
2017-10-06 11:03:16 +02:00
69dc73914a
merged RC_1_1 into master
2017-10-04 11:43:01 +02:00
99b19366a9
fix leak of peer_class objects (when setting per-torrent rate limits)
2017-10-03 17:32:49 +02:00
a619dfb996
more use of auto, const and minor code refactor in torrent.cpp
2017-09-24 23:23:30 -07:00
d22c44c057
fix kludge and down-cast to send upload_only. Promote upload-only to a top-level peer feature
2017-09-23 07:51:51 -07:00
ddc8711dbe
fix issue where peers could be disconnected while iterating over the peer list in the torrent. Specifically while marking peers as not-interesting
2017-09-21 07:26:13 -07:00
8d6b51d54c
minor cleanups
2017-09-16 13:48:11 +02:00
93bb84d94c
some random cleanup
2017-09-13 08:28:46 +02:00
55228756e5
make disk job flags type safe
2017-09-10 08:56:52 +02:00
95c8c3018a
use span in gzip, http_parser and http_connection
2017-09-04 22:33:38 +02:00
fe1c395579
merged RC_1_1 into master
2017-09-03 13:57:19 +02:00
7087a16b36
move some initialization of torrent from start() into the constructor
2017-09-02 21:24:00 +02:00
f022285b13
include endpoint in tracker alerts
2017-09-01 13:38:36 +02:00
52ccad23b9
read_piece: handle failure to allocate piece buffer
2017-08-29 12:24:17 +02:00
d250ba5a17
wrap destination string in i2p_peer in string_ptr handler ( #2268 )
2017-08-25 09:42:46 +02:00
e92cbf502c
remove the last use of session_impl get_ipv6_interface and get_ipv4_interface
2017-08-23 21:01:15 +02:00
fe37884bc6
fix IPv6 tracker support by performing the second announce in more cases
2017-08-19 18:56:51 +02:00
05b5b4ef4d
merged RC_1_1 into master
2017-08-16 22:46:47 +02:00
50c2aee8ec
don't create web seed connections if the torrent is upload only
...
The fix in 9a63d4696e
2017-08-11 08:16:00 +02:00
865ff09a84
merge RC_1_1 into master
2017-08-10 16:44:57 +02:00
2b98951ace
assert that trackers are not announced to while checking files
2017-08-06 20:21:03 +02:00
1f3730fa5a
fix force-recheck issue (new files would not be picked up)
2017-08-06 09:49:51 +02:00
6b1037eff5
convert enum values that are just used as constants, to actual constants with the correct type
2017-08-04 15:23:20 +02:00
322007bb6a
make save_state_flags a strong type
2017-07-30 09:06:41 -07:00
69bd2986de
convert a few more torrent_handle flags to type safe types
2017-07-27 13:16:23 -07:00
204a029b5f
merged RC_1_1 into master
2017-07-27 11:37:02 -07:00
24e4263bae
make torrent status flags be type safe
2017-07-27 09:33:35 -07:00
5222d92e9f
make resume_data_flags type safe
2017-07-27 00:07:15 -07:00
c4eb4c8b5f
use span in torrent_info constructors and deprecate the redundant flags argument
2017-07-22 00:00:44 -07:00
cedd468300
backport fix to clearing of piece picker in suggest_read_cache mode
2017-07-22 00:00:14 -07:00
f0ae2145ea
use a handle class for listen sockets instead of raw pointers
...
Listen socket handles need to be week_ptr so that they can detect when a listen
socket is removed in the middle of a tracker announce on it. Use a wrapper class
to enforce that no one outside of session_impl can hold ownership of the socket
across event boundaries.
To support unit tests, listen_socket_t is also split into a base class which
holds the members needed to support the public listen socket API.
2017-07-21 19:18:44 -07:00
87ca4bb26f
Fix bug where the resume data would fail to load the piece bitmask for seeds when suggest_cache was enabled
2017-07-21 19:06:02 -07:00
33a2abebfe
submit disk jobs in read_piece()
2017-07-18 07:21:07 -07:00
06070ea499
convert block request flags to type-safe flags
2017-07-17 17:56:07 -07:00
c4659bc345
convert peer_flags and peer_source_flags to type-safe flags
2017-07-17 10:22:32 -07:00
4947602a2f
make add_torrent_params::flags_t an enum class and move it out into its own header
2017-07-17 01:05:31 -07:00
00655d562b
Refactor several flags to torrent_handle::get_flags/set_flags.
2017-07-17 01:05:31 -07:00
73942de97a
carve out peer_list_entry into also being deprecated (it was only used by deprecated functions and some tests)
2017-07-16 19:20:29 -07:00
c4afb5e949
use a dedicated class template for flags types instead of enum class. It's more backwards compatible and improves ergonomics
2017-07-15 01:15:57 -07:00
Steven Siloti