b7f230316c
set the minimum number of checking jobs based on the number of hasher threads
...
To effectively mask the latency of generating more hash jobs there need to be
at least two jobs in-flight for each hasher thread.
2018-06-23 23:10:55 +02:00
1e3a7cf0f4
fix hash-job fast-path
2018-06-23 23:08:58 +02:00
0c147164bc
introduce a fast-path for the hash disk job
2018-06-20 01:00:16 +02:00
4ae262d2d4
fix race condition in part_file
2018-06-19 14:50:02 +02:00
81ce7aa4ab
Fix parts file i/o errors ( #3110 )
...
Since i/o operations are not synchronized, it is possible that one thread closes file handle, opened in another thread. With addition of `hidden` file attribute, an old bug in `part_file::open_file()` revealed both problems, causing a lot of random i/o errors in parts file. Fixing `open_file` bug should reduce the number of such errors back to 'normal'.
2018-06-18 14:34:39 +02:00
049d867c12
fixed race condition in random number generator
2018-06-06 09:54:49 +02:00
2408200475
fix race condition in stat_cache
2018-06-05 19:07:33 +02:00
794ccf4f79
remove unused disk stats counters
2018-06-05 19:03:04 +02:00
c55bc7dd42
improve error handling of failing to change file priority
2018-05-31 00:47:17 +02:00
396c5dd3af
remove use of deprecated function readdir_r
...
Ports 140b8ace
2018-05-28 16:06:41 +02:00
6ec6c1b340
since moving an existing file into the part file isn't supported, just don't use the partfile for existing files when their priority is set to 0
2018-05-24 23:45:28 +02:00
77191a3820
fix hidden attribute in file class
2018-05-23 10:39:10 +02:00
ed8fffc1a6
set the hidden attribute when creating the part file
2018-05-23 10:39:10 +02:00
54f00ce09d
don't change state to downloading if the torrent is finished
...
Move the transition to downloading after the torrent has been checked
for being finished. This prevents a spurious state_changed_alert when
adding a torrent which is already completed.
Also move the posting of the torrent_checked_alert to maintain the
historical ordering of that alert with respect to the transition out of
checking_resume_data.
2018-05-20 08:45:24 +02:00
243353a144
account for partially downloaded pieces when announcing as a seed
2018-05-13 22:35:04 +02:00
9ca12d6db5
restore aspects of the previous behavior of force-proxy. Instead of not opening any TCP listen sockets at all, open them but reject any incoming connection. This is because in RC_1_1, the UDP and TCP sockets are tied in subtle and unintuitive ways. This is much cleaner in the next major release and this patch will not need to be merged
2018-05-13 12:31:00 +02:00
f052d1ca40
Fix bandwidth allocation ( #2810 )
...
Don't allow peer connection to ask quota from bandwidth manager if send buffer is empty.
Remove undefined member function
Update download rate multiplier
2018-05-12 13:53:03 +02:00
299a545648
add test for suggests- and seed mode combined
2018-05-10 17:40:23 +02:00
8808eb7cdd
introduce a recursive mutex to protect the alert_manager, and hold the mutex while calling user callbacks and plugin hooks. This is required to ensure the underlying storage for alert allocations (in the stack allocators) is synchronized with the thread that may be accessing it
2018-05-01 23:17:51 +02:00
f5e33932d2
fix use after free in flush_range and flush_iovec
...
Calling blocks_flushed can cause the piece entry to be freed so its
callers need to be aware of that and avoid dereferencing the pointer if
the entry is freed.
2018-04-27 16:15:19 +02:00
366b7983d1
fix typo with bind_outgoing_socket~
2018-04-26 19:50:25 -04:00
21d8e9e26b
Add missing header <cstdarg> for va_list.
...
* Fix building on OpenBSD.
2018-04-24 23:09:25 -04:00
3ede0b9c20
fix last_upload, last_download and last_scrape to be reported accurately and saved/restored in resume data
2018-04-22 06:14:22 -04:00
44479bcca3
Fix storage initialization ( #2944 )
...
If `default_storage::has_any_file` fails during fastresume data check, `piece_manager::check_no_fastresume` will skip storage initialization. In such case, any storage operation that require part file will cause an application crash.
2018-04-21 18:35:55 +02:00
9cd0ae67e7
another boost-1.67 build fix
2018-04-13 14:43:41 +02:00
236e0e7699
pass default constructed boost::function instead of NULL
...
Clang 6 defines NULL as nullptr which breaks implicit construction
of boost::function from NULL.
2018-04-12 14:32:31 +02:00
aaf9304a3b
update year in copyright header
2018-04-09 09:04:33 +02:00
105934e578
bump version
2018-04-08 23:08:39 +02:00
c5a5e084dd
:strtoll() returns LLONG_MAX if the input overflows. Handle this case properly in the http parser
2018-04-08 18:34:25 +02:00
c08a6bf430
Make SACK header to be able to take up the whole packet. Rename m_in_buf_size to m_receive_buffer_capacity
2018-04-07 18:55:14 +02:00
257f625e2e
Increase m_in_buf_size and max_packet_reorder to better handle links with high latency
2018-04-07 18:55:14 +02:00
bf2f0a9c55
Fix advertised window being counted twice in congestion check
2018-04-07 18:55:14 +02:00
9d83da110b
Delay hash_failed_alert until on_piece_sync()
...
Delay the hash_failed_alert until after synchronizing with the IO thread
so that it can be used to synchronize piece progress.
2018-04-07 15:59:40 +02:00
357217326d
some cleanups
2018-04-05 12:59:35 +02:00
a5e0578c88
fix part-file header allocation
2018-04-03 20:46:49 +02:00
77102102d6
simplify some for-loops in xml_parse
2018-04-03 18:45:04 +02:00
49ae7858a8
fix potential fd leak in enum_net_interfaces
2018-04-03 13:44:33 +02:00
98d5313598
don't perform DNS lookups for the DHT bootstrap unless DHT is enabled
2018-04-01 23:53:12 +02:00
6a2df1034a
add some asserts and checks preventing IPv6 addresses to make it into libtorrent when IPv6 support is disabled
2018-03-31 14:17:06 +02:00
1c867a5026
Changing file priorities while checking interrupts checking.
...
Also, if the last file has zero priority, checking is interrupted prematurely.
2018-03-26 02:59:10 +02:00
02a01fa22e
fix issue where the current tracker would be skipped for the next tracker in the same tier
2018-03-25 14:40:38 +02:00
82f87b0655
remove redundant check in tracker announce. This is checked in http_tracker_connection
2018-03-21 23:38:10 +01:00
09bf97b79e
minor fixes in utp_socket_impl
2018-03-18 17:03:05 +01:00
0edb0f28c1
stat files in the disk thread, in default_storage::initialize() instead of the constructor
2018-03-15 14:54:49 +01:00
a06e4f696b
track whether a file is eligible for using the partfile on a per-file basis. This is intended to improve backwards compatibility, to better support resuming files downloaded with older versions of libtorrent
2018-03-11 12:52:56 +01:00
05f7a95604
fix reporting &redundant= in tracker announces
2018-03-08 02:11:46 +01:00
24dea1f845
fix tie-break in duplicate peer connection disconnect logic
2018-02-21 21:04:28 +01:00
eec34e3ac3
fix issue with SSL tracker connections left in CLOSE_WAIT state ( #2797 )
2018-02-20 08:40:47 +01:00
f94b62acf7
CMake improvements
...
CMake build scripts improved to simplify configuring and building of
project and tests.
Better use of compile definitions by replacing add_definitions with
target_compile_definitions. Use INTERFACE, PUBLIC and PRIVATE keywords
to separate scope of TORRENT_BUILDING_SHARED and TORRENT_LINKING_SHARED
definitions.
* Move tests to the separate file - test/CmakeLists.txt
* Fix use of compile definitions
* Remove redundant tailqueue.cpp
2018-02-19 23:23:15 +01:00
1ede34da8a
undo the patch to restore incoming TCP connections over SOCKS5
2018-02-19 00:01:42 +01:00
a1860426b8
defer truncating existing files until the first time we write to them
2018-02-10 18:33:41 +01:00
77181c1469
fix issue when receiving a torrent with 0-sized padfiles as magnet link
2018-02-09 17:41:30 +01:00
91e03c789c
fix issue resuming 1.0.x downloads with a file priority 0
2018-01-31 22:43:07 +01:00
01c41fadcf
fix torrent_status::next_announce
2018-01-29 15:08:18 +01:00
ca3ea591df
fix pad-file scalability issue
2018-01-29 03:00:37 +01:00
b729021625
make coalesce-buffers work on windows and systemps with pwritev()/preadv()
2018-01-28 23:05:01 +01:00
fa03cbea9b
Revise torrent state update
...
* Remove unused m_in_state_updates
* Update m_state_subscription comments
2018-01-27 09:17:40 +01:00
bc4d53c71f
restore support for incoming connections over SOCKS5 (disabled by default)
2018-01-25 09:14:14 +01:00
efd096d879
use unique peer_ids per connection
2018-01-23 16:40:16 +01:00
0ee6b7d142
build for iOS on travis
2018-01-18 22:37:37 +01:00
a67eb2f059
fix tracker connection bind issue for IPv6 trackers
2018-01-14 06:47:13 -05:00
a9085db760
fix error handling of merkle torrents
2018-01-13 17:33:36 -05:00
f29bb69612
fix error handling of unsupported hard-links
2018-01-13 08:36:48 -05:00
1877724c17
raise auto piece size selection limit to 16 MB in create_torrent()
...
16 MB is chosen to have a bit more future proof
Also rewrite the auto piece size selection algorithm, so that it will scale with
torrent content size, suggested by @ssiloti.
2018-01-08 15:24:47 -05:00
c8bf782bd0
bump version number to 1.1.6
2017-12-29 15:53:51 +01:00
7ea5946305
remove some last lexical_cast residual
2017-12-27 12:44:36 +01:00
3971897c14
remove invalid assert
2017-12-24 11:28:02 +01:00
43d7f980d0
make the chunk header parser properly fail at end of buffer, and not require zero terminated strings
2017-12-23 17:06:50 +01:00
b5d4bc5e62
back-port path fixup in file_storage add_file
2017-12-23 12:02:17 +01:00
47709244d3
back-port fixed assert in chunk parser
2017-12-23 12:01:40 +01:00
62bf524e75
disable DHT logging with the TORRENT_DISABLE_LOGGING macros as well
2017-12-23 12:01:18 +01:00
b7decd452e
add getters for peer_class_filter and peer_class_type_filter
2017-12-23 09:25:06 +01:00
67be35739c
:attempt to fix disconnections when torrents enter upload mode due to failures
2017-12-23 09:24:26 +01:00
94f4e88e05
Fix local network address mappings.
2017-12-20 11:28:36 +01:00
178281e1c5
make torrent_handler::set_priority() to use peer_classes
2017-12-18 00:56:44 +01:00
d52763805c
back-port the tracker timeout test from master
2017-12-16 13:54:15 +01:00
d1a63cd781
fix build against boost-1.66, specifically the boost.asio changes
2017-12-15 11:29:53 +01:00
86c83fe976
fix asio debugging
2017-12-12 10:11:09 -05:00
fe6473039c
fix rate limit utp feature
2017-12-11 08:40:35 -05:00
b00b3184c0
some minor i2p cleanups
2017-12-08 09:57:21 +01:00
a286b9da47
fix i2p support
2017-12-08 09:57:21 +01:00
f81a20a035
fix loading resume data when in seed mode
2017-12-03 23:43:55 +01:00
0fe2e85fee
fix part-file creation race condition (back-port from master)
2017-12-03 18:13:54 +01:00
c745d3f00d
fix incorrect use of make_tick_handler
2017-12-02 12:20:36 +01:00
4b467f82ac
fix issue with initializing settings on session construction
2017-12-02 12:20:36 +01:00
e15f466137
fix issue with receiving interested before metadata ( #2557 )
2017-11-25 15:31:37 +01:00
5e7666526e
fix IPv6 tracker announce issue
2017-11-23 10:11:59 +01:00
1593916e62
fix ipv6 udp tracker test
2017-11-23 00:05:08 +01:00
a57ad00e15
fix force-proxy regression (udp sockets would not be opened)
2017-11-21 08:54:16 +01:00
04c2c35f8d
restore path sanitization behavior of ':'
2017-11-21 08:50:09 +01:00
096ce54fae
fix issue where new listen sockets would not be opened when leaving force_proxy mode
2017-11-14 12:38:22 +01:00
dc612b6423
keep updating aux::time_now() while there are announces
...
This fixes an infinite loop when an announce during shutown fails and
aux::time_now() has fallen behind clock_type::now() by more than the
delay calculated in announce_entry::failed(). If this happens,
announce_entry::can_announce() can forever return true when called from
torrent::announce_with_tracker() because that function uses
clock_type::now().
Also change torrent::announce_with_tracker() to use aux::time_now() just
for consistency with the reset of the announce related functions.
2017-10-26 23:42:35 +02:00
205fe5e7ea
fix full allocation failure on APFS
2017-10-16 00:08:10 +02:00
2b72a7321a
send one last state update when a paused torrent's rates reach zero ( #2436 )
2017-10-11 23:10:40 +02:00
f19cca1374
fix infinite loop when parsing certain invalid magnet links
2017-10-11 09:11:58 +02:00
a9524550d7
don't delete pieces from cache with refcount > 0
2017-10-09 17:48:08 +02:00
830ef0bedd
prevent dependency on openssl from leaking outside of libtorrent (libssl and libcrypto should not be a usage requirement). This cleans up most tests to build without having to also link against openssl
2017-10-09 17:15:35 +02:00
f080149081
fix parsing of torrents with certain invalid filenames
2017-10-08 15:54:08 +02:00
cdd9f91999
fix leak of torrent_peer objecs (entries in peer_list)
2017-10-07 11:43:42 +02:00
4e1c5738a2
back-port openssl API compat patch from master
2017-10-07 01:10:41 +02:00
Steven Siloti