ba224a1577
restore the parse_magnet_uri overload that amends an add_torrent_params object
2017-12-14 12:20:02 +01:00
9e0a3aead1
use info hash from params instead of passing it separately
2017-12-14 10:18:33 +01:00
7b06a5ee6e
merged RC_1_1 into master
2017-12-13 12:36:35 +01:00
86c83fe976
fix asio debugging
2017-12-12 10:11:09 -05:00
fe6473039c
fix rate limit utp feature
2017-12-11 08:40:35 -05:00
b00b3184c0
some minor i2p cleanups
2017-12-08 09:57:21 +01:00
a286b9da47
fix i2p support
2017-12-08 09:57:21 +01:00
c4cf7ebae6
Merge branch 'master' of https://github.com/arvidn/libtorrent
2017-12-07 18:31:26 +01:00
90ccd5180f
merged RC_1_1 into master
2017-12-07 18:31:16 +01:00
db61d9cc20
minor cleanup, refactor and typos ( #2593 )
2017-12-07 07:51:55 +01:00
f81a20a035
fix loading resume data when in seed mode
2017-12-03 23:43:55 +01:00
0fe2e85fee
fix part-file creation race condition (back-port from master)
2017-12-03 18:13:54 +01:00
c16eb32b94
merge RC_1_1 into master
2017-12-03 18:12:35 +01:00
c745d3f00d
fix incorrect use of make_tick_handler
2017-12-02 12:20:36 +01:00
4b467f82ac
fix issue with initializing settings on session construction
2017-12-02 12:20:36 +01:00
5ce798197c
merged RC_1_1 into master
2017-12-02 11:39:23 +01:00
163d13e1d2
implemented support magnet URI extension, select specific file indices for download, BEP53 ( #2578 )
2017-12-01 12:40:19 +01:00
28f096e94e
added const to static arrays, minor refactor in alert.cpp
2017-12-01 09:57:00 +01:00
af6b54ed78
more use of const, auto loop, cleanup in escape_string.cpp
2017-11-30 18:12:21 +01:00
7fe75dd1eb
trivial code refactor in entry and string_util related code
2017-11-29 20:08:15 +01:00
a6656aeb93
generate random keys for use in tracker announces. keys are unique for each torrent and the listen interface they announce via
2017-11-29 00:10:35 +01:00
f2681412e7
more use of const in peer_connection.cpp and minor code refactor
2017-11-28 09:45:40 +01:00
e0dee20f3e
more use of emplace_back in torrent_info.cpp and minor general refactor
2017-11-27 20:12:23 +01:00
e15f466137
fix issue with receiving interested before metadata ( #2557 )
2017-11-25 15:31:37 +01:00
ee1f4aa129
more use of auto, const and minor refactor in torrent.cpp ( #2554 )
2017-11-25 01:22:52 +01:00
57ec82cb2e
fix indentation in torrent.cpp
2017-11-24 22:15:30 +01:00
4bc93cff38
merge RC_1_1 into master
2017-11-23 18:01:32 +01:00
5e7666526e
fix IPv6 tracker announce issue
2017-11-23 10:11:59 +01:00
f73473a6ec
don't early move shared_ptr plugin in torrent::add_extension_fun, added test for it
2017-11-23 08:00:08 +01:00
59fe15eb84
more use of emplace_back in torrent.cpp
2017-11-23 07:52:50 +01:00
d8ea7fc5eb
merged RC_1_1 into master
2017-11-23 01:17:43 +01:00
1593916e62
fix ipv6 udp tracker test
2017-11-23 00:05:08 +01:00
a57ad00e15
fix force-proxy regression (udp sockets would not be opened)
2017-11-21 08:54:16 +01:00
04c2c35f8d
restore path sanitization behavior of ':'
2017-11-21 08:50:09 +01:00
22f8bdfebc
merge RC_1_1 into master
2017-11-21 00:50:02 +01:00
c97bd53cde
more use of const, emplace_back and minor code refactor
2017-11-20 23:45:41 +01:00
c734f42ac3
make tracker announces happen even if there are no open listen sockets ( #2529 )
...
support announcing to IPv6 trackers and running an IPv6 DHT when not listening for incoming connections
2017-11-20 23:42:22 +01:00
30a7b52855
use a proper optional value instead of a sentiel value for bytes_left()
2017-11-19 21:25:06 +01:00
f262bbdcea
use seconds32 as the retry-time for web seeds
2017-11-19 16:20:36 +01:00
096ce54fae
fix issue where new listen sockets would not be opened when leaving force_proxy mode
2017-11-14 12:38:22 +01:00
2dc0204261
fix backwards compatibility in deprecated parse_magnet_uri
2017-11-13 15:38:08 +01:00
521587c026
make sure the cork destructor doesn't leak exceptions
2017-11-12 23:03:54 +01:00
b6a73eeaaa
simplify trigger_unchoke and trigger_optimistic_unchoke on session_impl, abd make them noexcept
2017-11-12 15:48:46 +01:00
94dcd8e14b
remove unused transaction id member of DHT observers
2017-11-12 15:46:33 +01:00
d00451994b
stop posting alerts when the session is shutting down. Nobody will be able to see them anyway. It also solves some issues around destruction order where posting alerts require certain things to still be around in the session_impl object
2017-11-12 09:12:59 +01:00
c771f16c5c
lint guided refactor in dht source code ( #2516 )
2017-11-12 00:50:24 +01:00
1c278cc697
add API to query whether alerts have been dropped or not
2017-11-11 15:42:53 +01:00
254f813626
factor out handler allocator and reuse it for posting deferred peer removals on torrents
2017-11-11 10:41:39 +01:00
b88c193742
fix sign conversion warning in peer_class_type_filter
2017-11-11 09:17:37 +01:00
d4864b8b18
some noexcept fixes
2017-11-10 09:05:15 +01:00
1ed68551d7
merged RC_1_1 into master
2017-11-10 01:37:35 +01:00
8ac6bbe553
add http_parser::header_int ( #2472 )
2017-11-09 23:43:26 +01:00
21eb9f782c
opt call is_finished()
2017-11-09 20:52:48 +01:00
fc74c032f0
minor cleanup and modernization of torrent_peer
2017-11-09 15:48:27 +01:00
f41d2b5d3b
move shared_ptr instead of copying them, when constructing DHT observers
2017-11-08 23:09:43 +01:00
b0c101a475
Update identify_client.cpp
2017-11-08 23:04:15 +01:00
7730eea401
restore backwards compatibility with the API before download_priority_t was introduced
2017-11-06 01:24:24 +01:00
a690e6c76d
add throwing overload of parse_magnet_uri
2017-11-05 20:31:06 +01:00
6785046c2f
introduce a download_priority_t type, for uniform an type-safe piece- and file priorities
2017-11-02 08:20:21 +01:00
f57b90b500
introduce type for torrent queue_position
2017-11-01 10:52:45 +01:00
5480c08184
enable/disable the internal ip notifier with new setting ( #2487 )
2017-11-01 10:51:51 +01:00
f02e7514e1
fix issue of null m_part_file in default_storage readv/writev ( #2490 )
...
call need_partfile if necessary in default_storage constructor and no .reset() in release_files()
2017-10-31 16:49:58 +01:00
7aa5570589
Remove twice assigned values
2017-10-30 19:13:56 +01:00
f040d6d860
added reopen_network_sockets method to allow manual reopen of listen/outgoing sockets ( #2476 )
2017-10-28 12:15:35 +02:00
dc612b6423
keep updating aux::time_now() while there are announces
...
This fixes an infinite loop when an announce during shutown fails and
aux::time_now() has fallen behind clock_type::now() by more than the
delay calculated in announce_entry::failed(). If this happens,
announce_entry::can_announce() can forever return true when called from
torrent::announce_with_tracker() because that function uses
clock_type::now().
Also change torrent::announce_with_tracker() to use aux::time_now() just
for consistency with the reset of the announce related functions.
2017-10-26 23:42:35 +02:00
50bef25786
make the piece-picker less two-phase initialized
2017-10-26 23:39:15 +02:00
ab4f140328
using NETLINK_NO_ENOBUFS to ignore ENOBUFS in netlink based ip notifier ( #2475 )
2017-10-26 11:15:19 +02:00
80ac90727b
remove some questionable code from disk_io_thread when deleting files for a torrent and extend transfer test to cover deleting files while seeding
2017-10-25 19:00:54 +02:00
9e69bf3618
introduce a type to refer to a torrent-list-index, to improve type safety
2017-10-25 13:39:37 +02:00
b380bf8059
minor and general code cleanup/refactor
2017-10-25 09:58:47 +02:00
174a2ca65f
add limit of max 50 upnp mappings and recover free global mappings ( #2470 )
2017-10-24 16:16:22 +02:00
989a65f18e
upnp: reduce size NewPortMappingDescription
2017-10-24 12:27:46 +02:00
1ce3483a9e
creating part file if needed only in set_file_priorities
2017-10-24 09:56:49 +02:00
7216b69188
revert early return in session_impl::on_port_mapping and only check for error if cast_vote ( #2468 )
2017-10-24 09:54:57 +02:00
6409cb42e1
fix implicit-fallthrough warnings with gcc 7
2017-10-23 19:18:33 +02:00
bb409c5ee9
missing return if error in session_impl::on_port_mapping, doc typo ( #2459 )
2017-10-23 12:36:51 +02:00
98effc8d88
minor disk_io_job piece_hash cleanup
2017-10-22 16:49:25 +02:00
74ecf63906
close connection in upnp::on_upnp_xml and added abort/closing returns
2017-10-20 11:46:41 +02:00
244d18dcf8
merged RC_1_1 into master
2017-10-17 09:38:51 +02:00
205fe5e7ea
fix full allocation failure on APFS
2017-10-16 00:08:10 +02:00
8083a6c2bd
some code indentation, one more use of nullptr and constexpr
2017-10-15 04:30:10 +02:00
a6c85496b5
make parse_magnet_uri return the add_torrent_params instead of of taking an in-out parameter
2017-10-15 04:29:53 +02:00
516df740a3
make session_handle::get_torrent_status return the vector instead of taking an out-parameter
2017-10-14 23:35:35 +02:00
bb65acb082
make feature_flags proper type-safe
2017-10-14 23:33:48 +02:00
f0bac4cac7
merged RC_1_1 into master
2017-10-14 15:22:22 +02:00
8adcfdbf41
make disk_buffer_holder know the size of the bufer it holds, to fix buffer overrun in chained_buffer
...
fix
2017-10-13 21:07:31 +02:00
58a76e26a8
fix warnings from asio/ssl includes
2017-10-13 21:06:42 +02:00
8af89da689
fix GCC-4.9 build
2017-10-13 10:08:51 +02:00
2b72a7321a
send one last state update when a paused torrent's rates reach zero ( #2436 )
2017-10-11 23:10:40 +02:00
85b6d98454
merged RC_1_1 into master
2017-10-11 11:19:02 +02:00
f19cca1374
fix infinite loop when parsing certain invalid magnet links
2017-10-11 09:11:58 +02:00
9111d5977e
make the variables holding the source of external IPs type-safe
2017-10-10 22:38:36 +02:00
60b74d2616
merged RC_1_1 into master
2017-10-10 14:25:12 +02:00
a9524550d7
don't delete pieces from cache with refcount > 0
2017-10-09 17:48:08 +02:00
830ef0bedd
prevent dependency on openssl from leaking outside of libtorrent (libssl and libcrypto should not be a usage requirement). This cleans up most tests to build without having to also link against openssl
2017-10-09 17:15:35 +02:00
0c6b17ed82
don't try to connect to a global address with a local source address
2017-10-09 01:10:26 +02:00
1d15e6bfb4
merge RC_1_1 into master
2017-10-08 18:21:25 +02:00
f080149081
fix parsing of torrents with certain invalid filenames
2017-10-08 15:54:08 +02:00
cdd9f91999
fix leak of torrent_peer objecs (entries in peer_list)
2017-10-07 11:43:42 +02:00
4e1c5738a2
back-port openssl API compat patch from master
2017-10-07 01:10:41 +02:00
7f3c38025f
making use of openssl API 1.1 compatible
2017-10-06 11:03:16 +02:00
ed31664ee3
deduce the second argument to iconv() instead of requiring it to be configured via a macro
2017-10-06 10:52:09 +02:00
69dc73914a
merged RC_1_1 into master
2017-10-04 11:43:01 +02:00
7e748956e6
Provide a default ip_change_notifier implementation
...
Right now, compiling fails if there's no ip_change_notifier for the
current platform.
2017-10-04 08:56:55 +02:00
99b19366a9
fix leak of peer_class objects (when setting per-torrent rate limits)
2017-10-03 17:32:49 +02:00
27af8c398a
more use of emplace_back and const in create_torrent.cpp
2017-10-03 10:53:04 +02:00
5f3661aaa2
back port overflow checking from master
2017-10-02 00:02:14 +02:00
2ea5115bcc
fix the torrent_info size overflow check
2017-10-01 22:54:28 +02:00
21fef88928
stricten up the filename sanitization a bit
2017-10-01 20:30:02 +02:00
c0d76a5304
fix regression in torrent size check
2017-10-01 16:44:58 +02:00
3255375095
back-port file name sanitization patch to RC_1_1
2017-10-01 16:44:10 +02:00
33b03e1f8e
improve handling of case where a torrent file has no files in it
2017-10-01 10:53:43 +02:00
5026659cb6
clean up and fix edge cases in update_path_index
2017-10-01 04:43:41 +02:00
17d78d3b8f
fix bounds checking in parsing of gzip header
2017-10-01 03:33:38 +02:00
9d276ada8a
fix issue with the name in single file torrents being sanitized away
2017-10-01 01:12:39 +02:00
12e92aeeb4
make the chunk header parser a bit more strict and accurate (and not rely on there being a 0 termiator character)
2017-09-30 11:59:00 -07:00
61733787f7
fix redundant assert in gzip header check
2017-09-29 23:51:45 -07:00
86c37af147
fix integer overflow in torrent_info
2017-09-29 14:08:47 -07:00
f3796060d3
add const
2017-09-29 14:06:40 -07:00
68f05d6380
fix some warnings and integer overflow with torrents that are too big
2017-09-28 14:59:28 -07:00
c8d51689bb
backport: fix windows file preallocation issue
2017-09-28 12:53:28 -07:00
c66f4cc62a
fix some warnings, mostly 0 -> nullptr
2017-09-28 07:33:10 -07:00
53ab7684fd
minor code refactor and cleanup in port mapping code
2017-09-28 01:17:21 -07:00
6e396a85c2
fix windows file preallocation issue
2017-09-28 02:14:20 +03:00
45fe6c0110
code refactor in torrent_handle::info_hash
2017-09-24 23:23:47 -07:00
a619dfb996
more use of auto, const and minor code refactor in torrent.cpp
2017-09-24 23:23:30 -07:00
2cbf35489f
fiw warning in ConvertUTF.cpp
2017-09-24 23:23:14 -07:00
edad33d270
fix const correctness in get_peer_class
2017-09-24 14:49:55 -07:00
4c4c630fae
merge RC_1_1 into master
2017-09-23 10:46:29 -07:00
d22c44c057
fix kludge and down-cast to send upload_only. Promote upload-only to a top-level peer feature
2017-09-23 07:51:51 -07:00
5441874f10
fix integer overflow in whole_pieces_threshold logic
2017-09-23 06:59:13 -07:00
1d9b10a32b
fix warning for Xcode 9, added const and minor code refactor to bt_peer_connection.cpp
2017-09-22 04:46:16 -07:00
8648de3706
DHT nodes should only handle requests on their socket ( #2355 )
2017-09-21 21:00:38 -07:00
ddc8711dbe
fix issue where peers could be disconnected while iterating over the peer list in the torrent. Specifically while marking peers as not-interesting
2017-09-21 07:26:13 -07:00
a8c020892a
more use of auto, const and minor code refactor in ut_pex.cpp
2017-09-21 04:33:42 +02:00
5c91301e6d
more use of auto, const, size, minor code refactor and cleanup
2017-09-18 23:59:41 +02:00
65d16142aa
remove redundant null check
2017-09-18 00:51:26 +02:00
9839507ecd
simplify to_string to not apply unary - to an unsigned integer
2017-09-17 21:23:24 +02:00
7717c02c2f
run sonarqube with deprecated functions disabled. fix some of its code smells
2017-09-17 18:06:53 +02:00
646581f8a2
use new instead of malloc
2017-09-17 17:13:57 +02:00
0232dc35cd
deprecate lock_files ( #2344 )
...
File locking interacts poorly with the path to replace a read only file handle
with a read/write one. For performance reasons the old handle is not closed
until the new one is put in place. With file locking this obviously cannot
work because the first handle is holding a lock on the file. As a result,
file_pool::open_file fails in this case. Even if we dropped the reference to
the read only file handle before attempting to re-open it, the open could still
fail if another thread is holding a reference to the read only handle.
There doesn't seem to be a good way around this. The simple solution would be
to always open files in read/write mode, but that has obvious safety downsides.
Any other solution would significantly complicate the file pool code.
Deprecating file locking seems to be the least bad option.
2017-09-17 10:43:27 +02:00
1a8660bca7
don't shadow static_category in alerts
2017-09-16 19:58:11 +02:00
8d6b51d54c
minor cleanups
2017-09-16 13:48:11 +02:00
582d9dfc24
removed leading :: in posix_fadvise to allow for fix in old android API build ( #2341 )
2017-09-16 13:47:49 +02:00
93bb84d94c
some random cleanup
2017-09-13 08:28:46 +02:00
ccbd6cbcfe
remove rss_reader.py, since rss has been reprecated. fix python binding for torrent_handle, to be hashable. update client_test.py to not use deprecated APIs and follow best (libtorrent) practice
2017-09-11 22:28:57 +02:00
df8a57efb7
select which DHT port to report based on the connection's local endpoint ( #2316 )
2017-09-10 10:25:04 +02:00
55228756e5
make disk job flags type safe
2017-09-10 08:56:52 +02:00
a86bc767de
minor cleanup and code refactor in web_peer_connection.cpp ( #2322 )
2017-09-10 08:52:31 +02:00
7cc2619aad
more use of auto and minor code refactor in routing_table.cpp
2017-09-08 08:49:06 +02:00
arvidn