7e748956e6
Provide a default ip_change_notifier implementation
...
Right now, compiling fails if there's no ip_change_notifier for the
current platform.
2017-10-04 08:56:55 +02:00
99b19366a9
fix leak of peer_class objects (when setting per-torrent rate limits)
2017-10-03 17:32:49 +02:00
27af8c398a
more use of emplace_back and const in create_torrent.cpp
2017-10-03 10:53:04 +02:00
5f3661aaa2
back port overflow checking from master
2017-10-02 00:02:14 +02:00
2ea5115bcc
fix the torrent_info size overflow check
2017-10-01 22:54:28 +02:00
21fef88928
stricten up the filename sanitization a bit
2017-10-01 20:30:02 +02:00
c0d76a5304
fix regression in torrent size check
2017-10-01 16:44:58 +02:00
3255375095
back-port file name sanitization patch to RC_1_1
2017-10-01 16:44:10 +02:00
33b03e1f8e
improve handling of case where a torrent file has no files in it
2017-10-01 10:53:43 +02:00
5026659cb6
clean up and fix edge cases in update_path_index
2017-10-01 04:43:41 +02:00
17d78d3b8f
fix bounds checking in parsing of gzip header
2017-10-01 03:33:38 +02:00
9d276ada8a
fix issue with the name in single file torrents being sanitized away
2017-10-01 01:12:39 +02:00
12e92aeeb4
make the chunk header parser a bit more strict and accurate (and not rely on there being a 0 termiator character)
2017-09-30 11:59:00 -07:00
61733787f7
fix redundant assert in gzip header check
2017-09-29 23:51:45 -07:00
86c37af147
fix integer overflow in torrent_info
2017-09-29 14:08:47 -07:00
f3796060d3
add const
2017-09-29 14:06:40 -07:00
68f05d6380
fix some warnings and integer overflow with torrents that are too big
2017-09-28 14:59:28 -07:00
c8d51689bb
backport: fix windows file preallocation issue
2017-09-28 12:53:28 -07:00
c66f4cc62a
fix some warnings, mostly 0 -> nullptr
2017-09-28 07:33:10 -07:00
53ab7684fd
minor code refactor and cleanup in port mapping code
2017-09-28 01:17:21 -07:00
6e396a85c2
fix windows file preallocation issue
2017-09-28 02:14:20 +03:00
45fe6c0110
code refactor in torrent_handle::info_hash
2017-09-24 23:23:47 -07:00
a619dfb996
more use of auto, const and minor code refactor in torrent.cpp
2017-09-24 23:23:30 -07:00
2cbf35489f
fiw warning in ConvertUTF.cpp
2017-09-24 23:23:14 -07:00
edad33d270
fix const correctness in get_peer_class
2017-09-24 14:49:55 -07:00
4c4c630fae
merge RC_1_1 into master
2017-09-23 10:46:29 -07:00
d22c44c057
fix kludge and down-cast to send upload_only. Promote upload-only to a top-level peer feature
2017-09-23 07:51:51 -07:00
5441874f10
fix integer overflow in whole_pieces_threshold logic
2017-09-23 06:59:13 -07:00
1d9b10a32b
fix warning for Xcode 9, added const and minor code refactor to bt_peer_connection.cpp
2017-09-22 04:46:16 -07:00
8648de3706
DHT nodes should only handle requests on their socket ( #2355 )
2017-09-21 21:00:38 -07:00
ddc8711dbe
fix issue where peers could be disconnected while iterating over the peer list in the torrent. Specifically while marking peers as not-interesting
2017-09-21 07:26:13 -07:00
a8c020892a
more use of auto, const and minor code refactor in ut_pex.cpp
2017-09-21 04:33:42 +02:00
5c91301e6d
more use of auto, const, size, minor code refactor and cleanup
2017-09-18 23:59:41 +02:00
65d16142aa
remove redundant null check
2017-09-18 00:51:26 +02:00
9839507ecd
simplify to_string to not apply unary - to an unsigned integer
2017-09-17 21:23:24 +02:00
7717c02c2f
run sonarqube with deprecated functions disabled. fix some of its code smells
2017-09-17 18:06:53 +02:00
646581f8a2
use new instead of malloc
2017-09-17 17:13:57 +02:00
0232dc35cd
deprecate lock_files ( #2344 )
...
File locking interacts poorly with the path to replace a read only file handle
with a read/write one. For performance reasons the old handle is not closed
until the new one is put in place. With file locking this obviously cannot
work because the first handle is holding a lock on the file. As a result,
file_pool::open_file fails in this case. Even if we dropped the reference to
the read only file handle before attempting to re-open it, the open could still
fail if another thread is holding a reference to the read only handle.
There doesn't seem to be a good way around this. The simple solution would be
to always open files in read/write mode, but that has obvious safety downsides.
Any other solution would significantly complicate the file pool code.
Deprecating file locking seems to be the least bad option.
2017-09-17 10:43:27 +02:00
1a8660bca7
don't shadow static_category in alerts
2017-09-16 19:58:11 +02:00
8d6b51d54c
minor cleanups
2017-09-16 13:48:11 +02:00
582d9dfc24
removed leading :: in posix_fadvise to allow for fix in old android API build ( #2341 )
2017-09-16 13:47:49 +02:00
93bb84d94c
some random cleanup
2017-09-13 08:28:46 +02:00
ccbd6cbcfe
remove rss_reader.py, since rss has been reprecated. fix python binding for torrent_handle, to be hashable. update client_test.py to not use deprecated APIs and follow best (libtorrent) practice
2017-09-11 22:28:57 +02:00
df8a57efb7
select which DHT port to report based on the connection's local endpoint ( #2316 )
2017-09-10 10:25:04 +02:00
55228756e5
make disk job flags type safe
2017-09-10 08:56:52 +02:00
a86bc767de
minor cleanup and code refactor in web_peer_connection.cpp ( #2322 )
2017-09-10 08:52:31 +02:00
7cc2619aad
more use of auto and minor code refactor in routing_table.cpp
2017-09-08 08:49:06 +02:00
c848f6d978
improve some asserts in storage.cpp
2017-09-07 23:00:58 +02:00
bb51dcdbb9
move dht_settings into its own header cpp file-pair and dht_settings into the dht namespace
2017-09-04 22:38:16 +02:00
95c8c3018a
use span in gzip, http_parser and http_connection
2017-09-04 22:33:38 +02:00
061732ddec
bump version
2017-09-04 15:35:45 +02:00
53ff169db1
use string_view in find_metric_idx
2017-09-04 07:50:13 +02:00
fe1c395579
merged RC_1_1 into master
2017-09-03 13:57:19 +02:00
5361ffc1c2
add_file_borrow: use string_view instead of pointer, size parameters ( #2302 )
2017-09-02 23:58:36 +02:00
7087a16b36
move some initialization of torrent from start() into the constructor
2017-09-02 21:24:00 +02:00
24d08cdf82
fix protocol_str in portmap_alert
2017-09-02 10:39:55 +02:00
2025c15ec1
cleanup tokenize_string -> split_string
2017-09-02 07:46:16 +02:00
f8ba4f480f
use span in parse_utf8_codepoint
2017-09-02 07:03:46 +02:00
11f008e90e
use a strong typedef for port mapping id
2017-09-02 07:02:07 +02:00
ac914d4415
avoid port mapping of local addresses ( #2296 )
2017-09-01 19:28:27 +02:00
f022285b13
include endpoint in tracker alerts
2017-09-01 13:38:36 +02:00
f734ad067b
straighten out some type-safety in port mapping enums ( #2285 )
2017-08-30 20:47:49 +02:00
fe09ca9b97
more use of auto, const and minor cleanup in session_impl.cpp
2017-08-30 20:30:06 +02:00
621da10e60
hold an owning reference to storage objects in try_flush_write_blocks
...
It is possible for all other references to a storage object to be
destroyed while try_flush_write_blocks is running. If the storage is
destroyed then find_piece will crash when trying to re-aquire the
shared_ptr. To prevent this, keep the storage alive by holding a
shared_ptr to it in try_flush_write_blocks.
Normally the fence job when stopping a torrent would prevent the storage
object from being destroyed until all flush jobs are complete.
try_flush_write_blocks can be run after every disk job though so it has
the potential to "stradle the fence".
If the associated torrent does get unloaded then it is expected that
find_piece will return NULL thus causing the entry to be ignored.
2017-08-30 12:45:06 +02:00
d0ea585859
minor code optimization in broadcast_socket.cpp
2017-08-29 22:29:11 +02:00
52ccad23b9
read_piece: handle failure to allocate piece buffer
2017-08-29 12:24:17 +02:00
5db597c8b3
more use of std::tuple_size<> and empty()
2017-08-28 22:47:34 +02:00
1075ae3b8d
remove session pool allocator and use the buffer class instead ( #2274 )
...
simplify append_buffer by using size() to determine size of the buffer. make the move explicit in chained_buffer::init_buffer_entry
2017-08-28 11:37:53 +02:00
d4986f878f
treat unique local addresses as local
...
These addresses are not globally routable so they should be considered local.
2017-08-28 11:34:47 +02:00
d250ba5a17
wrap destination string in i2p_peer in string_ptr handler ( #2268 )
2017-08-25 09:42:46 +02:00
1ce4089229
log failures to parse interface and node lists from settings
2017-08-24 07:59:22 +02:00
e92cbf502c
remove the last use of session_impl get_ipv6_interface and get_ipv4_interface
2017-08-23 21:01:15 +02:00
1290e6f5af
simplify buffer handling in rc4_decrypt calls
2017-08-23 07:01:12 +02:00
22c047f8a0
factor out and simplify get_syncoffset
2017-08-23 06:59:44 +02:00
f311bf354e
remove left-overs from disk buffer pool allocator
2017-08-21 16:36:00 +02:00
5130827fc7
minor code refactor and cleanup in bt_peer_connection ( #2261 )
2017-08-21 11:00:00 +02:00
d59d394d5b
remove residual mentions of mtu for interfaces
2017-08-20 22:34:20 +02:00
66734e2e5b
using if_indextoname instead of RTM_GETLINK to fill the interface name in enum_net_interfaces ( #2253 )
...
using if_indextoname instead of RTM_GETLINK to fill the interface name in enum_net_interfaces. removed IFA_LABEL switch case, removed ip_interface::mtu, master rebase
2017-08-20 10:55:59 +02:00
fe37884bc6
fix IPv6 tracker support by performing the second announce in more cases
2017-08-19 18:56:51 +02:00
2365611507
remove support for using a pool allocator for disk buffers ( #2257 )
2017-08-19 11:04:39 +02:00
73e898e38e
disable disk cache pool allocator by default
...
The pool allocator has known issues with not releasing memory when it should
and is of dubious benefit.
See #2251
2017-08-18 09:39:24 +02:00
070066e892
more use of emplace_back and minor code simplification
2017-08-17 08:08:51 +02:00
05b5b4ef4d
merged RC_1_1 into master
2017-08-16 22:46:47 +02:00
b5fe0f95a2
fix issue in UTF-8 encoding validation
2017-08-16 13:15:19 +02:00
b70d3efba9
fix infinite loop when parsing torrents whose filenames have zeroes. #2247
2017-08-16 07:21:34 +02:00
bde4718e3f
typos, auto loop refactor and more std::
2017-08-16 07:01:50 +02:00
6a3be6cfd3
minor trivial code optimization
2017-08-15 23:30:28 +02:00
fcb9c7b6f3
fix invalid read in parse_int() in bdecode_node() and lazy_bdecode()
2017-08-15 00:01:37 +02:00
48de05ba82
lint-based code review in utp related code
2017-08-13 07:49:43 +02:00
50c2aee8ec
don't create web seed connections if the torrent is upload only
...
The fix in 9a63d4696e
2017-08-11 08:16:00 +02:00
0ac01a8532
header fix for use of stringstream
2017-08-10 22:02:10 +02:00
5f4816f1d8
fix include in http_connection.cpp
2017-08-10 19:47:42 +02:00
865ff09a84
merge RC_1_1 into master
2017-08-10 16:44:57 +02:00
560ef29276
fix issue with very long tracker- and web seed URLs. Instead of using a fixed length stack allocated request buffer, use a dynamically growing stringstream
2017-08-10 14:01:11 +02:00
4e497e1383
fix issue where paths were not correctly coalesced when adding files to file_storage (used more memory than necessary)
2017-08-10 12:10:46 +02:00
bb6f2b9837
extend file_storage tests. Make pad files separate paths and file names properly
2017-08-10 01:33:35 +02:00
378a0e974b
fix issue of force-recheck or seeding from read-only media, torrents with empty files in them. Previously libtorrent would create empty files up-front unconditionally, now they won't be created if they already exist
2017-08-09 18:48:49 +02:00
721c4d016a
more use of emplace_back in write_resume_data ( #2221 )
2017-08-09 00:19:11 +02:00
8ed17ab311
minor code refactor, more use of nullptr, typos
2017-08-07 21:15:14 +02:00
2b98951ace
assert that trackers are not announced to while checking files
2017-08-06 20:21:03 +02:00
Tim Niederhausen