59a29a44e2
promote errors in parsing listen_interfaces to post listen_failed_alert
2019-12-09 06:54:31 +01:00
0c2d3a0dac
optimize setting with unlimited unchoke slots
2019-11-26 20:54:52 +01:00
b26629885b
fix storing udp port mappings in listen_socket_t
2019-10-23 15:50:37 +02:00
7878f68370
add some missing documentation. undeprecate error_file_metadata ahead of master undeprecating it
2019-09-08 10:51:46 +02:00
a3440e54bb
make aux::session_settings thread-safe. this allows all threads to share the same settings object, which has low contention and is rarely updated
2019-09-01 03:41:36 +02:00
bfe0e1f27d
hide some internal functions. error if namespaces are preceded by whitespace (as the docs generation script requires them to start at the beginning of the line)
2019-08-07 20:48:26 -07:00
3995ffeafd
similar to how low RTT DHT nodes are preferred over high RTT nodes, also have an affinity for nodes with node IDs derived from their IP
2019-07-28 16:13:16 -07:00
ba731ef0cf
make sure session cleanup releases all its references to torrents
2019-04-22 22:31:51 +02:00
aec5c50282
Track the mapped port for each NAT mapping transport ( #3793 )
...
* Track the mapped port for each NAT mapping transport
Each transport needs to be tracked separately so that a failed mapping request
doesn't cause the listen port for a socket to be cleared to zero.
* add template specialization to allow enums as indexes
* use aux::array for port mappings
2019-04-22 01:50:44 +02:00
3a4a7b742a
deduplicate code implementing log2p1()
2019-03-23 22:44:32 +01:00
57e56d5070
factor out logic around adding torrents to the session into insert_torrent()
2019-03-03 12:56:24 +01:00
a2196a4194
fix warning in session_impl
2019-02-12 00:58:40 +01:00
3e582100d0
removed repeated code and minor code refactor
2018-12-05 09:13:54 +01:00
507fffe872
move where socket buffers are set up, to happen after the socket is opened. log errors in the peer's log instead of session and torrent
2018-12-02 04:03:03 +01:00
7a51813d32
improve peer debug logging
2018-12-02 04:03:03 +01:00
35ec87af4f
add stats counter for the number of outstanding async_accept calls
2018-11-30 02:15:45 +01:00
cc49a7fb15
fix assertion when sending a udp packet to a closed socket
...
This can happen particularly during shutdown. We should eventually get to a
point where this doesn't happen, but since we close the sockets immediately
upon initiating shutdown it's hard to avoid for now.
2018-11-30 02:15:22 +01:00
1b2832e018
convert some for-loops into std algorithms
2018-11-27 19:43:01 +01:00
5383854768
make span's and sha1_hash's index and size types signed (instead of unsigned). Specifically std::ptrdiff_t. In line with the direction of gsl span and reduce signed->unsigned casts
2018-11-16 14:06:22 +01:00
5929ad4cae
merge RC_1_1 into master (again)
2018-11-15 22:55:52 +01:00
29cddaa23e
merged RC_1_1 into master
2018-11-15 15:19:24 +01:00
6d886f29a9
support moving the whole add_torrent_params object into the add_torrent call on session
2018-11-14 19:11:11 +01:00
0c76a3a0c5
require tracker_request objects be moved into queue_manager. also replace non-const reference parameter with rvalue reference
2018-11-14 17:09:04 +01:00
13dd7cfe1e
a better fix to the ssl port announce bug
2018-11-14 07:36:22 +01:00
4d88c83576
add rvalue reference overloads for add_torrent_params, settings_pack and session_params. Those structures are pretty large so being able to take them by rvalue reference may be beneficial
2018-11-13 08:05:56 +01:00
d0e146eb75
merged RC_1_1 into master
2018-11-01 09:48:41 +01:00
e1eb12e60f
ssl listen port fix and improved tracker announce logging
2018-10-29 18:38:14 +01:00
b00ce69d58
remove params.url.clear();
2018-10-25 09:49:38 +02:00
3fb05d77d8
fix warnings
2018-10-20 20:56:26 +02:00
d2f19a2d73
merged RC_1_1 into master
2018-10-01 16:34:21 +02:00
81356cfce1
add make_tcp() and make_udp() to convert endpoint types
2018-09-19 10:57:28 -07:00
c9043dec53
force proxy no longer disables the DHT
2018-08-20 08:24:31 +02:00
28c94b54ed
minor code refactor for more use of const and emplace
2018-08-20 08:06:37 +02:00
b90564d418
remove the IPv6 enable/disable build config
2018-08-19 22:20:54 +02:00
fef1b947f3
fix issue in self-connection detection introduced with the change to generate unique peer-ids for each connection. Now, the torrent keeps track of all of our peer-ids generated for outgoing (bittorrent) connections, and we check them against incoming peers' peer-ids
2018-08-19 22:19:53 +02:00
b3dbce5790
merge RC_1_1 into master
2018-08-13 09:32:17 +02:00
6d2541f131
improve connect-boost feature, to make new torrents quickly connect peers
2018-08-09 20:12:56 +02:00
7be9547817
add a few more stats counters measuring outgoing connection attempts. simplify session_stats_header_alert by posting it on first call to post_session_stats() instead of making it gated by the alert_mask
2018-08-09 20:10:35 +02:00
92f1937b97
fix typo in #if tests for TORRENT_DISABLE_ENCRYPTION
2018-07-29 09:04:16 +02:00
b3856d3027
narrow the scope affected by TORRENT_DISABLE_EXTENSIONS to only disable the user extensions, but always support the extension message and the built-in extensions, like lt_donthave and seed_mode
2018-07-26 09:31:49 +02:00
4282dd072a
factor out generate_peer_id into its own file
2018-07-25 08:49:18 +02:00
730ef15b08
minor cleanups
2018-07-24 16:34:46 +02:00
dcb8b816a3
only post alerts for newly opened listen sockets, and only attempt to map ports for newly opened sockets. track has_incoming_connections per listen socket
2018-07-23 15:04:23 +02:00
f4b0dbf115
merged RC_1_1 into master
2018-07-20 09:28:21 +02:00
1ebc5f9ef2
remove special handling of uTP peers
2018-07-20 07:47:08 +02:00
d9d387d711
minor code cleanup, more use of const ( #3174 )
...
* minor code cleanup, more use of const, using u literal per lint
* revert use of unsigned literal
* reverted loop change
2018-07-16 18:23:38 +02:00
4aa3c4573a
use the strong type for pause flags
2018-07-16 12:06:21 +02:00
4633258fbe
make the DHT announce flags a strong type
2018-07-16 12:04:16 +02:00
e5be30157f
set port in handshake based on source address ( #3172 )
2018-07-15 21:15:04 +02:00
961cf62cad
dht: announce with per-interface listen port
2018-07-12 08:36:57 +02:00
b750b6cc2c
deprecate (and disable) the force-proxy setting. Instead, always use the proxy when set, never fall back on circumventing it
2018-07-08 18:26:47 +02:00
2c5da2778a
more lint oriented code refactor/cleanup
2018-06-29 13:27:29 +02:00
fbaa1afd62
return a vector of mapping ids from add_port_mapping
2018-06-07 18:18:31 -07:00
f6720e31ed
don't re-map all listen sockets when changing listen_interfaces
...
New sockets will be mapped regardless of the remap parameter. Requesting
full re-mapping just creates unecessary network traffic.
2018-06-07 18:16:08 -07:00
78be52112f
create a natpmp instance for each listen socket
2018-06-07 18:16:08 -07:00
6c4869f044
moved instantiate_connection to aux namespace
2018-05-29 09:25:25 +02:00
534276e7a5
refactor to use the utility function for bind_socket_to_device() instead of using the bind_to_device socket option directly, to make it best effort. include operation enum in udp_error alert.
2018-05-23 12:11:04 +02:00
92a7188163
only start a new accept request on new listen sockets
...
Existing sockets already have an outstanding accept.
Also fix mapping new listen sockets when re-mapping is not requested.
2018-05-22 11:06:33 +02:00
17055ad4d1
don't enable reuse-address for UDP sockets, as it will always succeed and not get any incoming packets. It's better to detect a port conflict and try a different port. Also implement port-retry logic for the UDP sockets
2018-05-13 22:36:02 +02:00
fe612ca167
replace the TORRENT_CFG ABI check with inline namespaces around the symbol that can change ABI based on build configuration options
2018-05-13 19:25:17 +02:00
9ca12d6db5
restore aspects of the previous behavior of force-proxy. Instead of not opening any TCP listen sockets at all, open them but reject any incoming connection. This is because in RC_1_1, the UDP and TCP sockets are tied in subtle and unintuitive ways. This is much cleaner in the next major release and this patch will not need to be merged
2018-05-13 12:31:00 +02:00
ddd1168296
don't attempt to make uTP connections if we don't have any outgoing UDP sockets
2018-05-12 13:34:58 +02:00
4d17e0132e
fix empty outgoing interfaces for UDP sockets
2018-05-12 13:34:58 +02:00
8621477239
merged RC_1_1 into master
2018-04-28 14:36:24 +02:00
21d8e9e26b
Add missing header <cstdarg> for va_list.
...
* Fix building on OpenBSD.
2018-04-24 23:09:25 -04:00
f0227451a6
merged RC_1_1 into master
2018-04-13 01:47:41 +02:00
9b1e79660f
removed unnecessary parentheses around min/max, added some const modifier ( #2926 )
2018-04-11 15:19:00 +02:00
aaf9304a3b
update year in copyright header
2018-04-09 09:04:33 +02:00
a7406de2b8
remove the global cache of the current time, just use clock::now() instead
2018-04-07 21:43:18 +02:00
0d9862a8dd
fix wrong variable name
2018-04-04 19:41:03 +02:00
16f1deb3ec
merged RC_1_1 into master
2018-04-04 15:28:33 +02:00
98d5313598
don't perform DNS lookups for the DHT bootstrap unless DHT is enabled
2018-04-01 23:53:12 +02:00
5b922072e9
avoid calls to .address() when looking for endpoint protocol ( #2892 )
...
using is_v4 and is_v6 where possible
2018-04-01 13:48:17 +02:00
6a2df1034a
add some asserts and checks preventing IPv6 addresses to make it into libtorrent when IPv6 support is disabled
2018-03-31 14:17:06 +02:00
9696082355
merged RC_1_1 into master
2018-02-25 09:36:12 +01:00
1ede34da8a
undo the patch to restore incoming TCP connections over SOCKS5
2018-02-19 00:01:42 +01:00
a0a63341c7
fix haiku build
2018-02-04 19:10:43 +01:00
a33c81ad33
shave down session_interface by one function, reduce the dependencies between torrent and session
2018-01-29 03:00:59 +01:00
308cbfe097
merged RC_1_1 into master
2018-01-27 02:36:55 +01:00
bc4d53c71f
restore support for incoming connections over SOCKS5 (disabled by default)
2018-01-25 09:14:14 +01:00
4fef787212
merged RC_1_1 into master
2018-01-24 00:37:05 +01:00
efd096d879
use unique peer_ids per connection
2018-01-23 16:40:16 +01:00
785fffd976
make url_random take a span
2018-01-15 01:49:42 -05:00
a67eb2f059
fix tracker connection bind issue for IPv6 trackers
2018-01-14 06:47:13 -05:00
65fef972a2
apply some c++11 modernization
2018-01-11 04:51:39 -05:00
3a9861e237
complete the error handling test and make it part of the default simulation test suite. It will run a file transfer between two clients repeatedly, each time cause another memory allocation fail, until every single memory allocation has failed once. Any invariant check failure, assertion or signal will cause the test to fail
2018-01-08 04:44:52 -05:00
88643dd121
fix m_in_constructor assert for peer_connection (if the peer connection is constructed, but bt_peer_connection constructor fails, it needs to be cleared). Fix an invariant in session on ungraceful shutdown. Make test framework a bit more robust
2018-01-06 14:29:20 -05:00
98ade28237
using make_address instead of deprecated from_string when boost>=1.66 ( #2659 )
...
using make_address instead of deprecated from_string when boost>=1.66
2018-01-04 04:48:22 -05:00
0731200149
block_size is a constant, no need in passing it around as a variable
2018-01-03 08:45:25 -05:00
aae12250ae
support forced shutdown/destruction of torrent objects
2017-12-28 14:11:55 +01:00
5f0c9a0c1d
improve error handling during session shutdown
2017-12-28 13:52:07 +01:00
c1abafc0cc
reserve space in the undead peers list up-front, to not have to allocate memory when disconnecting
2017-12-27 21:24:16 +01:00
5ebd05b047
handle serious errors in on_accept_connection handler
2017-12-27 21:23:25 +01:00
ab9fcdf029
reserve space in torrent lists up-front, to make transitioning list membership unable to fail
2017-12-27 15:42:46 +01:00
40292a1d51
don't heap-allocate handlers for incoming UDP packets
2017-12-24 11:22:30 +01:00
753826cbb8
merger RC_1_1 into master
2017-12-23 18:15:01 +01:00
62bf524e75
disable DHT logging with the TORRENT_DISABLE_LOGGING macros as well
2017-12-23 12:01:18 +01:00
94f4e88e05
Fix local network address mappings.
2017-12-20 11:28:36 +01:00
a54f76d5df
deprecate status_code from tracker_error_alert (it's already part of the error_code), simplify code a bit
2017-12-19 00:55:51 +01:00
96bf0ad5de
fix reopening of listen sockets when disabling force-proxy
2017-12-17 08:25:51 +01:00
arvidn