fixes and asserts partly related to the freeing of the piece picker

ChangeLog

@@ -1,3 +1,5 @@
+	* Implemented an optmization which frees the piece_picker once a torrent
+	  turns into a seed.
 	* Added support for uT peer exchange extension, implemented by Massaroddel.
 	* Modified the quota management to offer better bandwidth balancing
 	  between peers.

src/peer_connection.cpp

@@ -953,6 +953,9 @@ namespace libtorrent
 
 		boost::shared_ptr<torrent> t = m_torrent.lock();
 		assert(t);
+#ifndef NDEBUG
+		t->check_invariant();
+#endif
 
 #ifdef TORRENT_VERBOSE_LOGGING
 		(*m_logger) << to_simple_string(second_clock::universal_time())
@@ -982,6 +985,7 @@ namespace libtorrent
 		if (t->is_seed()) return;
 
 		piece_picker& picker = t->picker();
+		piece_manager& fs = t->filesystem();
 
 		piece_block block_finished(p.piece, p.start / t->block_size());
 		bool redundant = true;
@@ -1074,7 +1078,7 @@ namespace libtorrent
 
 		if (redundant) return;
 
-		t->filesystem().write(data, p.piece, p.start, p.length);
+		fs.write(data, p.piece, p.start, p.length);
 
 		bool was_seed = t->is_seed();
 		bool was_finished = picker.num_filtered() + t->num_pieces()

src/torrent.cpp

@@ -654,7 +654,7 @@ namespace libtorrent
 
 	size_type torrent::quantized_bytes_done() const
 	{
-		INVARIANT_CHECK;
+//		INVARIANT_CHECK;
 
 		if (!valid_metadata()) return 0;
 
@@ -702,6 +702,7 @@ namespace libtorrent
 		
 		size_type total_done
 			= m_num_pieces * m_torrent_file.piece_length();
+		assert(m_num_pieces < m_torrent_file.num_pieces());
 
 		// if we have the last piece, we have to correct
 		// the amount we have, since the first calculation
@@ -715,6 +716,8 @@ namespace libtorrent
 				wanted_done += corr;
 		}
 
+		assert(total_done < m_torrent_file.total_size());
+
 		const std::vector<piece_picker::downloading_piece>& dl_queue
 			= m_picker->get_download_queue();
 
@@ -725,7 +728,8 @@ namespace libtorrent
 			dl_queue.begin(); i != dl_queue.end(); ++i)
 		{
 			int corr = 0;
-			assert(!m_have_pieces[i->index]);
+			if (m_have_pieces[i->index]) continue;
+//			assert(!m_have_pieces[i->index]);
 
 			for (int j = 0; j < blocks_per_piece; ++j)
 			{
@@ -926,6 +930,9 @@ namespace libtorrent
 	{
 		INVARIANT_CHECK;
 
+		assert(valid_metadata());
+		if (is_seed()) return;
+
 		// this call is only valid on torrents with metadata
 		assert(m_picker.get());
 		assert(index >= 0);
@@ -942,6 +949,9 @@ namespace libtorrent
 		INVARIANT_CHECK;
 
 		// this call is only valid on torrents with metadata
+		assert(valid_metadata());
+		if (is_seed()) return;
+
 		assert(m_picker.get());
 
 		// TODO: update peer's interesting-bit
@@ -969,6 +979,9 @@ namespace libtorrent
 	bool torrent::is_piece_filtered(int index) const
 	{
 		// this call is only valid on torrents with metadata
+		assert(valid_metadata());
+		if (is_seed()) return false;
+		
 		assert(m_picker.get());
 		assert(index >= 0);
 		assert(index < m_torrent_file.num_pieces());
@@ -981,6 +994,14 @@ namespace libtorrent
 		INVARIANT_CHECK;
 
 		// this call is only valid on torrents with metadata
+		assert(valid_metadata());
+		if (is_seed())
+		{
+			bitmask.clear();
+			bitmask.resize(m_torrent_file.num_pieces(), false);
+			return;
+		}
+
 		assert(m_picker.get());
 		m_picker->filtered_pieces(bitmask);
 	}
@@ -990,7 +1011,7 @@ namespace libtorrent
 		INVARIANT_CHECK;
 
 		// this call is only valid on torrents with metadata
-		if (!valid_metadata()) return;
+		if (!valid_metadata() || is_seed()) return;
 
 		// the bitmask need to have exactly one bit for every file
 		// in the torrent
@@ -1647,7 +1668,7 @@ namespace libtorrent
 
 	session_settings const& torrent::settings() const
 	{
-		INVARIANT_CHECK;
+//		INVARIANT_CHECK;
 
 		return m_ses.settings();
 	}
@@ -1666,6 +1687,21 @@ namespace libtorrent
 				assert(false);
 		}
 
+		if (valid_metadata())
+		{
+			assert(m_have_pieces.size() == m_torrent_file.num_pieces());
+		}
+		else
+		{
+			assert(m_have_pieces.empty());
+		}
+
+		size_type total_done = quantized_bytes_done();
+		if (is_seed())
+			assert(total_done == m_torrent_file.total_size());
+		else
+			assert(total_done != m_torrent_file.total_size());
+
 // This check is very expensive.
 //		assert(m_num_pieces
 //			== std::count(m_have_pieces.begin(), m_have_pieces.end(), true));
@@ -2204,13 +2240,24 @@ namespace libtorrent
 		st.num_pieces = m_num_pieces;
 
 		if (m_got_tracker_response == false)
+		{
 			st.state = torrent_status::connecting_to_tracker;
-		else if (m_num_pieces == (int)m_have_pieces.size())
+		}
+		else if (is_seed())
+		{
+			assert(st.total_done == m_torrent_file.total_size());
 			st.state = torrent_status::seeding;
+		}
 		else if (st.total_wanted_done == st.total_wanted)
+		{
+			assert(!is_seed());
+			assert(st.total_done != m_torrent_file.total_size());
 			st.state = torrent_status::finished;
+		}
 		else
+		{
 			st.state = torrent_status::downloading;
+		}
 
 		st.num_seeds = num_seeds();
 		if (m_picker.get())