regenerate html
This commit is contained in:
Arvid Norberg
parent
eff0bf97b8
commit
ea4dbf603f
|
|
@ -3,7 +3,7 @@
|
|||
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
|
||||
<head>
|
||||
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
|
||||
<meta name="generator" content="Docutils 0.11: http://docutils.sourceforge.net/" />
|
||||
<meta name="generator" content="Docutils 0.10: http://docutils.sourceforge.net/" />
|
||||
<title>BitTorrent DHT security extension</title>
|
||||
<meta name="author" content="Arvid Norberg, arvid@rasterbar.com" />
|
||||
<link rel="stylesheet" type="text/css" href="../../css/base.css" />
|
||||
|
|
@ -55,13 +55,13 @@
|
|||
<div class="contents topic" id="table-of-contents">
|
||||
<p class="topic-title first">Table of contents</p>
|
||||
<ul class="simple">
|
||||
<li><a class="reference internal" href="#id1" id="id2">BitTorrent DHT security extension</a></li>
|
||||
<li><a class="reference internal" href="#considerations" id="id3">considerations</a></li>
|
||||
<li><a class="reference internal" href="#node-id-restriction" id="id4">Node ID restriction</a></li>
|
||||
<li><a class="reference internal" href="#bootstrapping" id="id5">bootstrapping</a></li>
|
||||
<li><a class="reference internal" href="#enforcement" id="id6">enforcement</a></li>
|
||||
<li><a class="reference internal" href="#backwards-compatibility-and-transition" id="id7">backwards compatibility and transition</a></li>
|
||||
<li><a class="reference internal" href="#forward-compatibility" id="id8">forward compatibility</a></li>
|
||||
<li><a class="reference internal" href="#id1" id="id3">BitTorrent DHT security extension</a></li>
|
||||
<li><a class="reference internal" href="#considerations" id="id4">considerations</a></li>
|
||||
<li><a class="reference internal" href="#node-id-restriction" id="id5">Node ID restriction</a></li>
|
||||
<li><a class="reference internal" href="#bootstrapping" id="id6">bootstrapping</a></li>
|
||||
<li><a class="reference internal" href="#enforcement" id="id7">enforcement</a></li>
|
||||
<li><a class="reference internal" href="#backwards-compatibility-and-transition" id="id8">backwards compatibility and transition</a></li>
|
||||
<li><a class="reference internal" href="#forward-compatibility" id="id9">forward compatibility</a></li>
|
||||
</ul>
|
||||
</div>
|
||||
<div class="section" id="id1">
|
||||
|
|
@ -107,19 +107,22 @@ forced to run their DHT nodes on the same node ID.</p>
|
|||
<p>In order to avoid the number node IDs controlled to grow linearly by the number
|
||||
of IPs, as well as allowing more than one node ID per external IP, the node
|
||||
ID can be restricted at each class level of the IP.</p>
|
||||
<p>Another important property of the restriction put on node IDs is that the
|
||||
distribution of the IDs remoain uniform. This is why CRC32 was chosen
|
||||
as the hash function. See <a class="reference external" href="http://blog.libtorrent.org/2012/12/dht-security/">comparisons of hash functions</a>.</p>
|
||||
<p>The expression to calculate a valid ID prefix (from an IPv4 address) is:</p>
|
||||
<pre class="literal-block">
|
||||
sha1((ip & 0x01071f7f) .. r)
|
||||
crc32((ip & 0x01071f7f) .. r)
|
||||
</pre>
|
||||
<p>And for an IPv6 address (<tt class="docutils literal">ip</tt> is the high 64 bits of the address):</p>
|
||||
<pre class="literal-block">
|
||||
sha1((ip & 0x000103070f1f3f7f) .. r)
|
||||
crc32((ip & 0x000103070f1f3f7f) .. r)
|
||||
</pre>
|
||||
<p><tt class="docutils literal">r</tt> is a random number in the range [0, 7]. The resulting integer,
|
||||
representing the masked IP address is supposed to be big-endian before
|
||||
hashed. The ".." means concatenation.</p>
|
||||
<p>The details of implementing this is to evaluate the expression, store the
|
||||
result in a big endian 64 bit integer and hash those 8 bytes with SHA-1.</p>
|
||||
result in a big endian 64 bit integer and hash those 8 bytes with CRC32.</p>
|
||||
<p>The first 4 bytes of the node ID used in the DHT MUST match the first 4
|
||||
bytes in the resulting hash. The last byte of the hash MUST match the
|
||||
random number (<tt class="docutils literal">r</tt>) used to generate the hash.</p>
|
||||
|
|
@ -138,13 +141,17 @@ uint8_t* mask = num_octets == 4 ? v4_mask : v8_mask;
|
|||
for (int i = 0; i < num_octets; ++i)
|
||||
ip[i] &= mask[i];
|
||||
|
||||
SHA_CTX ctx;
|
||||
SHA1_Init(&ctx);
|
||||
SHA1_Update(&ctx, (unsigned char*)ip, num_octets);
|
||||
uint32_t rand = rand() & 0xff;
|
||||
uint8_t r = rand & 0x7;
|
||||
SHA1_Update(&ctx, (unsigned char*)&r, 1);
|
||||
SHA1_Final(&ctx, node_id);
|
||||
|
||||
uint32_t crc = crc32(0, NULL, 0);
|
||||
crc = crc32(crc, ip, num_octets);
|
||||
crc = crc32(crc, &r, 1);
|
||||
|
||||
node_id[0] = (crc >> 24) & 0xff;
|
||||
node_id[1] = (crc >> 16) & 0xff;
|
||||
node_id[2] = (crc >> 8) & 0xff;
|
||||
node_id[3] = crc & 0xff;
|
||||
for (int i = 4; i < 19; ++i) node_id[i] = std::rand();
|
||||
node_id[19] = rand;
|
||||
</pre>
|
||||
|
|
@ -152,11 +159,11 @@ node_id[19] = rand;
|
|||
<pre class="literal-block">
|
||||
IP rand example node ID
|
||||
============ ===== ==========================================
|
||||
124.31.75.21 1 <strong>f766f9f5</strong> 0c5d6a4ec8a88e4c6ab4c28b95eee4 <strong>01</strong>
|
||||
21.75.31.124 86 <strong>7ee04779</strong> 4e7a08645677bbd1cfe7d8f956d532 <strong>56</strong>
|
||||
65.23.51.170 22 <strong>76a626ff</strong> bc8f112a3d426c84764f8c2a1150e6 <strong>16</strong>
|
||||
84.124.73.14 65 <strong>beb4e619</strong> 1bb1fe518101ceef99462b947a01ff <strong>41</strong>
|
||||
43.213.53.83 90 <strong>ace5613a</strong> 5b7c4be0237986d5243b87aa6d5130 <strong>5a</strong>
|
||||
124.31.75.21 1 <strong>1712f6c7</strong> 0c5d6a4ec8a88e4c6ab4c28b95eee4 <strong>01</strong>
|
||||
21.75.31.124 86 <strong>946406c1</strong> 4e7a08645677bbd1cfe7d8f956d532 <strong>56</strong>
|
||||
65.23.51.170 22 <strong>fefd9220</strong> bc8f112a3d426c84764f8c2a1150e6 <strong>16</strong>
|
||||
84.124.73.14 65 <strong>af1546dd</strong> 1bb1fe518101ceef99462b947a01ff <strong>41</strong>
|
||||
43.213.53.83 90 <strong>a9e920bf</strong> 5b7c4be0237986d5243b87aa6d5130 <strong>5a</strong>
|
||||
</pre>
|
||||
<p>The bold parts of the node ID are the important parts. The rest are
|
||||
random numbers.</p>
|
||||
|
|
|
|||
|
|
@ -3,7 +3,7 @@
|
|||
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
|
||||
<head>
|
||||
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
|
||||
<meta name="generator" content="Docutils 0.11: http://docutils.sourceforge.net/" />
|
||||
<meta name="generator" content="Docutils 0.10: http://docutils.sourceforge.net/" />
|
||||
<title>libtorrent manual</title>
|
||||
<meta name="author" content="Arvid Norberg, arvid@rasterbar.com" />
|
||||
<link rel="stylesheet" type="text/css" href="../../css/base.css" />
|
||||
|
|
@ -53,36 +53,15 @@
|
|||
<div class="contents topic" id="table-of-contents">
|
||||
<p class="topic-title first">Table of contents</p>
|
||||
<ul class="simple">
|
||||
<li><a class="reference internal" href="#running-and-building-tests" id="id3">running and building tests</a></li>
|
||||
<li><a class="reference internal" href="#id1" id="id4">lighty</a></li>
|
||||
<li><a class="reference internal" href="#delegate" id="id5">delegate</a></li>
|
||||
<li><a class="reference internal" href="#openssl" id="id6">OpenSSL</a></li>
|
||||
<li><a class="reference internal" href="#running-and-building-tests" id="id2">running and building tests</a></li>
|
||||
<li><a class="reference internal" href="#delegate" id="id3">delegate</a></li>
|
||||
</ul>
|
||||
</div>
|
||||
<div class="section" id="running-and-building-tests">
|
||||
<h1>running and building tests</h1>
|
||||
<p>Some of the tests of libtorrent are not self contained. For instance, in
|
||||
order to test the <tt class="docutils literal">http_connection</tt> class in libtorrent, the test requires
|
||||
<a class="reference external" href="http://www.lighttpd.net">lighty</a>. This document outlines the requirements of the tests as well as
|
||||
describes how to set up your environment to be able to run them.</p>
|
||||
</div>
|
||||
<div class="section" id="id1">
|
||||
<h1>lighty</h1>
|
||||
<p>Download <a class="reference external" href="http://www.lighttpd.net">lighty</a>. I've tested with <tt class="docutils literal"><span class="pre">lighttpd-1.4.19</span></tt>. If libtorrent is built
|
||||
with SSL support (which it is by default), lighty needs SSL support as well.</p>
|
||||
<p>To build lighty with SSL support do:</p>
|
||||
<pre class="literal-block">
|
||||
./configure --with-openssl
|
||||
</pre>
|
||||
<p>Followed by:</p>
|
||||
<pre class="literal-block">
|
||||
sudo make install
|
||||
</pre>
|
||||
<p>Make sure you have SSL support in lighty by running:</p>
|
||||
<pre class="literal-block">
|
||||
lighttpd -V
|
||||
</pre>
|
||||
<p>Which gives you a list of all enabled features.</p>
|
||||
<p>The tests for SOCKS and HTTP proxy relies on <tt class="docutils literal">delegate</tt> being installed
|
||||
to set up test proxies. This document outlines the requirements of the
|
||||
tests as well as describes how to set up your environment to be able to run them.</p>
|
||||
</div>
|
||||
<div class="section" id="delegate">
|
||||
<h1>delegate</h1>
|
||||
|
|
@ -93,21 +72,6 @@ HTTP proxies.</p>
|
|||
<a class="reference external" href="http://www.delegate.org/delegate/download/">deletate's download page</a>. Make sure to name the executable <tt class="docutils literal">delegated</tt>
|
||||
and put it in a place where a shell can pick it up, in its <tt class="docutils literal">PATH</tt>. For
|
||||
instance <tt class="docutils literal">/bin</tt>.</p>
|
||||
</div>
|
||||
<div class="section" id="openssl">
|
||||
<h1>OpenSSL</h1>
|
||||
<p>In order to create an SSL certificate for <a class="reference external" href="http://www.lighttpd.net">lighty</a>, openssl is used. More
|
||||
specifically, the following command is issued by the test to create the
|
||||
certificate file:</p>
|
||||
<pre class="literal-block">
|
||||
echo -e "AU\ntest province\ntest city\ntest company\ntest department\n\
|
||||
tester\ntest@test.com" | openssl req -new -x509 -keyout server.pem \
|
||||
-out server.pem -days 365 -nodes
|
||||
</pre>
|
||||
<p>This will write <tt class="docutils literal">server.pem</tt> which is referenced in the lighty
|
||||
confiuration file.</p>
|
||||
<p>OpenSSL comes installed with most Linux and BSD distros, including Mac OS X.
|
||||
You can download it from <a class="reference external" href="http://www.openssl.org/">the openssl homepage</a>.</p>
|
||||
</div>
|
||||
</div>
|
||||
<div id="footer">
|
||||
|
|
|
|||
104
docs/todo.html
104
docs/todo.html
|
|
@ -25,7 +25,7 @@
|
|||
<span style="color: #3c3">11 relevant</span>
|
||||
<span style="color: #77f">16 feasible</span>
|
||||
<span style="color: #999">35 notes</span>
|
||||
<table width="100%" border="1" style="border-collapse: collapse;"><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(0)">../src/torrent.cpp:5798</a></td><td>support SSL over uTP</td></tr><tr id="0" style="display: none;" colspan="3"><td colspan="3"><h2>support SSL over uTP</h2><h4>../src/torrent.cpp:5798</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // we'll instantiate a TCP connection
|
||||
<table width="100%" border="1" style="border-collapse: collapse;"><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(0)">../src/torrent.cpp:5801</a></td><td>support SSL over uTP</td></tr><tr id="0" style="display: none;" colspan="3"><td colspan="3"><h2>support SSL over uTP</h2><h4>../src/torrent.cpp:5801</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // we'll instantiate a TCP connection
|
||||
utp_socket_manager* sm = 0;
|
||||
|
||||
if (m_ses.m_settings.enable_outgoing_utp
|
||||
|
|
@ -76,7 +76,7 @@
|
|||
}
|
||||
|
||||
m_ses.setup_socket_buffers(*s);
|
||||
</pre></td></tr><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(1)">../src/torrent.cpp:6148</a></td><td>if peer is a really good peer, maybe we shouldn't disconnect it</td></tr><tr id="1" style="display: none;" colspan="3"><td colspan="3"><h2>if peer is a really good peer, maybe we shouldn't disconnect it</h2><h4>../src/torrent.cpp:6148</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> return false;
|
||||
</pre></td></tr><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(1)">../src/torrent.cpp:6151</a></td><td>if peer is a really good peer, maybe we shouldn't disconnect it</td></tr><tr id="1" style="display: none;" colspan="3"><td colspan="3"><h2>if peer is a really good peer, maybe we shouldn't disconnect it</h2><h4>../src/torrent.cpp:6151</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> return false;
|
||||
}
|
||||
TORRENT_ASSERT(m_connections.find(p) == m_connections.end());
|
||||
m_connections.insert(p);
|
||||
|
|
@ -282,7 +282,7 @@ in the torrent. That should be taken into account here.</h2><h4>../src/piece_pic
|
|||
// ignored as long as possible. All blocks found in downloading
|
||||
// pieces are regarded as backup blocks
|
||||
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(5)">../src/session_impl.cpp:5180</a></td><td>if we still can't find the torrent, we should probably look for it by url here</td></tr><tr id="5" style="display: none;" colspan="3"><td colspan="3"><h2>if we still can't find the torrent, we should probably look for it by url here</h2><h4>../src/session_impl.cpp:5180</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(5)">../src/session_impl.cpp:5208</a></td><td>if we still can't find the torrent, we should probably look for it by url here</td></tr><tr id="5" style="display: none;" colspan="3"><td colspan="3"><h2>if we still can't find the torrent, we should probably look for it by url here</h2><h4>../src/session_impl.cpp:5208</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
||||
}
|
||||
#if defined TORRENT_VERBOSE_LOGGING || defined TORRENT_LOGGING || defined TORRENT_ERROR_LOGGING
|
||||
else
|
||||
|
|
@ -333,7 +333,7 @@ in the torrent. That should be taken into account here.</h2><h4>../src/piece_pic
|
|||
torrent_ptr->start();
|
||||
|
||||
#ifndef TORRENT_DISABLE_EXTENSIONS
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(6)">../src/torrent.cpp:5916</a></td><td>pass in ec along with the alert</td></tr><tr id="6" style="display: none;" colspan="3"><td colspan="3"><h2>pass in ec along with the alert</h2><h4>../src/torrent.cpp:5916</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(6)">../src/torrent.cpp:5919</a></td><td>pass in ec along with the alert</td></tr><tr id="6" style="display: none;" colspan="3"><td colspan="3"><h2>pass in ec along with the alert</h2><h4>../src/torrent.cpp:5919</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
||||
if (info_hash != m_torrent_file->info_hash())
|
||||
{
|
||||
if (alerts().should_post<metadata_failed_alert>())
|
||||
|
|
@ -384,7 +384,7 @@ in the torrent. That should be taken into account here.</h2><h4>../src/piece_pic
|
|||
{
|
||||
std::set<peer_connection*>::iterator p = i++;
|
||||
(*p)->disconnect_if_redundant();
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(7)">../src/torrent.cpp:8306</a></td><td>will pick_pieces ever return an empty set?</td></tr><tr id="7" style="display: none;" colspan="3"><td colspan="3"><h2>will pick_pieces ever return an empty set?</h2><h4>../src/torrent.cpp:8306</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (added_request)
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(7)">../src/torrent.cpp:8321</a></td><td>will pick_pieces ever return an empty set?</td></tr><tr id="7" style="display: none;" colspan="3"><td colspan="3"><h2>will pick_pieces ever return an empty set?</h2><h4>../src/torrent.cpp:8321</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (added_request)
|
||||
{
|
||||
peers_with_requests.insert(peers_with_requests.begin(), &c);
|
||||
if (i->first_requested == min_time()) i->first_requested = now;
|
||||
|
|
@ -425,6 +425,7 @@ in the torrent. That should be taken into account here.</h2><h4>../src/piece_pic
|
|||
for (std::list<web_seed_entry>::const_iterator i = m_web_seeds.begin()
|
||||
, end(m_web_seeds.end()); i != end; ++i)
|
||||
{
|
||||
if (i->peer_info.banned) continue;
|
||||
if (i->type != type) continue;
|
||||
ret.insert(i->url);
|
||||
}
|
||||
|
|
@ -434,7 +435,6 @@ in the torrent. That should be taken into account here.</h2><h4>../src/piece_pic
|
|||
void torrent::remove_web_seed(std::string const& url, web_seed_entry::type_t type)
|
||||
{
|
||||
std::list<web_seed_entry>::iterator i = std::find_if(m_web_seeds.begin(), m_web_seeds.end()
|
||||
, (boost::bind(&web_seed_entry::url, _1)
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(8)">../src/utp_stream.cpp:608</a></td><td>support the option to turn it off</td></tr><tr id="8" style="display: none;" colspan="3"><td colspan="3"><h2>support the option to turn it off</h2><h4>../src/utp_stream.cpp:608</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> UTP_STATE_ERROR_WAIT,
|
||||
|
||||
// there are no more references to this socket
|
||||
|
|
@ -583,8 +583,7 @@ m_replies_bytes_sent[e["r"]] += int(m_send_buf.size());</h2><h4>../src/kademlia/
|
|||
|
||||
}}
|
||||
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(11)">../src/kademlia/node.cpp:63</a></td><td>make this configurable in dht_settings</td></tr><tr id="11" style="display: none;" colspan="3"><td colspan="3"><h2>make this configurable in dht_settings</h2><h4>../src/kademlia/node.cpp:63</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#include "libtorrent/alert.hpp"
|
||||
#include "libtorrent/socket.hpp"
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(11)">../src/kademlia/node.cpp:64</a></td><td>make this configurable in dht_settings</td></tr><tr id="11" style="display: none;" colspan="3"><td colspan="3"><h2>make this configurable in dht_settings</h2><h4>../src/kademlia/node.cpp:64</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#include "libtorrent/socket.hpp"
|
||||
#include "libtorrent/random.hpp"
|
||||
#include "libtorrent/aux_/session_impl.hpp"
|
||||
#include "libtorrent/kademlia/node_id.hpp"
|
||||
|
|
@ -594,7 +593,8 @@ m_replies_bytes_sent[e["r"]] += int(m_send_buf.size());</h2><h4>../src/kademlia/
|
|||
|
||||
#include "libtorrent/kademlia/refresh.hpp"
|
||||
#include "libtorrent/kademlia/find_data.hpp"
|
||||
#include "libtorrent/rsa.hpp"
|
||||
|
||||
#include "ed25519.h"
|
||||
|
||||
namespace libtorrent { namespace dht
|
||||
{
|
||||
|
|
@ -685,7 +685,7 @@ private:
|
|||
void mapping_expired(error_code const& e, int i);
|
||||
void close_impl(mutex::scoped_lock& l);
|
||||
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(13)">../include/libtorrent/torrent_info.hpp:659</a></td><td>these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memory</td></tr><tr id="13" style="display: none;" colspan="3"><td colspan="3"><h2>these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memory</h2><h4>../include/libtorrent/torrent_info.hpp:659</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> std::vector<announce_entry> m_urls;
|
||||
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(13)">../include/libtorrent/torrent_info.hpp:663</a></td><td>these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memory</td></tr><tr id="13" style="display: none;" colspan="3"><td colspan="3"><h2>these strings (m_comment, m_created_by, m_ssl_root_cert) could be lazy_entry* to save memory</h2><h4>../include/libtorrent/torrent_info.hpp:663</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> std::vector<announce_entry> m_urls;
|
||||
std::vector<web_seed_entry> m_web_seeds;
|
||||
nodes_t m_nodes;
|
||||
|
||||
|
|
@ -891,8 +891,8 @@ all completed disk operations</h2><h4>../src/peer_connection.cpp:2568</h4><pre s
|
|||
return;
|
||||
}
|
||||
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(17)">../src/session_impl.cpp:5551</a></td><td>report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address</td></tr><tr id="17" style="display: none;" colspan="3"><td colspan="3"><h2>report the proper address of the router as the source IP of
|
||||
this understanding of our external address, instead of the empty address</h2><h4>../src/session_impl.cpp:5551</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::on_port_mapping(int mapping, address const& ip, int port
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(17)">../src/session_impl.cpp:5579</a></td><td>report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address</td></tr><tr id="17" style="display: none;" colspan="3"><td colspan="3"><h2>report the proper address of the router as the source IP of
|
||||
this understanding of our external address, instead of the empty address</h2><h4>../src/session_impl.cpp:5579</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::on_port_mapping(int mapping, address const& ip, int port
|
||||
, error_code const& ec, int map_transport)
|
||||
{
|
||||
TORRENT_ASSERT(is_network_thread());
|
||||
|
|
@ -943,7 +943,7 @@ this understanding of our external address, instead of the empty address</h2><h4
|
|||
{
|
||||
// INVARIANT_CHECK;
|
||||
TORRENT_ASSERT(is_network_thread());
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(18)">../src/session_impl.cpp:5761</a></td><td>report errors as alerts</td></tr><tr id="18" style="display: none;" colspan="3"><td colspan="3"><h2>report errors as alerts</h2><h4>../src/session_impl.cpp:5761</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(18)">../src/session_impl.cpp:5789</a></td><td>report errors as alerts</td></tr><tr id="18" style="display: none;" colspan="3"><td colspan="3"><h2>report errors as alerts</h2><h4>../src/session_impl.cpp:5789</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
||||
|
||||
void session_impl::add_dht_router(std::pair<std::string, int> const& node)
|
||||
{
|
||||
|
|
@ -994,9 +994,9 @@ this understanding of our external address, instead of the empty address</h2><h4
|
|||
, local_port, external_port);
|
||||
return;
|
||||
}
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(19)">../src/session_impl.cpp:6230</a></td><td>we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily</td></tr><tr id="19" style="display: none;" colspan="3"><td colspan="3"><h2>we only need to do this if our global IPv4 address has changed
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(19)">../src/session_impl.cpp:6258</a></td><td>we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily</td></tr><tr id="19" style="display: none;" colspan="3"><td colspan="3"><h2>we only need to do this if our global IPv4 address has changed
|
||||
since the DHT (currently) only supports IPv4. Since restarting the DHT
|
||||
is kind of expensive, it would be nice to not do it unnecessarily</h2><h4>../src/session_impl.cpp:6230</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::set_external_address(address const& ip
|
||||
is kind of expensive, it would be nice to not do it unnecessarily</h2><h4>../src/session_impl.cpp:6258</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::set_external_address(address const& ip
|
||||
, int source_type, address const& source)
|
||||
{
|
||||
#if defined TORRENT_VERBOSE_LOGGING
|
||||
|
|
@ -1047,11 +1047,11 @@ is kind of expensive, it would be nice to not do it unnecessarily</h2><h4>../src
|
|||
|
||||
#ifdef TORRENT_DISK_STATS
|
||||
TORRENT_ASSERT(m_buffer_allocations >= 0);
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(20)">../src/torrent.cpp:1168</a></td><td>make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file</td></tr><tr id="20" style="display: none;" colspan="3"><td colspan="3"><h2>make this depend on the error and on the filesystem the
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(20)">../src/torrent.cpp:1169</a></td><td>make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file</td></tr><tr id="20" style="display: none;" colspan="3"><td colspan="3"><h2>make this depend on the error and on the filesystem the
|
||||
files are being downloaded to. If the error is no_space_left_on_device
|
||||
and the filesystem doesn't support sparse files, only zero the priorities
|
||||
of the pieces that are at the tails of all files, leaving everything
|
||||
up to the highest written piece in each file</h2><h4>../src/torrent.cpp:1168</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (c) c->disconnect(errors::no_memory);
|
||||
up to the highest written piece in each file</h2><h4>../src/torrent.cpp:1169</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (c) c->disconnect(errors::no_memory);
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
@ -1102,8 +1102,8 @@ up to the highest written piece in each file</h2><h4>../src/torrent.cpp:1168</h4
|
|||
int size = m_torrent_file->piece_size(r.piece);
|
||||
if (rp->fail)
|
||||
{
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(21)">../src/torrent.cpp:5419</a></td><td>save the send_stats state instead of throwing them away it may pose an issue when downgrading though</td></tr><tr id="21" style="display: none;" colspan="3"><td colspan="3"><h2>save the send_stats state instead of throwing them away
|
||||
it may pose an issue when downgrading though</h2><h4>../src/torrent.cpp:5419</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> ? (1 << k) : 0;
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(21)">../src/torrent.cpp:5422</a></td><td>save the send_stats state instead of throwing them away it may pose an issue when downgrading though</td></tr><tr id="21" style="display: none;" colspan="3"><td colspan="3"><h2>save the send_stats state instead of throwing them away
|
||||
it may pose an issue when downgrading though</h2><h4>../src/torrent.cpp:5422</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> ? (1 << k) : 0;
|
||||
bitmask.append(1, v);
|
||||
TORRENT_ASSERT(bits == 8 || j == num_bitmask_bytes - 1);
|
||||
}
|
||||
|
|
@ -1154,8 +1154,8 @@ it may pose an issue when downgrading though</h2><h4>../src/torrent.cpp:5419</h4
|
|||
|
||||
// write have bitmask
|
||||
// the pieces string has one byte per piece. Each
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(22)">../src/torrent.cpp:6074</a></td><td>ideally, we would disconnect the oldest connection i.e. the one that has waited the longest to connect.</td></tr><tr id="22" style="display: none;" colspan="3"><td colspan="3"><h2>ideally, we would disconnect the oldest connection
|
||||
i.e. the one that has waited the longest to connect.</h2><h4>../src/torrent.cpp:6074</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (m_ses.is_aborted())
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(22)">../src/torrent.cpp:6077</a></td><td>ideally, we would disconnect the oldest connection i.e. the one that has waited the longest to connect.</td></tr><tr id="22" style="display: none;" colspan="3"><td colspan="3"><h2>ideally, we would disconnect the oldest connection
|
||||
i.e. the one that has waited the longest to connect.</h2><h4>../src/torrent.cpp:6077</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (m_ses.is_aborted())
|
||||
{
|
||||
p->disconnect(errors::session_closing);
|
||||
return false;
|
||||
|
|
@ -1206,9 +1206,9 @@ i.e. the one that has waited the longest to connect.</h2><h4>../src/torrent.cpp:
|
|||
{
|
||||
boost::shared_ptr<peer_plugin> pp((*i)->new_connection(p));
|
||||
if (pp) p->add_extension(pp);
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(23)">../src/torrent.cpp:6315</a></td><td>should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though</td></tr><tr id="23" style="display: none;" colspan="3"><td colspan="3"><h2>should disconnect all peers that have the pieces we have
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(23)">../src/torrent.cpp:6318</a></td><td>should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though</td></tr><tr id="23" style="display: none;" colspan="3"><td colspan="3"><h2>should disconnect all peers that have the pieces we have
|
||||
not just seeds. It would be pretty expensive to check all pieces
|
||||
for all peers though</h2><h4>../src/torrent.cpp:6315</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> TORRENT_ASSERT(is_finished());
|
||||
for all peers though</h2><h4>../src/torrent.cpp:6318</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> TORRENT_ASSERT(is_finished());
|
||||
TORRENT_ASSERT(m_state != torrent_status::finished && m_state != torrent_status::seeding);
|
||||
|
||||
set_state(torrent_status::finished);
|
||||
|
|
@ -1412,7 +1412,7 @@ this check can be removed as well</h2><h4>../src/torrent_info.cpp:416</h4><pre s
|
|||
{
|
||||
TORRENT_ASSERT(leafs > 0);
|
||||
return (leafs << 1) - 1;
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(27)">../src/kademlia/node.cpp:699</a></td><td>find_node should write directly to the response entry</td></tr><tr id="27" style="display: none;" colspan="3"><td colspan="3"><h2>find_node should write directly to the response entry</h2><h4>../src/kademlia/node.cpp:699</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
||||
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(27)">../src/kademlia/node.cpp:700</a></td><td>find_node should write directly to the response entry</td></tr><tr id="27" style="display: none;" colspan="3"><td colspan="3"><h2>find_node should write directly to the response entry</h2><h4>../src/kademlia/node.cpp:700</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
||||
TORRENT_LOG(node) << " values: " << reply["values"].list().size();
|
||||
}
|
||||
#endif
|
||||
|
|
@ -1899,7 +1899,7 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|||
size_t arguments_start = url.find('?');
|
||||
if (arguments_start != std::string::npos)
|
||||
url += "&";
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(37)">../src/i2p_stream.cpp:172</a></td><td>move this to proxy_base and use it in all proxies</td></tr><tr id="37" style="display: none;" colspan="3"><td colspan="3"><h2>move this to proxy_base and use it in all proxies</h2><h4>../src/i2p_stream.cpp:172</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(37)">../src/i2p_stream.cpp:181</a></td><td>move this to proxy_base and use it in all proxies</td></tr><tr id="37" style="display: none;" colspan="3"><td colspan="3"><h2>move this to proxy_base and use it in all proxies</h2><h4>../src/i2p_stream.cpp:181</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
||||
m_state = sam_idle;
|
||||
|
||||
std::string name = m_sam_socket->name_lookup();
|
||||
|
|
@ -1940,16 +1940,16 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|||
return;
|
||||
}
|
||||
|
||||
#if defined TORRENT_ASIO_DEBUGGING
|
||||
add_outstanding_async("i2p_stream::connected");
|
||||
#endif
|
||||
m_sock.async_connect(i->endpoint(), boost::bind(
|
||||
&i2p_stream::connected, this, _1, h));
|
||||
}
|
||||
|
||||
void i2p_stream::connected(error_code const& e, boost::shared_ptr<handler_type> h)
|
||||
{
|
||||
if (handle_error(e, h)) return;
|
||||
|
||||
// send hello command
|
||||
m_state = read_hello_response;
|
||||
#if defined TORRENT_ASIO_DEBUGGING
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(38)">../src/packet_buffer.cpp:176</a></td><td>use compare_less_wrap for this comparison as well</td></tr><tr id="38" style="display: none;" colspan="3"><td colspan="3"><h2>use compare_less_wrap for this comparison as well</h2><h4>../src/packet_buffer.cpp:176</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> while (new_size < size)
|
||||
new_size <<= 1;
|
||||
|
||||
|
|
@ -2105,7 +2105,7 @@ we can construct a full bitfield</h2><h4>../src/peer_connection.cpp:2731</h4><pr
|
|||
TORRENT_ASSERT(t->has_picker());
|
||||
TORRENT_ASSERT(t->picker().is_requested(block));
|
||||
#endif
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(41)">../src/peer_connection.cpp:3985</a></td><td>we should probably just send a HAVE_ALL here</td></tr><tr id="41" style="display: none;" colspan="3"><td colspan="3"><h2>we should probably just send a HAVE_ALL here</h2><h4>../src/peer_connection.cpp:3985</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> std::fill(m_recv_buffer.begin() + m_recv_pos, m_recv_buffer.end(), 0);
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(41)">../src/peer_connection.cpp:3986</a></td><td>we should probably just send a HAVE_ALL here</td></tr><tr id="41" style="display: none;" colspan="3"><td colspan="3"><h2>we should probably just send a HAVE_ALL here</h2><h4>../src/peer_connection.cpp:3986</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> std::fill(m_recv_buffer.begin() + m_recv_pos, m_recv_buffer.end(), 0);
|
||||
#endif
|
||||
|
||||
m_packet_size = packet_size;
|
||||
|
|
@ -2156,8 +2156,8 @@ we can construct a full bitfield</h2><h4>../src/peer_connection.cpp:2731</h4><pr
|
|||
}
|
||||
|
||||
void peer_connection::update_desired_queue_size()
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(42)">../src/peer_connection.cpp:4572</a></td><td>peers should really be corked/uncorked outside of all completed disk operations</td></tr><tr id="42" style="display: none;" colspan="3"><td colspan="3"><h2>peers should really be corked/uncorked outside of
|
||||
all completed disk operations</h2><h4>../src/peer_connection.cpp:4572</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // this means we're in seed mode and we haven't yet
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(42)">../src/peer_connection.cpp:4576</a></td><td>peers should really be corked/uncorked outside of all completed disk operations</td></tr><tr id="42" style="display: none;" colspan="3"><td colspan="3"><h2>peers should really be corked/uncorked outside of
|
||||
all completed disk operations</h2><h4>../src/peer_connection.cpp:4576</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // this means we're in seed mode and we haven't yet
|
||||
// verified this piece (r.piece)
|
||||
t->filesystem().async_read_and_hash(r, boost::bind(&peer_connection::on_disk_read_complete
|
||||
, self(), _1, _2, r), cache.second);
|
||||
|
|
@ -2260,7 +2260,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|||
{
|
||||
iter = std::lower_bound(
|
||||
m_peers.begin(), m_peers.end()
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(44)">../src/policy.cpp:1895</a></td><td>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</td></tr><tr id="44" style="display: none;" colspan="3"><td colspan="3"><h2>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</h2><h4>../src/policy.cpp:1895</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#endif
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(44)">../src/policy.cpp:1897</a></td><td>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</td></tr><tr id="44" style="display: none;" colspan="3"><td colspan="3"><h2>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</h2><h4>../src/policy.cpp:1897</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#endif
|
||||
, on_parole(false)
|
||||
, banned(false)
|
||||
#ifndef TORRENT_DISABLE_DHT
|
||||
|
|
@ -2311,7 +2311,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|||
{
|
||||
return size_type(prev_amount_upload) << 10;
|
||||
}
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(45)">../src/session_impl.cpp:1905</a></td><td>recalculate all connect candidates for all torrents</td></tr><tr id="45" style="display: none;" colspan="3"><td colspan="3"><h2>recalculate all connect candidates for all torrents</h2><h4>../src/session_impl.cpp:1905</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> m_upload_rate.close();
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(45)">../src/session_impl.cpp:1913</a></td><td>recalculate all connect candidates for all torrents</td></tr><tr id="45" style="display: none;" colspan="3"><td colspan="3"><h2>recalculate all connect candidates for all torrents</h2><h4>../src/session_impl.cpp:1913</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> m_upload_rate.close();
|
||||
|
||||
// #error closing the udp socket here means that
|
||||
// the uTP connections cannot be closed gracefully
|
||||
|
|
@ -2362,7 +2362,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|||
void session_impl::set_settings(session_settings const& s)
|
||||
{
|
||||
INVARIANT_CHECK;
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(46)">../src/session_impl.cpp:3265</a></td><td>have a separate list for these connections, instead of having to loop through all of them</td></tr><tr id="46" style="display: none;" colspan="3"><td colspan="3"><h2>have a separate list for these connections, instead of having to loop through all of them</h2><h4>../src/session_impl.cpp:3265</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // --------------------------------------------------------------
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(46)">../src/session_impl.cpp:3293</a></td><td>have a separate list for these connections, instead of having to loop through all of them</td></tr><tr id="46" style="display: none;" colspan="3"><td colspan="3"><h2>have a separate list for these connections, instead of having to loop through all of them</h2><h4>../src/session_impl.cpp:3293</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // --------------------------------------------------------------
|
||||
if (!m_paused) m_auto_manage_time_scaler--;
|
||||
if (m_auto_manage_time_scaler < 0)
|
||||
{
|
||||
|
|
@ -2413,7 +2413,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|||
TORRENT_ASSERT(!t.is_aborted());
|
||||
if (t.statistics().upload_rate() * 11 / 10 > t.upload_limit())
|
||||
++congested_torrents;
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(47)">../src/session_impl.cpp:4325</a></td><td>allow extensions to sort torrents for queuing</td></tr><tr id="47" style="display: none;" colspan="3"><td colspan="3"><h2>allow extensions to sort torrents for queuing</h2><h4>../src/session_impl.cpp:4325</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> else if (!t->is_paused())
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(47)">../src/session_impl.cpp:4353</a></td><td>allow extensions to sort torrents for queuing</td></tr><tr id="47" style="display: none;" colspan="3"><td colspan="3"><h2>allow extensions to sort torrents for queuing</h2><h4>../src/session_impl.cpp:4353</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> else if (!t->is_paused())
|
||||
{
|
||||
TORRENT_ASSERT(t->m_resume_data_loaded || !t->valid_metadata());
|
||||
--hard_limit;
|
||||
|
|
@ -2464,9 +2464,9 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|||
void session_impl::recalculate_optimistic_unchoke_slots()
|
||||
{
|
||||
TORRENT_ASSERT(is_network_thread());
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(48)">../src/session_impl.cpp:4481</a></td><td>use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections</td></tr><tr id="48" style="display: none;" colspan="3"><td colspan="3"><h2>use a lower limit than m_settings.connections_limit
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(48)">../src/session_impl.cpp:4509</a></td><td>use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections</td></tr><tr id="48" style="display: none;" colspan="3"><td colspan="3"><h2>use a lower limit than m_settings.connections_limit
|
||||
to allocate the to 10% or so of connection slots for incoming
|
||||
connections</h2><h4>../src/session_impl.cpp:4481</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
||||
connections</h2><h4>../src/session_impl.cpp:4509</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
||||
if (m_boost_connections > max_connections)
|
||||
{
|
||||
m_boost_connections -= max_connections;
|
||||
|
|
@ -2517,7 +2517,7 @@ connections</h2><h4>../src/session_impl.cpp:4481</h4><pre style="background: #f6
|
|||
int num_attempts = 1;
|
||||
if (!t.is_finished())
|
||||
{
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(49)">../src/session_impl.cpp:4515</a></td><td>make this bias configurable</td></tr><tr id="49" style="display: none;" colspan="3"><td colspan="3"><h2>make this bias configurable</h2><h4>../src/session_impl.cpp:4515</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"></pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(50)">../src/session_impl.cpp:4516</a></td><td>also take average_peers into account, to create a bias for downloading torrents with < average peers</td></tr><tr id="50" style="display: none;" colspan="3"><td colspan="3"><h2>also take average_peers into account, to create a bias for downloading torrents with < average peers</h2><h4>../src/session_impl.cpp:4516</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> average_peers = num_downloads_peers / num_downloads;
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(49)">../src/session_impl.cpp:4543</a></td><td>make this bias configurable</td></tr><tr id="49" style="display: none;" colspan="3"><td colspan="3"><h2>make this bias configurable</h2><h4>../src/session_impl.cpp:4543</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"></pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(50)">../src/session_impl.cpp:4544</a></td><td>also take average_peers into account, to create a bias for downloading torrents with < average peers</td></tr><tr id="50" style="display: none;" colspan="3"><td colspan="3"><h2>also take average_peers into account, to create a bias for downloading torrents with < average peers</h2><h4>../src/session_impl.cpp:4544</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> average_peers = num_downloads_peers / num_downloads;
|
||||
|
||||
if (m_next_connect_torrent == m_torrents.end())
|
||||
m_next_connect_torrent = m_torrents.begin();
|
||||
|
|
@ -2568,7 +2568,7 @@ connections</h2><h4>../src/session_impl.cpp:4481</h4><pre style="background: #f6
|
|||
if (max_connections == 0) return;
|
||||
if (num_connections() >= m_settings.connections_limit) return;
|
||||
}
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(51)">../src/session_impl.cpp:4660</a></td><td>make configurable</td></tr><tr id="51" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4660</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(51)">../src/session_impl.cpp:4688</a></td><td>make configurable</td></tr><tr id="51" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4688</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
||||
#ifdef TORRENT_DEBUG
|
||||
for (std::vector<peer_connection*>::const_iterator i = peers.begin()
|
||||
, end(peers.end()), prev(peers.end()); i != end; ++i)
|
||||
|
|
@ -2601,7 +2601,7 @@ connections</h2><h4>../src/session_impl.cpp:4481</h4><pre style="background: #f6
|
|||
|
||||
++m_allowed_upload_slots;
|
||||
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(52)">../src/session_impl.cpp:4674</a></td><td>make configurable</td></tr><tr id="52" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4674</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> >= (*i)->uploaded_in_last_round() * 1000
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(52)">../src/session_impl.cpp:4702</a></td><td>make configurable</td></tr><tr id="52" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4702</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> >= (*i)->uploaded_in_last_round() * 1000
|
||||
* (1 + t2->priority()) / total_milliseconds(unchoke_interval));
|
||||
}
|
||||
prev = i;
|
||||
|
|
@ -2860,12 +2860,12 @@ if file_base is used. This is not a widely used feature though</h2><h4>../src/st
|
|||
// makes unaligned requests (and the disk cache is disabled or fully utilized
|
||||
// for write cache).
|
||||
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(57)">../src/torrent.cpp:1367</a></td><td>is verify_peer_cert called once per certificate in the chain, and this function just tells us which depth we're at right now? If so, the comment makes sense. any certificate that isn't the leaf (i.e. the one presented by the peer) should be accepted automatically, given preverified is true. The leaf certificate need to be verified to make sure its DN matches the info-hash</td></tr><tr id="57" style="display: none;" colspan="3"><td colspan="3"><h2>is verify_peer_cert called once per certificate in the chain, and
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(57)">../src/torrent.cpp:1370</a></td><td>is verify_peer_cert called once per certificate in the chain, and this function just tells us which depth we're at right now? If so, the comment makes sense. any certificate that isn't the leaf (i.e. the one presented by the peer) should be accepted automatically, given preverified is true. The leaf certificate need to be verified to make sure its DN matches the info-hash</td></tr><tr id="57" style="display: none;" colspan="3"><td colspan="3"><h2>is verify_peer_cert called once per certificate in the chain, and
|
||||
this function just tells us which depth we're at right now? If so, the comment
|
||||
makes sense.
|
||||
any certificate that isn't the leaf (i.e. the one presented by the peer)
|
||||
should be accepted automatically, given preverified is true. The leaf certificate
|
||||
need to be verified to make sure its DN matches the info-hash</h2><h4>../src/torrent.cpp:1367</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (pp) p->add_extension(pp);
|
||||
need to be verified to make sure its DN matches the info-hash</h2><h4>../src/torrent.cpp:1370</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (pp) p->add_extension(pp);
|
||||
}
|
||||
|
||||
// if files are checked for this torrent, call the extension
|
||||
|
|
@ -2916,12 +2916,12 @@ need to be verified to make sure its DN matches the info-hash</h2><h4>../src/tor
|
|||
{
|
||||
#if defined(TORRENT_VERBOSE_LOGGING) || defined(TORRENT_LOGGING)
|
||||
match = true;
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(58)">../src/torrent.cpp:5152</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync</td></tr><tr id="58" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(58)">../src/torrent.cpp:5155</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync</td></tr><tr id="58" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
||||
renamed, but also if they have been merged into a single file for instance
|
||||
maybe use the same format as .torrent files and reuse some code from torrent_info
|
||||
The mapped_files needs to be read both in the network thread
|
||||
and in the disk thread, since they both have their own mapped files structures
|
||||
which are kept in sync</h2><h4>../src/torrent.cpp:5152</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (m_seed_mode) m_verified.resize(m_torrent_file->num_pieces(), false);
|
||||
which are kept in sync</h2><h4>../src/torrent.cpp:5155</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (m_seed_mode) m_verified.resize(m_torrent_file->num_pieces(), false);
|
||||
super_seeding(rd.dict_find_int_value("super_seeding", 0));
|
||||
|
||||
m_last_scrape = rd.dict_find_int_value("last_scrape", 0);
|
||||
|
|
@ -2972,12 +2972,12 @@ which are kept in sync</h2><h4>../src/torrent.cpp:5152</h4><pre style="backgroun
|
|||
{
|
||||
char const* p = piece_priority->string_ptr();
|
||||
for (int i = 0; i < piece_priority->string_length(); ++i)
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(59)">../src/torrent.cpp:5288</a></td><td>if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents</td></tr><tr id="59" style="display: none;" colspan="3"><td colspan="3"><h2>if this is a merkle torrent and we can't
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(59)">../src/torrent.cpp:5291</a></td><td>if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents</td></tr><tr id="59" style="display: none;" colspan="3"><td colspan="3"><h2>if this is a merkle torrent and we can't
|
||||
restore the tree, we need to wipe all the
|
||||
bits in the have array, but not necessarily
|
||||
we might want to do a full check to see if we have
|
||||
all the pieces. This is low priority since almost
|
||||
no one uses merkle torrents</h2><h4>../src/torrent.cpp:5288</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> add_web_seed(url, web_seed_entry::http_seed);
|
||||
no one uses merkle torrents</h2><h4>../src/torrent.cpp:5291</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> add_web_seed(url, web_seed_entry::http_seed);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -3028,9 +3028,9 @@ no one uses merkle torrents</h2><h4>../src/torrent.cpp:5288</h4><pre style="back
|
|||
ret["num_complete"] = m_complete;
|
||||
ret["num_incomplete"] = m_incomplete;
|
||||
ret["num_downloaded"] = m_downloaded;
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(60)">../src/torrent.cpp:5476</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base</td></tr><tr id="60" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(60)">../src/torrent.cpp:5479</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base</td></tr><tr id="60" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
||||
renamed, but also if they have been merged into a single file for instance.
|
||||
using file_base</h2><h4>../src/torrent.cpp:5476</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> entry::string_type& pieces = ret["pieces"].string();
|
||||
using file_base</h2><h4>../src/torrent.cpp:5479</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> entry::string_type& pieces = ret["pieces"].string();
|
||||
pieces.resize(m_torrent_file->num_pieces());
|
||||
if (is_seed())
|
||||
{
|
||||
|
|
@ -3081,10 +3081,10 @@ using file_base</h2><h4>../src/torrent.cpp:5476</h4><pre style="background: #f6f
|
|||
error_code ec;
|
||||
policy::peer const* p = *i;
|
||||
address addr = p->address();
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(61)">../src/torrent.cpp:7985</a></td><td>go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece</td></tr><tr id="61" style="display: none;" colspan="3"><td colspan="3"><h2>go through the pieces we have and count the total number
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(61)">../src/torrent.cpp:8000</a></td><td>go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece</td></tr><tr id="61" style="display: none;" colspan="3"><td colspan="3"><h2>go through the pieces we have and count the total number
|
||||
of downloaders we have. Only count peers that are interested in us
|
||||
since some peers might not send have messages for pieces we have
|
||||
it num_interested == 0, we need to pick a new piece</h2><h4>../src/torrent.cpp:7985</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
||||
it num_interested == 0, we need to pick a new piece</h2><h4>../src/torrent.cpp:8000</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
||||
|
||||
rarest_pieces.clear();
|
||||
rarest_rarity = pp.peer_count;
|
||||
|
|
@ -3291,7 +3291,7 @@ m_sock.bind(endpoint, ec);</h2><h4>../include/libtorrent/proxy_base.hpp:152</h4>
|
|||
m_sock.close(ec);
|
||||
m_resolver.cancel();
|
||||
}
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(65)">../include/libtorrent/torrent_info.hpp:118</a></td><td>include the number of peers received from this tracker, at last announce</td></tr><tr id="65" style="display: none;" colspan="3"><td colspan="3"><h2>include the number of peers received from this tracker, at last announce</h2><h4>../include/libtorrent/torrent_info.hpp:118</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
||||
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(65)">../include/libtorrent/torrent_info.hpp:122</a></td><td>include the number of peers received from this tracker, at last announce</td></tr><tr id="65" style="display: none;" colspan="3"><td colspan="3"><h2>include the number of peers received from this tracker, at last announce</h2><h4>../include/libtorrent/torrent_info.hpp:122</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
||||
// if this tracker failed the last time it was contacted
|
||||
// this error code specifies what error occurred
|
||||
error_code last_error;
|
||||
|
|
|
|||
Loading…
Reference in New Issue