|
|
|
|
@ -21,7 +21,7 @@
|
|
|
|
|
|
|
|
|
|
</head><body>
|
|
|
|
|
<h1>libtorrent todo-list</h1>
|
|
|
|
|
<span style="color: #f77">4 important</span>
|
|
|
|
|
<span style="color: #f77">3 important</span>
|
|
|
|
|
<span style="color: #3c3">5 relevant</span>
|
|
|
|
|
<span style="color: #77f">15 feasible</span>
|
|
|
|
|
<span style="color: #999">36 notes</span>
|
|
|
|
|
@ -184,58 +184,7 @@ when it doesn't have any of the file do the following</h2><h4>../src/web_peer_co
|
|
|
|
|
{
|
|
|
|
|
// we should not try this server again.
|
|
|
|
|
t->remove_web_seed(this);
|
|
|
|
|
</pre></td></tr><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(3)">../src/kademlia/routing_table.cpp:131</a></td><td>cache the depth!</td></tr><tr id="3" style="display: none;" colspan="3"><td colspan="3"><h2>cache the depth!</h2><h4>../src/kademlia/routing_table.cpp:131</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">{
|
|
|
|
|
int deepest_bucket = 0;
|
|
|
|
|
int deepest_size = 0;
|
|
|
|
|
for (table_t::const_iterator i = m_buckets.begin()
|
|
|
|
|
, end(m_buckets.end()); i != end; ++i)
|
|
|
|
|
{
|
|
|
|
|
deepest_size = i->live_nodes.size(); // + i->replacements.size();
|
|
|
|
|
if (deepest_size < m_bucket_size) break;
|
|
|
|
|
// this bucket is full
|
|
|
|
|
++deepest_bucket;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (deepest_bucket == 0) return 1 + deepest_size;
|
|
|
|
|
|
|
|
|
|
if (deepest_size < m_bucket_size / 2) return (size_type(1) << deepest_bucket) * m_bucket_size;
|
|
|
|
|
else return (size_type(2) << deepest_bucket) * deepest_size;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
int routing_table::depth() const
|
|
|
|
|
{
|
|
|
|
|
<div style="background: #ffff00" width="100%"> int deepest_bucket = 0;
|
|
|
|
|
</div> for (table_t::const_iterator i = m_buckets.begin()
|
|
|
|
|
, end(m_buckets.end()); i != end; ++i)
|
|
|
|
|
{
|
|
|
|
|
if (i->live_nodes.size() < m_bucket_size / 2)
|
|
|
|
|
break;
|
|
|
|
|
// this bucket is full
|
|
|
|
|
++deepest_bucket;
|
|
|
|
|
}
|
|
|
|
|
return deepest_bucket;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#if (defined TORRENT_DHT_VERBOSE_LOGGING || defined TORRENT_DEBUG) && TORRENT_USE_IOSTREAM
|
|
|
|
|
|
|
|
|
|
void routing_table::print_state(std::ostream& os) const
|
|
|
|
|
{
|
|
|
|
|
os << "kademlia routing table state\n"
|
|
|
|
|
<< "bucket_size: " << m_bucket_size << "\n"
|
|
|
|
|
<< "global node count: " << num_global_nodes() << "\n"
|
|
|
|
|
<< "node_id: " << m_id << "\n\n";
|
|
|
|
|
|
|
|
|
|
os << "number of nodes per bucket:\n-- live ";
|
|
|
|
|
for (int i = 8; i < 160; ++i)
|
|
|
|
|
os << "-";
|
|
|
|
|
os << "\n";
|
|
|
|
|
|
|
|
|
|
int max_size = bucket_limit(0);
|
|
|
|
|
for (int k = 0; k < max_size; ++k)
|
|
|
|
|
{
|
|
|
|
|
for (table_t::const_iterator i = m_buckets.begin(), end(m_buckets.end());
|
|
|
|
|
i != end; ++i)
|
|
|
|
|
</pre></td></tr><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(4)">../include/libtorrent/kademlia/find_data.hpp:60</a></td><td>rename this class to get_peers, since that's what it does find_data is an unnecessarily generic name</td></tr><tr id="4" style="display: none;" colspan="3"><td colspan="3"><h2>rename this class to get_peers, since that's what it does
|
|
|
|
|
</pre></td></tr><tr style="background: #fcc"><td>relevance 3</td><td><a href="javascript:expand(3)">../include/libtorrent/kademlia/find_data.hpp:60</a></td><td>rename this class to get_peers, since that's what it does find_data is an unnecessarily generic name</td></tr><tr id="3" style="display: none;" colspan="3"><td colspan="3"><h2>rename this class to get_peers, since that's what it does
|
|
|
|
|
find_data is an unnecessarily generic name</h2><h4>../include/libtorrent/kademlia/find_data.hpp:60</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#include <libtorrent/kademlia/node_id.hpp>
|
|
|
|
|
#include <libtorrent/kademlia/routing_table.hpp>
|
|
|
|
|
#include <libtorrent/kademlia/rpc_manager.hpp>
|
|
|
|
|
@ -287,7 +236,7 @@ protected:
|
|
|
|
|
nodes_callback m_nodes_callback;
|
|
|
|
|
std::map<node_id, std::string> m_write_tokens;
|
|
|
|
|
node_id const m_target;
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(5)">../src/torrent.cpp:8369</a></td><td>will pick_pieces ever return an empty set?</td></tr><tr id="5" style="display: none;" colspan="3"><td colspan="3"><h2>will pick_pieces ever return an empty set?</h2><h4>../src/torrent.cpp:8369</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (added_request)
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(4)">../src/torrent.cpp:8369</a></td><td>will pick_pieces ever return an empty set?</td></tr><tr id="4" style="display: none;" colspan="3"><td colspan="3"><h2>will pick_pieces ever return an empty set?</h2><h4>../src/torrent.cpp:8369</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (added_request)
|
|
|
|
|
{
|
|
|
|
|
peers_with_requests.insert(peers_with_requests.begin(), &c);
|
|
|
|
|
if (i->first_requested == min_time()) i->first_requested = now;
|
|
|
|
|
@ -338,7 +287,7 @@ protected:
|
|
|
|
|
void torrent::remove_web_seed(std::string const& url, web_seed_entry::type_t type)
|
|
|
|
|
{
|
|
|
|
|
std::list<web_seed_entry>::iterator i = std::find_if(m_web_seeds.begin(), m_web_seeds.end()
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(6)">../src/utp_stream.cpp:1862</a></td><td>we might want to do something else here as well, to resend the packet immediately without it being an MTU probe</td></tr><tr id="6" style="display: none;" colspan="3"><td colspan="3"><h2>we might want to do something else here
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(5)">../src/utp_stream.cpp:1862</a></td><td>we might want to do something else here as well, to resend the packet immediately without it being an MTU probe</td></tr><tr id="5" style="display: none;" colspan="3"><td colspan="3"><h2>we might want to do something else here
|
|
|
|
|
as well, to resend the packet immediately without
|
|
|
|
|
it being an MTU probe</h2><h4>../src/utp_stream.cpp:1862</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">// if ((rand() % 100) > 0)
|
|
|
|
|
#endif
|
|
|
|
|
@ -391,7 +340,7 @@ it being an MTU probe</h2><h4>../src/utp_stream.cpp:1862</h4><pre style="backgro
|
|
|
|
|
m_state = UTP_STATE_ERROR_WAIT;
|
|
|
|
|
test_socket_state();
|
|
|
|
|
return false;
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(7)">../src/utp_stream.cpp:2505</a></td><td>sequence number, source IP and connection ID should be verified before accepting a reset packet</td></tr><tr id="7" style="display: none;" colspan="3"><td colspan="3"><h2>sequence number, source IP and connection ID should be
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(6)">../src/utp_stream.cpp:2505</a></td><td>sequence number, source IP and connection ID should be verified before accepting a reset packet</td></tr><tr id="6" style="display: none;" colspan="3"><td colspan="3"><h2>sequence number, source IP and connection ID should be
|
|
|
|
|
verified before accepting a reset packet</h2><h4>../src/utp_stream.cpp:2505</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> m_reply_micro = boost::uint32_t(total_microseconds(receive_time - min_time()))
|
|
|
|
|
- ph->timestamp_microseconds;
|
|
|
|
|
boost::uint32_t prev_base = m_their_delay_hist.initialized() ? m_their_delay_hist.base() : 0;
|
|
|
|
|
@ -443,7 +392,7 @@ verified before accepting a reset packet</h2><h4>../src/utp_stream.cpp:2505</h4>
|
|
|
|
|
, this, int(ph->ack_nr), m_seq_nr);
|
|
|
|
|
m_sm->inc_stats_counter(utp_socket_manager::redundant_pkts_in);
|
|
|
|
|
return true;
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(8)">../src/web_peer_connection.cpp:546</a></td><td>create a mapping of file-index to redirection URLs. Use that to form URLs instead. Support to reconnect to a new server without destructing this peer_connection</td></tr><tr id="8" style="display: none;" colspan="3"><td colspan="3"><h2>create a mapping of file-index to redirection URLs. Use that to form URLs instead. Support to reconnect to a new server without destructing this peer_connection</h2><h4>../src/web_peer_connection.cpp:546</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> t->remove_web_seed(this);
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(7)">../src/web_peer_connection.cpp:546</a></td><td>create a mapping of file-index to redirection URLs. Use that to form URLs instead. Support to reconnect to a new server without destructing this peer_connection</td></tr><tr id="7" style="display: none;" colspan="3"><td colspan="3"><h2>create a mapping of file-index to redirection URLs. Use that to form URLs instead. Support to reconnect to a new server without destructing this peer_connection</h2><h4>../src/web_peer_connection.cpp:546</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> t->remove_web_seed(this);
|
|
|
|
|
disconnect(errors::missing_location, 2);
|
|
|
|
|
#ifdef TORRENT_DEBUG
|
|
|
|
|
TORRENT_ASSERT(m_statistics.last_payload_downloaded()
|
|
|
|
|
@ -494,7 +443,7 @@ verified before accepting a reset packet</h2><h4>../src/utp_stream.cpp:2505</h4>
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(9)">../src/kademlia/node.cpp:69</a></td><td>make this configurable in dht_settings</td></tr><tr id="9" style="display: none;" colspan="3"><td colspan="3"><h2>make this configurable in dht_settings</h2><h4>../src/kademlia/node.cpp:69</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#include "libtorrent/kademlia/routing_table.hpp"
|
|
|
|
|
</pre></td></tr><tr style="background: #cfc"><td>relevance 2</td><td><a href="javascript:expand(8)">../src/kademlia/node.cpp:69</a></td><td>make this configurable in dht_settings</td></tr><tr id="8" style="display: none;" colspan="3"><td colspan="3"><h2>make this configurable in dht_settings</h2><h4>../src/kademlia/node.cpp:69</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#include "libtorrent/kademlia/routing_table.hpp"
|
|
|
|
|
#include "libtorrent/kademlia/node.hpp"
|
|
|
|
|
#include <libtorrent/kademlia/dht_observer.hpp>
|
|
|
|
|
|
|
|
|
|
@ -545,7 +494,7 @@ void purge_peers(std::set<peer_entry>& peers)
|
|
|
|
|
|
|
|
|
|
void nop() {}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(10)">../src/http_seed_connection.cpp:117</a></td><td>in chunked encoding mode, this assert won't hold. the chunk headers should be subtracted from the receive_buffer_size</td></tr><tr id="10" style="display: none;" colspan="3"><td colspan="3"><h2>in chunked encoding mode, this assert won't hold.
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(9)">../src/http_seed_connection.cpp:117</a></td><td>in chunked encoding mode, this assert won't hold. the chunk headers should be subtracted from the receive_buffer_size</td></tr><tr id="9" style="display: none;" colspan="3"><td colspan="3"><h2>in chunked encoding mode, this assert won't hold.
|
|
|
|
|
the chunk headers should be subtracted from the receive_buffer_size</h2><h4>../src/http_seed_connection.cpp:117</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> boost::optional<piece_block_progress>
|
|
|
|
|
http_seed_connection::downloading_piece_progress() const
|
|
|
|
|
{
|
|
|
|
|
@ -597,7 +546,7 @@ the chunk headers should be subtracted from the receive_buffer_size</h2><h4>../s
|
|
|
|
|
std::string request;
|
|
|
|
|
request.reserve(400);
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(11)">../src/peer_connection.cpp:2570</a></td><td>peers should really be corked/uncorked outside of all completed disk operations</td></tr><tr id="11" style="display: none;" colspan="3"><td colspan="3"><h2>peers should really be corked/uncorked outside of
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(10)">../src/peer_connection.cpp:2570</a></td><td>peers should really be corked/uncorked outside of all completed disk operations</td></tr><tr id="10" style="display: none;" colspan="3"><td colspan="3"><h2>peers should really be corked/uncorked outside of
|
|
|
|
|
all completed disk operations</h2><h4>../src/peer_connection.cpp:2570</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
|
|
|
|
|
|
|
|
|
if (is_disconnecting()) return;
|
|
|
|
|
@ -649,8 +598,8 @@ all completed disk operations</h2><h4>../src/peer_connection.cpp:2570</h4><pre s
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(12)">../src/session_impl.cpp:5720</a></td><td>report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address</td></tr><tr id="12" style="display: none;" colspan="3"><td colspan="3"><h2>report the proper address of the router as the source IP of
|
|
|
|
|
this understanding of our external address, instead of the empty address</h2><h4>../src/session_impl.cpp:5720</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::on_port_mapping(int mapping, address const& ip, int port
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(11)">../src/session_impl.cpp:5717</a></td><td>report the proper address of the router as the source IP of this understanding of our external address, instead of the empty address</td></tr><tr id="11" style="display: none;" colspan="3"><td colspan="3"><h2>report the proper address of the router as the source IP of
|
|
|
|
|
this understanding of our external address, instead of the empty address</h2><h4>../src/session_impl.cpp:5717</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::on_port_mapping(int mapping, address const& ip, int port
|
|
|
|
|
, error_code const& ec, int map_transport)
|
|
|
|
|
{
|
|
|
|
|
TORRENT_ASSERT(is_network_thread());
|
|
|
|
|
@ -701,7 +650,7 @@ this understanding of our external address, instead of the empty address</h2><h4
|
|
|
|
|
{
|
|
|
|
|
// INVARIANT_CHECK;
|
|
|
|
|
TORRENT_ASSERT(is_network_thread());
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(13)">../src/session_impl.cpp:5930</a></td><td>report errors as alerts</td></tr><tr id="13" style="display: none;" colspan="3"><td colspan="3"><h2>report errors as alerts</h2><h4>../src/session_impl.cpp:5930</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(12)">../src/session_impl.cpp:5927</a></td><td>report errors as alerts</td></tr><tr id="12" style="display: none;" colspan="3"><td colspan="3"><h2>report errors as alerts</h2><h4>../src/session_impl.cpp:5927</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
|
|
|
|
|
|
|
|
|
void session_impl::add_dht_router(std::pair<std::string, int> const& node)
|
|
|
|
|
{
|
|
|
|
|
@ -752,9 +701,9 @@ this understanding of our external address, instead of the empty address</h2><h4
|
|
|
|
|
, local_port, external_port);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(14)">../src/session_impl.cpp:6401</a></td><td>we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily</td></tr><tr id="14" style="display: none;" colspan="3"><td colspan="3"><h2>we only need to do this if our global IPv4 address has changed
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(13)">../src/session_impl.cpp:6398</a></td><td>we only need to do this if our global IPv4 address has changed since the DHT (currently) only supports IPv4. Since restarting the DHT is kind of expensive, it would be nice to not do it unnecessarily</td></tr><tr id="13" style="display: none;" colspan="3"><td colspan="3"><h2>we only need to do this if our global IPv4 address has changed
|
|
|
|
|
since the DHT (currently) only supports IPv4. Since restarting the DHT
|
|
|
|
|
is kind of expensive, it would be nice to not do it unnecessarily</h2><h4>../src/session_impl.cpp:6401</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::set_external_address(address const& ip
|
|
|
|
|
is kind of expensive, it would be nice to not do it unnecessarily</h2><h4>../src/session_impl.cpp:6398</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> void session_impl::set_external_address(address const& ip
|
|
|
|
|
, int source_type, address const& source)
|
|
|
|
|
{
|
|
|
|
|
#if defined TORRENT_VERBOSE_LOGGING
|
|
|
|
|
@ -805,7 +754,7 @@ is kind of expensive, it would be nice to not do it unnecessarily</h2><h4>../src
|
|
|
|
|
|
|
|
|
|
#ifdef TORRENT_DISK_STATS
|
|
|
|
|
TORRENT_ASSERT(m_buffer_allocations >= 0);
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(15)">../src/torrent.cpp:1158</a></td><td>make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file</td></tr><tr id="15" style="display: none;" colspan="3"><td colspan="3"><h2>make this depend on the error and on the filesystem the
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(14)">../src/torrent.cpp:1158</a></td><td>make this depend on the error and on the filesystem the files are being downloaded to. If the error is no_space_left_on_device and the filesystem doesn't support sparse files, only zero the priorities of the pieces that are at the tails of all files, leaving everything up to the highest written piece in each file</td></tr><tr id="14" style="display: none;" colspan="3"><td colspan="3"><h2>make this depend on the error and on the filesystem the
|
|
|
|
|
files are being downloaded to. If the error is no_space_left_on_device
|
|
|
|
|
and the filesystem doesn't support sparse files, only zero the priorities
|
|
|
|
|
of the pieces that are at the tails of all files, leaving everything
|
|
|
|
|
@ -860,7 +809,7 @@ up to the highest written piece in each file</h2><h4>../src/torrent.cpp:1158</h4
|
|
|
|
|
int size = m_torrent_file->piece_size(r.piece);
|
|
|
|
|
if (rp->fail)
|
|
|
|
|
{
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(16)">../src/torrent.cpp:5444</a></td><td>save the send_stats state instead of throwing them away it may pose an issue when downgrading though</td></tr><tr id="16" style="display: none;" colspan="3"><td colspan="3"><h2>save the send_stats state instead of throwing them away
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(15)">../src/torrent.cpp:5444</a></td><td>save the send_stats state instead of throwing them away it may pose an issue when downgrading though</td></tr><tr id="15" style="display: none;" colspan="3"><td colspan="3"><h2>save the send_stats state instead of throwing them away
|
|
|
|
|
it may pose an issue when downgrading though</h2><h4>../src/torrent.cpp:5444</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> ? (1 << k) : 0;
|
|
|
|
|
bitmask.append(1, v);
|
|
|
|
|
TORRENT_ASSERT(bits == 8 || j == num_bitmask_bytes - 1);
|
|
|
|
|
@ -912,7 +861,7 @@ it may pose an issue when downgrading though</h2><h4>../src/torrent.cpp:5444</h4
|
|
|
|
|
|
|
|
|
|
// write have bitmask
|
|
|
|
|
// the pieces string has one byte per piece. Each
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(17)">../src/torrent.cpp:6350</a></td><td>should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though</td></tr><tr id="17" style="display: none;" colspan="3"><td colspan="3"><h2>should disconnect all peers that have the pieces we have
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(16)">../src/torrent.cpp:6350</a></td><td>should disconnect all peers that have the pieces we have not just seeds. It would be pretty expensive to check all pieces for all peers though</td></tr><tr id="16" style="display: none;" colspan="3"><td colspan="3"><h2>should disconnect all peers that have the pieces we have
|
|
|
|
|
not just seeds. It would be pretty expensive to check all pieces
|
|
|
|
|
for all peers though</h2><h4>../src/torrent.cpp:6350</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> TORRENT_ASSERT(m_state != torrent_status::finished && m_state != torrent_status::seeding);
|
|
|
|
|
|
|
|
|
|
@ -965,7 +914,7 @@ for all peers though</h2><h4>../src/torrent.cpp:6350</h4><pre style="background:
|
|
|
|
|
// under a different limit with the auto-manager. Make sure we
|
|
|
|
|
// update auto-manage torrents in that case
|
|
|
|
|
if (m_auto_managed)
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(18)">../src/torrent_info.cpp:181</a></td><td>we might save constructing a std::string if this would take a char const* instead</td></tr><tr id="18" style="display: none;" colspan="3"><td colspan="3"><h2>we might save constructing a std::string if this would take a char const* instead</h2><h4>../src/torrent_info.cpp:181</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(17)">../src/torrent_info.cpp:181</a></td><td>we might save constructing a std::string if this would take a char const* instead</td></tr><tr id="17" style="display: none;" colspan="3"><td colspan="3"><h2>we might save constructing a std::string if this would take a char const* instead</h2><h4>../src/torrent_info.cpp:181</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
tmp_path += i[0];
|
|
|
|
|
tmp_path += i[1];
|
|
|
|
|
tmp_path += i[2];
|
|
|
|
|
@ -1016,7 +965,7 @@ for all peers though</h2><h4>../src/torrent.cpp:6350</h4><pre style="background:
|
|
|
|
|
path_element.resize(max_path_len);
|
|
|
|
|
}
|
|
|
|
|
else
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(19)">../src/torrent_info.cpp:387</a></td><td>this logic should be a separate step done once the torrent is loaded, and the original filenames should be preserved!</td></tr><tr id="19" style="display: none;" colspan="3"><td colspan="3"><h2>this logic should be a separate step
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(18)">../src/torrent_info.cpp:387</a></td><td>this logic should be a separate step done once the torrent is loaded, and the original filenames should be preserved!</td></tr><tr id="18" style="display: none;" colspan="3"><td colspan="3"><h2>this logic should be a separate step
|
|
|
|
|
done once the torrent is loaded, and the original
|
|
|
|
|
filenames should be preserved!</h2><h4>../src/torrent_info.cpp:387</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
while (*s1 != 0 || *s2 != 0)
|
|
|
|
|
@ -1053,33 +1002,36 @@ filenames should be preserved!</h2><h4>../src/torrent_info.cpp:387</h4><pre styl
|
|
|
|
|
// as long as this file already exists
|
|
|
|
|
// increase the counter
|
|
|
|
|
int cnt = 0;
|
|
|
|
|
while (!files.insert(e.path).second)
|
|
|
|
|
if (!files.insert(e.path).second)
|
|
|
|
|
{
|
|
|
|
|
++cnt;
|
|
|
|
|
char suffix[50];
|
|
|
|
|
snprintf(suffix, sizeof(suffix), "%d%s", cnt, extension(e.path).c_str());
|
|
|
|
|
replace_extension(e.path, suffix);
|
|
|
|
|
std::string base = remove_extension(e.path);
|
|
|
|
|
std::string ext = extension(e.path);
|
|
|
|
|
do
|
|
|
|
|
{
|
|
|
|
|
++cnt;
|
|
|
|
|
char new_ext[50];
|
|
|
|
|
snprintf(new_ext, sizeof(new_ext), ".%d%s", cnt, ext.c_str());
|
|
|
|
|
e.path = base + new_ext;
|
|
|
|
|
} while (!files.insert(e.path).second);
|
|
|
|
|
}
|
|
|
|
|
target.add_file(e, file_hash ? file_hash->string_ptr() + info_ptr_diff : 0);
|
|
|
|
|
|
|
|
|
|
// This is a memory optimization! Instead of having
|
|
|
|
|
// each entry keep a string for its filename, make it
|
|
|
|
|
// simply point into the info-section buffer
|
|
|
|
|
int last_index = target.num_files() - 1;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(20)">../src/torrent_info.cpp:418</a></td><td>once the filename renaming is removed from here this check can be removed as well</td></tr><tr id="20" style="display: none;" colspan="3"><td colspan="3"><h2>once the filename renaming is removed from here
|
|
|
|
|
this check can be removed as well</h2><h4>../src/torrent_info.cpp:418</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (!extract_single_file(*list.list_at(i), e, root_dir
|
|
|
|
|
, &file_hash, &fee, &mtime))
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
// as long as this file already exists
|
|
|
|
|
// increase the counter
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(19)">../src/torrent_info.cpp:423</a></td><td>once the filename renaming is removed from here this check can be removed as well</td></tr><tr id="19" style="display: none;" colspan="3"><td colspan="3"><h2>once the filename renaming is removed from here
|
|
|
|
|
this check can be removed as well</h2><h4>../src/torrent_info.cpp:423</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // increase the counter
|
|
|
|
|
int cnt = 0;
|
|
|
|
|
while (!files.insert(e.path).second)
|
|
|
|
|
if (!files.insert(e.path).second)
|
|
|
|
|
{
|
|
|
|
|
++cnt;
|
|
|
|
|
char suffix[50];
|
|
|
|
|
snprintf(suffix, sizeof(suffix), "%d%s", cnt, extension(e.path).c_str());
|
|
|
|
|
replace_extension(e.path, suffix);
|
|
|
|
|
std::string base = remove_extension(e.path);
|
|
|
|
|
std::string ext = extension(e.path);
|
|
|
|
|
do
|
|
|
|
|
{
|
|
|
|
|
++cnt;
|
|
|
|
|
char new_ext[50];
|
|
|
|
|
snprintf(new_ext, sizeof(new_ext), ".%d%s", cnt, ext.c_str());
|
|
|
|
|
e.path = base + new_ext;
|
|
|
|
|
} while (!files.insert(e.path).second);
|
|
|
|
|
}
|
|
|
|
|
target.add_file(e, file_hash ? file_hash->string_ptr() + info_ptr_diff : 0);
|
|
|
|
|
|
|
|
|
|
@ -1118,7 +1070,7 @@ this check can be removed as well</h2><h4>../src/torrent_info.cpp:418</h4><pre s
|
|
|
|
|
{
|
|
|
|
|
TORRENT_ASSERT(leafs > 0);
|
|
|
|
|
return (leafs << 1) - 1;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(21)">../src/kademlia/node.cpp:772</a></td><td>find_node should write directly to the response entry</td></tr><tr id="21" style="display: none;" colspan="3"><td colspan="3"><h2>find_node should write directly to the response entry</h2><h4>../src/kademlia/node.cpp:772</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(20)">../src/kademlia/node.cpp:772</a></td><td>find_node should write directly to the response entry</td></tr><tr id="20" style="display: none;" colspan="3"><td colspan="3"><h2>find_node should write directly to the response entry</h2><h4>../src/kademlia/node.cpp:772</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
TORRENT_LOG(node) << " values: " << reply["values"].list().size();
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
@ -1169,7 +1121,7 @@ this check can be removed as well</h2><h4>../src/torrent_info.cpp:418</h4><pre s
|
|
|
|
|
// listen port and instead use the source port of the packet?
|
|
|
|
|
if (msg_keys[5] && msg_keys[5]->int_value() != 0)
|
|
|
|
|
port = m.addr.port();
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(22)">../include/libtorrent/ip_voter.hpp:100</a></td><td>instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.</td></tr><tr id="22" style="display: none;" colspan="3"><td colspan="3"><h2>instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.</h2><h4>../include/libtorrent/ip_voter.hpp:100</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> bloom_filter<32> m_external_address_voters;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(21)">../include/libtorrent/ip_voter.hpp:100</a></td><td>instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.</td></tr><tr id="21" style="display: none;" colspan="3"><td colspan="3"><h2>instead, have one instance per possible subnet, global IPv4, global IPv6, loopback, 192.168.x.x, 10.x.x.x, etc.</h2><h4>../include/libtorrent/ip_voter.hpp:100</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> bloom_filter<32> m_external_address_voters;
|
|
|
|
|
std::vector<external_ip_t> m_external_addresses;
|
|
|
|
|
address m_external_address;
|
|
|
|
|
};
|
|
|
|
|
@ -1196,7 +1148,7 @@ this check can be removed as well</h2><h4>../src/torrent_info.cpp:418</h4><pre s
|
|
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(23)">../include/libtorrent/utp_stream.hpp:376</a></td><td>implement blocking write. Low priority since it's not used (yet)</td></tr><tr id="23" style="display: none;" colspan="3"><td colspan="3"><h2>implement blocking write. Low priority since it's not used (yet)</h2><h4>../include/libtorrent/utp_stream.hpp:376</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> for (typename Mutable_Buffers::const_iterator i = buffers.begin()
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(22)">../include/libtorrent/utp_stream.hpp:377</a></td><td>implement blocking write. Low priority since it's not used (yet)</td></tr><tr id="22" style="display: none;" colspan="3"><td colspan="3"><h2>implement blocking write. Low priority since it's not used (yet)</h2><h4>../include/libtorrent/utp_stream.hpp:377</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> for (typename Mutable_Buffers::const_iterator i = buffers.begin()
|
|
|
|
|
, end(buffers.end()); i != end; ++i)
|
|
|
|
|
{
|
|
|
|
|
using asio::buffer_cast;
|
|
|
|
|
@ -1247,7 +1199,7 @@ this check can be removed as well</h2><h4>../src/torrent_info.cpp:418</h4><pre s
|
|
|
|
|
TORRENT_ASSERT(false);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(24)">../include/libtorrent/web_peer_connection.hpp:126</a></td><td>if we make this be a disk_buffer_holder instead we would save a copy sometimes use allocate_disk_receive_buffer and release_disk_receive_buffer</td></tr><tr id="24" style="display: none;" colspan="3"><td colspan="3"><h2>if we make this be a disk_buffer_holder instead
|
|
|
|
|
</pre></td></tr><tr style="background: #ccf"><td>relevance 1</td><td><a href="javascript:expand(23)">../include/libtorrent/web_peer_connection.hpp:126</a></td><td>if we make this be a disk_buffer_holder instead we would save a copy sometimes use allocate_disk_receive_buffer and release_disk_receive_buffer</td></tr><tr id="23" style="display: none;" colspan="3"><td colspan="3"><h2>if we make this be a disk_buffer_holder instead
|
|
|
|
|
we would save a copy sometimes
|
|
|
|
|
use allocate_disk_receive_buffer and release_disk_receive_buffer</h2><h4>../include/libtorrent/web_peer_connection.hpp:126</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
bool maybe_harvest_block();
|
|
|
|
|
@ -1300,7 +1252,7 @@ use allocate_disk_receive_buffer and release_disk_receive_buffer</h2><h4>../incl
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(25)">../src/bt_peer_connection.cpp:617</a></td><td>this could be optimized using knuth morris pratt</td></tr><tr id="25" style="display: none;" colspan="3"><td colspan="3"><h2>this could be optimized using knuth morris pratt</h2><h4>../src/bt_peer_connection.cpp:617</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(24)">../src/bt_peer_connection.cpp:617</a></td><td>this could be optimized using knuth morris pratt</td></tr><tr id="24" style="display: none;" colspan="3"><td colspan="3"><h2>this could be optimized using knuth morris pratt</h2><h4>../src/bt_peer_connection.cpp:617</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
disconnect(errors::no_memory);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
@ -1351,7 +1303,7 @@ use allocate_disk_receive_buffer and release_disk_receive_buffer</h2><h4>../incl
|
|
|
|
|
// }
|
|
|
|
|
|
|
|
|
|
// no complete sync
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(26)">../src/bt_peer_connection.cpp:2083</a></td><td>if we're finished, send upload_only message</td></tr><tr id="26" style="display: none;" colspan="3"><td colspan="3"><h2>if we're finished, send upload_only message</h2><h4>../src/bt_peer_connection.cpp:2083</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(25)">../src/bt_peer_connection.cpp:2083</a></td><td>if we're finished, send upload_only message</td></tr><tr id="25" style="display: none;" colspan="3"><td colspan="3"><h2>if we're finished, send upload_only message</h2><h4>../src/bt_peer_connection.cpp:2083</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (msg[5 + k / 8] & (0x80 >> (k % 8))) bitfield_string[k] = '1';
|
|
|
|
|
else bitfield_string[k] = '0';
|
|
|
|
|
}
|
|
|
|
|
peer_log("==> BITFIELD [ %s ]", bitfield_string.c_str());
|
|
|
|
|
@ -1402,7 +1354,7 @@ use allocate_disk_receive_buffer and release_disk_receive_buffer</h2><h4>../incl
|
|
|
|
|
std::back_insert_iterator<std::string> out(remote_address);
|
|
|
|
|
detail::write_address(remote().address(), out);
|
|
|
|
|
handshake["yourip"] = remote_address;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(27)">../src/bt_peer_connection.cpp:3325</a></td><td>move the erasing into the loop above remove all payload ranges that has been sent</td></tr><tr id="27" style="display: none;" colspan="3"><td colspan="3"><h2>move the erasing into the loop above
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(26)">../src/bt_peer_connection.cpp:3325</a></td><td>move the erasing into the loop above remove all payload ranges that has been sent</td></tr><tr id="26" style="display: none;" colspan="3"><td colspan="3"><h2>move the erasing into the loop above
|
|
|
|
|
remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.cpp:3325</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> for (std::vector<range>::iterator i = m_payloads.begin();
|
|
|
|
|
i != m_payloads.end(); ++i)
|
|
|
|
|
{
|
|
|
|
|
@ -1454,7 +1406,7 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|
|
|
|
TORRENT_ASSERT(m_sent_handshake);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(28)">../src/file.cpp:1346</a></td><td>is there any way to pre-fetch data from a file on windows?</td></tr><tr id="28" style="display: none;" colspan="3"><td colspan="3"><h2>is there any way to pre-fetch data from a file on windows?</h2><h4>../src/file.cpp:1346</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(27)">../src/file.cpp:1358</a></td><td>is there any way to pre-fetch data from a file on windows?</td></tr><tr id="27" style="display: none;" colspan="3"><td colspan="3"><h2>is there any way to pre-fetch data from a file on windows?</h2><h4>../src/file.cpp:1358</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
void file::init_file()
|
|
|
|
|
{
|
|
|
|
|
if (m_page_size != 0) return;
|
|
|
|
|
@ -1505,7 +1457,7 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|
|
|
|
#ifdef TORRENT_DEBUG
|
|
|
|
|
if (m_open_mode & no_buffer)
|
|
|
|
|
{
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(29)">../src/http_tracker_connection.cpp:99</a></td><td>support authentication (i.e. user name and password) in the URL</td></tr><tr id="29" style="display: none;" colspan="3"><td colspan="3"><h2>support authentication (i.e. user name and password) in the URL</h2><h4>../src/http_tracker_connection.cpp:99</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> , aux::session_impl const& ses
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(28)">../src/http_tracker_connection.cpp:99</a></td><td>support authentication (i.e. user name and password) in the URL</td></tr><tr id="28" style="display: none;" colspan="3"><td colspan="3"><h2>support authentication (i.e. user name and password) in the URL</h2><h4>../src/http_tracker_connection.cpp:99</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> , aux::session_impl const& ses
|
|
|
|
|
, proxy_settings const& ps
|
|
|
|
|
, std::string const& auth
|
|
|
|
|
#if TORRENT_USE_I2P
|
|
|
|
|
@ -1556,7 +1508,7 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|
|
|
|
if (arguments_start != std::string::npos)
|
|
|
|
|
url += "&";
|
|
|
|
|
else
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(30)">../src/i2p_stream.cpp:204</a></td><td>move this to proxy_base and use it in all proxies</td></tr><tr id="30" style="display: none;" colspan="3"><td colspan="3"><h2>move this to proxy_base and use it in all proxies</h2><h4>../src/i2p_stream.cpp:204</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(29)">../src/i2p_stream.cpp:204</a></td><td>move this to proxy_base and use it in all proxies</td></tr><tr id="29" style="display: none;" colspan="3"><td colspan="3"><h2>move this to proxy_base and use it in all proxies</h2><h4>../src/i2p_stream.cpp:204</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
i2p_stream::i2p_stream(io_service& io_service)
|
|
|
|
|
: proxy_base(io_service)
|
|
|
|
|
, m_id(0)
|
|
|
|
|
@ -1607,7 +1559,7 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|
|
|
|
void i2p_stream::connected(error_code const& e, boost::shared_ptr<handler_type> h)
|
|
|
|
|
{
|
|
|
|
|
TORRENT_ASSERT(m_magic == 0x1337);
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(31)">../src/packet_buffer.cpp:176</a></td><td>use compare_less_wrap for this comparison as well</td></tr><tr id="31" style="display: none;" colspan="3"><td colspan="3"><h2>use compare_less_wrap for this comparison as well</h2><h4>../src/packet_buffer.cpp:176</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> while (new_size < size)
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(30)">../src/packet_buffer.cpp:176</a></td><td>use compare_less_wrap for this comparison as well</td></tr><tr id="30" style="display: none;" colspan="3"><td colspan="3"><h2>use compare_less_wrap for this comparison as well</h2><h4>../src/packet_buffer.cpp:176</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> while (new_size < size)
|
|
|
|
|
new_size <<= 1;
|
|
|
|
|
|
|
|
|
|
void** new_storage = (void**)malloc(sizeof(void*) * new_size);
|
|
|
|
|
@ -1658,7 +1610,7 @@ remove all payload ranges that has been sent</h2><h4>../src/bt_peer_connection.c
|
|
|
|
|
if (m_storage[m_last & mask]) break;
|
|
|
|
|
++m_last;
|
|
|
|
|
m_last &= 0xffff;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(32)">../src/peer_connection.cpp:2733</a></td><td>this might need something more so that once we have the metadata we can construct a full bitfield</td></tr><tr id="32" style="display: none;" colspan="3"><td colspan="3"><h2>this might need something more
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(31)">../src/peer_connection.cpp:2733</a></td><td>this might need something more so that once we have the metadata we can construct a full bitfield</td></tr><tr id="31" style="display: none;" colspan="3"><td colspan="3"><h2>this might need something more
|
|
|
|
|
so that once we have the metadata
|
|
|
|
|
we can construct a full bitfield</h2><h4>../src/peer_connection.cpp:2733</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
#ifdef TORRENT_VERBOSE_LOGGING
|
|
|
|
|
@ -1711,7 +1663,7 @@ we can construct a full bitfield</h2><h4>../src/peer_connection.cpp:2733</h4><pr
|
|
|
|
|
boost::shared_ptr<torrent> t = m_torrent.lock();
|
|
|
|
|
TORRENT_ASSERT(t);
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(33)">../src/peer_connection.cpp:2864</a></td><td>sort the allowed fast set in priority order</td></tr><tr id="33" style="display: none;" colspan="3"><td colspan="3"><h2>sort the allowed fast set in priority order</h2><h4>../src/peer_connection.cpp:2864</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // this piece index later
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(32)">../src/peer_connection.cpp:2864</a></td><td>sort the allowed fast set in priority order</td></tr><tr id="32" style="display: none;" colspan="3"><td colspan="3"><h2>sort the allowed fast set in priority order</h2><h4>../src/peer_connection.cpp:2864</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // this piece index later
|
|
|
|
|
m_allowed_fast.push_back(index);
|
|
|
|
|
|
|
|
|
|
// if the peer has the piece and we want
|
|
|
|
|
@ -1762,7 +1714,7 @@ we can construct a full bitfield</h2><h4>../src/peer_connection.cpp:2733</h4><pr
|
|
|
|
|
TORRENT_ASSERT(t->has_picker());
|
|
|
|
|
TORRENT_ASSERT(t->picker().is_requested(block));
|
|
|
|
|
#endif
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(34)">../src/peer_connection.cpp:4577</a></td><td>peers should really be corked/uncorked outside of all completed disk operations</td></tr><tr id="34" style="display: none;" colspan="3"><td colspan="3"><h2>peers should really be corked/uncorked outside of
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(33)">../src/peer_connection.cpp:4577</a></td><td>peers should really be corked/uncorked outside of all completed disk operations</td></tr><tr id="33" style="display: none;" colspan="3"><td colspan="3"><h2>peers should really be corked/uncorked outside of
|
|
|
|
|
all completed disk operations</h2><h4>../src/peer_connection.cpp:4577</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // this means we're in seed mode and we haven't yet
|
|
|
|
|
// verified this piece (r.piece)
|
|
|
|
|
t->filesystem().async_read_and_hash(r, boost::bind(&peer_connection::on_disk_read_complete
|
|
|
|
|
@ -1814,7 +1766,7 @@ all completed disk operations</h2><h4>../src/peer_connection.cpp:4577</h4><pre s
|
|
|
|
|
#endif
|
|
|
|
|
write_reject_request(r);
|
|
|
|
|
if (t->seed_mode()) t->leave_seed_mode(false);
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(35)">../src/policy.cpp:857</a></td><td>only allow _one_ connection to use this override at a time</td></tr><tr id="35" style="display: none;" colspan="3"><td colspan="3"><h2>only allow _one_ connection to use this
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(34)">../src/policy.cpp:857</a></td><td>only allow _one_ connection to use this override at a time</td></tr><tr id="34" style="display: none;" colspan="3"><td colspan="3"><h2>only allow _one_ connection to use this
|
|
|
|
|
override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> " external: " << external.external_address(m_peers[candidate]->address()) <<
|
|
|
|
|
" t: " << (session_time - m_peers[candidate]->last_connected) <<
|
|
|
|
|
" ]\n";
|
|
|
|
|
@ -1866,7 +1818,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|
|
|
|
{
|
|
|
|
|
iter = std::lower_bound(
|
|
|
|
|
m_peers.begin(), m_peers.end()
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(36)">../src/policy.cpp:1902</a></td><td>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</td></tr><tr id="36" style="display: none;" colspan="3"><td colspan="3"><h2>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</h2><h4>../src/policy.cpp:1902</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#endif
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(35)">../src/policy.cpp:1902</a></td><td>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</td></tr><tr id="35" style="display: none;" colspan="3"><td colspan="3"><h2>how do we deal with our external address changing? Pass in a force-update maybe? and keep a version number in policy</h2><h4>../src/policy.cpp:1902</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">#endif
|
|
|
|
|
, on_parole(false)
|
|
|
|
|
, banned(false)
|
|
|
|
|
#ifndef TORRENT_DISABLE_DHT
|
|
|
|
|
@ -1917,7 +1869,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|
|
|
|
{
|
|
|
|
|
return size_type(prev_amount_upload) << 10;
|
|
|
|
|
}
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(37)">../src/session_impl.cpp:1943</a></td><td>recalculate all connect candidates for all torrents</td></tr><tr id="37" style="display: none;" colspan="3"><td colspan="3"><h2>recalculate all connect candidates for all torrents</h2><h4>../src/session_impl.cpp:1943</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> m_upload_rate.close();
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(36)">../src/session_impl.cpp:1940</a></td><td>recalculate all connect candidates for all torrents</td></tr><tr id="36" style="display: none;" colspan="3"><td colspan="3"><h2>recalculate all connect candidates for all torrents</h2><h4>../src/session_impl.cpp:1940</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> m_upload_rate.close();
|
|
|
|
|
|
|
|
|
|
// #error closing the udp socket here means that
|
|
|
|
|
// the uTP connections cannot be closed gracefully
|
|
|
|
|
@ -1968,7 +1920,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|
|
|
|
template <class Socket>
|
|
|
|
|
void static set_socket_buffer_size(Socket& s, session_settings const& sett, error_code& ec)
|
|
|
|
|
{
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(38)">../src/session_impl.cpp:3394</a></td><td>have a separate list for these connections, instead of having to loop through all of them</td></tr><tr id="38" style="display: none;" colspan="3"><td colspan="3"><h2>have a separate list for these connections, instead of having to loop through all of them</h2><h4>../src/session_impl.cpp:3394</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // --------------------------------------------------------------
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(37)">../src/session_impl.cpp:3391</a></td><td>have a separate list for these connections, instead of having to loop through all of them</td></tr><tr id="37" style="display: none;" colspan="3"><td colspan="3"><h2>have a separate list for these connections, instead of having to loop through all of them</h2><h4>../src/session_impl.cpp:3391</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> // --------------------------------------------------------------
|
|
|
|
|
if (!m_paused) m_auto_manage_time_scaler--;
|
|
|
|
|
if (m_auto_manage_time_scaler < 0)
|
|
|
|
|
{
|
|
|
|
|
@ -2019,7 +1971,7 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|
|
|
|
TORRENT_ASSERT(!t.is_aborted());
|
|
|
|
|
if (t.statistics().upload_rate() * 11 / 10 > t.upload_limit())
|
|
|
|
|
++congested_torrents;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(39)">../src/session_impl.cpp:4484</a></td><td>allow extensions to sort torrents for queuing</td></tr><tr id="39" style="display: none;" colspan="3"><td colspan="3"><h2>allow extensions to sort torrents for queuing</h2><h4>../src/session_impl.cpp:4484</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> else if (!t->is_paused())
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(38)">../src/session_impl.cpp:4481</a></td><td>allow extensions to sort torrents for queuing</td></tr><tr id="38" style="display: none;" colspan="3"><td colspan="3"><h2>allow extensions to sort torrents for queuing</h2><h4>../src/session_impl.cpp:4481</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> else if (!t->is_paused())
|
|
|
|
|
{
|
|
|
|
|
TORRENT_ASSERT(t->m_resume_data_loaded || !t->valid_metadata());
|
|
|
|
|
--hard_limit;
|
|
|
|
|
@ -2070,9 +2022,9 @@ override at a time</h2><h4>../src/policy.cpp:857</h4><pre style="background: #f6
|
|
|
|
|
void session_impl::recalculate_optimistic_unchoke_slots()
|
|
|
|
|
{
|
|
|
|
|
TORRENT_ASSERT(is_network_thread());
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(40)">../src/session_impl.cpp:4640</a></td><td>use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections</td></tr><tr id="40" style="display: none;" colspan="3"><td colspan="3"><h2>use a lower limit than m_settings.connections_limit
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(39)">../src/session_impl.cpp:4637</a></td><td>use a lower limit than m_settings.connections_limit to allocate the to 10% or so of connection slots for incoming connections</td></tr><tr id="39" style="display: none;" colspan="3"><td colspan="3"><h2>use a lower limit than m_settings.connections_limit
|
|
|
|
|
to allocate the to 10% or so of connection slots for incoming
|
|
|
|
|
connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
connections</h2><h4>../src/session_impl.cpp:4637</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
if (m_boost_connections > max_connections)
|
|
|
|
|
{
|
|
|
|
|
m_boost_connections -= max_connections;
|
|
|
|
|
@ -2123,7 +2075,7 @@ connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6
|
|
|
|
|
int num_attempts = 1;
|
|
|
|
|
if (!t.is_finished())
|
|
|
|
|
{
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(41)">../src/session_impl.cpp:4674</a></td><td>make this bias configurable</td></tr><tr id="41" style="display: none;" colspan="3"><td colspan="3"><h2>make this bias configurable</h2><h4>../src/session_impl.cpp:4674</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"></pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(42)">../src/session_impl.cpp:4675</a></td><td>also take average_peers into account, to create a bias for downloading torrents with < average peers</td></tr><tr id="42" style="display: none;" colspan="3"><td colspan="3"><h2>also take average_peers into account, to create a bias for downloading torrents with < average peers</h2><h4>../src/session_impl.cpp:4675</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> average_peers = num_downloads_peers / num_downloads;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(40)">../src/session_impl.cpp:4671</a></td><td>make this bias configurable</td></tr><tr id="40" style="display: none;" colspan="3"><td colspan="3"><h2>make this bias configurable</h2><h4>../src/session_impl.cpp:4671</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"></pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(41)">../src/session_impl.cpp:4672</a></td><td>also take average_peers into account, to create a bias for downloading torrents with < average peers</td></tr><tr id="41" style="display: none;" colspan="3"><td colspan="3"><h2>also take average_peers into account, to create a bias for downloading torrents with < average peers</h2><h4>../src/session_impl.cpp:4672</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> average_peers = num_downloads_peers / num_downloads;
|
|
|
|
|
|
|
|
|
|
if (m_next_connect_torrent == m_torrents.end())
|
|
|
|
|
m_next_connect_torrent = m_torrents.begin();
|
|
|
|
|
@ -2174,7 +2126,7 @@ connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6
|
|
|
|
|
if (max_connections == 0) return;
|
|
|
|
|
if (num_connections() >= m_settings.connections_limit) return;
|
|
|
|
|
}
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(43)">../src/session_impl.cpp:4819</a></td><td>make configurable</td></tr><tr id="43" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4819</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(42)">../src/session_impl.cpp:4816</a></td><td>make configurable</td></tr><tr id="42" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4816</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
#ifdef TORRENT_DEBUG
|
|
|
|
|
for (std::vector<peer_connection*>::const_iterator i = peers.begin()
|
|
|
|
|
, end(peers.end()), prev(peers.end()); i != end; ++i)
|
|
|
|
|
@ -2207,7 +2159,7 @@ connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6
|
|
|
|
|
|
|
|
|
|
++m_allowed_upload_slots;
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(44)">../src/session_impl.cpp:4833</a></td><td>make configurable</td></tr><tr id="44" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4833</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> >= (*i)->uploaded_in_last_round() * 1000
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(43)">../src/session_impl.cpp:4830</a></td><td>make configurable</td></tr><tr id="43" style="display: none;" colspan="3"><td colspan="3"><h2>make configurable</h2><h4>../src/session_impl.cpp:4830</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> >= (*i)->uploaded_in_last_round() * 1000
|
|
|
|
|
* (1 + t2->priority()) / total_milliseconds(unchoke_interval));
|
|
|
|
|
}
|
|
|
|
|
prev = i;
|
|
|
|
|
@ -2258,7 +2210,7 @@ connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6
|
|
|
|
|
// if our current upload rate is less than 90% of our
|
|
|
|
|
// limit AND most torrents are not "congested", i.e.
|
|
|
|
|
// they are not holding back because of a per-torrent
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(45)">../src/storage.cpp:324</a></td><td>if the read fails, set error and exit immediately</td></tr><tr id="45" style="display: none;" colspan="3"><td colspan="3"><h2>if the read fails, set error and exit immediately</h2><h4>../src/storage.cpp:324</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (m_storage->disk_pool()) block_size = m_storage->disk_pool()->block_size();
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(44)">../src/storage.cpp:324</a></td><td>if the read fails, set error and exit immediately</td></tr><tr id="44" style="display: none;" colspan="3"><td colspan="3"><h2>if the read fails, set error and exit immediately</h2><h4>../src/storage.cpp:324</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> if (m_storage->disk_pool()) block_size = m_storage->disk_pool()->block_size();
|
|
|
|
|
int size = slot_size;
|
|
|
|
|
int num_blocks = (size + block_size - 1) / block_size;
|
|
|
|
|
|
|
|
|
|
@ -2309,7 +2261,7 @@ connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6
|
|
|
|
|
{
|
|
|
|
|
buf.iov_len = (std::min)(block_size, size);
|
|
|
|
|
// deliberately pass in 0 as flags, to disable random_access
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(46)">../src/storage.cpp:358</a></td><td>if the read fails, set error and exit immediately</td></tr><tr id="46" style="display: none;" colspan="3"><td colspan="3"><h2>if the read fails, set error and exit immediately</h2><h4>../src/storage.cpp:358</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(45)">../src/storage.cpp:358</a></td><td>if the read fails, set error and exit immediately</td></tr><tr id="45" style="display: none;" colspan="3"><td colspan="3"><h2>if the read fails, set error and exit immediately</h2><h4>../src/storage.cpp:358</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
ph.h.update((char const*)bufs[i].iov_base, bufs[i].iov_len);
|
|
|
|
|
small_piece_size -= bufs[i].iov_len;
|
|
|
|
|
}
|
|
|
|
|
@ -2360,7 +2312,7 @@ connections</h2><h4>../src/session_impl.cpp:4640</h4><pre style="background: #f6
|
|
|
|
|
, m_file_priority(file_prio)
|
|
|
|
|
, m_pool(fp)
|
|
|
|
|
, m_page_size(page_size())
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(47)">../src/storage.cpp:629</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info</td></tr><tr id="47" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(46)">../src/storage.cpp:629</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info</td></tr><tr id="46" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
|
|
|
|
renamed, but also if they have been merged into a single file for instance
|
|
|
|
|
maybe use the same format as .torrent files and reuse some code from torrent_info</h2><h4>../src/storage.cpp:629</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> for (;;)
|
|
|
|
|
{
|
|
|
|
|
@ -2413,7 +2365,7 @@ maybe use the same format as .torrent files and reuse some code from torrent_inf
|
|
|
|
|
|
|
|
|
|
for (int i = 0; i < file_sizes_ent->list_size(); ++i)
|
|
|
|
|
{
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(48)">../src/storage.cpp:1246</a></td><td>what if file_base is used to merge several virtual files into a single physical file? We should probably disable this if file_base is used. This is not a widely used feature though</td></tr><tr id="48" style="display: none;" colspan="3"><td colspan="3"><h2>what if file_base is used to merge several virtual files
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(47)">../src/storage.cpp:1246</a></td><td>what if file_base is used to merge several virtual files into a single physical file? We should probably disable this if file_base is used. This is not a widely used feature though</td></tr><tr id="47" style="display: none;" colspan="3"><td colspan="3"><h2>what if file_base is used to merge several virtual files
|
|
|
|
|
into a single physical file? We should probably disable this
|
|
|
|
|
if file_base is used. This is not a widely used feature though</h2><h4>../src/storage.cpp:1246</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> int bytes_transferred = 0;
|
|
|
|
|
// if the file is opened in no_buffer mode, and the
|
|
|
|
|
@ -2466,7 +2418,7 @@ if file_base is used. This is not a widely used feature though</h2><h4>../src/st
|
|
|
|
|
// makes unaligned requests (and the disk cache is disabled or fully utilized
|
|
|
|
|
// for write cache).
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(49)">../src/torrent.cpp:1359</a></td><td>is verify_peer_cert called once per certificate in the chain, and this function just tells us which depth we're at right now? If so, the comment makes sense. any certificate that isn't the leaf (i.e. the one presented by the peer) should be accepted automatically, given preverified is true. The leaf certificate need to be verified to make sure its DN matches the info-hash</td></tr><tr id="49" style="display: none;" colspan="3"><td colspan="3"><h2>is verify_peer_cert called once per certificate in the chain, and
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(48)">../src/torrent.cpp:1359</a></td><td>is verify_peer_cert called once per certificate in the chain, and this function just tells us which depth we're at right now? If so, the comment makes sense. any certificate that isn't the leaf (i.e. the one presented by the peer) should be accepted automatically, given preverified is true. The leaf certificate need to be verified to make sure its DN matches the info-hash</td></tr><tr id="48" style="display: none;" colspan="3"><td colspan="3"><h2>is verify_peer_cert called once per certificate in the chain, and
|
|
|
|
|
this function just tells us which depth we're at right now? If so, the comment
|
|
|
|
|
makes sense.
|
|
|
|
|
any certificate that isn't the leaf (i.e. the one presented by the peer)
|
|
|
|
|
@ -2522,7 +2474,7 @@ need to be verified to make sure its DN matches the info-hash</h2><h4>../src/tor
|
|
|
|
|
{
|
|
|
|
|
#if defined(TORRENT_VERBOSE_LOGGING) || defined(TORRENT_LOGGING)
|
|
|
|
|
match = true;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(50)">../src/torrent.cpp:5177</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync</td></tr><tr id="50" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(49)">../src/torrent.cpp:5177</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance maybe use the same format as .torrent files and reuse some code from torrent_info The mapped_files needs to be read both in the network thread and in the disk thread, since they both have their own mapped files structures which are kept in sync</td></tr><tr id="49" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
|
|
|
|
renamed, but also if they have been merged into a single file for instance
|
|
|
|
|
maybe use the same format as .torrent files and reuse some code from torrent_info
|
|
|
|
|
The mapped_files needs to be read both in the network thread
|
|
|
|
|
@ -2578,7 +2530,7 @@ which are kept in sync</h2><h4>../src/torrent.cpp:5177</h4><pre style="backgroun
|
|
|
|
|
{
|
|
|
|
|
char const* p = piece_priority->string_ptr();
|
|
|
|
|
for (int i = 0; i < piece_priority->string_length(); ++i)
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(51)">../src/torrent.cpp:5313</a></td><td>if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents</td></tr><tr id="51" style="display: none;" colspan="3"><td colspan="3"><h2>if this is a merkle torrent and we can't
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(50)">../src/torrent.cpp:5313</a></td><td>if this is a merkle torrent and we can't restore the tree, we need to wipe all the bits in the have array, but not necessarily we might want to do a full check to see if we have all the pieces. This is low priority since almost no one uses merkle torrents</td></tr><tr id="50" style="display: none;" colspan="3"><td colspan="3"><h2>if this is a merkle torrent and we can't
|
|
|
|
|
restore the tree, we need to wipe all the
|
|
|
|
|
bits in the have array, but not necessarily
|
|
|
|
|
we might want to do a full check to see if we have
|
|
|
|
|
@ -2634,7 +2586,7 @@ no one uses merkle torrents</h2><h4>../src/torrent.cpp:5313</h4><pre style="back
|
|
|
|
|
ret["num_complete"] = m_complete;
|
|
|
|
|
ret["num_incomplete"] = m_incomplete;
|
|
|
|
|
ret["num_downloaded"] = m_downloaded;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(52)">../src/torrent.cpp:5501</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base</td></tr><tr id="52" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(51)">../src/torrent.cpp:5501</a></td><td>make this more generic to not just work if files have been renamed, but also if they have been merged into a single file for instance. using file_base</td></tr><tr id="51" style="display: none;" colspan="3"><td colspan="3"><h2>make this more generic to not just work if files have been
|
|
|
|
|
renamed, but also if they have been merged into a single file for instance.
|
|
|
|
|
using file_base</h2><h4>../src/torrent.cpp:5501</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> entry::string_type& pieces = ret["pieces"].string();
|
|
|
|
|
pieces.resize(m_torrent_file->num_pieces());
|
|
|
|
|
@ -2687,7 +2639,7 @@ using file_base</h2><h4>../src/torrent.cpp:5501</h4><pre style="background: #f6f
|
|
|
|
|
error_code ec;
|
|
|
|
|
policy::peer const* p = *i;
|
|
|
|
|
address addr = p->address();
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(53)">../src/torrent.cpp:8048</a></td><td>go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece</td></tr><tr id="53" style="display: none;" colspan="3"><td colspan="3"><h2>go through the pieces we have and count the total number
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(52)">../src/torrent.cpp:8048</a></td><td>go through the pieces we have and count the total number of downloaders we have. Only count peers that are interested in us since some peers might not send have messages for pieces we have it num_interested == 0, we need to pick a new piece</td></tr><tr id="52" style="display: none;" colspan="3"><td colspan="3"><h2>go through the pieces we have and count the total number
|
|
|
|
|
of downloaders we have. Only count peers that are interested in us
|
|
|
|
|
since some peers might not send have messages for pieces we have
|
|
|
|
|
it num_interested == 0, we need to pick a new piece</h2><h4>../src/torrent.cpp:8048</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
|
|
|
|
@ -2741,7 +2693,7 @@ it num_interested == 0, we need to pick a new piece</h2><h4>../src/torrent.cpp:8
|
|
|
|
|
{
|
|
|
|
|
m_picker->get_availability(avail_vec);
|
|
|
|
|
}
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(54)">../src/udp_tracker_connection.cpp:550</a></td><td>it would be more efficient to not use a string here. however, the problem is that some trackers will respond with actual strings. For example i2p trackers</td></tr><tr id="54" style="display: none;" colspan="3"><td colspan="3"><h2>it would be more efficient to not use a string here.
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(53)">../src/udp_tracker_connection.cpp:550</a></td><td>it would be more efficient to not use a string here. however, the problem is that some trackers will respond with actual strings. For example i2p trackers</td></tr><tr id="53" style="display: none;" colspan="3"><td colspan="3"><h2>it would be more efficient to not use a string here.
|
|
|
|
|
however, the problem is that some trackers will respond
|
|
|
|
|
with actual strings. For example i2p trackers</h2><h4>../src/udp_tracker_connection.cpp:550</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> }
|
|
|
|
|
|
|
|
|
|
@ -2794,7 +2746,7 @@ with actual strings. For example i2p trackers</h2><h4>../src/udp_tracker_connect
|
|
|
|
|
{
|
|
|
|
|
restart_read_timeout();
|
|
|
|
|
int action = detail::read_int32(buf);
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(55)">../src/utp_stream.cpp:1573</a></td><td>this loop may not be very efficient</td></tr><tr id="55" style="display: none;" colspan="3"><td colspan="3"><h2>this loop may not be very efficient</h2><h4>../src/utp_stream.cpp:1573</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> TORRENT_ASSERT(p->header_size >= sizeof(utp_header) + sack_size + 2);
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(54)">../src/utp_stream.cpp:1573</a></td><td>this loop may not be very efficient</td></tr><tr id="54" style="display: none;" colspan="3"><td colspan="3"><h2>this loop may not be very efficient</h2><h4>../src/utp_stream.cpp:1573</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> TORRENT_ASSERT(p->header_size >= sizeof(utp_header) + sack_size + 2);
|
|
|
|
|
memmove(ptr, ptr + sack_size + 2, p->size - p->header_size);
|
|
|
|
|
p->header_size -= sack_size + 2;
|
|
|
|
|
p->size -= sack_size + 2;
|
|
|
|
|
@ -2845,8 +2797,8 @@ bool utp_socket_impl::send_pkt(int flags)
|
|
|
|
|
if (sack > 32) sack = 32;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(56)">../src/kademlia/routing_table.cpp:280</a></td><td>instad of refreshing a bucket by using find_nodes, ping each node periodically</td></tr><tr id="56" style="display: none;" colspan="3"><td colspan="3"><h2>instad of refreshing a bucket by using find_nodes,
|
|
|
|
|
ping each node periodically</h2><h4>../src/kademlia/routing_table.cpp:280</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> os << "]\n";
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(55)">../src/kademlia/routing_table.cpp:291</a></td><td>instad of refreshing a bucket by using find_nodes, ping each node periodically</td></tr><tr id="55" style="display: none;" colspan="3"><td colspan="3"><h2>instad of refreshing a bucket by using find_nodes,
|
|
|
|
|
ping each node periodically</h2><h4>../src/kademlia/routing_table.cpp:291</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> os << "]\n";
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@ -2897,7 +2849,7 @@ bool compare_bucket_refresh(routing_table_node const& lhs, routing_table_nod
|
|
|
|
|
// target = (target & ~mask) | (root & mask)
|
|
|
|
|
node_id root = m_id;
|
|
|
|
|
root &= mask;
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(57)">../include/libtorrent/config.hpp:305</a></td><td>Make this count Unicode characters instead of bytes on windows</td></tr><tr id="57" style="display: none;" colspan="3"><td colspan="3"><h2>Make this count Unicode characters instead of bytes on windows</h2><h4>../include/libtorrent/config.hpp:305</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(56)">../include/libtorrent/config.hpp:305</a></td><td>Make this count Unicode characters instead of bytes on windows</td></tr><tr id="56" style="display: none;" colspan="3"><td colspan="3"><h2>Make this count Unicode characters instead of bytes on windows</h2><h4>../include/libtorrent/config.hpp:305</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
// ==== eCS(OS/2) ===
|
|
|
|
|
#elif defined __OS2__
|
|
|
|
|
#define TORRENT_OS2
|
|
|
|
|
@ -2948,7 +2900,7 @@ bool compare_bucket_refresh(routing_table_node const& lhs, routing_table_nod
|
|
|
|
|
#include <stdarg.h>
|
|
|
|
|
|
|
|
|
|
// internal
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(58)">../include/libtorrent/proxy_base.hpp:166</a></td><td>it would be nice to remember the bind port and bind once we know where the proxy is m_sock.bind(endpoint, ec);</td></tr><tr id="58" style="display: none;" colspan="3"><td colspan="3"><h2>it would be nice to remember the bind port and bind once we know where the proxy is
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(57)">../include/libtorrent/proxy_base.hpp:166</a></td><td>it would be nice to remember the bind port and bind once we know where the proxy is m_sock.bind(endpoint, ec);</td></tr><tr id="57" style="display: none;" colspan="3"><td colspan="3"><h2>it would be nice to remember the bind port and bind once we know where the proxy is
|
|
|
|
|
m_sock.bind(endpoint, ec);</h2><h4>../include/libtorrent/proxy_base.hpp:166</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
return m_sock.get_option(opt, ec);
|
|
|
|
|
}
|
|
|
|
|
@ -3000,7 +2952,7 @@ m_sock.bind(endpoint, ec);</h2><h4>../include/libtorrent/proxy_base.hpp:166</h4>
|
|
|
|
|
m_sock.close(ec);
|
|
|
|
|
m_resolver.cancel();
|
|
|
|
|
}
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(59)">../include/libtorrent/torrent_info.hpp:123</a></td><td>include the number of peers received from this tracker, at last announce</td></tr><tr id="59" style="display: none;" colspan="3"><td colspan="3"><h2>include the number of peers received from this tracker, at last announce</h2><h4>../include/libtorrent/torrent_info.hpp:123</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(58)">../include/libtorrent/torrent_info.hpp:123</a></td><td>include the number of peers received from this tracker, at last announce</td></tr><tr id="58" style="display: none;" colspan="3"><td colspan="3"><h2>include the number of peers received from this tracker, at last announce</h2><h4>../include/libtorrent/torrent_info.hpp:123</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;">
|
|
|
|
|
// if this tracker failed the last time it was contacted
|
|
|
|
|
// this error code specifies what error occurred
|
|
|
|
|
error_code last_error;
|
|
|
|
|
@ -3051,7 +3003,7 @@ m_sock.bind(endpoint, ec);</h2><h4>../include/libtorrent/proxy_base.hpp:166</h4>
|
|
|
|
|
// flags for the source bitmask, each indicating where
|
|
|
|
|
// we heard about this tracker
|
|
|
|
|
enum tracker_source
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(60)">../include/libtorrent/upnp.hpp:121</a></td><td>support using the windows API for UPnP operations as well</td></tr><tr id="60" style="display: none;" colspan="3"><td colspan="3"><h2>support using the windows API for UPnP operations as well</h2><h4>../include/libtorrent/upnp.hpp:121</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
</pre></td></tr><tr style="background: #ccc"><td>relevance 0</td><td><a href="javascript:expand(59)">../include/libtorrent/upnp.hpp:121</a></td><td>support using the windows API for UPnP operations as well</td></tr><tr id="59" style="display: none;" colspan="3"><td colspan="3"><h2>support using the windows API for UPnP operations as well</h2><h4>../include/libtorrent/upnp.hpp:121</h4><pre style="background: #f6f6f6; border: solid 1px #ddd;"> {
|
|
|
|
|
virtual const char* name() const BOOST_SYSTEM_NOEXCEPT;
|
|
|
|
|
virtual std::string message(int ev) const BOOST_SYSTEM_NOEXCEPT;
|
|
|
|
|
virtual boost::system::error_condition default_error_condition(int ev) const BOOST_SYSTEM_NOEXCEPT
|
|
|
|
|
|
Arvid Norberg