improve debug logging of dht routing table

src/kademlia/routing_table.cpp

@@ -190,6 +190,35 @@ void routing_table::print_state(std::ostream& os) const
 				<< "\n";
 		}
 	}
+
+	os << "node spread per bucket:\n";
+	bucket_index = 0;
+	for (table_t::const_iterator i = m_buckets.begin(), end(m_buckets.end());
+		i != end; ++i, ++bucket_index)
+	{
+		// mask out the first 8 bits
+		node_id mask(0);
+		mask[0] = 0xe0;
+		const int mask_shift = 5;
+		bool sub_buckets[8];
+		memset(sub_buckets, 0, sizeof(sub_buckets));
+		
+		for (bucket_t::const_iterator j = i->live_nodes.begin()
+			, end(i->live_nodes.end()); j != end; ++j)
+		{
+			node_id id = j->id;
+			id <<= bucket_index + 1;
+			id &= mask;
+			id >>= mask_shift;
+			int b = id[0];
+			TORRENT_ASSERT(b >= 0 && b < 8);
+			sub_buckets[b] = true;
+		}
+
+		os << bucket_index << ": [";
+		for (int i = 0; i < 8; ++i) os << (sub_buckets[i] ? "X" : " ");
+		os << "]\n";
+	}
 }
 
 #endif

src/kademlia/traversal_algorithm.cpp

@@ -213,7 +213,10 @@ void traversal_algorithm::finished(observer_ptr o)
 	// if this flag is set, it means we increased the
 	// branch factor for it, and we should restore it
 	if (o->flags & observer::flag_short_timeout)
+	{
+		TORRENT_ASSERT(m_branch_factor > 0);
 		--m_branch_factor;
+	}
 
 	TORRENT_ASSERT(o->flags & observer::flag_queried);
 	o->flags |= observer::flag_alive;