premiere/premiere-libtorrent
2
2
Fork 1
Code Issues Pull Requests Releases Wiki Activity

fix empty key in default settings in python binding when building with deprecated functions off

Browse Source
This commit is contained in:
arvidn 2020-04-03 16:33:24 +02:00 committed by Arvid Norberg
parent 3185b627ef
commit 93aa1956a4
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bindings/python/src/session.cpp
View File

@ -152,19 +152,23 @@ namespace
for (int i = settings_pack::string_type_base;
i < settings_pack::max_string_setting_internal; ++i)
{
ret[name_for_setting(i)] = sett.get_str(i);
// deprecated settings are still here, they just have empty names
char const* name = name_for_setting(i);
if (name[0] != '\0') ret[name] = sett.get_str(i);
}
for (int i = settings_pack::int_type_base;
i < settings_pack::max_int_setting_internal; ++i)
{
ret[name_for_setting(i)] = sett.get_int(i);
char const* name = name_for_setting(i);
if (name[0] != '\0') ret[name] = sett.get_int(i);
}
for (int i = settings_pack::bool_type_base;
i < settings_pack::max_bool_setting_internal; ++i)
{
ret[name_for_setting(i)] = sett.get_bool(i);
char const* name = name_for_setting(i);
if (name[0] != '\0') ret[name] = sett.get_bool(i);
}
return ret;
}

1
bindings/python/test.py
View File

@ -705,6 +705,7 @@ class test_example_client(unittest.TestCase):
def test_default_settings(self):
default = lt.default_settings()
self.assertNotIn('', default)
print(default)