diff --git a/include/libtorrent/upnp.hpp b/include/libtorrent/upnp.hpp index f77286c30..e3b0cd71d 100644 --- a/include/libtorrent/upnp.hpp +++ b/include/libtorrent/upnp.hpp @@ -199,8 +199,6 @@ private: void map_timer(error_code const& ec); void try_map_upnp(bool timer = false); void discover_device_impl(); - static address_v4 upnp_multicast_address; - static udp::endpoint upnp_multicast_endpoint; void resend_request(error_code const& e); void on_reply(udp::endpoint const& from, char* buffer diff --git a/src/natpmp.cpp b/src/natpmp.cpp index 730ba1688..eb518faae 100644 --- a/src/natpmp.cpp +++ b/src/natpmp.cpp @@ -81,7 +81,7 @@ void natpmp::start() TORRENT_ASSERT(is_single_thread()); error_code ec; - address gateway = get_default_gateway(m_socket.get_io_service(), ec); + address const gateway = get_default_gateway(m_socket.get_io_service(), ec); if (ec) { #ifndef TORRENT_DISABLE_LOGGING @@ -115,7 +115,7 @@ void natpmp::start() disable(ec); return; } - m_socket.bind(udp::endpoint(address_v4::any(), 0), ec); + m_socket.bind({address_v4::any(), 0}, ec); if (ec) { disable(ec); @@ -128,8 +128,7 @@ void natpmp::start() , m_remote, std::bind(&natpmp::on_reply, self(), _1, _2)); send_get_ip_address_request(); - for (std::vector::iterator i = m_mappings.begin() - , end(m_mappings.end()); i != end; ++i) + for (auto i = m_mappings.begin(), end(m_mappings.end()); i != end; ++i) { if (i->protocol == portmap_protocol::none || i->act != portmap_action::none) @@ -211,8 +210,7 @@ void natpmp::disable(error_code const& ec) TORRENT_ASSERT(is_single_thread()); m_disabled = true; - for (std::vector::iterator i = m_mappings.begin() - , end(m_mappings.end()); i != end; ++i) + for (auto i = m_mappings.begin(), end(m_mappings.end()); i != end; ++i) { if (i->protocol == portmap_protocol::none) continue; portmap_protocol const proto = i->protocol; @@ -314,7 +312,7 @@ void natpmp::update_mapping(port_mapping_t const i) return; } - natpmp::mapping_t const& m = m_mappings[i]; + mapping_t const& m = m_mappings[i]; #ifndef TORRENT_DISABLE_LOGGING mapping_log("update", m); @@ -412,7 +410,7 @@ void natpmp::resend_request(port_mapping_t const i, error_code const& e) } void natpmp::on_reply(error_code const& e - , std::size_t bytes_transferred) + , std::size_t const bytes_transferred) { TORRENT_ASSERT(is_single_thread()); @@ -465,10 +463,10 @@ void natpmp::on_reply(error_code const& e } char* in = msg_buf; - int version = read_uint8(in); - int cmd = read_uint8(in); - int result = read_uint16(in); - int time = aux::numeric_cast(read_uint32(in)); + int const version = read_uint8(in); + int const cmd = read_uint8(in); + int const result = read_uint16(in); + int const time = aux::numeric_cast(read_uint32(in)); TORRENT_UNUSED(version); TORRENT_UNUSED(time); @@ -505,7 +503,7 @@ void natpmp::on_reply(error_code const& e #ifndef TORRENT_DISABLE_LOGGING char msg[200]; - int num_chars = std::snprintf(msg, sizeof(msg), "<== port map [" + int const num_chars = std::snprintf(msg, sizeof(msg), "<== port map [" " protocol: %s local: %u external: %u ttl: %u ]" , (cmd - 128 == 1 ? "udp" : "tcp") , private_port, public_port, lifetime); @@ -600,8 +598,7 @@ void natpmp::update_expiration_timer() time_point const now = aux::time_now() + milliseconds(100); time_point min_expire = now + seconds(3600); port_mapping_t min_index{-1}; - for (std::vector::iterator i = m_mappings.begin() - , end(m_mappings.end()); i != end; ++i) + for (auto i = m_mappings.begin(), end(m_mappings.end()); i != end; ++i) { if (i->protocol == portmap_protocol::none || i->act != portmap_action::none) continue; diff --git a/src/upnp.cpp b/src/upnp.cpp index 491894691..8c951373f 100644 --- a/src/upnp.cpp +++ b/src/upnp.cpp @@ -626,7 +626,7 @@ void upnp::try_map_upnp(bool const timer) bool override_ignore_non_routers = false; if (m_ignore_non_routers && timer) { - // if we don't ave any devices that match our default route, we + // if we don't have any devices that match our default route, we // should try to map with the ones we did hear from anyway, // regardless of if they are not running at our gateway. override_ignore_non_routers = std::none_of(m_devices.begin() @@ -1342,7 +1342,7 @@ void upnp::on_upnp_map_response(error_code const& e return; } - std::string ct = p.header("content-type"); + std::string const& ct = p.header("content-type"); if (!ct.empty() && ct.find_first_of("text/xml") == std::string::npos && ct.find_first_of("text/soap+xml") == std::string::npos