tweak some TODO comments and fix one

This commit is contained in:
Arvid Norberg 2014-12-31 14:41:35 +00:00
parent bc117e5f40
commit 1039d4ae86
5 changed files with 7 additions and 5 deletions

View File

@ -600,6 +600,8 @@ namespace libtorrent
// decreased in the piece_picker // decreased in the piece_picker
void remove_peer(peer_connection* p); void remove_peer(peer_connection* p);
// cancel requests to this block from any peer we're
// connected to on this torrent
void cancel_block(piece_block block); void cancel_block(piece_block block);
bool want_tick() const; bool want_tick() const;

View File

@ -230,7 +230,7 @@ namespace libtorrent
#endif #endif
} }
// TODO: 3 it would be nice to have the number of threads be set dynamically // TODO: 1 it would be nice to have the number of threads be set dynamically
void disk_io_thread::set_num_threads(int i, bool wait) void disk_io_thread::set_num_threads(int i, bool wait)
{ {
TORRENT_ASSERT(m_magic == 0x1337); TORRENT_ASSERT(m_magic == 0x1337);

View File

@ -881,7 +881,7 @@ void routing_table::split_bucket()
if (b.size() > bucket_size_limit) if (b.size() > bucket_size_limit)
{ {
// TODO: 3 move the lowest priority nodes to the replacement bucket // TODO: 2 move the lowest priority nodes to the replacement bucket
for (bucket_t::iterator i = b.begin() + bucket_size_limit for (bucket_t::iterator i = b.begin() + bucket_size_limit
, end(b.end()); i != end; ++i) , end(b.end()); i != end; ++i)
{ {

View File

@ -5779,8 +5779,6 @@ retry:
} }
} }
// TODO: 3 If socket jobs could be higher level, to include RC4 encryption and decryption,
// we would offload the main thread even more
void session_impl::post_socket_job(socket_job& j) void session_impl::post_socket_job(socket_job& j)
{ {
uintptr_t idx = 0; uintptr_t idx = 0;

View File

@ -1066,7 +1066,9 @@ namespace libtorrent
} }
else else
{ {
// TODO: 3 if any other peer has a busy request to this block, we need to cancel it too // if any other peer has a busy request to this block, we need
// to cancel it too
cancel_block(block_finished);
if (has_picker()) if (has_picker())
picker().write_failed(block_finished); picker().write_failed(block_finished);