From 0eee042bf917eca5bc57db8df2c71d43b9eb5869 Mon Sep 17 00:00:00 2001 From: FranciscoPombal Date: Thu, 27 Feb 2020 12:38:25 +0000 Subject: [PATCH] Fix some more unlikely integer truncation --- src/torrent_info.cpp | 2 +- test/test_dht.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/torrent_info.cpp b/src/torrent_info.cpp index 8dc1a45fb..d0e791591 100644 --- a/src/torrent_info.cpp +++ b/src/torrent_info.cpp @@ -465,7 +465,7 @@ namespace { { // pad files don't need a path element, we'll just store them // under the .pad directory - char cnt[10]; + char cnt[11]; std::snprintf(cnt, sizeof(cnt), "%d", pad_file_cnt); path = combine_path(".pad", cnt); ++pad_file_cnt; diff --git a/test/test_dht.cpp b/test/test_dht.cpp index 6d9dadd53..a2e96da32 100644 --- a/test/test_dht.cpp +++ b/test/test_dht.cpp @@ -2387,7 +2387,7 @@ TORRENT_TEST(immutable_put) TEST_ERROR(t.error_string); continue; } - char tok[10]; + char tok[11]; std::snprintf(tok, sizeof(tok), "%02d", idx); msg_args args; @@ -2418,7 +2418,7 @@ TORRENT_TEST(immutable_put) TEST_EQUAL(put_immutable_item_keys[2].string_value(), "put"); span const v = put_immutable_item_keys[6].data_section(); TEST_EQUAL(v, span(flat_data)); - char tok[10]; + char tok[11]; std::snprintf(tok, sizeof(tok), "%02d", idx); TEST_EQUAL(put_immutable_item_keys[5].string_value(), tok); if (put_immutable_item_keys[0].string_value() != "q" @@ -2492,7 +2492,7 @@ TORRENT_TEST(mutable_put) TEST_ERROR(t.error_string); continue; } - char tok[10]; + char tok[11]; std::snprintf(tok, sizeof(tok), "%02d", idx); msg_args args; @@ -2528,7 +2528,7 @@ TORRENT_TEST(mutable_put) , std::string(sig.bytes.data(), signature::len)); span const v = put_mutable_item_keys[10].data_section(); TEST_CHECK(v == itemv); - char tok[10]; + char tok[11]; std::snprintf(tok, sizeof(tok), "%02d", idx); TEST_EQUAL(put_mutable_item_keys[9].string_value(), tok); if (put_mutable_item_keys[0].string_value() != "q"