From 78d400313324fd5dd72353e57e0dda81d2b37cab Mon Sep 17 00:00:00 2001
From: Retro_Guy <retro.guy@rocksolidbbs.com>
Date: Sat, 28 Sep 2024 12:46:42 -0700
Subject: [PATCH] Only log failed message retrieval after all steps to retry.

---
 Rocksolid_Light/rocksolid/lib/message.inc.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Rocksolid_Light/rocksolid/lib/message.inc.php b/Rocksolid_Light/rocksolid/lib/message.inc.php
index 09fdf77..5d35790 100644
--- a/Rocksolid_Light/rocksolid/lib/message.inc.php
+++ b/Rocksolid_Light/rocksolid/lib/message.inc.php
@@ -267,7 +267,6 @@ function message_read($id, $bodynum = 0, $group = "")
             }
         }
         if (! isset($rawmessage) || $rawmessage === FALSE) {
-            file_put_contents($debug_log, "\n" . logging_prefix() . " " . $config_name . " Unable to retrieve: " . $group . ":" . $id . " from local server", FILE_APPEND);
             if (! isset($ns)) {
                 $ns = nntp_open();
             }
@@ -282,7 +281,9 @@ function message_read($id, $bodynum = 0, $group = "")
                 // should check, if the thread stored in the spool-directory
                 // also doesnt't contain that article...
                 thread_cache_removearticle($group, $id);
+                file_put_contents($debug_log, "\n" . logging_prefix() . " " . $config_name . " Unable to retrieve: " . $group . ":" . $id . " from local server", FILE_APPEND);
                 return false;
+            } else {
             }
             $rawmessage = array();
             $line = line_read($ns);