From 6b97505f66add58a087c3ba9c38c0802fdb44a6c Mon Sep 17 00:00:00 2001
From: Samuel Elliott <samuel@fancy.org.uk>
Date: Wed, 18 Jul 2018 20:57:05 +0100
Subject: [PATCH] Remove unused imports

---
 client/src/builtin/EmoteModule.js                   | 4 ++--
 client/src/modules/content.js                       | 2 +-
 client/src/modules/contentmanager.js                | 1 -
 client/src/modules/discordapi.js                    | 2 +-
 client/src/modules/eventhook.js                     | 1 -
 client/src/modules/extmodulemanager.js              | 2 --
 client/src/modules/modulemanager.js                 | 2 +-
 client/src/modules/patcher.js                       | 2 +-
 client/src/modules/pluginapi.js                     | 2 +-
 client/src/modules/pluginmanager.js                 | 2 +-
 client/src/modules/reactcomponents.js               | 6 +++---
 client/src/modules/settings.js                      | 4 ++--
 client/src/modules/thememanager.js                  | 5 +----
 client/src/structs/settings/multiplechoiceoption.js | 2 --
 client/src/structs/settings/setting.js              | 2 --
 client/src/structs/settings/settingsproxy.js        | 1 -
 client/src/structs/settings/settingsset.js          | 2 +-
 client/src/structs/settings/types/custom.js         | 2 --
 client/src/ui/bdui.js                               | 3 +--
 client/src/ui/modals.js                             | 2 +-
 client/src/ui/profilebadges.js                      | 4 +---
 common/modules/async-eventemitter.js                | 6 +++---
 common/modules/utils.js                             | 7 +------
 core/src/main.js                                    | 1 -
 core/src/modules/utils.js                           | 1 -
 25 files changed, 22 insertions(+), 46 deletions(-)

diff --git a/client/src/builtin/EmoteModule.js b/client/src/builtin/EmoteModule.js
index 9e6d59f6..bdf2c122 100644
--- a/client/src/builtin/EmoteModule.js
+++ b/client/src/builtin/EmoteModule.js
@@ -8,8 +8,8 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { Events, Settings, Globals, WebpackModules, ReactComponents, MonkeyPatch } from 'modules';
-import { DOM, VueInjector, Reflection } from 'ui';
+import { Settings, Globals, WebpackModules, ReactComponents, MonkeyPatch } from 'modules';
+import { VueInjector, Reflection } from 'ui';
 import { Utils, FileUtils, ClientLogger as Logger } from 'common';
 import path from 'path';
 import EmoteComponent from './EmoteComponent.vue';
diff --git a/client/src/modules/content.js b/client/src/modules/content.js
index 854761a6..61d0101d 100644
--- a/client/src/modules/content.js
+++ b/client/src/modules/content.js
@@ -8,7 +8,7 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { Utils, FileUtils, ClientLogger as Logger, AsyncEventEmitter } from 'common';
+import { Utils, ClientLogger as Logger, AsyncEventEmitter } from 'common';
 import { Modals } from 'ui';
 import Database from './database';
 
diff --git a/client/src/modules/contentmanager.js b/client/src/modules/contentmanager.js
index 915b924a..f89e7f94 100644
--- a/client/src/modules/contentmanager.js
+++ b/client/src/modules/contentmanager.js
@@ -12,7 +12,6 @@ import Content from './content';
 import Globals from './globals';
 import Database from './database';
 import { Utils, FileUtils, ClientLogger as Logger } from 'common';
-import { Events } from 'modules';
 import { SettingsSet, ErrorEvent } from 'structs';
 import { Modals } from 'ui';
 import path from 'path';
diff --git a/client/src/modules/discordapi.js b/client/src/modules/discordapi.js
index bc5a78e8..b9c4113e 100644
--- a/client/src/modules/discordapi.js
+++ b/client/src/modules/discordapi.js
@@ -8,7 +8,7 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { List, InsufficientPermissions } from 'structs';
+import { List } from 'structs';
 import { User, Channel, Guild, Message } from 'discordstructs';
 import { WebpackModules } from './webpackmodules';
 
diff --git a/client/src/modules/eventhook.js b/client/src/modules/eventhook.js
index eccad42e..b1b76650 100644
--- a/client/src/modules/eventhook.js
+++ b/client/src/modules/eventhook.js
@@ -8,7 +8,6 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { Utils, ClientLogger as Logger } from 'common';
 import { WebpackModules } from './webpackmodules';
 import Events from './events';
 import EventListener from './eventlistener';
diff --git a/client/src/modules/extmodulemanager.js b/client/src/modules/extmodulemanager.js
index 89bf2efd..8055c84c 100644
--- a/client/src/modules/extmodulemanager.js
+++ b/client/src/modules/extmodulemanager.js
@@ -10,8 +10,6 @@
 
 import ContentManager from './contentmanager';
 import ExtModule from './extmodule';
-import { ClientLogger as Logger } from 'common';
-import { Events } from 'modules';
 
 export default class extends ContentManager {
 
diff --git a/client/src/modules/modulemanager.js b/client/src/modules/modulemanager.js
index ddb35bd3..4b2e25fd 100644
--- a/client/src/modules/modulemanager.js
+++ b/client/src/modules/modulemanager.js
@@ -9,7 +9,7 @@
 */
 
 import { ClientLogger as Logger } from 'common';
-import { Events, SocketProxy, EventHook, CssEditor } from 'modules';
+import { SocketProxy, EventHook, CssEditor } from 'modules';
 import { ProfileBadges, ClassNormaliser } from 'ui';
 import Updater from './updater';
 
diff --git a/client/src/modules/patcher.js b/client/src/modules/patcher.js
index f82951df..8f2cbce5 100644
--- a/client/src/modules/patcher.js
+++ b/client/src/modules/patcher.js
@@ -9,7 +9,7 @@
 */
 
 import { WebpackModules } from './webpackmodules';
-import { ClientLogger as Logger, Utils } from 'common';
+import { ClientLogger as Logger } from 'common';
 
 export class Patcher {
 
diff --git a/client/src/modules/pluginapi.js b/client/src/modules/pluginapi.js
index 9c504635..8bf614df 100644
--- a/client/src/modules/pluginapi.js
+++ b/client/src/modules/pluginapi.js
@@ -231,7 +231,7 @@ export default class PluginApi {
         this.injectedStyles.splice(this.injectedStyles.indexOf(styleid), 1);
         DOM.deleteStyle(styleid);
     }
-    deleteAllStyles(id, css) {
+    deleteAllStyles(id) {
         for (let id of this.injectedStyles) {
             this.deleteStyle(id);
         }
diff --git a/client/src/modules/pluginmanager.js b/client/src/modules/pluginmanager.js
index 2e4bffbf..906b62b0 100644
--- a/client/src/modules/pluginmanager.js
+++ b/client/src/modules/pluginmanager.js
@@ -8,7 +8,7 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { Events, Permissions } from 'modules';
+import { Permissions } from 'modules';
 import { Modals } from 'ui';
 import { ErrorEvent } from 'structs';
 import { ClientLogger as Logger } from 'common';
diff --git a/client/src/modules/reactcomponents.js b/client/src/modules/reactcomponents.js
index 5e4676fe..58473748 100644
--- a/client/src/modules/reactcomponents.js
+++ b/client/src/modules/reactcomponents.js
@@ -12,7 +12,7 @@
 
 import { Reflection } from 'ui';
 import { Filters, ClientLogger as Logger } from 'common';
-import { MonkeyPatch, Patcher } from './patcher';
+import { MonkeyPatch } from './patcher';
 import { WebpackModules } from './webpackmodules';
 import DiscordApi from './discordapi';
 
@@ -242,7 +242,7 @@ export class ReactComponents {
         });
     }
 
-    static setName(name, filter, callback) {
+    static setName(name, filter) {
         const have = this.components.find(c => c.id === name);
         if (have) return have;
 
@@ -260,7 +260,7 @@ export class ReactComponents {
         const have = this.unknownComponents.find(c => c.component === component);
         for (const [fi, filter] of this.nameSetters.entries()) {
             if (filter.filter.filter(component)) {
-                console.log('filter match!');
+                Logger.log('ReactComponents', 'Filter match!');
                 component.displayName = filter.name;
                 this.nameSetters.splice(fi, 1);
                 return this.push(component, retVal);
diff --git a/client/src/modules/settings.js b/client/src/modules/settings.js
index e9256b9d..9b539df2 100644
--- a/client/src/modules/settings.js
+++ b/client/src/modules/settings.js
@@ -9,8 +9,8 @@
 */
 
 import { EmoteModule } from 'builtin';
-import { SettingsSet, SettingUpdatedEvent } from 'structs';
-import { Utils, FileUtils, ClientLogger as Logger } from 'common';
+import { SettingsSet } from 'structs';
+import { FileUtils, ClientLogger as Logger } from 'common';
 import path from 'path';
 import Globals from './globals';
 import CssEditor from './csseditor';
diff --git a/client/src/modules/thememanager.js b/client/src/modules/thememanager.js
index 2ddf8bd8..4914cb05 100644
--- a/client/src/modules/thememanager.js
+++ b/client/src/modules/thememanager.js
@@ -10,8 +10,6 @@
 
 import ContentManager from './contentmanager';
 import Theme from './theme';
-import { FileUtils } from 'common';
-import path from 'path';
 
 export default class ThemeManager extends ContentManager {
 
@@ -116,8 +114,7 @@ export default class ThemeManager extends ContentManager {
      * @return {Promise}
      */
     static async parseSetting(setting) {
-        const { type, id, value } = setting;
-        const name = id.replace(/[^a-zA-Z0-9-]/g, '-').replace(/--/g, '-');
+        const name = setting.id.replace(/[^a-zA-Z0-9-]/g, '-').replace(/--/g, '-');
         const scss = await setting.toSCSS();
 
         if (scss) return [name, scss];
diff --git a/client/src/structs/settings/multiplechoiceoption.js b/client/src/structs/settings/multiplechoiceoption.js
index 3e583c91..217ab430 100644
--- a/client/src/structs/settings/multiplechoiceoption.js
+++ b/client/src/structs/settings/multiplechoiceoption.js
@@ -8,8 +8,6 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import { Utils } from 'common';
-
 export default class MultipleChoiceOption {
 
     constructor(args) {
diff --git a/client/src/structs/settings/setting.js b/client/src/structs/settings/setting.js
index de2ffcc4..286706f0 100644
--- a/client/src/structs/settings/setting.js
+++ b/client/src/structs/settings/setting.js
@@ -8,8 +8,6 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import { Utils } from 'common';
-
 import BoolSetting from './types/bool';
 import StringSetting from './types/text';
 import NumberSetting from './types/number';
diff --git a/client/src/structs/settings/settingsproxy.js b/client/src/structs/settings/settingsproxy.js
index 03541b68..d8de7720 100644
--- a/client/src/structs/settings/settingsproxy.js
+++ b/client/src/structs/settings/settingsproxy.js
@@ -10,7 +10,6 @@
 
 import SettingsSet from './settingsset';
 import SettingsCategory from './settingscategory';
-import Setting from './types/basesetting';
 
 const setHandler = {
     get({ set }, category_id) {
diff --git a/client/src/structs/settings/settingsset.js b/client/src/structs/settings/settingsset.js
index 465c2b3d..51aaba2c 100644
--- a/client/src/structs/settings/settingsset.js
+++ b/client/src/structs/settings/settingsset.js
@@ -365,7 +365,7 @@ export default class SettingsSet extends AsyncEventEmitter {
      * Merges a set into this set without emitting events (and therefore synchronously).
      * This only exists for use by the constructor.
      */
-    _merge(newSet, emit_multi = true) {
+    _merge(newSet) {
         let updatedSettings = [];
         // const categories = newSet instanceof Array ? newSet : newSet.settings;
         const categories = newSet && newSet.args ? newSet.args.settings : newSet ? newSet.settings : newSet;
diff --git a/client/src/structs/settings/types/custom.js b/client/src/structs/settings/types/custom.js
index 31c3effd..c632d53b 100644
--- a/client/src/structs/settings/types/custom.js
+++ b/client/src/structs/settings/types/custom.js
@@ -11,8 +11,6 @@
 import { Globals } from 'modules';
 import path from 'path';
 import Setting from './basesetting';
-import SettingsCategory from '../settingscategory';
-import SettingsScheme from '../settingsscheme';
 
 export default class CustomSetting extends Setting {
 
diff --git a/client/src/ui/bdui.js b/client/src/ui/bdui.js
index 658019f6..7ff68d9c 100644
--- a/client/src/ui/bdui.js
+++ b/client/src/ui/bdui.js
@@ -8,8 +8,7 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { Events, WebpackModules, DiscordApi, MonkeyPatch } from 'modules';
-import { Utils } from 'common';
+import { Events, DiscordApi } from 'modules';
 import { remote } from 'electron';
 import DOM from './dom';
 import Vue from './vue';
diff --git a/client/src/ui/modals.js b/client/src/ui/modals.js
index b963f765..370e977b 100644
--- a/client/src/ui/modals.js
+++ b/client/src/ui/modals.js
@@ -8,7 +8,7 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import { Utils, FileUtils, ClientLogger as Logger, AsyncEventEmitter } from 'common';
+import { ClientLogger as Logger, AsyncEventEmitter } from 'common';
 import { Settings, Events, PluginManager, ThemeManager } from 'modules';
 import BaseModal from './components/common/Modal.vue';
 import BasicModal from './components/bd/modals/BasicModal.vue';
diff --git a/client/src/ui/profilebadges.js b/client/src/ui/profilebadges.js
index 617f05dd..57cbf6d5 100644
--- a/client/src/ui/profilebadges.js
+++ b/client/src/ui/profilebadges.js
@@ -10,8 +10,7 @@
 
 import { Module, ReactComponents, ReactHelpers, MonkeyPatch, WebpackModules } from 'modules';
 import { Reflection } from 'ui';
-import { Utils, ClientLogger as Logger } from 'common';
-import DOM from './dom';
+import { ClientLogger as Logger } from 'common';
 import { BdBadge } from './components/bd';
 import VueInjector from './vueinjector';
 import contributors from '../data/contributors';
@@ -95,7 +94,6 @@ export default class extends Module {
     async patchNameTag() {
         if (this.PatchedNameTag) return this.PatchedNameTag;
 
-        const ProfileBadges = this;
         const selector = '.' + WebpackModules.getClassName('nameTag', 'username', 'discriminator', 'ownerIcon');
         const NameTag = await ReactComponents.getComponent('NameTag', { selector });
 
diff --git a/common/modules/async-eventemitter.js b/common/modules/async-eventemitter.js
index be173698..f5a8f2b4 100644
--- a/common/modules/async-eventemitter.js
+++ b/common/modules/async-eventemitter.js
@@ -11,7 +11,7 @@
 import EventEmitter from 'events';
 
 /**
- * Extends Node.js' EventEmitter to trigger event listeners asyncronously.
+ * Extends Node.js' EventEmitter to call event listeners asyncronously.
  */
 export default class AsyncEventEmitter extends EventEmitter {
 
@@ -42,7 +42,7 @@ export default class AsyncEventEmitter extends EventEmitter {
 
     /**
      * Adds an event listener that will be removed when it is called and therefore only be called once.
-     * If a callback is not specified a promise that is resolved once the event is triggered is returned.
+     * If a callback is not specified a promise that is resolved once the event is emitted is returned.
      */
     once(event, callback) {
         if (callback) {
@@ -50,7 +50,7 @@ export default class AsyncEventEmitter extends EventEmitter {
             return EventEmitter.prototype.once.apply(this, arguments);
         }
 
-        // Otherwise return a promise that is resolved once this event is triggered
+        // Otherwise return a promise that is resolved once this event is emitted
         return new Promise((resolve, reject) => {
             EventEmitter.prototype.once.call(this, event, data => {
                 return resolve(data);
diff --git a/common/modules/utils.js b/common/modules/utils.js
index b88abe08..508cf1fe 100644
--- a/common/modules/utils.js
+++ b/common/modules/utils.js
@@ -8,7 +8,6 @@
  * LICENSE file in the root directory of this source tree.
 */
 
-import path from 'path';
 import fs from 'fs';
 import _ from 'lodash';
 import filetype from 'file-type';
@@ -91,11 +90,7 @@ export class Utils {
      * @return {Any} The cloned value
      */
     static deepclone(value, exclude) {
-        try {
-            if (exclude && exclude(value)) return value;
-        } catch (err) {
-            console.error(arguments, err);
-        }
+        if (exclude && exclude(value)) return value;
 
         if (typeof value === 'object') {
             if (value instanceof Array) return value.map(i => this.deepclone(i, exclude));
diff --git a/core/src/main.js b/core/src/main.js
index 0cfe3c23..23a92132 100644
--- a/core/src/main.js
+++ b/core/src/main.js
@@ -183,7 +183,6 @@ export class BetterDiscord {
     }
 
     async waitForWindow() {
-        const self = this;
         return new Promise(resolve => {
             const defer = setInterval(() => {
                 const windows = BrowserWindow.getAllWindows();
diff --git a/core/src/modules/utils.js b/core/src/modules/utils.js
index 2a846926..ac793dce 100644
--- a/core/src/modules/utils.js
+++ b/core/src/modules/utils.js
@@ -10,7 +10,6 @@
 
 // TODO Use common
 
-import path from 'path';
 import fs from 'fs';
 
 import Module from './modulebase';