lesderid
/
salty-ircd
1
0
Fork 1
Code Issues 6 Pull Requests Releases Wiki Activity

Send error on invalid MODE operation (non-strict)

This commit is contained in:
Les De Ridder 2020-10-14 07:23:19 +02:00
parent f6eece74bf
commit a3f306b9ba
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
source/ircd/connection.d
View File

@ -1041,7 +1041,11 @@ class Connection
auto add = modeString[0] == '+'; auto add = modeString[0] == '+';
if (!add && modeString[0] != '-') if (!add && modeString[0] != '-')
{ {
//TODO: If RFC-strictness is off, send a malformed message error //NOTE: The RFCs don't specify what should happen on malformed mode operations
version (BasicFixes)
{
sendMalformedMessageError(message.command, "Invalid mode operation: " ~ modeString[0]);
}
continue; continue;
} }
@ -1053,7 +1057,7 @@ class Connection
auto changedModes = modeString[1 .. $]; auto changedModes = modeString[1 .. $];
foreach (mode; changedModes) foreach (mode; changedModes)
{ {
//when RFC-strictness is off, maybe send an error when trying to do an illegal change //TODO: If RFC-strictness is off, maybe send an error when trying to do an illegal change
switch (mode) switch (mode)
{ {
case 'i': case 'i':
@ -1132,7 +1136,11 @@ class Connection
auto add = modeString[0] == '+'; auto add = modeString[0] == '+';
if (!add && modeString[0] != '-') if (!add && modeString[0] != '-')
{ {
//TODO: If RFC-strictness is off, send a malformed message error //NOTE: The RFCs don't specify what should happen on malformed mode operations
version (BasicFixes)
{
sendMalformedMessageError(message.command, "Invalid mode operation: " ~ modeString[0]);
}
return; return;
} }
@ -1443,6 +1451,11 @@ class Connection
], true)); ], true));
} }
void sendMalformedMessageError(string command, string description)
{
send(Message(_server.name, "ERROR", [command, "Malformed message: " ~ description], true));
}
void sendWelcome() void sendWelcome()
{ {
send(Message(_server.name, "001", [ send(Message(_server.name, "001", [