From a8451d40c1a57236b858b463016bb81e7f61cad5 Mon Sep 17 00:00:00 2001 From: Les De Ridder Date: Fri, 10 Jul 2020 21:38:43 +0200 Subject: [PATCH] Remove psymtab stub Because we weren't fully setting up the psymtab, we ended up dereferencing invalid/null pointers when its functions were called. For now, we just deal with 'no symbols found' errors, because it's better than crashing. Fixes main issue in #2 --- gdb/pdb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/pdb.c b/gdb/pdb.c index 51e896a..a5ed08d 100644 --- a/gdb/pdb.c +++ b/gdb/pdb.c @@ -336,10 +336,6 @@ read_pdb (struct objfile *objfile, minimal_symbol_reader & reader) printf_filtered (_("Reading symbols from %s...\n"), pdb_path.c_str ()); - //TODO: Use this. For now, we allocate the symtab so we don't print we found no symbols. - auto psymtab = allocate_psymtab (objfile->original_name, objfile); - (void) psymtab; - it = r_list_iterator (gsym_data_stream->globals_list); while (r_list_iter_next (it)) {