Commit Graph

5278 Commits

Author SHA1 Message Date
Thomas Goyne eee4da0642 Change the selection before committing deletions of lines
For whatever reason this was sometimes being done after the commit,
which resulted in a lot of code only working by coincidence when the
grid commit handler happened to be the first one to be called.
2013-10-27 07:03:51 -07:00
Thomas Goyne 2f14c395e7 Preserve line current length in Duplicate and Shift
It's quite rare to actually want a multi-frame line followed by a
single-frame line; in most cases they're either all a single frame (in
which case this behaves the same as it always has), or they're all
multi-line, in which case this should be more convenient.
2013-10-26 08:44:16 -07:00
Thomas Goyne 1f04d02c1b Fix check for script yuv matrix matching video yuv matrix 2013-10-25 16:31:56 -07:00
Thomas Goyne f275ed5628 Update the manual URL now that the 3.1 manual partially exists 2013-10-25 14:10:33 -07:00
Thomas Goyne 5f63a3fcce Remove the help/files command
The local docs it tries to open don't actually exists and if they're
ever added, the help contents command opens them anyway so I'm not sure
what the intended purpose of the command ever was.
2013-10-25 14:09:42 -07:00
Thomas Goyne 3a852f102d Remove entirely superfluous doxygen comments in commands 2013-10-25 14:03:35 -07:00
Thomas Goyne 51d516979b Improve some help text for commands
Consistently use the imperative mood and expand some overly terse help
messages.
2013-10-25 13:54:20 -07:00
Thomas Goyne c5e30709a6 Add a command to cycle between subtitle providers 2013-10-24 14:32:49 -07:00
Thomas Goyne 879ef35bd4 Add missing include 2013-10-24 13:17:53 -07:00
Thomas Goyne e737ea415d Fix compilation with UTF-8 wxString 2013-10-24 13:16:13 -07:00
Thomas Goyne 50f92ef573 Actually uudecode attachments when extracting them
Closes #1653.
2013-10-24 09:00:42 -07:00
Thomas Goyne b1ecefe0f2 Remove pointless data member (CID #739030) 2013-10-23 17:08:27 -07:00
Thomas Goyne 01a38a5e86 Use more make_unique
Shuts up a bunch of Coverity false-positives and might fix a true
positive or two.
2013-10-23 17:08:12 -07:00
Thomas Goyne da5445a09f Fix incorrect scope of variable in mkv_wrap.cpp
Worked by coincidence since the required value was left on the stack.

CID #1111282.
2013-10-23 17:08:12 -07:00
Thomas Goyne 9936bf0eca Initialize drop when loading timecodes (CID #1111295) 2013-10-23 17:08:12 -07:00
Thomas Goyne 09a3174cb8 Initialize more stuff in OpenALPlayer's constructor (CID #1111296) 2013-10-23 17:08:11 -07:00
Thomas Goyne 0e2cc0938f Strongly bind global lua functions used in the standard modules 2013-10-22 08:55:04 -07:00
Thomas Goyne 8367f9960c Eliminate warnings with VS2012 + Win8 SDK 2013-10-22 07:45:23 -07:00
Thomas Goyne d3247d16fb Pass -mmacosx-version-min=10.7 to more stuff 2013-10-21 18:12:42 -07:00
Thomas Goyne 535a17bcf2 Remove pointess OSX_ prefix from functions 2013-10-21 18:11:37 -07:00
Thomas Goyne cbff449f8f Put config files in the right place on OS X 2013-10-21 18:09:34 -07:00
Thomas Goyne eeb574b1f9 Fix dmg creation on 10.9 2013-10-17 10:08:27 -07:00
Thomas Goyne 2640dc42a1 Fix EBU STL export 2013-10-17 09:43:44 -07:00
Thomas Goyne 73e1dc1b60 Honor the color matrix tag from the subtitles file when appropriate
If the script's matrix matches the video's matrix, use that even if
Force BT.601 is on, and if it's TV.601, use that even if Force BT.601 is
off.

This should mostly eliminate the common problems resulting from  mixed
values of the Force BT.601 option.

Closes #1649.
2013-10-17 08:04:03 -07:00
Thomas Goyne 4116f030af Clean up factory_manager a bit 2013-10-16 18:08:43 -07:00
Thomas Goyne 7bd1da7d45 Fix saving screenshots of dummy video 2013-10-16 17:29:03 -07:00
Thomas Goyne e57035c832 Lock aspect ratio in the scale tool when alt is held down 2013-10-16 16:41:21 -07:00
Thomas Goyne b254a6823b Fix double confirmation when exiting with unsaved changes
For some reason the close event is getting sent multiple times and
them getting processed in the event loop for the confirmation dialog,
resulting in two dialogs.
2013-10-16 16:41:04 -07:00
Thomas Goyne 9ea3dbd847 Make ffmpeg explicitly depend on zlib 2013-10-16 14:04:42 -07:00
Thomas Goyne 9dbca06179 Actually copy the current value in IntValidator's copy constructor 2013-10-15 16:02:25 -07:00
Thomas Goyne d4a7a1a9b6 Build osx-bundle-restart-helper via the Makefile rather than as part of bundle creation 2013-10-15 12:17:47 -07:00
Thomas Goyne ebd01c50c9 Rewrite NumValidator
Split int validating and double validating into two separate classes.

Make double parsing, validating and stringifying locale-aware. This is
far more complicated than it needs to be due to that Aegisub's locale
handling is a total mess.

Use DoubleValidator rather than wxFloatingPointValidator, because the
latter doesn't work with Aegisub's locale mess (on OS X it uses the C
locale for some things, and the locale reported by CoreFoundation for
others).

Closes #1568.
2013-10-15 10:59:23 -07:00
Thomas Goyne 3691849bac Fix logging on OS X
Passing nullptr to ostrstream's constructor is a nonstandard extension
that libc++ doesn't support, and as it turns out preallocating a buffer
doesn't actually meaningfully improve performance anyway.
2013-10-13 09:06:46 -07:00
Thomas Goyne 82412e6428 Fix compilation with UTF-8 wxString 2013-10-12 08:41:37 -07:00
Thomas Goyne e5faae462f Remove some pointless configure checks
Speeds up configure by about 10%.
2013-10-11 18:45:22 -07:00
Thomas Goyne 267de7ed07 Fix crash when the video height or width is zero
Closes #1555. Closes #1644.
2013-10-08 15:21:26 -07:00
Thomas Goyne 4d8adff9d6 Build wx with wxStandardPaths enabled
It's still needed to get the path to the executable when restarting to
switch UI languages.
2013-10-08 07:33:01 -07:00
Thomas Goyne 6694baf3f0 Allow using , as the separator in time edit controls 2013-10-08 07:19:56 -07:00
Thomas Goyne 7a6fd4bb1e Make saving transient UI state in the file optional
It significantly increases the amount of noise when tracking subtitle
files in source control.

Closes #1535.
2013-10-07 17:57:16 -07:00
Thomas Goyne 1cdd461023 Separate UI state info from functional ASS info headers a bit
Prefix script info entries that are just storing Aegisub UI state with
"Aegisub ", and use a separate AssFile method to get/set them.
2013-10-07 17:57:16 -07:00
Thomas Goyne 62114d45f5 Fix reading MicroDVD files 2013-10-06 07:37:35 -07:00
Thomas Goyne 822c596206 Fix overriding charset for subtitle files
IconvWrapper needs the non-lowercased charset for the pretty -> real
name mapping to work.
2013-10-06 07:11:53 -07:00
Thomas Goyne 6f79d8731f Pass the detected or chosen charset to SubtitleFormat::CanReadFile
The MicroDVD format needs it since it also probes the file contents.
2013-10-06 07:04:40 -07:00
Thomas Goyne 73b0f7c88c Add support for Windows 7's taskbar progress indicator 2013-10-05 20:12:35 -07:00
Thomas Goyne 216b5ef0c7 Increase maximum template depth for parser.o
The latest version of clang has reduced the default.
2013-10-05 20:12:34 -07:00
Thomas Goyne 91c31f646e Opt out of AppNap while progress bars are active 2013-10-05 20:12:34 -07:00
Thomas Goyne 9a21c13cbe Use agi::scoped_holder to close files in mkvwrap 2013-10-05 15:41:22 -07:00
Thomas Goyne bbd4cbef78 Fix shifting contiguous selections downward
Reverse iterators behave differently from regular iterators when
swapping (regular iterators continue to point at the same elements,
while reverse iterators do not), so instead use regular iterators with a
negative step for shifting down.
2013-09-30 17:01:15 -07:00
Thomas Goyne 921d5ed01a Only paint the margin values in the grid if they're non-zero
Showing zero is mildly misleading since it's actually default margin
rather than no margin, and this makes it much easier to spot the rows
where there's actually an interesting value.
2013-09-27 18:02:54 -07:00
Thomas Goyne 04435a13a3 Remove some unused AudioPlayer methods 2013-09-26 20:31:20 -07:00
Thomas Goyne 703b1fc3a7 Extract common stuff for wrapper audio providers to a base class 2013-09-26 20:18:29 -07:00
Thomas Goyne 07ad40dd3f Improve audio loading progress reporting
Even without the animation the reported progress was an average of 1.5
blocks behind the actual progress, and with the animation it was two
blocks behind. Assuming constant-speed audio decoding it should now be
nearly accurate (it still ignores that the last block may be smaller
than the rest).
2013-09-26 19:01:18 -07:00
Thomas Goyne 932747e70a Make progress bars less jerky 2013-09-26 16:13:32 -07:00
Thomas Goyne 382708132c Update indexing progress less often
wxTheApp->QueueEvent is sufficiently slow that updating the progress
could sometimes take longer than the actual indexing.
2013-09-26 16:13:24 -07:00
Thomas Goyne a28aafcdab Fix crash when cancelling an automation script 2013-09-24 07:45:50 -07:00
Thomas Goyne 7651e83314 Fix setting selection/active line from automation scripts
The error handling function is under the results of the called function,
not at the top of the stack, so lua_pop was removing the wrong thing.
2013-09-23 14:15:45 -07:00
Thomas Goyne 260b37ba8e Fix line numbers for moonscript files in error messages 2013-09-22 18:44:03 -07:00
Thomas Goyne 646e5deb52 Canonicalize Automation script file names for nicer errors 2013-09-22 17:40:27 -07:00
Thomas Goyne 2be9218560 Double the size of the Automation log window 2013-09-21 16:20:19 -07:00
Thomas Goyne 32990fce49 Don't try to add stack traces to non-string errors 2013-09-21 16:12:19 -07:00
Thomas Goyne ec7d75d1ae Fix an occasional crash when loading Automation scripts
cmd::reg and AssExportFilterChain::Register are not thread-safe, so
guard them with a mutex.
2013-09-21 15:59:28 -07:00
Thomas Goyne f1ed0e4313 Fix display of automation errors on startup
The wxLogger isn't created until it's needed by the main thread, so any
errors logged on a background thread before the logger was first used on
the main thread were simply being discarded. Fix this by forcing the
creation of the logger very early in the startup process.
2013-09-21 12:52:11 -07:00
Thomas Goyne ced3dd7a7e Improve error reporting when an automation script fails to load
Cut down on the amount of redundant information displayed so that the
actual error is visible.
2013-09-21 12:10:37 -07:00
Thomas Goyne 1a8fbf35f1 Improve lua stack trace display 2013-09-21 11:22:58 -07:00
Thomas Goyne 8fade74026 Actually trim whitespace when combining lines
regex_replace does not mutate the string in place.
2013-09-21 11:21:25 -07:00
Thomas Goyne e315ceb236 Print the stack trace on lua errors 2013-09-21 09:44:44 -07:00
Thomas Goyne d81e2f45ac Add an option to ignore whitespace for the character counter 2013-09-20 07:43:33 -07:00
Thomas Goyne ac09590389 Devirtualize OptionValue::GetName 2013-09-20 06:51:04 -07:00
Thomas Goyne bd88cde436 Remove agi::OptionValue::GetDefault*
They aren't actually used for much of anything.
2013-09-20 06:51:04 -07:00
Thomas Goyne cb549e5aa9 Significantly speed up dragging lots of vector clip control points 2013-09-18 16:18:38 -07:00
Thomas Goyne 8d5a54ff5e Fix crash when smoothing freehand curves 2013-09-18 15:59:01 -07:00
Thomas Goyne 6a6c983f19 Add box selection to the move mode of the vector clip tool
Closes #1404.
2013-09-18 15:52:48 -07:00
Thomas Goyne c62ebf7e8b Use std::to_wstring rather than wxString::Format("%d", ...)
std::to_wstring is significantly faster and is a bit shorter.
2013-09-18 08:32:30 -07:00
Thomas Goyne 64ecd29169 Switch to using an intrusive list for the visual tool features
Slightly improves performance and eliminates a bunch of really clunky
passing around and storing of iterators.
2013-09-17 16:23:36 -07:00
Thomas Goyne b4ba31fe45 Bump dependency versions 2013-09-17 09:09:57 -07:00
Thomas Goyne 6cd6ee9845 Use auto more places 2013-09-17 07:51:07 -07:00
Thomas Goyne 0d50820178 Clean up BaseGrid a little 2013-09-17 07:51:06 -07:00
Thomas Goyne e5afaf8a45 Handle subtitle lines pasted into the edit box
If the text being pasted can be parsed as ASS dialogue events, then do
so even if the edit box is focused since it's rather unlikely that
the user actually wants ASS subtitle events in their subs.
2013-09-16 11:02:20 -07:00
Thomas Goyne 5787ca4ae0 Cache widths of strings in SetColumnWidths 2013-09-16 10:43:56 -07:00
Thomas Goyne 079ccc728d Significantly speed up resizing the window with large files open
SetColumnWidths can take a long time to run and the only column that can
change width on resize is the last one, so only update that.
2013-09-16 10:26:41 -07:00
Thomas Goyne bb89378b7f Skip empty lines in the kanji timer 2013-09-16 09:43:57 -07:00
Thomas Goyne 98048c135a Shut up clang analyzer warning 2013-09-16 08:40:27 -07:00
Thomas Goyne e72e183f27 Remove incorrect ! in check for changed calltip position 2013-09-16 07:58:06 -07:00
Thomas Goyne af2028e971 Pass unique_ptrs around by value 2013-09-16 06:43:17 -07:00
Thomas Goyne 40a0d8b2f7 Actually delete the lines in AssFile's destructor 2013-09-15 16:58:04 -07:00
Thomas Goyne bfc7f56e20 Only go back one line rather than two 2013-09-15 15:37:49 -07:00
Thomas Goyne 80c9f67ce8 Rewrite the auto-matcher for the karaoke timing copier
Operate on characters rather than bytes in the dialog so that it
actually works with Kanji.

Rewrite the auto-matcher to handle more cases and add unit tests for it.
2013-09-15 14:52:16 -07:00
Thomas Goyne 3e3bd37a26 Switch to using Bind for DialogKanjiTimer events 2013-09-14 08:26:59 -07:00
Thomas Goyne 1d7334c129 Disable the wxGTK accelerator workaround for wx 2.9.5
Unsurprisingly the munging around with the menu bar implementation
details has resulted in things breaking, but fortunately the problem it
was working around (#1314) appears to have been fixed entirely.

Closes #1628.
2013-09-01 13:34:53 -07:00
Thomas Goyne 2a35763a8a Add Backspace to the table of key names. Closes #1631. 2013-09-01 12:27:42 -07:00
Thomas Goyne 51b21576cc Support duplicate order numbers in Matroska files
Such files are pretty broken, but apparently other stuff allows it.
2013-08-26 17:25:26 -07:00
Thomas Goyne f427c4574d Revert "Don't invert horizontal scroll on the audio display on OS X"
This has been fixed upstream.
2013-08-20 12:20:37 -07:00
Thomas Goyne 0b210673f9 Zoom into the mouse's position in the audio display
Rather than pinning the time at the center of the audio display, pin the
time at the mouse's position since that's the area the user probably
cares about. If the mouse is not over the audio display (such as if the
user is adjusting the zoom via the sliders rather than the mouse wheel),
just use the center as it used to.
2013-08-20 12:11:39 -07:00
Thomas Goyne 1f5b98b11d Bump ffmpeg and boost versions 2013-08-19 12:51:19 -07:00
Thomas Goyne 6c5adde19a Fix wx compilation and silence a warning when compiling wx 2013-08-19 12:51:19 -07:00
Maxime Gauduin 0a2c0ab75e wxStandardPaths is protected as of wxgtk 2.9.5
Closes #1625, #1626, #1627.
2013-08-18 19:14:53 -07:00
Thomas Goyne ae9f05d876 "Allow grid to take focus" -> "Focus grid on click"
The grid can still be focused via the keyboard, so the previous label
was misleading.
2013-08-17 15:10:17 -07:00
Thomas Goyne f714d60a54 Build parser.cpp first
Shaves a few seconds off parallel builds with 4+ cores by avoiding
having everything else finish while it's still building.
2013-08-17 15:08:58 -07:00
Thomas Goyne b68578f1d9 Eliminate a bogus limit of 100 for a bunch of rarely-used options 2013-08-17 15:06:07 -07:00
Thomas Goyne dd6542c143 Use ForwardMouseWheelEvent rather than checking window bounds 2013-08-14 20:09:10 -07:00