10a11ce0cc
Fixed some of the larger memory leaks in the LibassSubtitlesProvider detected by valgrind
...
Originally committed to SVN as r2970.
2009-05-22 04:09:09 +00:00
17f0e664f0
Initialize a variable in the audio display that sometimes was used without any initial value being assigned to it.
...
Originally committed to SVN as r2969.
2009-05-22 02:27:36 +00:00
ef4021f757
Make error handling in DSound2 audio player more robust. When an error happened in the playback thread, the error_happened flag was set, but was never cleared when the error was detected in the main thread. Furthermore, the main thread didn't act upon the error besides showing it, it kept acting as if the playback thread was still alive and playing, causing the error to be triggered continuously requiring you to kill Aegisub to get out.
...
Made the error_happened event reset itself after being checked so the check only succeeds the first time. (The playback thread returns from its threadproc upon error.) Mark playback thread as dead when error is detected, such that a new thread will be created next time playback is started, effectively making errors non-fatal.
Playback still works as expected, however I haven't tested what actually happens now when an error occurs.
Originally committed to SVN as r2968.
2009-05-22 01:41:31 +00:00
bceabf4848
Fixed some mismatched new[]/deletes in the audio display detected by valgrind
...
Originally committed to SVN as r2967.
2009-05-22 00:05:25 +00:00
fff437ea19
Fixed a memory leak in the CSRISubtitlesProvider
...
Originally committed to SVN as r2966.
2009-05-21 23:02:34 +00:00
b4a5032b2e
Fixed some memory leaks in the kanji timer
...
Originally committed to SVN as r2965.
2009-05-21 22:57:43 +00:00
ecc4b618b3
Fixed a memory leak in the style manager, the storage of catalog styles was never being cleared when closed.
...
Originally committed to SVN as r2964.
2009-05-21 22:24:52 +00:00
acf2f5fa40
Fixed some memory leaks in the style manager detected by valgrind
...
Originally committed to SVN as r2963.
2009-05-21 22:15:32 +00:00
68d2681193
Fixed a memory leak in the dummy video provider detected by valgrind. The video frame was being allocated but never deallocated.
...
Originally committed to SVN as r2962.
2009-05-21 19:49:23 +00:00
350d9e5db7
Fixed some memory leaks in the translation assistant detected by valgrind
...
Originally committed to SVN as r2961.
2009-05-21 18:37:36 +00:00
dd1c706d5c
FFMS2: More ICL warning inspired fixes
...
Originally committed to SVN as r2960.
2009-05-21 10:39:14 +00:00
ccf24ae3af
FFMS2: ICL compilation fix
...
Originally committed to SVN as r2959.
2009-05-21 10:05:53 +00:00
cb698b5c3f
FFMS2: Another small typo after all the changes
...
Originally committed to SVN as r2957.
2009-05-20 22:40:55 +00:00
67e9033899
FFMS2: Missing #ifdef
...
Originally committed to SVN as r2956.
2009-05-20 19:05:42 +00:00
34c50c8cd9
FFMS2:
...
Split indexing into a 2 step process so track numbers/types become known in advance
Big code cleanup and renaming
Originally committed to SVN as r2955.
2009-05-20 18:57:03 +00:00
083e2ee91c
Initialized a variable that was being used before it was assigned an initial value
...
Originally committed to SVN as r2954.
2009-05-20 18:29:01 +00:00
5bdcf2f63a
Update #742 , attempt fixing the bug. Removing wxEXPAND from some sizers, seems to work fine on Windows. Will test Mac build when tinderbox builds it.
...
Originally committed to SVN as r2953.
2009-05-18 23:37:41 +00:00
6f0c5e6489
* Fixed some more memory leaks reported by valgrind and msvc by reimplementing a couple of singleton pattern based classes
...
* Fixed a memory leak that occurred from never deleting a wxBitmap allocated in OpenGLTextGlyph
Originally committed to SVN as r2952.
2009-05-18 05:51:37 +00:00
392fbdfa4d
Fix a bunch of memory leaks reported by valgrind and msvc about the registered factories never being cleared.
...
Originally committed to SVN as r2951.
2009-05-18 05:42:54 +00:00
9891c28977
Add a corresponding PopEventHandler call for each PushEventHandler call, this fixes a couple of memory leaks reported by valgrind and msvc.
...
Originally committed to SVN as r2950.
2009-05-18 05:33:49 +00:00
f1bfb947cf
Call TestDestroy() to ensure we can delete the FontsCollectorThread, fixes #561
...
Originally committed to SVN as r2949.
2009-05-18 05:24:07 +00:00
5717f81ef2
Update FFMS2 providers to account for FFMS2 API change in last commit.
...
Also update ffms2.lib to corresponding version.
Originally committed to SVN as r2948.
2009-05-17 22:12:46 +00:00
cd8d965324
FFMS2:
...
Some more API cleanup
General cleanup
Originally committed to SVN as r2947.
2009-05-17 22:02:43 +00:00
8195d36ee5
Update Japanese translation.
...
Originally committed to SVN as r2946.
2009-05-17 15:17:52 +00:00
008f7f3853
Prevent an out of range exception from being thrown. (was commonly being thrown when commit was used on the last row of the grid)
...
Originally committed to SVN as r2945.
2009-05-17 05:47:28 +00:00
ef407b6e68
Make FFmpegSource video and audio providers build again after FFMS2 changes last night.
...
Originally committed to SVN as r2944.
2009-05-16 12:47:23 +00:00
7fcfaa5dc6
Updated ffms2.lib.
...
Originally committed to SVN as r2943.
2009-05-16 12:46:50 +00:00
a312985f36
Split video backend and UI into separate groups in MSVC project file.
...
Originally committed to SVN as r2942.
2009-05-16 12:46:22 +00:00
0b583dcd0d
As required by r2940 supply -DFFMS_EXPORTS when building the library.
...
Originally committed to SVN as r2941.
2009-05-16 12:13:27 +00:00
ab8f6e6239
FFMS2:
...
Rename lots of things, THIS BREAKS THE AEGISUB BUILD because of changed exported type and function names.
Fixed an uninitialized memory bug that would make it crash on unindexed audio tracks in mastroska.
Made ffms.h C-friendlier.
Exports the start time of an audio track in the audio properties.
Less signedness and type conversion warnings.
Originally committed to SVN as r2940.
2009-05-15 23:11:18 +00:00
f6bd6df490
Hack to fix #687 , if playing to end of audio, changing the selection end shouldn't affect the playback end: it should still play to end of audio.
...
Originally committed to SVN as r2939.
2009-05-15 15:23:34 +00:00
a6c7a8a724
Apply Plorkyeran's patch to close #843 .
...
Originally committed to SVN as r2938.
2009-05-15 12:44:36 +00:00
5bb56ae5d4
Fix gcc breakage caused by last commit, and remove an unused variable while at it.
...
Originally committed to SVN as r2937.
2009-05-15 12:31:09 +00:00
a3cd374bc0
Add a bit of sanity checking to FractionalTime.
...
Originally committed to SVN as r2936.
2009-05-15 12:18:33 +00:00
1520e51dd0
Fixed Replace Next not marking the script as modified.
...
Originally committed to SVN as r2935.
2009-05-15 02:50:43 +00:00
988df0ab81
Fix #809 , properly close all SRT overrides during export and ensure overrides in recombined lines do not affect each other (per the example I gave in the report.)
...
Originally committed to SVN as r2934.
2009-05-15 01:34:00 +00:00
44e17e9e11
Converting audio provider didn't know about channel count during bitdepth and samplerate conversion and intermixed samples from channels and more, resulting in garbage output. Fixes #726 .
...
Originally committed to SVN as r2933.
2009-05-15 00:48:43 +00:00
863d89ba4f
aegisub_endian.h was missing from MSVC project.
...
Originally committed to SVN as r2932.
2009-05-14 23:58:24 +00:00
8ca726119f
Fix #825 for good, I hope. Get some sense worked into the handling of AssEntry::StartMS and AssDialogue::Start using some private members and virtual getter/setter functions.
...
Originally committed to SVN as r2931.
2009-05-14 23:45:20 +00:00
fb6280b2e7
More const correctness in AssTime, broke build because I forgot to add const keyword to implementation too.
...
Originally committed to SVN as r2930.
2009-05-14 23:27:38 +00:00
3977fff411
Const correctness in AssTime.
...
Originally committed to SVN as r2929.
2009-05-14 23:09:04 +00:00
4e417a6dae
Change audio autoscroll behaviour:
...
* In karaoke mode, instead of scrolling start to end of active line into view, scroll start of selection to end of line into view. This gives sensible results when horizontal zoom is great enough that the entire line isn't visible at once and the syllable is too far from the start of the line. This fixes #677 .
* If the line is too long to fit in the display, always left-align it instead of sometimes left-aligning and sometimes centering. (I think the old behaviour depended on the actual scroll position.)
Originally committed to SVN as r2928.
2009-05-14 22:12:05 +00:00
84b068b53a
Undo last change, code *was* used after all. Strangely my compiler didn't complain on first try...
...
Removing the comment about "is this even used?" as well...
Originally committed to SVN as r2927.
2009-05-14 21:44:43 +00:00
cab268c9bb
Remove some unused code from karaoke UI.
...
Originally committed to SVN as r2926.
2009-05-14 21:26:39 +00:00
523421300d
Split audio sources in MSVC project into Backend and UI groups.
...
Originally committed to SVN as r2925.
2009-05-14 21:25:08 +00:00
1cc280216c
* Fixed a mismatched new[]/delete
...
* Fixed a memory leak that would occur when loading subtitles from a matroska file
Originally committed to SVN as r2924.
2009-05-14 18:28:57 +00:00
ce15bc55bc
* Fixed the styling assistant marking the script as modified when it was unfocused and the Enable preview checkbox was unchecked even if no changes actually were made in the styling assistant.
...
* Removed some no longer needed code in the styling assistant.
Originally committed to SVN as r2923.
2009-05-14 17:29:07 +00:00
2acf887157
Fix #845 by counting how many output lines were produced by applying a template to a line, instead of assuming that a template always gets applied, even if it's a code template.
...
Originally committed to SVN as r2922.
2009-05-14 15:34:37 +00:00
f4808b82a0
Made the styling assistant modeless so the user can access other controls within aegisub without having to close the styling assistant, fixes #397
...
Originally committed to SVN as r2921.
2009-05-14 07:02:01 +00:00
ffa5a2021d
- Reworked the SMPTE timecode handling with Plorkyeran's help. It does now handle dropframe timecodes as well; the ms->SMPTE handling has been tested and seems reasonably correct, while the reverse conversion remains untested and unused. The Adobe Encore export filter will now use dropframe timecodes properly (previously it would play pretend with wallclock hours/minutes/seconds and incorrect frame numbers).
...
- Changed the SubtitleFormat::AskForFPS dialog box; removed the "PAL/NTSC only" choice and added a "show SMPTE dropframe" parameter instead. Also added 50fps as a choice.
- While I was at it, reworked the TranStation export filter so it actually looks ahead to see if the next line will overlap with the current, and if so, move the end time of the current line backwards one frame, which fixes #767
Originally committed to SVN as r2920.
2009-05-13 20:24:21 +00:00
harukalover