iqbalrifai
/
Aegisub
mirror of https://github.com/odrling/Aegisub
1
0
Fork 0
Code Issues Releases Wiki Activity

Always use change_value for setting spin ctrls in the color picker 

With wxCocoa the change events from SetValue are processed immediately,
resulting in significant breakage as in some cases multiple spin
controls need to be set at once. Even on other platforms where things
appeared to work due to the change notifications being delayed, they
still didn't do anything useful and slowed updates down slightly.

Originally committed to SVN as r6787.
This commit is contained in:
Thomas Goyne 2012-05-15 13:39:45 +00:00
parent ad64e8e48a
commit 5b9ba0205a
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
aegisub/src/dialog_colorpicker.cpp
View File

@ -1173,24 +1173,24 @@ void DialogColorPicker::OnSpectrumChange(wxCommandEvent &)
int i = colorspace_choice->GetSelection();
switch (i) {
case 0:
rgb_input[2]->SetValue(spectrum->GetX());
rgb_input[1]->SetValue(spectrum->GetY());
change_value(rgb_input[2], spectrum->GetX());
change_value(rgb_input[1], spectrum->GetY());
break;
case 1:
rgb_input[2]->SetValue(spectrum->GetX());
rgb_input[0]->SetValue(spectrum->GetY());
change_value(rgb_input[2], spectrum->GetX());
change_value(rgb_input[0], spectrum->GetY());
break;
case 2:
rgb_input[1]->SetValue(spectrum->GetX());
rgb_input[0]->SetValue(spectrum->GetY());
change_value(rgb_input[1], spectrum->GetX());
change_value(rgb_input[0], spectrum->GetY());
break;
case 3:
hsl_input[1]->SetValue(spectrum->GetX());
hsl_input[0]->SetValue(spectrum->GetY());
change_value(hsl_input[1], spectrum->GetX());
change_value(hsl_input[0], spectrum->GetY());
break;
case 4:
hsv_input[1]->SetValue(spectrum->GetX());
hsv_input[2]->SetValue(spectrum->GetY());
change_value(hsv_input[1], spectrum->GetX());
change_value(hsv_input[2], spectrum->GetY());
break;
}
@ -1213,15 +1213,15 @@ void DialogColorPicker::OnSliderChange(wxCommandEvent &)
int i = colorspace_choice->GetSelection();
switch (i) {
case 0: case 1: case 2:
rgb_input[i]->SetValue(slider->GetY());
change_value(rgb_input[i], slider->GetY());
UpdateFromRGB(false);
break;
case 3:
hsl_input[2]->SetValue(slider->GetY());
change_value(hsl_input[2], slider->GetY());
UpdateFromHSL(false);
break;
case 4:
hsv_input[0]->SetValue(slider->GetY());
change_value(hsv_input[0], slider->GetY());
UpdateFromHSV(false);
break;
}