iqbalrifai
/
Aegisub
mirror of https://github.com/odrling/Aegisub
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove pointless explicit empty constructors from OptionValue base classes 

Originally committed to SVN as r5813.
This commit is contained in:
Thomas Goyne 2011-11-04 19:42:04 +00:00
parent 723d3b9780
commit 579203989b
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
aegisub/libaegisub/include/libaegisub/option_value.h
View File

@ -56,7 +56,6 @@ protected:
} }
public: public:
OptionValue() {};
virtual ~OptionValue() {}; virtual ~OptionValue() {};
@ -148,9 +147,6 @@ CONFIG_OPTIONVALUE(Bool, bool)
class OptionValueList: public OptionValue { class OptionValueList: public OptionValue {
friend class ConfigVisitor; friend class ConfigVisitor;
protected:
OptionValueList() {};
virtual ~OptionValueList() {};
virtual void InsertString(const std::string val) { throw ListTypeError("string", " insert "); } virtual void InsertString(const std::string val) { throw ListTypeError("string", " insert "); }
virtual void InsertInt(const int64_t val) { throw ListTypeError("int", " insert "); } virtual void InsertInt(const int64_t val) { throw ListTypeError("int", " insert "); }
virtual void InsertDouble(const double val) { throw ListTypeError("double", " insert "); } virtual void InsertDouble(const double val) { throw ListTypeError("double", " insert "); }
@ -169,7 +165,7 @@ protected:
virtual std::string GetString() const { return "";} \ virtual std::string GetString() const { return "";} \
OptionValueList##type_name(std::string member_name): name(member_name) {} \ OptionValueList##type_name(std::string member_name): name(member_name) {} \
void GetList##type_name(std::vector<type> &out) const { out = array; } \ void GetList##type_name(std::vector<type> &out) const { out = array; } \
void SetList##type_name(const std::vector<type>& val) { array = val; NotifyChanged(); } \ void SetList##type_name(const std::vector<type>& val) { array = val; NotifyChanged(); } \
void GetDefaultList##type_name(std::vector<type> &out) const { out = array_default; } \ void GetDefaultList##type_name(std::vector<type> &out) const { out = array_default; } \
OptionType GetType() const { return OptionValue::Type_List_##type_name; } \ OptionType GetType() const { return OptionValue::Type_List_##type_name; } \
std::string GetName() const { return name; } \ std::string GetName() const { return name; } \