From b697ad6ca0ec7c7df87884e2e65cf719ca58b91e Mon Sep 17 00:00:00 2001 From: arch1t3cht Date: Wed, 17 Aug 2022 02:54:09 +0200 Subject: [PATCH 1/2] Remove access checks in windows fs operations These were giving false negatives on samba shares, which broke the font collector. Windows also recommends to not use access checks in these cases, and instead just see if the operations succeeds or not. --- libaegisub/windows/fs.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/libaegisub/windows/fs.cpp b/libaegisub/windows/fs.cpp index 8102c6ee3..f626407e2 100644 --- a/libaegisub/windows/fs.cpp +++ b/libaegisub/windows/fs.cpp @@ -60,9 +60,7 @@ void Touch(path const& file) { } void Copy(fs::path const& from, fs::path const& to) { - acs::CheckFileRead(from); CreateDirectory(to.parent_path()); - acs::CheckDirWrite(to.parent_path()); if (!CopyFile(from.wstring().c_str(), to.wstring().c_str(), false)) { switch (GetLastError()) { From 1e958cd1a1b7d564a983e2fa224b30f0381b4228 Mon Sep 17 00:00:00 2001 From: arch1t3cht Date: Wed, 17 Aug 2022 02:59:15 +0200 Subject: [PATCH 2/2] Typo fix --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 95a453820..09459ba1b 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ The `cibuilds` branch makes some CI builds of snapshots of `feature` at relevant - [`color_picker_fix2`](https://github.com/arch1t3cht/Aegisub/tree/color_picker_fix2): Add an option (under "Interface") to restrict the color picker to the window, which fixes the color picker on Linux in a lot of cases. - [`avisynth`](https://github.com/arch1t3cht/Aegisub/tree/avisynth): Reenable Avisynth support on Windows and enable Avisynth on Linux - [`bestsource`](https://github.com/arch1t3cht/Aegisub/tree/bestsource): Add BestSource audio and video source. This source is slower than others by multiple orders of magnitude, but in exchange it can guarantee exact seeking. -- [`vapoursynth`](https://github.com/arch1t3cht/Aegisub/tree/vapourssynth): Add Vapoursynth audio and video source +- [`vapoursynth`](https://github.com/arch1t3cht/Aegisub/tree/vapoursynth): Add Vapoursynth audio and video source - [`bugfixes`](https://github.com/arch1t3cht/Aegisub/tree/bugfixes): Various fixes necessary for compilation. Most branches are based on this. - [`fixes`](https://github.com/arch1t3cht/Aegisub/tree/fixes): Miscellaneous bugfixes - [`misc_dc`](https://github.com/arch1t3cht/Aegisub/tree/misc_dc): Miscellaneous changes taken from AegisubDC