Remove pointless empty destructors

An explicit empty destructor is only needed when a class has a smart
pointer to an incomplete type.
This commit is contained in:
Thomas Goyne 2012-12-11 09:06:21 -08:00
parent 9a77d564e4
commit 0b133de08f
12 changed files with 1 additions and 44 deletions

View File

@ -49,9 +49,6 @@ enum AssBlockType {
BLOCK_DRAWING BLOCK_DRAWING
}; };
class AssOverrideParameter;
class AssOverrideTag;
std::size_t hash_value(wxString const& s); std::size_t hash_value(wxString const& s);
/// @class AssDialogueBlock /// @class AssDialogueBlock
@ -104,7 +101,6 @@ public:
class AssDialogueBlockOverride : public AssDialogueBlock { class AssDialogueBlockOverride : public AssDialogueBlock {
public: public:
AssDialogueBlockOverride(wxString const& text = wxString()) : AssDialogueBlock(text) { } AssDialogueBlockOverride(wxString const& text = wxString()) : AssDialogueBlock(text) { }
~AssDialogueBlockOverride();
std::vector<AssOverrideTag> Tags; std::vector<AssOverrideTag> Tags;

View File

@ -57,9 +57,6 @@ AssExporter::AssExporter(agi::Context *c)
{ {
} }
AssExporter::~AssExporter () {
}
void AssExporter::DrawSettings(wxWindow *parent, wxSizer *target_sizer) { void AssExporter::DrawSettings(wxWindow *parent, wxSizer *target_sizer) {
is_default = false; is_default = false;
for (auto filter : *AssExportFilterChain::GetFilterList()) { for (auto filter : *AssExportFilterChain::GetFilterList()) {

View File

@ -63,7 +63,6 @@ class AssExporter {
public: public:
AssExporter(agi::Context *c); AssExporter(agi::Context *c);
~AssExporter();
/// Get the names of all registered export filters /// Get the names of all registered export filters
wxArrayString GetAllFilterNames() const; wxArrayString GetAllFilterNames() const;

View File

@ -423,9 +423,6 @@ void parse_parameters(AssOverrideTag *tag, const wxString &text, AssOverrideTagP
} }
// From ass_dialogue.h // From ass_dialogue.h
AssDialogueBlockOverride::~AssDialogueBlockOverride() {
}
void AssDialogueBlockOverride::ParseTags() { void AssDialogueBlockOverride::ParseTags() {
Tags.clear(); Tags.clear();

View File

@ -137,8 +137,6 @@ AudioBox::AudioBox(wxWindow *parent, agi::Context *context)
audioDisplay->SetAmplitudeScale(pow(mid(1, VerticalZoom->GetValue(), 100) / 50.0, 3)); audioDisplay->SetAmplitudeScale(pow(mid(1, VerticalZoom->GetValue(), 100) / 50.0, 3));
} }
AudioBox::~AudioBox() { }
BEGIN_EVENT_TABLE(AudioBox,wxSashWindow) BEGIN_EVENT_TABLE(AudioBox,wxSashWindow)
EVT_COMMAND_SCROLL(Audio_Horizontal_Zoom, AudioBox::OnHorizontalZoom) EVT_COMMAND_SCROLL(Audio_Horizontal_Zoom, AudioBox::OnHorizontalZoom)
EVT_COMMAND_SCROLL(Audio_Vertical_Zoom, AudioBox::OnVerticalZoom) EVT_COMMAND_SCROLL(Audio_Vertical_Zoom, AudioBox::OnVerticalZoom)

View File

@ -86,7 +86,6 @@ class AudioBox : public wxSashWindow {
public: public:
AudioBox(wxWindow *parent, agi::Context *context); AudioBox(wxWindow *parent, agi::Context *context);
~AudioBox();
void ShowKaraokeBar(bool show); void ShowKaraokeBar(bool show);

View File

@ -91,10 +91,6 @@ AudioRenderer::AudioRenderer()
SetHeight(1); SetHeight(1);
} }
AudioRenderer::~AudioRenderer()
{
}
void AudioRenderer::SetMillisecondsPerPixel(double new_pixel_ms) void AudioRenderer::SetMillisecondsPerPixel(double new_pixel_ms)
{ {
if (pixel_ms == new_pixel_ms) return; if (pixel_ms == new_pixel_ms) return;

View File

@ -143,12 +143,6 @@ public:
/// provider must be set before the audio renderer is functional. /// provider must be set before the audio renderer is functional.
AudioRenderer(); AudioRenderer();
/// @brief Destructor
///
/// Only destroys internal data, audio provider and bitmap providers are
/// owned by the consumer of audio rendering.
~AudioRenderer();
/// @brief Set horizontal zoom /// @brief Set horizontal zoom
/// @param pixel_ms Milliseconds per pixel to render audio at /// @param pixel_ms Milliseconds per pixel to render audio at
/// ///

View File

@ -32,9 +32,6 @@
/// @ingroup configuration_ui /// @ingroup configuration_ui
/// ///
////////////
// Includes
#include "config.h" #include "config.h"
#include <wx/button.h> #include <wx/button.h>
@ -49,10 +46,6 @@
#include "libresrc/libresrc.h" #include "libresrc/libresrc.h"
#include "version.h" #include "version.h"
/// @brief Constructor
/// @param parent Parent frame.
///
AboutScreen::AboutScreen(wxWindow *parent) AboutScreen::AboutScreen(wxWindow *parent)
: wxDialog (parent, -1, _("About Aegisub"), wxDefaultPosition, wxDefaultSize, wxCAPTION | wxCLOSE_BOX , _("About Aegisub")) : wxDialog (parent, -1, _("About Aegisub"), wxDefaultPosition, wxDefaultSize, wxCAPTION | wxCLOSE_BOX , _("About Aegisub"))
{ {
@ -157,11 +150,3 @@ AboutScreen::AboutScreen(wxWindow *parent)
SetSizerAndFit(MainSizer); SetSizerAndFit(MainSizer);
CentreOnParent(); CentreOnParent();
} }
/// @brief Destructor
///
AboutScreen::~AboutScreen () {
}

View File

@ -39,5 +39,4 @@
class AboutScreen: public wxDialog { class AboutScreen: public wxDialog {
public: public:
AboutScreen(wxWindow *parent); AboutScreen(wxWindow *parent);
~AboutScreen();
}; };

View File

@ -69,9 +69,6 @@ VisualToolBase::VisualToolBase(VideoDisplay *parent, agi::Context *context)
parent->Bind(wxEVT_MOUSE_CAPTURE_LOST, &VisualToolBase::OnMouseCaptureLost, this); parent->Bind(wxEVT_MOUSE_CAPTURE_LOST, &VisualToolBase::OnMouseCaptureLost, this);
} }
VisualToolBase::~VisualToolBase() {
}
void VisualToolBase::OnCommit(int type) { void VisualToolBase::OnCommit(int type) {
holding = false; holding = false;
dragging = false; dragging = false;

View File

@ -151,7 +151,7 @@ public:
virtual void Draw()=0; virtual void Draw()=0;
virtual void SetDisplayArea(int x, int y, int w, int h); virtual void SetDisplayArea(int x, int y, int w, int h);
virtual void SetToolbar(wxToolBar *) { } virtual void SetToolbar(wxToolBar *) { }
virtual ~VisualToolBase(); virtual ~VisualToolBase() { }
}; };
/// Visual tool base class containing all common feature-related functionality /// Visual tool base class containing all common feature-related functionality