mirror of https://github.com/odrling/Aegisub
Remove pointless empty destructors
An explicit empty destructor is only needed when a class has a smart pointer to an incomplete type.
This commit is contained in:
parent
9a77d564e4
commit
0b133de08f
|
@ -49,9 +49,6 @@ enum AssBlockType {
|
|||
BLOCK_DRAWING
|
||||
};
|
||||
|
||||
class AssOverrideParameter;
|
||||
class AssOverrideTag;
|
||||
|
||||
std::size_t hash_value(wxString const& s);
|
||||
|
||||
/// @class AssDialogueBlock
|
||||
|
@ -104,7 +101,6 @@ public:
|
|||
class AssDialogueBlockOverride : public AssDialogueBlock {
|
||||
public:
|
||||
AssDialogueBlockOverride(wxString const& text = wxString()) : AssDialogueBlock(text) { }
|
||||
~AssDialogueBlockOverride();
|
||||
|
||||
std::vector<AssOverrideTag> Tags;
|
||||
|
||||
|
|
|
@ -57,9 +57,6 @@ AssExporter::AssExporter(agi::Context *c)
|
|||
{
|
||||
}
|
||||
|
||||
AssExporter::~AssExporter () {
|
||||
}
|
||||
|
||||
void AssExporter::DrawSettings(wxWindow *parent, wxSizer *target_sizer) {
|
||||
is_default = false;
|
||||
for (auto filter : *AssExportFilterChain::GetFilterList()) {
|
||||
|
|
|
@ -63,7 +63,6 @@ class AssExporter {
|
|||
|
||||
public:
|
||||
AssExporter(agi::Context *c);
|
||||
~AssExporter();
|
||||
|
||||
/// Get the names of all registered export filters
|
||||
wxArrayString GetAllFilterNames() const;
|
||||
|
|
|
@ -423,9 +423,6 @@ void parse_parameters(AssOverrideTag *tag, const wxString &text, AssOverrideTagP
|
|||
}
|
||||
|
||||
// From ass_dialogue.h
|
||||
AssDialogueBlockOverride::~AssDialogueBlockOverride() {
|
||||
}
|
||||
|
||||
void AssDialogueBlockOverride::ParseTags() {
|
||||
Tags.clear();
|
||||
|
||||
|
|
|
@ -137,8 +137,6 @@ AudioBox::AudioBox(wxWindow *parent, agi::Context *context)
|
|||
audioDisplay->SetAmplitudeScale(pow(mid(1, VerticalZoom->GetValue(), 100) / 50.0, 3));
|
||||
}
|
||||
|
||||
AudioBox::~AudioBox() { }
|
||||
|
||||
BEGIN_EVENT_TABLE(AudioBox,wxSashWindow)
|
||||
EVT_COMMAND_SCROLL(Audio_Horizontal_Zoom, AudioBox::OnHorizontalZoom)
|
||||
EVT_COMMAND_SCROLL(Audio_Vertical_Zoom, AudioBox::OnVerticalZoom)
|
||||
|
|
|
@ -86,7 +86,6 @@ class AudioBox : public wxSashWindow {
|
|||
|
||||
public:
|
||||
AudioBox(wxWindow *parent, agi::Context *context);
|
||||
~AudioBox();
|
||||
|
||||
void ShowKaraokeBar(bool show);
|
||||
|
||||
|
|
|
@ -91,10 +91,6 @@ AudioRenderer::AudioRenderer()
|
|||
SetHeight(1);
|
||||
}
|
||||
|
||||
AudioRenderer::~AudioRenderer()
|
||||
{
|
||||
}
|
||||
|
||||
void AudioRenderer::SetMillisecondsPerPixel(double new_pixel_ms)
|
||||
{
|
||||
if (pixel_ms == new_pixel_ms) return;
|
||||
|
|
|
@ -143,12 +143,6 @@ public:
|
|||
/// provider must be set before the audio renderer is functional.
|
||||
AudioRenderer();
|
||||
|
||||
/// @brief Destructor
|
||||
///
|
||||
/// Only destroys internal data, audio provider and bitmap providers are
|
||||
/// owned by the consumer of audio rendering.
|
||||
~AudioRenderer();
|
||||
|
||||
/// @brief Set horizontal zoom
|
||||
/// @param pixel_ms Milliseconds per pixel to render audio at
|
||||
///
|
||||
|
|
|
@ -32,9 +32,6 @@
|
|||
/// @ingroup configuration_ui
|
||||
///
|
||||
|
||||
|
||||
////////////
|
||||
// Includes
|
||||
#include "config.h"
|
||||
|
||||
#include <wx/button.h>
|
||||
|
@ -49,10 +46,6 @@
|
|||
#include "libresrc/libresrc.h"
|
||||
#include "version.h"
|
||||
|
||||
|
||||
/// @brief Constructor
|
||||
/// @param parent Parent frame.
|
||||
///
|
||||
AboutScreen::AboutScreen(wxWindow *parent)
|
||||
: wxDialog (parent, -1, _("About Aegisub"), wxDefaultPosition, wxDefaultSize, wxCAPTION | wxCLOSE_BOX , _("About Aegisub"))
|
||||
{
|
||||
|
@ -157,11 +150,3 @@ AboutScreen::AboutScreen(wxWindow *parent)
|
|||
SetSizerAndFit(MainSizer);
|
||||
CentreOnParent();
|
||||
}
|
||||
|
||||
|
||||
/// @brief Destructor
|
||||
///
|
||||
AboutScreen::~AboutScreen () {
|
||||
}
|
||||
|
||||
|
||||
|
|
|
@ -39,5 +39,4 @@
|
|||
class AboutScreen: public wxDialog {
|
||||
public:
|
||||
AboutScreen(wxWindow *parent);
|
||||
~AboutScreen();
|
||||
};
|
||||
|
|
|
@ -69,9 +69,6 @@ VisualToolBase::VisualToolBase(VideoDisplay *parent, agi::Context *context)
|
|||
parent->Bind(wxEVT_MOUSE_CAPTURE_LOST, &VisualToolBase::OnMouseCaptureLost, this);
|
||||
}
|
||||
|
||||
VisualToolBase::~VisualToolBase() {
|
||||
}
|
||||
|
||||
void VisualToolBase::OnCommit(int type) {
|
||||
holding = false;
|
||||
dragging = false;
|
||||
|
|
|
@ -151,7 +151,7 @@ public:
|
|||
virtual void Draw()=0;
|
||||
virtual void SetDisplayArea(int x, int y, int w, int h);
|
||||
virtual void SetToolbar(wxToolBar *) { }
|
||||
virtual ~VisualToolBase();
|
||||
virtual ~VisualToolBase() { }
|
||||
};
|
||||
|
||||
/// Visual tool base class containing all common feature-related functionality
|
||||
|
|
Loading…
Reference in New Issue