From 4580537537817fb6f1f4d50927979eab987bdd2a Mon Sep 17 00:00:00 2001
From: muxator <a.mux@inwind.it>
Date: Fri, 20 Jul 2018 23:58:47 +0200
Subject: [PATCH] tests: fix frontend tests on firefox

These changes make the frontend tests send keydown instead of keypress in
firefox, in accordance with #3413 (Use keydown instead of keypress on Firefox).

The percentage of passing frontend in Firefox 61 on this revision is 100%.
---
 tests/frontend/specs/bold.js                      |  2 +-
 tests/frontend/specs/indentation.js               |  4 ++--
 tests/frontend/specs/italic.js                    |  2 +-
 tests/frontend/specs/ordered_list.js              |  2 +-
 tests/frontend/specs/scroll.js                    |  2 +-
 tests/frontend/specs/select_formatting_buttons.js |  2 +-
 tests/frontend/specs/undo.js                      | 10 +++++-----
 7 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/frontend/specs/bold.js b/tests/frontend/specs/bold.js
index b54466e4..888eb660 100644
--- a/tests/frontend/specs/bold.js
+++ b/tests/frontend/specs/bold.js
@@ -44,7 +44,7 @@ describe("bold button", function(){
     //select this text element
     $firstTextElement.sendkeys('{selectall}');
 
-    if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE){ // if it's a mozilla or IE 
+    if(inner$(window)[0].bowser.modernIE){ // if it's IE
       var evtType = "keypress";
     }else{
       var evtType = "keydown";
diff --git a/tests/frontend/specs/indentation.js b/tests/frontend/specs/indentation.js
index 9294cefb..dd12fc31 100644
--- a/tests/frontend/specs/indentation.js
+++ b/tests/frontend/specs/indentation.js
@@ -15,7 +15,7 @@ describe("indentation button", function(){
     //select this text element
     $firstTextElement.sendkeys('{selectall}');
 
-    if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE){ // if it's a mozilla or IE
+    if(inner$(window)[0].bowser.modernIE){ // if it's IE
       var evtType = "keypress";
     }else{
       var evtType = "keydown";
@@ -325,7 +325,7 @@ describe("indentation button", function(){
 
 function pressEnter(){
   var inner$ = helper.padInner$;
-  if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE){ // if it's a mozilla or IE
+  if(inner$(window)[0].bowser.modernIE){ // if it's IE
     var evtType = "keypress";
   }else{
     var evtType = "keydown";
diff --git a/tests/frontend/specs/italic.js b/tests/frontend/specs/italic.js
index bf7f2bc6..cecbc180 100644
--- a/tests/frontend/specs/italic.js
+++ b/tests/frontend/specs/italic.js
@@ -44,7 +44,7 @@ describe("italic some text", function(){
     //select this text element
     $firstTextElement.sendkeys('{selectall}');
 
-    if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE){ // if it's a mozilla or IE  
+    if(inner$(window)[0].bowser.modernIE){ // if it's IE
       var evtType = "keypress";
     }else{
       var evtType = "keydown";
diff --git a/tests/frontend/specs/ordered_list.js b/tests/frontend/specs/ordered_list.js
index 57196fef..e7509e88 100644
--- a/tests/frontend/specs/ordered_list.js
+++ b/tests/frontend/specs/ordered_list.js
@@ -111,7 +111,7 @@ describe("assign ordered list", function(){
 
   var triggerCtrlShiftShortcut = function(shortcutChar) {
     var inner$ = helper.padInner$;
-    if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE) { // if it's a mozilla or IE
+    if(inner$(window)[0].bowser.modernIE) { // if it's IE
       var evtType = "keypress";
     }else{
       var evtType = "keydown";
diff --git a/tests/frontend/specs/scroll.js b/tests/frontend/specs/scroll.js
index 096b06b6..94756b85 100644
--- a/tests/frontend/specs/scroll.js
+++ b/tests/frontend/specs/scroll.js
@@ -513,7 +513,7 @@ describe('scroll when focus line is out of viewport', function () {
   var pressKey = function(keyCode, shiftIsPressed){
     var inner$ = helper.padInner$;
     var evtType;
-    if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE){ // if it's a mozilla or IE
+    if(inner$(window)[0].bowser.modernIE){ // if it's IE
       evtType = 'keypress';
     }else{
       evtType = 'keydown';
diff --git a/tests/frontend/specs/select_formatting_buttons.js b/tests/frontend/specs/select_formatting_buttons.js
index 5fb97600..b6ec6d0c 100644
--- a/tests/frontend/specs/select_formatting_buttons.js
+++ b/tests/frontend/specs/select_formatting_buttons.js
@@ -88,7 +88,7 @@ describe("select formatting buttons when selection has style applied", function(
     //select this text element
     $firstTextElement.sendkeys('{selectall}');
 
-    if(inner$(window)[0].bowser.firefox || inner$(window)[0].bowser.modernIE){ // if it's a mozilla or IE
+    if(inner$(window)[0].bowser.modernIE){ // if it's IE
       var evtType = "keypress";
     }else{
       var evtType = "keydown";
diff --git a/tests/frontend/specs/undo.js b/tests/frontend/specs/undo.js
index b8b7c785..3644734f 100644
--- a/tests/frontend/specs/undo.js
+++ b/tests/frontend/specs/undo.js
@@ -44,11 +44,11 @@ describe("undo button", function(){
     var modifiedValue = $firstTextElement.text(); // get the modified value
     expect(modifiedValue).not.to.be(originalValue); // expect the value to change
 
-    if(inner$(window)[0].bowser.firefox){ // if it's a mozilla browser
-      var evtType = "keypress";
-    }else{
-      var evtType = "keydown";
-    }
+    /*
+     * ACHTUNG: this is the only place in the test codebase in which a keydown
+     * is sent for IE. Everywhere else IE uses keypress.
+     */
+    var evtType = "keydown";
 
     var e = inner$.Event(evtType);
     e.ctrlKey = true; // Control key