fuwafuwa
/
etherpad-lite
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

handle auth fails

This commit is contained in:
John McLear 2014-11-26 17:34:44 +00:00
parent 88b3d99fbd
commit 16f3ebb3ba
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/node/handler/APIHandler.js
View File

@ -450,6 +450,7 @@ exports.handle = function(apiVersion, functionName, fields, req, res)
if(fields["apikey"] != apikey.trim())
{
res.statusCode = 401;
res.send({code: 4, message: "no or wrong API Key", data: null});
return;
}

7
tests/backend/specs/api.js
View File

@ -34,10 +34,9 @@ describe('Permission', function(){
it('errors if can connect without correct APIKey', function(done) {
// This is broken because Etherpad doesn't handle HTTP codes properly see #2343
// If your APIKey is password you deserve to fail all tests anyway
throw new Error("Erroring anyway just because the API seems broken here");
api.get('/api/'+apiVersion+'/createPad&apikey=password&padID=test')
.expect('Content-Type', /json/)
.expect(200, done)
var permErrorURL = '/api/'+apiVersion+'/createPad?apikey=password&padID=test';
api.get(permErrorURL)
.expect(401, done)
});
})