fuwafuwa
/
etherpad-lite
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

The pad name sanitizer shouldn't drop query params. issue #779

This commit is contained in:
Jordan Hollinger 2012-06-13 15:48:58 -04:00
parent b599cdf6e5
commit 08a00af617
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/node/hooks/express/padurlsanitize.js
View File

@ -1,4 +1,5 @@
var padManager = require('../../db/PadManager'); var padManager = require('../../db/PadManager');
var url = require('url');
exports.expressCreateServer = function (hook_name, args, cb) { exports.expressCreateServer = function (hook_name, args, cb) {
//redirects browser to the pad's sanitized url if needed. otherwise, renders the html //redirects browser to the pad's sanitized url if needed. otherwise, renders the html
@ -14,9 +15,11 @@ exports.expressCreateServer = function (hook_name, args, cb) {
//the pad id was sanitized, so we redirect to the sanitized version //the pad id was sanitized, so we redirect to the sanitized version
if(sanitizedPadId != padId) if(sanitizedPadId != padId)
{ {
var real_path = req.path.replace(/^\/p\/[^\/]+/, '/p/' + sanitizedPadId); var real_url = req.url.replace(/^\/p\/[^\/]+/, '/p/' + sanitizedPadId);
res.header('Location', real_path); var query = url.parse(req.url).query;
res.send('You should be redirected to <a href="' + real_path + '">' + real_path + '</a>', 302); if ( query ) real_url += '?' + query;
res.header('Location', real_url);
res.send('You should be redirected to <a href="' + real_url + '">' + real_url + '</a>', 302);
} }
//the pad id was fine, so just render it //the pad id was fine, so just render it
else else