From 03c2b3102f7378f26e2d943305b0628a42ab4cd2 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 23 May 2018 11:51:07 +0200 Subject: [PATCH 1/4] PR template ## Problem - *The template is hardly used by contributors unless they're part of Apps group.* ## Solution - *Add an automatic template for all PR* ## PR Status Could be reviewed and tested. ## Validation --- *Minor decision* - [ ] **Code review** : - [ ] **Approval (LGTM)** : - [ ] **Approval (LGTM)** : When the PR is mark as ready to merge, you have to wait for 3 days before really merge it. --- pull_request_template.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..91aa307 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,23 @@ +## Problem +- *Description of why you made this PR* + +## Solution +- *And how you fix that* + +## PR Status +*Obviously, you should really check these affirmations* +Work finished. Package_check, basic tests and upgrade from last version OK. +Could be reviewed and tested. + +## Validation +--- +*Minor decision* +- **Upgrade previous version** : +- [ ] **Code review** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- **CI succeeded** : +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20-BRANCH-%20(Official)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20-BRANCH-%20(Official)/) *Please replace '-BRANCH-' in this link for a PR from a local branch.* +or +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20PR-NUM-%20(Official_fork)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20PR-NUM-%20(Official_fork)/) *Replace '-NUM-' by the PR number in this link for a PR from a forked repository.* +When the PR is mark as ready to merge, you have to wait for 3 days before really merge it. From c0130d0a40bf5e94f1d2f0bed5a8f1aa057fa6db Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 23 May 2018 12:45:32 +0200 Subject: [PATCH 2/4] Add checkboxes for status --- pull_request_template.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 91aa307..2f48c04 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -5,9 +5,11 @@ - *And how you fix that* ## PR Status -*Obviously, you should really check these affirmations* -Work finished. Package_check, basic tests and upgrade from last version OK. -Could be reviewed and tested. +- [ ] Work finished. +- [ ] Tested with Package_check. +- [ ] Fix or enhancement tested. +- [ ] Upgrade from last version tested. +- [ ] Can be reviewed and tested. ## Validation --- From 22d624093c497ba0c5c057ff249c941ed67ab952 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Wed, 23 May 2018 13:40:38 +0200 Subject: [PATCH 3/4] Typo fix --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 2f48c04..82fcea3 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -22,4 +22,4 @@ [![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20-BRANCH-%20(Official)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20-BRANCH-%20(Official)/) *Please replace '-BRANCH-' in this link for a PR from a local branch.* or [![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20PR-NUM-%20(Official_fork)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/searx_ynh%20PR-NUM-%20(Official_fork)/) *Replace '-NUM-' by the PR number in this link for a PR from a forked repository.* -When the PR is mark as ready to merge, you have to wait for 3 days before really merge it. +When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. From 70954ec24c4dc11bc499fc6cda68b397ec0a22d8 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 23 May 2018 17:53:30 +0200 Subject: [PATCH 4/4] Replace work by code. --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 82fcea3..5f38ab0 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -5,7 +5,7 @@ - *And how you fix that* ## PR Status -- [ ] Work finished. +- [ ] Code finished. - [ ] Tested with Package_check. - [ ] Fix or enhancement tested. - [ ] Upgrade from last version tested.