Tidying

src/freedombone

@@ -473,7 +473,6 @@ function interactive_configuration {
   fi
 
   freedombone-config \
-      -u $MY_USERNAME \
       -f $CONFIGURATION_FILE \
       -w $FREEDOMBONE_WEBSITE \
       -b $FREEDOMBONE_BITMESSAGE \
@@ -501,13 +500,11 @@ function interactive_configuration {
 if [[ $1 == "menuconfig" ]]; then
   interactive_configuration
 else
+  while [[ $# > 1 ]]
+  do
+  key="$1"
 
-# Oddly it appears that command line parsing cannot be done inside of a function
-while [[ $# > 1 ]]
-do
-key="$1"
-
-case $key in
+  case $key in
     -h|--help)
     show_help
     ;;
@@ -648,9 +645,9 @@ case $key in
     *)
     # unknown option
     ;;
-esac
-shift
-done
+  esac
+  shift
+  done
 fi
 
 function parse_args {

src/freedombone-config

@@ -136,14 +136,13 @@ function save_configuration_file {
 
   echo "MY_USERNAME=$MY_USERNAME" > $CONFIGURATION_FILE
   echo "DOMAIN_NAME=$DOMAIN_NAME" >> $CONFIGURATION_FILE
-  echo "MY_EMAIL_ADDRESS=$MY_EMAIL_ADDRESS" >> $CONFIGURATION_FILE
   echo "SYSTEM_TYPE=$SYSTEM_TYPE" >> $CONFIGURATION_FILE
   echo "INSTALLING_ON_BBB=$INSTALLING_ON_BBB" >> $CONFIGURATION_FILE
   echo "DDNS_PROVIDER=$DDNS_PROVIDER" >> $CONFIGURATION_FILE
   echo "DDNS_USERNAME=$DDNS_USERNAME" >> $CONFIGURATION_FILE
-  # does this need to be saved?
   echo "DDNS_PASSWORD=$DDNS_PASSWORD" >> $CONFIGURATION_FILE
   echo "MY_NAME=$MY_NAME" >> $CONFIGURATION_FILE
+  echo "MY_EMAIL_ADDRESS=$MY_EMAIL_ADDRESS" >> $CONFIGURATION_FILE
   echo "LOCAL_NETWORK_STATIC_IP_ADDRESS=$LOCAL_NETWORK_STATIC_IP_ADDRESS" >> $CONFIGURATION_FILE
   echo "ROUTER_IP_ADDRESS=$ROUTER_IP_ADDRESS" >> $CONFIGURATION_FILE
   echo "ENABLE_CJDNS=$ENABLE_CJDNS" >> $CONFIGURATION_FILE