From 7b61ac3ddf0bfe660266e70fc7c10f048758698f Mon Sep 17 00:00:00 2001 From: net Date: Wed, 15 Oct 2014 06:46:47 +0300 Subject: [PATCH 1/2] Fix #2310. Play by the 8tracks rules --- youtube_dl/extractor/eighttracks.py | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/youtube_dl/extractor/eighttracks.py b/youtube_dl/extractor/eighttracks.py index c1b4c729e..101a09699 100644 --- a/youtube_dl/extractor/eighttracks.py +++ b/youtube_dl/extractor/eighttracks.py @@ -4,10 +4,12 @@ from __future__ import unicode_literals import json import random import re +import time from .common import InfoExtractor from ..utils import ( compat_str, + ExtractorError, ) @@ -112,14 +114,30 @@ class EightTracksIE(InfoExtractor): session = str(random.randint(0, 1000000000)) mix_id = data['id'] track_count = data['tracks_count'] + duration = data['duration'] + avg_song_duration = duration / track_count first_url = 'http://8tracks.com/sets/%s/play?player=sm&mix_id=%s&format=jsonh' % (session, mix_id) next_url = first_url entries = [] + for i in range(track_count): - api_json = self._download_webpage( - next_url, playlist_id, - note='Downloading song information %d/%d' % (i + 1, track_count), - errnote='Failed to download song information') + + api_json = None + download_tries = 0 + + while api_json is None: + try: + api_json = self._download_webpage( + next_url, playlist_id, + note='Downloading song information %d/%d' % (i + 1, track_count), + errnote='Failed to download song information') + except ExtractorError: + if download_tries > 3: + raise + else: + ++download_tries + time.sleep(avg_song_duration) + api_data = json.loads(api_json) track_data = api_data['set']['track'] info = { @@ -131,6 +149,7 @@ class EightTracksIE(InfoExtractor): 'ext': 'm4a', } entries.append(info) + next_url = 'http://8tracks.com/sets/%s/next?player=sm&mix_id=%s&format=jsonh&track_id=%s' % ( session, mix_id, track_data['id']) return { From 754f0008ec6b87316ce3e4807f150726ff2af3c5 Mon Sep 17 00:00:00 2001 From: netanel Date: Sat, 6 Dec 2014 09:20:35 +0200 Subject: [PATCH 2/2] fix increment operator --- youtube_dl/extractor/eighttracks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/youtube_dl/extractor/eighttracks.py b/youtube_dl/extractor/eighttracks.py index 101a09699..f093592a8 100644 --- a/youtube_dl/extractor/eighttracks.py +++ b/youtube_dl/extractor/eighttracks.py @@ -135,7 +135,7 @@ class EightTracksIE(InfoExtractor): if download_tries > 3: raise else: - ++download_tries + download_tries += 1 time.sleep(avg_song_duration) api_data = json.loads(api_json)