albino/ngircd-tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

conn.c: fix NumConnections imbalance

Browse Source 
New_Server() can call Conn_Close() in its error paths,
but that function decrements the number of current active
connections. Thus we need to increment it earlier.
This commit is contained in:
Florian Westphal 2009-05-17 21:32:53 +02:00
parent 8e2c5816ee
commit 9b1c47220f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ngircd/conn.c
View File

@ -1696,6 +1696,8 @@ New_Server( int Server , ng_ipaddr_t *dest)
return; return;
} }
/* Conn_Close() decrements this counter again */
NumConnections++;
Client_SetIntroducer( c, c ); Client_SetIntroducer( c, c );
Client_SetToken( c, TOKEN_OUTBOUND ); Client_SetToken( c, TOKEN_OUTBOUND );
@ -1725,7 +1727,6 @@ New_Server( int Server , ng_ipaddr_t *dest)
return; return;
} }
#endif #endif
NumConnections++;
LogDebug("Registered new connection %d on socket %d (%ld in total).", LogDebug("Registered new connection %d on socket %d (%ld in total).",
new_sock, My_Connections[new_sock].sock, NumConnections); new_sock, My_Connections[new_sock].sock, NumConnections);
Conn_OPTION_ADD( &My_Connections[new_sock], CONN_ISCONNECTING ); Conn_OPTION_ADD( &My_Connections[new_sock], CONN_ISCONNECTING );