Commit Graph

3564 Commits

Author SHA1 Message Date
Nikolay Sivov ae3f25cc44 msi: Fixed same file handle closed twice (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-11 19:54:12 +09:00
Thomas Faber 689f048497 msi: Use the intended attributes when overwriting the target file in cabinet_copy_file.
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:08:41 +01:00
Sergey Isakov 88a96478c3 msi/tests: Simplify the logic in an if condition.
Signed-off-by: Sergey Isakov <isakov-sl@bk.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-27 20:53:22 +09:00
Hugh McMaster 11669fa5e2 Assorted spelling and grammar fixes.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
Dmitry Timoshkov 2ee784e624 msi: Make sure to reset the 'in_quotes' state in all cases.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 21:11:05 +09:00
Dmitry Timoshkov 2d7f00c8d3 Revert "msi: Correctly parse double quotes in the token value.".
This reverts commit 42caac841e.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 21:10:59 +09:00
Nikolay Sivov fe8ecc23aa msi/tests: Add missing return value test (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-28 12:45:04 +09:00
Nikolay Sivov 2257928a7a msi: Use VARIANT_BOOL values consistently for VT_BOOL type (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:19:51 +09:00
Gerald Pfeifer 40922ccd4f msi: Avoid shift overflow in msi_view_get_row.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:32 +09:00
Dmitry Timoshkov 6b9a87c7a8 msi: Add a trace to msi_get_property.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:58 +09:00
Dmitry Timoshkov 42caac841e msi: Correctly parse double quotes in the token value.
This fixes an installer that passes to InstallProduct a command line like
PROPERTY1="Installing ""Product name"" version 8.0" PROPERTY2=1 PROPERTY3=1
In this case properties PROPERTY2 and PROPERTY3 were not recognized and that
led to an installation failure when a custom action didn't see them as set.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:38 +09:00
Dmitry Timoshkov 1b3087e79f msi/tests: Add a test for MsiInstallProduct with command line containing double quotes inside of the property.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:32 +09:00
Hans Leidekker 9a5788afc1 msi: Set the PrimaryVolumeSpaceRequired and PrimaryVolumeSpaceRemaining properties.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
2015-10-01 16:23:15 +09:00
Hans Leidekker 100c043e89 msi/tests: Fix a test failure on Ultimate editions.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
2015-09-25 21:02:52 +02:00
Akihiro Sagawa 6e51cfddfd msi: Feature treeview should have WS_TABSTOP style. 2015-09-14 16:47:52 +09:00
Piotr Caban f326e372d1 msi/tests: Fix MsiProvideQualifiedComponent test failure. 2015-09-14 16:19:27 +09:00
Piotr Caban e8f4fea5a0 msi: Check HKLM/Software/Classes/Installer/Components path while looking for components. 2015-09-09 18:26:32 +09:00
Hans Leidekker fca92ae67c msi/tests: Avoid test failures when running as an unprivileged user. 2015-09-07 18:52:14 +09:00
Jacek Caban d8f79a037c msi: Fixed varg0 leak in InstallerImpl_SummaryInformation. 2015-09-01 15:23:53 +09:00
Hans Leidekker d3ce29449b msi: Implement Installer::SummaryInformation. 2015-08-26 23:15:26 +09:00
Hans Leidekker ddaba7a369 msi: Don't add the same environment string more than once. 2015-08-26 23:15:26 +09:00
Dmitry Timoshkov 2ad9312f02 msi: Avoid using dialog record after free. 2015-08-18 19:57:11 +09:00
Hans Leidekker 99dfc15e72 msi: Only remove environment strings that were added on install. 2015-08-18 17:30:17 +09:00
Hans Leidekker 7834983541 msi/tests: Mark a test result on win2k3 as broken. 2015-07-17 20:19:41 +09:00
Huw Davies fed41f5306 msi: Don't call CloseServiceHandle() with an invalid handle. 2015-07-16 21:20:50 +09:00
Hans Leidekker dfae842cca msi/tests: Avoid another test failure on win2k3. 2015-07-15 23:19:32 +09:00
Hans Leidekker 0bd46f1501 msi: Add a stub implementation of MsiJoinTransaction. 2015-07-15 23:19:29 +09:00
Hans Leidekker f9dc20cfcc msi: Fix a couple of memory leaks (Coverity). 2015-07-15 23:19:25 +09:00
Hans Leidekker 17405f6b91 msi: Check the return value of MSI_QueryGetRecord (Coverity). 2015-07-15 23:19:23 +09:00
Huw Davies e1a65bed68 msi: Be more selective about which access modes are used to open or create keys.
An installer was failing when trying to create subkeys after denying
delete access to their parent key.
2015-07-15 23:19:09 +09:00
Huw Davies 4a992fec01 msi: Fix a registry key leak. 2015-07-15 23:18:54 +09:00
Hans Leidekker b71075ad9b msi/tests: Avoid test failures on win2k3. 2015-07-10 21:44:49 +09:00
Bernhard Übelacker a1dbf4d78b msi: Remove shortcut which calls RegEnumValueW with value and val_count as NULL. 2015-07-01 15:19:13 +09:00
Bernhard Übelacker db5f235a8b msi/tests: Test MsiSourceListEnumMediaDisks with volumeLabel and diskPrompt as NULL. 2015-07-01 15:19:09 +09:00
Hans Leidekker 597c5f9c4b msi: Open database cabinet streams through the streams implementation. 2015-06-22 19:18:48 +09:00
Hans Leidekker 806ff30f92 msi/tests: Fix test failures on win2k3. 2015-06-22 19:17:50 +09:00
Marcus Meissner d0cb2519b6 msi: Free rec in error exit (Coverity). 2015-06-12 15:24:44 +09:00
Alexandre Julliard 12a2b849a6 msi: Inherit state for radio buttons from the parent group dynamically. 2015-04-29 12:22:57 +09:00
Hans Leidekker 4710e973f8 msi: Initialize a variable (valgrind). 2015-04-21 22:21:36 +09:00
Hans Leidekker e6ce4de393 msi: Fix an invalid memory access (valgrind). 2015-04-21 22:21:31 +09:00
Hans Leidekker 55b678e186 msi: Initialize a variable (valgrind). 2015-04-21 22:21:27 +09:00
Hans Leidekker 6ef2d26a53 msi: Fix a trace.
Reported by Marcus Meissner.
2015-04-21 22:21:24 +09:00
Hans Leidekker 8969377647 msi: Perform a suffix match on the volume name. 2015-04-17 14:52:45 +09:00
Hans Leidekker 20c3c09fac msi: Improve the check for files obsoleted by patches. 2015-04-17 14:52:42 +09:00
Hans Leidekker dc2228305c msi: Add support for patching global assembly files. 2015-04-10 22:46:19 +09:00
Hans Leidekker d263c91ce2 msi: Assume that file patches from registered MSI patches have already been applied. 2015-04-10 22:46:19 +09:00
Hans Leidekker e4fd6265eb msi: Take the component action into account for file patches. 2015-04-10 22:46:19 +09:00
Hans Leidekker 17b80c8ec0 msi: Don't read past the end of the patch list in MsiApplyMultiplePatchesW. 2015-04-10 22:46:18 +09:00
Hans Leidekker eb116d6640 msi: Get rid of global variables the cabinet extraction callbacks. 2015-04-01 22:34:20 +09:00
Hans Leidekker 17b05316a5 msi: Clean up handling of temporary files. 2015-04-01 22:34:20 +09:00