Commit Graph

1326 Commits

Author SHA1 Message Date
Mike McCormack 61aabd66f5 Warning fixes for gcc 4.0. 2005-08-15 10:49:39 +00:00
Saulius Krasuckas 6400c8e3dd Fix some SHGetSpecialFolderPathA exceptions on WinME:
- pass pointer to valid buffer as lpszPath.
- disable check passing NULL as lpszPath.
2005-08-15 10:22:56 +00:00
Alexandre Julliard 640bf7c6e8 Authors: Michael Jung <mjung@iss.tu-darmstadt.de>, Ge van Geldorp <gvg@reactos.com>
- Prepend Desktop folder path for files/directories stored in the
  filesystem Desktop folder when GetDisplayNameOf is called with the
  SHGDN_FORPARSING flags.
- Add testcases.
2005-08-15 09:41:58 +00:00
Saulius Krasuckas 7be2cd973c XP returns E_INVALIDARG on failure. 2005-08-15 09:40:45 +00:00
Saulius Krasuckas 68d4ca1f6a Win98 returns HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND)) on failure. 2005-08-12 10:33:37 +00:00
Michael Jung e4d2ef4559 Use wine_get_dos_file_name instead of GetFullPathName. 2005-08-12 10:32:47 +00:00
Francois Gouget df6ed2f4e8 Fix the return value of SHELL_Argify() so it once again returns true
if a '%1' or equivalent placeholder was found. This fixes
ShellExecuteEx(lpFile="foo.txt", lpClass="txtfile").
2005-08-11 17:04:31 +00:00
Steven Edwards c8857c0786 Correct definition of SFGAO_STORAGEANCESTOR. 2005-08-11 10:33:21 +00:00
Francois Gouget efe2bbd0ec Fix handling of SEE_MASK_CLASSNAME and SEE_MASK_CLASSKEY. They are not
disjoint flags.
2005-08-11 10:29:44 +00:00
Alexandre Julliard 78340756f3 Use ERR instead of DPRINTF in dump_pidl_hex. 2005-08-09 20:48:17 +00:00
Saulius Krasuckas c3760e7de1 Remove trailing backslash. 2005-08-08 18:03:47 +00:00
Alexandre Julliard d37f0abf07 Don't prefix the functions DllCanUnloadNow, DllGetClassObject and
Dll(Un)RegisterServer with the dll name so that the compiler can check
the prototypes.
2005-08-08 17:35:28 +00:00
Saulius Krasuckas 843314ed9a Wine and NT4 returns E_FAIL on failure. 2005-08-08 11:04:30 +00:00
Alexandre Julliard 49b7fdcfc0 Removed the broken mmap64 configure check, and moved the
_FILE_OFFSET_BITS define to wine/port.h. Made sure that all files that
need the define include it.
2005-08-03 21:25:10 +00:00
Mike McCormack bc4a576a06 gcc 4.0 RegSetValueEx warning fixes. 2005-08-03 11:03:44 +00:00
Saulius Krasuckas 60f2d44e1f Added test for IShellFolder_ParseDisplayName. 2005-08-02 14:41:51 +00:00
Jozef Stefanka 3a29a309a4 Fixed browsing to other directories in Word 2003 file open
dialog. Double clicking on a folder in the File->Open dialog works
now.
2005-07-30 19:03:32 +00:00
Alexandre Julliard b1a9701bb5 Replace the _ICOM_THIS_From macros by inline functions the way it's
already done in shelllink.c.
2005-07-27 11:10:52 +00:00
Alexandre Julliard 89cbfd8fac Get rid of the _ICOM_THIS macros and call the inline function
directly instead.
2005-07-26 20:02:25 +00:00
Alexandre Julliard b8d3075d83 Uncomment the typedef in the DECLARE_INTERFACE macro, and get rid of
duplicate typedefs.
2005-07-26 18:32:53 +00:00
Paul Vriens 5b325a6d15 Skip test that crashes on W2K/WinXP/W2K. 2005-07-24 17:12:06 +00:00
Francois Gouget 5179aa1bae Get started testing ShellExecute(). 2005-07-24 16:26:53 +00:00
Vincent Béron 05b2c1cc81 Remove multiple declarations of the same function, keeping the public
one as reference.
2005-07-24 16:17:28 +00:00
Troy Rollo d1b575e940 Return attributes for the correct file in the unixfs ParseDisplayName. 2005-07-21 11:00:57 +00:00
Michael Jung 39a6c8b456 Initial support for the IPersistFolder3 interface. 2005-07-20 10:44:54 +00:00
Michael Jung 47c0906369 Only initialize shell folders via the IPersistFolder3 interface in
SHELL32_CoCreateInitSF if the pidl which specifies the child is of
type 'Folder'. Otherwise fall back to IPersistFolder.
2005-07-20 10:29:05 +00:00
Troy Rollo 2a52813024 When using PATHMODE_UNIX, all files are in the file system. 2005-07-19 11:40:36 +00:00
Michael Jung 1032fdc595 Use CP_UNIXCP instead of CP_ACP when converting paths (Pointed out by
Troy Rollo).
2005-07-18 13:13:42 +00:00
Michael Jung ff23dd29be Release shell folders only if they were successfully acquired. 2005-07-18 13:13:05 +00:00
Michael Jung 4ec5aa68b2 Append filename extension if necessary in IShellFolder::SetNameOf. 2005-07-18 09:12:20 +00:00
Michael Jung 9568893940 Add file type column in detailed shell view.
Make the order of shell view columns 'prefix-compatible' with
shfldr_fs.
Don't remove filename extensions for path pidls in GetDisplayNameOf.
2005-07-15 11:43:25 +00:00
Michael Jung 6b7778f36b Do filename postprocessing in GetDisplayNameOf (Hide filename
extensions if appropriate).
2005-07-15 09:58:03 +00:00
Michael Jung 1e6fe17958 Don't cache child pidls in UnixFolder, but create them on the fly. 2005-07-12 17:00:36 +00:00
Detlef Riekenberg a7a6927d9b Printers_RegisterWindowW / Printers_UnregisterWindow implemented as
stub.
Show the FIXME in Printer_LoadIconsW only when needed.
2005-07-11 18:02:20 +00:00
Francois Gouget 28dc5a8afc Assorted spelling fixes. 2005-07-11 10:59:41 +00:00
Michael Jung 9ccea1149b Don't use unix filesystem specific attributes in UnixFolder's pidls. 2005-07-11 10:24:09 +00:00
Michael Jung 5dd3e48154 Release parent shell folder in GetAttributesOf. 2005-07-11 10:23:56 +00:00
Michael Jung 433197172d Fail in SHGetDataFromIDList when called on special folder. 2005-07-08 14:18:32 +00:00
Michael Jung 8b87bdd76b Partially implemented UnixFolder's ISFHelper::CopyItems method. 2005-07-08 14:18:14 +00:00
Michael Jung 9f4c67d50d Return correct HRESULT code in UnixFolder's IEnumIDList::Next.
Corresponding test.
2005-07-08 11:30:18 +00:00
Mike McCormack d7b9a23afd gcc 4.0 -Wpointer-sign fixes (Reg* functions). 2005-07-06 19:08:05 +00:00
Michael Jung 6d6ec608d8 Implemented UnixFolder's ISFHelper::DeleteItems interface. 2005-07-06 15:43:51 +00:00
Alexandre Julliard 6b6d937c89 Authors: Michael Lin <mlin@corvu.com.au>, Michael Jung <mjung@iss.tu-darmstadt.de>
Implemented UnixFolder's ISFHelper::AddFolder.
2005-07-06 11:11:00 +00:00
Detlef Riekenberg b6b4787e95 Printer_LoadIconsW: implemented minimal version. 2005-07-05 20:59:35 +00:00
Alexandre Julliard d201828370 Authors: Michael Lin <mlin@corvu.com.au>, Michael Jung <mjung@iss.tu-darmstadt.de>
ISFHelper interface support for UnixFolder (currently only stubs).
2005-07-05 20:55:43 +00:00
Alexandre Julliard 9fef38488a Authors: Michael Lin <mlin@corvu.com.au>, Michael Jung <mjung@iss.tu-darmstadt.de>
Implemented UnixFolder's IShellFolder::SetNameOf.
2005-07-05 16:18:00 +00:00
Marcelo Duarte af80bbe701 Update shell32 resources for Portuguese. 2005-07-05 10:59:11 +00:00
Michael Jung 8130a6eb44 Return correct attributes in ParseDisplayName. 2005-07-05 10:58:11 +00:00
Mike McCormack e28c014a84 -Wpointer-sign fixes. 2005-07-03 12:03:35 +00:00
Mike McCormack b8fc783be2 Avoid warnings in generated tests by casting sizeof(x) to an int. 2005-07-03 11:23:30 +00:00
Robert Shearman d5714dfc50 Implement ShellDDEInit. 2005-06-30 20:45:57 +00:00
Michael Jung 7110f82795 Register unixfs at desktop level in DllRegisterServer. 2005-06-30 11:00:03 +00:00
Michael Jung c0995c2c93 Fix two more corner cases in UNIXFS_get_unix_path and UNIXFS_path_to_pidl. 2005-06-30 10:59:51 +00:00
Saulius Krasuckas 5678f65c07 Prepare for adding new tests.
- Put OleInitialize and OleUninitialize in the main block.
- Move test_BindToObject before test_EnumObjects_and_CompareIDs.
2005-06-30 10:23:14 +00:00
Michael Jung 9393580ab5 If the unixfs is rooted at the Desktop folder, forward
ParseDisplayName calls to it instead of to MyComputer.
2005-06-29 11:17:33 +00:00
Vitaliy Margolen eed690f973 ILFree is not available on all versions. 2005-06-29 11:00:59 +00:00
Aric Stewart b152076d3b Fix the BrowseForFolder dialog so that when it does the callbacks it
uses the correct message instead of always sending BEFM_INITIALIZED.
2005-06-27 18:46:47 +00:00
Michael Jung ad6bac918c Precisely compute the necessary pidl length in UNIXFS_path_to_pidl. 2005-06-27 18:46:36 +00:00
Saulius Krasuckas c48c3abd92 Additional test cases for IShellFolder_BindToObject. 2005-06-27 09:41:48 +00:00
Michael Jung 114975d937 Fix a lurking infinite loop in SHGetPathFromIDList. 2005-06-25 18:32:17 +00:00
Michael Jung 526377c511 Use the CallForAttributes registry value, instead of promoting the
root folder's SFGAO_FILESYSTEM flag to the registry.
2005-06-25 17:56:13 +00:00
Michael Jung 11cadc368a Support for shellfolder's CallForAttributes registry value. 2005-06-25 17:55:53 +00:00
Michael Jung bb562118c0 Added tests for ShellFolder's CallForAttributes value. 2005-06-24 11:33:35 +00:00
Alexandre Julliard f84401aa17 Sort entry points in the same order as Windows. 2005-06-23 09:57:11 +00:00
Saulius Krasuckas 77577822e3 - Move test init code back to START_TEST(shlfolder).
- Move creation and cleanup of a test-folders nearer to
  test_EnumObjects.
2005-06-22 18:04:04 +00:00
Saulius Krasuckas b98a26853c Cleanup the shlfolder test a bit more. 2005-06-21 20:04:17 +00:00
Michael Jung 8765e4a522 Propagate the root folder's attributes to the registry. 2005-06-21 09:42:38 +00:00
Vitaly Lipatov b39c3981c2 - Realize DoEnvironmentSubstA via ExpandEnvironmentStringsA.
- Fix types and return values.
- Add prototype into shellapi.h.
2005-06-20 15:33:48 +00:00
Stefan Huehner ac6f562b52 Fix more -Wstrict-prototypes warnings. 2005-06-20 14:18:03 +00:00
Michael Jung 74afc7f12e Use stat's dev/inode to compare paths instead of comparing the
strings. Defer building a folder's children SHITEMIDS until explicitly
asked for.
2005-06-20 11:42:23 +00:00
Stefan Leichter fcd6764928 Make shell32 tests loadable on NT4. 2005-06-20 10:31:14 +00:00
Mike McCormack 383302c11e Make functions static. 2005-06-20 10:30:15 +00:00
Francois Gouget 6394a15314 Assorted spelling fixes. 2005-06-17 20:59:49 +00:00
Francois Gouget 9769816b6e Fix winapi_check documentation warnings. 2005-06-17 20:58:33 +00:00
Francois Gouget f9280a3a95 Protect the unistd.h and sys/stat.h includes.
Include config.h.
Fixes warnings reported by winapi_check.
2005-06-17 20:56:02 +00:00
Michael Jung ff75b415d2 Remove trailing backslash from DOS paths in GetDisplayNameOf. 2005-06-17 12:12:35 +00:00
Marcus Meissner 96ebd31066 ExtractAssociatedIconA needs to allocate enough space to have EAIW
fill in lpIconPathW.
2005-06-17 09:52:33 +00:00
Mike McCormack 4d2d627c3f - forward AddRef, Release, QueryInterface and GetClassID to internal
implementations
- implement GetClassID properly
2005-06-16 10:43:50 +00:00
Mike McCormack 64a3b82831 SHCreateStreamOnFileW is implemented in shlwapi, so we don't need
another implementation in shell32.
2005-06-16 09:46:17 +00:00
Mike McCormack 0a44661d6f Switch IShellLink to use shlwapi.SHCreateStreamOnFileW. 2005-06-16 09:46:05 +00:00
Michael Jung e5ef9dd8dc Test GetAttributesOf on the MyComputer shellfolder. 2005-06-16 09:44:50 +00:00
Michael Jung e2dbc8044a Added tests for SHGetPathFromIDList. 2005-06-15 18:07:55 +00:00
Huw Davies 47db6bc567 Unquote the icon file path if it's quoted. 2005-06-15 18:07:43 +00:00
Mike McCormack c62940a1ac Remove some uses of wine/unicode.h functions. 2005-06-15 10:21:46 +00:00
Michael Jung ebb1aaee86 Implement SHGetPathFromIDList based on GetDisplayNameOf. 2005-06-15 10:20:00 +00:00
Michael Jung 8b4b4b3af2 Replace magic error constant. 2005-06-14 19:18:26 +00:00
Michael Jung 81b7509f3b Use SHGetPathFromIDList instead of SHELL32_GetPathFromIDList. 2005-06-14 19:17:41 +00:00
Michael Jung bb19a58a93 Return the correct attributes for the desktop folder.
Corresponding tests.
2005-06-14 18:10:24 +00:00
Michael Jung 5664a68033 Added tests to compare SHGetPathFromIDList and GetDisplayNameOf. 2005-06-14 17:21:25 +00:00
Mike McCormack 215bd9a70b Add the IContextMenu interface to the ShellLink object. 2005-06-14 11:38:55 +00:00
Mike McCormack 0569609e3d Implement ShellLink's IShellExtInit::Initialize() method. 2005-06-13 19:04:17 +00:00
Mike McCormack d4eb4f54ed - add the IShellExtInit interface to the ShellLink object
- use inline functions rather than macros to resolve the
  implementation pointer from an interface pointer
2005-06-13 11:50:09 +00:00
Michael Jung 71404a7372 Set the FILESYSANCESTOR and FILESYSTEM flags correctly in
GetAttributesOf.
2005-06-10 19:31:59 +00:00
Saulius Krasuckas 83ac47e53c Get current directory during tests on win9x too. 2005-06-09 12:05:50 +00:00
Mike McCormack fa1b7822a5 Add the IShellLinkDataList interface to the ShellLink object. 2005-06-09 12:05:38 +00:00
Mike McCormack 8e2cb0835c Add a cast to get rid of a warning. 2005-06-09 09:46:23 +00:00
Michael Jung d1f59dba67 Use shell icon cache instead of an own IExtractIcon implementation. 2005-06-09 09:43:18 +00:00
Mike McCormack b64186ad22 Warning fixes for -Wmissing-declarations and -Wwrite-strings. 2005-06-07 20:30:30 +00:00
Juan Lang ab88fd34dc Const-ify a mask. 2005-06-07 20:03:39 +00:00
Dmitry Timoshkov eba47f1dfe Make remaining OLE interface vtables const. 2005-06-06 19:50:35 +00:00
Michael Jung d20fde8a80 Allow for unixfs folders to be rooted at desktop level.
Moved dos->unix path conversion into canonicalize_path.
Fail in BindToObject, if called with empty pidl.
2005-06-06 19:37:47 +00:00
Michael Jung 38f2ee9d04 Let BindToObject fail, if called with empty relative pidl.
Tests to show that it should do so.
Fix SHBrowseForFolder to not pass an empty pidl to BindToObject.
2005-06-06 10:04:15 +00:00
Juan Lang 4571d0187f Set default for "My Documents" to $HOME, and "Desktop" to ~/Desktop. 2005-06-02 19:39:24 +00:00
Mike McCormack 4c6149ee0c Eliminate some -Wwrite-strings warnings. 2005-06-01 11:04:26 +00:00
Stefan Dösinger ea18de5f58 *Handle cidl==0 in shfldr_desktop, shfldr_fs and shfldr_mycomp.
*Remove the dwAttributes member from the IGenericSFImpl class, it's
not needed and can't be initialised in Initialize and InitializeEx.
2005-05-26 16:09:12 +00:00
Michael Jung 3c3495ea51 Add a new CLSID for UnixDosFolder, which is identical to UnixFolder,
but does unix <-> dos path conversion for GetDisplayNameOf and
ParseDisplayName.
2005-05-24 11:45:47 +00:00
Michael Jung 8016f6cc62 More robustly query the SHGDN_FORPARSING flag in the shell32's folders
GetDisplayNameOf methods.
2005-05-23 16:31:42 +00:00
Alexandre Julliard aebb745488 Comment out stub WEP entry points so that we can call WEP for builtin
dlls too.
2005-05-23 10:12:26 +00:00
Alexandre Julliard 0ddd30b0b6 Removed unnecessary code in the 16-bit DllEntryPoint function of some
dlls, and also fixed its ordinal in a few places.
2005-05-23 10:00:26 +00:00
Michael Jung 82ed0ce999 Consider only the GIL_FORSHORTCUT flag in SIC_CompareEntries. 2005-05-20 18:58:35 +00:00
Kouji Sasaki c1f2824429 Added the processing for determination of SFGAO_HASSUBFOLDER flag in
SHELL32_GetItemAttribute function.
2005-05-18 09:43:39 +00:00
Juan Lang f12eadf7bf - only log unsupported flags in ShellExecute
- environment variables are expanded, so SEE_MASK_DOENVSUBST is
  supported
2005-05-14 11:06:54 +00:00
Ge van Geldorp 40cb98269b Overlay icons for .lnk files with a small arrow in the lower left
corner.
2005-05-13 17:48:33 +00:00
Mike McCormack 3e2cb75349 Remove some unused include files. 2005-05-13 13:59:15 +00:00
Michael Jung a858a5a76c Replace '\\' by '/' in strings passed to ParseDisplayName to be able
to handle DOS-style relative paths.
2005-05-13 13:55:03 +00:00
Mike McCormack 1ae212a105 Split SHGetFileInfoW into two functions. 2005-05-12 09:56:48 +00:00
Michael Lin 9bd101d012 - Implement IPersistFolder2.
- Retrieve the correct attributes in ParseDisplayName().
2005-05-12 09:56:04 +00:00
Juan Lang 2439b5fdda Fixes to IShellFolder::GetAttributesOf implementations, spotted by
silverblade_:
- a count of zero is allowed to GetAttributesOf if apidl is NULL
- SFGAO_VALIDATE must be cleared upon return
2005-05-10 08:28:11 +00:00
Mike Hearn 25abe7c537 Fix SHELL_GetPathFromIDList[AW] to return the desktop path given an
empty PIDL.
2005-05-10 08:27:23 +00:00
Michael Jung ea3793b79d Support folder relative paths in UnixFolders' ParseDisplayName
method.
2005-05-09 19:33:01 +00:00
Alexandre Julliard 34fa35dc99 Added rules for building import libraries in the individual dll
makefiles, and added support for building a .def.a static import
library too.
2005-05-09 14:42:30 +00:00
Michael Jung 3a117bccd8 Always pass fully qualified paths to stat system call. 2005-05-09 09:26:02 +00:00
Huw Davies da13552c55 It makes no sense to have a left pointing arrow as the desktop icon.
Replace it with something more appropiate.
2005-05-09 09:25:28 +00:00
Robert Lunnon f4949b8d80 Make references to NAME_MAX refer to PATH_MAX instead. 2005-05-07 14:50:00 +00:00
Alexandre Julliard d62356aa1e Added rules to build import libraries in the individual dll makefiles.
Generate import libraries with the right name right away instead of
using an intermediate .spec.def file.
2005-05-07 12:39:52 +00:00
Michael Jung fc40dcf985 Make the root of the shell extension map to the root of the unix
filesystem.
2005-05-07 12:17:02 +00:00
Michael Jung 15934680f7 Return a cloned PIDL by SHBrowseForFolder to avoid heap corruption. 2005-05-06 19:33:06 +00:00
Michael Jung 94e5f01275 Display a drive icon for the unix root directory. 2005-05-06 19:32:54 +00:00
Francois Gouget 821d4c4645 Fix nativeapi.pm so it knows about AC_HEADER_STAT().
Make the error message about unexpected '#ifdef HAVE_XXX' clearer.
Protect sys/stat.h #includes with the corresponding '#ifdef HAVE_XXX'
check.
2005-05-06 16:22:54 +00:00
Francois Gouget f5c9da6860 Assorted spelling fixes. 2005-05-06 15:44:31 +00:00
Michael Jung 45bcdd2be1 Fixed GetDisplayNameOf method to not depend on incorrect behaviour
regarding the SHGDN_INFOLDER flag.
2005-05-05 10:30:51 +00:00
Michael Jung ddc26aa94e Fixed MyComputer's GetDisplayNameOf method. 2005-05-05 10:30:39 +00:00
Mike McCormack 2b2c6f2fba Remove static variables in SHBrowseForFolder implementation. 2005-05-04 09:48:15 +00:00
Mike McCormack 95a58eba7d Split up the window procedure. 2005-04-28 18:26:58 +00:00
Gerald Pfeifer 039869eed1 Include <limits.h> to get a definition of NAME_MAX. 2005-04-27 08:12:08 +00:00
Michael Jung 3abb5bd6bb Support for regular files (as opposed to directories). 2005-04-25 10:56:29 +00:00
Michael Jung 025bc2d8a2 Use the shell32 typical binary format for ITEMIDLISTs. 2005-04-22 21:29:17 +00:00
Michael Jung 2a788026a3 Fixed incorrect IShellFolder::EnumOjects API usage. 2005-04-22 19:07:00 +00:00
Mike McCormack 5960e7c93c MSI advertised shortcuts don't require a product ID. 2005-04-22 19:06:12 +00:00
Peter Berg Larsen 56c34e1b2c Rewritten DoEnvironmentSubst16. 2005-04-21 17:14:39 +00:00
Francois Gouget 4527aae24f Assorted spelling fixes. 2005-04-19 09:49:38 +00:00
Troy Rollo 98d336c363 Fix SEGV for non-fully-qualified destination paths.
Don't fail ShFileOperationW if FOF_ALLOWUNDO is passed.
2005-04-19 09:49:05 +00:00
Francois Gouget 3b36eee083 Add trailing '\n's to ok() calls. 2005-04-19 09:48:44 +00:00
Peter Berg Larsen 6e3bcb5a54 Replace strncpy with memcpy or lstrcpyn. 2005-04-18 10:30:55 +00:00
Huw Davies 7ac969d560 When we're hiding file extensions then SetNameOf should append the
original extension if SHGDN_FORPARSING isn't set.
The flags passed to SetNameOf refer to the dst string not the src
pidl.
2005-04-15 16:11:45 +00:00
Martin Fuchs d3b5018275 Correct comments of some export ordinals. 2005-04-13 15:17:16 +00:00
Huw Davies 0e5b772cdc Add a unicode pidl type.
Improve support for PT_YAGUID.
Improve IShellLink debugging.
2005-04-13 14:39:27 +00:00
Steven Edwards ad7f4daf35 Register Shell Drag and Drop Helper. 2005-04-13 11:07:49 +00:00
Michael Jung 9a4f552f2f Implemented the UnixFolder's IShellFolder2::CompareIDs method. 2005-04-13 11:01:10 +00:00
Huw Davies be428abd3e Better icon handling for some special folders.
Identify and add defines for a bunch of shell icons.
2005-04-12 12:00:40 +00:00