Commit Graph

3793 Commits

Author SHA1 Message Date
Ken Thomases 930e84dfd2 comctl32: Eliminate redundant local variable (gcWheelDelta == -wheelDelta). 2013-02-11 11:46:09 +01:00
Daniel Jelinski f9c3a612af comctl32/listview: Do not touch icon spacing if set explicitly. 2013-02-07 12:02:27 +01:00
Daniel Jelinski aeefa82185 comctl32/listview: Always use large icon size when calculating icon spacing. 2013-02-06 10:16:17 +01:00
Daniel Jelinski cb77ab1a00 comctl32/listview: Correct icon spacing calculation when set to 0 or -1. 2013-02-06 10:16:00 +01:00
Dmitry Timoshkov 7b3305169c comctl32: Test appropriate tool window for active state.
There is no point in testing owner of the tooltip itself since it's often
created as a popup of the desktop window.
2013-02-05 10:53:42 +01:00
Nikolay Sivov 8f87fc5b39 comctl32/listview: Fix item search with keyboard input. 2013-01-30 12:43:11 +01:00
Nikolay Sivov 8418ae5334 comctl32: Test WM_GETDLGCODE return value for TreeView. 2013-01-30 12:43:05 +01:00
Nikolay Sivov ac4192e769 comctl32: Use NM_RCLICK return value to allow default processing. 2013-01-30 12:43:01 +01:00
Francois Gouget a5ff4b8088 Assorted spelling fixes. 2013-01-29 12:13:04 +01:00
Nikolay Sivov 500da7def6 comctl32/listview: Implement dragging with right button with a message loop. 2013-01-28 14:04:19 +01:00
Nikolay Sivov ea57e29d08 comctl32/listview: Remove some dead code. 2013-01-14 11:02:18 +01:00
Nikolay Sivov dbd997c3c9 comctl32/listview: Update focus index when new item data is already there. 2013-01-14 11:02:12 +01:00
Nikolay Sivov b68e95abd8 comctl32/listview: Add a special case for deselect all attempt when nothing is selected. 2013-01-11 11:58:51 +01:00
Nikolay Sivov 7773d6b095 comctl32/listview: Always send LVN_ITEMCHANGING notification even if nothing changed. 2013-01-11 11:58:46 +01:00
Marcus Meissner 1fe4af293c comctl32: Initialize SYSTEMTIME structs (Coverity). 2013-01-10 19:18:45 +01:00
Nikolay Sivov 7bb36372c8 comctl32/listview: Use LVM_SETITEMSTATE directly in tests. 2013-01-10 16:06:03 +01:00
Nikolay Sivov 6227bbcff7 comctl32/listview: Fix focus index update when item is deleted. 2013-01-10 16:05:56 +01:00
Marcus Meissner d8d83d2eb3 comctl32: Avoid leak of hShell32 (Coverity). 2013-01-09 12:54:39 +01:00
Marcus Meissner 3173f17315 comctl32: Free the selection ranges (Coverity). 2013-01-08 12:30:15 +01:00
Daniel Jelinski 1964145713 comctl32/tests: Add tests for listview header image list. 2013-01-07 13:38:15 +01:00
Daniel Jelinski bad62c0267 comctl32/listview: Support header images. 2013-01-07 13:38:14 +01:00
Daniel Jelinski 8257ab9a76 comctl32/listview: Fix subitem drawing.
lpColumnInfo->fmt & LVCFMT_IMAGE is supposed to mean that header item has
an image. It is not supposed to mean that all items in that column
should reserve space for an icon if they don't have any.
2013-01-07 13:38:13 +01:00
Daniel Jelinski 9b8e3ca410 comctl32/listview: Update item height when changing font. 2013-01-07 13:38:12 +01:00
Daniel Jelinski 7b1fd9e527 comctl32/listview: Redraw items after insert/delete. 2013-01-07 13:38:11 +01:00
Daniel Jelinski 67eb9744d9 comctl32/listview: Fix calculating item height. 2013-01-07 13:38:11 +01:00
Nikolay Sivov 67c57b216c comctl32/listview: Improve LVM_GETSUBITEMRECT implementation for out-of-bounds item indices. 2013-01-03 16:44:07 +01:00
Andrew Talbot 23fde785ee comctl32: Avoid signed-unsigned integer comparisons. 2013-01-02 13:35:52 +01:00
Ričardas Barkauskas 2c8ea6ebff comctl32: Avoid code duplication by reusing PROPSHEET_GetPageIndex. 2012-12-26 18:23:04 +01:00
Ričardas Barkauskas 379d492b12 comctl32: Use index value if property sheet page isn't found. 2012-12-26 18:23:04 +01:00
Andrew Talbot 85ebbadcb0 comctl32: Indentation fix. 2012-12-17 11:47:39 +01:00
Michael Stefaniuc ab55448069 comctl32/tests: Get rid of a temp buffer. 2012-12-12 11:58:43 +01:00
Daniel Jelinski 06a0a01e18 comctl32/listview: Forward more header notifications to parent window. 2012-12-11 20:45:44 +01:00
Daniel Jelinski 12c065111b comctl32/listview: Convert header notifications to ANSI in place. 2012-12-11 20:45:44 +01:00
Daniel Jelinski 70df1d58cb comctl32/tests: Add listview header notification tests. 2012-12-11 20:45:43 +01:00
Nikolay Sivov fbd7f8813f comctl32: Fix font style when item is bold and hovered in track mode. 2012-12-11 20:45:41 +01:00
Andrew Talbot 441780b2f1 comctl32: Indentation fix. 2012-12-11 12:03:41 +01:00
Nikolay Sivov 3938bfd30d comctl32: Initialize id field for message tests. 2012-12-10 11:25:29 +01:00
Nikolay Sivov 9ed808e340 comctl32: Fix a ranges leak on error. 2012-12-10 11:25:00 +01:00
Andrew Talbot da71545319 comctl32: Remove unneeded address-of operators from array names. 2012-12-06 13:01:15 +01:00
Michael Stefaniuc 5bade39f55 comctl32: Remove a superfluous function pointer cast. 2012-11-30 19:12:16 +01:00
Daniel Jelinski c1157b79fd comctl32: Properly initialize internal structures. 2012-11-27 19:45:38 +01:00
Alexandre Julliard c3f0abfa40 comctl32/tests: Add some initial pager tests. 2012-11-20 17:23:39 +01:00
Alexandre Julliard 3ad9f29e02 comctl32/pager: Don't rely on PGN_CALCSIZE to set the non-scrollable dimension of the control. 2012-11-20 17:18:17 +01:00
Alexandre Julliard 7a78eed463 comctl32/pager: Fix tracking of mouse position inside the buttons. 2012-11-20 16:02:18 +01:00
Alexandre Julliard f3b8e68296 comctl32/pager: Use DrawFrameControl to paint the buttons. 2012-11-20 16:01:47 +01:00
Daniel Jelinski e9e09b66a0 comctl32: Move WM_SIZE handling into WM_WINDOWPOSCHANGED. 2012-11-13 16:54:54 +01:00
Piotr Caban b6b7eb050f comctl32: Fixed RBBS_BREAK flag unsetting in REBAR_HandleUDDrag. 2012-11-01 15:43:34 +01:00
Piotr Caban d2f4893cb6 comctl32: Don't update rebar layout if it doesn't change in REBAR_HandleUDDrag. 2012-11-01 15:43:29 +01:00
Hans Leidekker 232a44edaf comctl32: Use the dialog template caption as default propsheet title. 2012-10-29 14:40:13 +01:00
Alexandre Julliard c4bae8fab0 comctl32/tests: Don't delete the global font object. 2012-10-18 22:28:37 +02:00
Daniel Jelinski 50bdb257f9 comctl32/tests: Expanding/collapsing a node always sends associated messages. 2012-10-16 11:38:36 +02:00
Daniel Jelinski 0b6cf6e46a comctl32: Fix notifications and return value when collapsing already collapsed node. 2012-10-16 11:38:27 +02:00
Daniel Jelinski 9933f5e446 comctl32: Do not send TVN_ITEMEXPANDING when expanding item with no children. 2012-10-16 11:37:58 +02:00
Daniel Jelinski 06d284cabb comctl32: Allow expanding/collapsing treeview nodes multiple times. 2012-10-15 15:25:38 +02:00
Daniel Jelinski ae72b21641 comctl32: Clean up listview resizing code. 2012-10-01 12:20:30 +02:00
Daniel Jelinski 0edb0233a4 comctl32: Use GetWindowLong to check for scrollbar.
dwStyle is updated only in WM_STYLECHANGED, which is not sent
when displaying and hiding scrollbars.
2012-10-01 12:20:09 +02:00
Huw Davies 3cfc2ab772 comctl32: Forward the focus to the edit control if it exists. 2012-09-25 18:11:21 +02:00
Christian Costa 55ff254986 comctl32: Invalid format returned by NF_QUERY defaults to ANSI in treeview. 2012-09-24 16:38:16 +02:00
Michael Stefaniuc 9f56598fb9 comctl32/tests: Use the proper type for function pointers. 2012-09-13 13:56:34 +02:00
Michael Stefaniuc 5b19a55910 comctl32/tests: Remove commented out struct declaration. 2012-09-13 13:56:23 +02:00
Daniel Jelinski 425f0a25d6 comctl32: Invalidate correct rectangle for marquee selection. 2012-09-12 12:48:50 +02:00
Alexandre Julliard 0e9c9772ef comctl32: XOR'ing with a black pen is not useful. 2012-09-10 11:38:21 +02:00
Daniel Jelinski e389326bdd comctl32/listview: Do not draw unnecessary grid lines. 2012-09-03 16:45:50 +02:00
Piotr Caban 21898b2fba comctl32: Remove property sheet page that can't be initialized. 2012-08-29 20:13:48 +02:00
Nikolay Sivov 21897a9689 comctl32: Call interface methods properly. 2012-08-20 10:58:45 +02:00
Sergey Guralnik d54979e329 comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications. 2012-08-17 15:16:12 +02:00
Sergey Guralnik c7abff0a27 comctl32/tests: Add test for MCN_SELECT/MCN_SELCHANGE notifications. 2012-08-17 15:16:08 +02:00
Michael Stefaniuc 175eaf1074 comctl32: Avoid TRUE:FALSE conditional expressions. 2012-08-13 17:29:01 +02:00
Michael Stefaniuc 11d35ef8e7 comctl32: Get rid of two macros. 2012-08-13 17:28:53 +02:00
Daniel Jelinski baed448fc7 comctl32/treeview: Fix the position reported by WM_CONTEXTMENU. 2012-07-17 13:09:43 +02:00
Daniel Jelinski 067d528855 comctl32/treeview: Send WM_CONTEXTMENU only to parent window. 2012-07-17 13:09:43 +02:00
Daniel Jelinski 5e86d84337 comctl32/treeview: Inlined TREEVIEW_RButtonUp. 2012-07-17 13:09:43 +02:00
Daniel Jelinski c7212f8262 comctl32/treeview: Send WM_CONTEXTMENU everywhere, not just over items. 2012-07-17 13:09:42 +02:00
Daniel Jelinski 602dea1e12 comctl32/treeview: Fix NM_RCLICK behavior. 2012-07-17 13:09:42 +02:00
Daniel Jelinski 7e56fd38d8 comctl32/treeview: Clean up mouse tracking code. 2012-07-17 13:09:42 +02:00
Francois Gouget ac323a20ba comctl32: Simplify the string comparison functions a bit and use the CSTR_XXX macros. 2012-06-21 08:33:31 +02:00
Francois Gouget bede13b335 comctl32: Fix lstrncmpiW() so its return value is standard and use the CSTR_XXX macros. 2012-06-20 10:27:36 +02:00
Nikolay Sivov 6560d88151 comctl32/listview: Properly update selection mark on item state change. 2012-06-11 12:19:07 +02:00
Daniel Jelinski 4c6803d858 comctl32/tests: Treeview shouldn't modify cChildren if it was explicitly set. 2012-06-07 19:47:59 +02:00
Daniel Jelinski 1196aed33f comctl32: Allow label edit only if treeview style allows editing. 2012-06-07 16:26:25 +02:00
Michael Stefaniuc fe947be7e7 comctl32/tests: Remove stray backslashes at end of lines. 2012-06-07 10:33:17 +02:00
Dmitry Timoshkov 92a81c215f comctl32: Use WARN instead of ERR if a toolbar index is out of range. 2012-05-24 19:54:20 +02:00
Nikolay Sivov 95a15a3482 comctl32: Make it possible to use TVM_GETITEM with item from another tree. 2012-05-22 17:44:00 +02:00
Piotr Caban 99ff5683f3 comctl32: Don't make separator on first position hot. 2012-05-17 17:44:23 +02:00
Piotr Caban 2d75a2425e comctl32: Return if point is over a button in TOOLBAR_InternalHitTest. 2012-05-17 17:44:15 +02:00
Nikolay Sivov 21727c416f comctl32: When created with TCS_VERTICAL, TCS_MULTILINE is set automatically. 2012-05-17 10:18:39 +02:00
Nikolay Sivov ace41e9264 comctl32: Properly disable redraw on tab control. 2012-05-17 10:18:36 +02:00
Francois Gouget fac36c55e9 Assorted typo, spelling, wording and case fixes. 2012-05-15 16:26:43 +02:00
Piotr Caban 25f347892e comctl32: Make icons not overlapping in LVS_ICON mode. 2012-05-10 18:42:06 +02:00
Piotr Caban 8276a3375b comctl32: LVM_SETITEMTEXT is not supported on LVS_OWNERDATA. 2012-05-10 18:41:55 +02:00
Francois Gouget a0bb28f7d9 comctl32/tests: Add a trailing '\n' to an ok() call. 2012-04-25 17:20:42 +02:00
André Hentschel 4598c48041 comctl32: Remove unneeded shadow variables for comboex. 2012-04-18 17:10:34 +02:00
Akihiro Sagawa 8cedea0d60 comctl32: Truncate the info tip text when using ANSI version messages. 2012-04-16 11:50:00 +02:00
Akihiro Sagawa 28f26c9783 comctl32/tests: Add tests for long info tip texts. 2012-04-16 11:49:37 +02:00
Akihiro Sagawa b48f394e4f comctl32: Add support for retrieving lpszText in TOOLINFO structure. 2012-04-12 21:27:45 +02:00
Daniel Jelinski cd8609597a comctl32/tests: Added tests for treeview TVM_HITTEST message. 2012-04-05 14:51:33 +02:00
Daniel Jelinski c52d7acf54 comctl32/tests: Added test for treeview expand notifications on keyboard events. 2012-04-02 18:37:06 +02:00
Nikolay Sivov b326426fec comctl32: Use single notification message for setting all item state with LVM_SETITEMSTATE (LVS_OWNERDATA case only). 2012-03-26 18:15:51 +02:00
Nikolay Sivov f296c84feb comctl32: Update thumb position on autopage instead of deferring it. 2012-03-13 10:30:08 +01:00
Owen Rudge ffbdd27268 comctl32/datetime: Fix AM/PM handling with 12-hour fields. 2012-03-12 10:46:41 +01:00
Owen Rudge 74d1c11684 comctl32/datetime: Allow entering 'AM' or 'PM' via keyboard. 2012-03-12 10:46:35 +01:00
Owen Rudge 9147e7fd22 comctl32/datetime: Don't check box if no valid date set. 2012-03-12 10:46:14 +01:00
Owen Rudge 9de240bd0e comctl32/datetime: Don't allow an invalid year to be typed in. 2012-03-12 10:46:06 +01:00
Owen Rudge 3f93230812 comctl32/datetime: Ensure up/down/home/end increments remain within bounds. 2012-03-12 10:45:59 +01:00
Owen Rudge c8c3c4be91 comctl32/datetime: Check dates are within range in SetSystemTime. 2012-03-12 10:45:47 +01:00
Owen Rudge 300140e2cb comctl32/tests: Add test for DTM_SETSYSTEMTIME outside range limit. 2012-03-12 10:45:21 +01:00
Owen Rudge 72f174192b comctl32/monthcal: Check both min and max ranges in IsDateInValidRange. 2012-03-12 10:45:18 +01:00
Nikolay Sivov 3d4a4dae70 comctl32: Update thumb position on WM_MOUSEMOVE instead of deferring it. 2012-03-12 10:11:28 +01:00
Nikolay Sivov 0cae0842b9 comctl32/tests: Fix test failures running on February 29. 2012-02-29 10:32:09 +01:00
Francois Gouget 07d9d04de8 comctl32/tests: Make cbt_hook_proc() static. 2012-02-20 11:47:55 +01:00
Frédéric Delanoy 3c13f991e4 comctl32/tests: Use initialized window handle when rebuilding toolbar (Coverity). 2012-02-20 11:38:35 +01:00
Nikolay Sivov 31b44fb6e8 comctl32: Fix TB_SETEXTENDEDSTYLE to use mask passed in wParam. 2012-02-16 11:48:51 +01:00
Nikolay Sivov a4e2f47c2d comctl32: Trace Header order array contents. 2012-02-13 13:09:45 +01:00
Nikolay Sivov e508eae7d7 comctl32: Update ticks on TBM_SETRANGE. 2012-02-13 13:09:45 +01:00
Nikolay Sivov 11de98be34 comctl32: Update ticks on TBM_SETRANGEMIN. 2012-02-13 13:09:45 +01:00
Nikolay Sivov abde0c21e3 comctl32: Update ticks on TBM_SETRANGEMAX. 2012-02-13 13:09:45 +01:00
Nikolay Sivov e630e4997d comctl32: A test for auto-set TBSTYLE_TRANSPARENT style. 2012-02-09 09:39:58 -06:00
Nikolay Sivov b32b969eb6 comctl32: Invalidate before item is removed. 2012-02-08 10:50:12 -06:00
Michael Stefaniuc 482a5746ee comctl32: Remove an obsolete resource attribute. 2012-02-07 09:32:30 -06:00
André Hentschel 91a63ad08c comctl32/tests: Add some more thumb length tests. 2012-02-06 10:27:22 -06:00
Nikolay Sivov 1c1b1c0073 comctl32: More tests for Toolbar window style handling. 2012-02-01 16:42:45 +01:00
Thomas Faber 2fb139ffe7 comctl32: Fix MSVC build in imagelist.c. 2012-01-30 20:44:50 +01:00
Nikolay Sivov 91fbef88bf comctl32: Never release state image list. 2012-01-30 12:04:58 +01:00
Thomas Faber 05253f900f comctl32: Fix MSVC build in monthcal.c. 2012-01-30 11:51:35 +01:00
André Hentschel 80d9017e03 comctl32: Test and fix WM_GETTEXTLENGTH for statusbars. 2012-01-23 16:06:52 +01:00
Austin English 913fb67a5b comctl32: Fix a grammar error in comment. 2012-01-12 12:24:40 +01:00
Alexandre Julliard e0cc9a798b comctl32/syslink: Fix painting of background color for transparent controls. 2012-01-12 12:20:46 +01:00
Alexandre Julliard ff71cc2ca4 comctl32: Fix management of imagelist growth amount. 2012-01-11 17:47:31 +01:00
Nikolay Sivov e3688c2f9a comctl32: Remove redundant parameter from a helper. 2012-01-09 12:22:47 +01:00
Nikolay Sivov 9188b58e4c comctl32: Store style bits provided with WM_CREATE. 2012-01-09 12:22:39 +01:00
Nikolay Sivov 54b6c76720 comctl32: Fix TB_SETSTYLE behaviour and return value. 2012-01-09 12:22:31 +01:00
André Hentschel 9e0517ac6d comctl32: Also free pszHeaderTitle and pszHeaderSubTitle in DestroyPropertySheetPage. 2011-12-29 17:56:51 +01:00
Nikolay Sivov fade32b515 comctl32: Block selection change depending on TCN_SELCHANGING result. 2011-12-27 16:55:05 +01:00
Frédéric Delanoy 8d6f9e3036 comctl32: Avoid using uninitialized value (Coverity). 2011-12-20 20:24:00 +01:00
Nikolay Sivov 73354ef9d2 comctl32: Fix parameter validation for CreateMRUListLazyA(). 2011-12-20 10:10:32 +01:00
Alexandre Julliard 9c9e8dd141 comctl32/tests: Fix a test failure on older Windows. 2011-12-16 19:47:27 +01:00
Alexandre Julliard e0fc985f32 comctl32: Use GetDIBits to retrieve the default color map for an imagelist DIB section. 2011-12-16 17:40:31 +01:00
Alexandre Julliard 40cf298c75 comctl32: Use DrawIconEx to copy icon bits and use the correct background color. 2011-12-16 17:40:30 +01:00
Alexandre Julliard 65b7eb2635 comctl32/tests: Add some more tests for ImageList_Write. 2011-12-16 17:40:27 +01:00
Alexandre Julliard 129f48a692 comctl32: Don't try to mask out the image for palette-based bitmaps. 2011-12-15 10:49:03 +01:00
Nikolay Sivov 485fde811d comctl32/listview: Create header when LVS_EX_FULLROWSELECT is requested. 2011-12-09 21:15:26 +01:00
Alexandre Julliard 64f4c4161c comctl32: Convert dialogs to po files. 2011-12-05 20:38:21 +01:00
Nikolay Sivov dfbe664548 comctl32/listview: Create header when LVS_EX_GRIDLINES style is set. 2011-12-05 12:23:24 +01:00
Alexandre Julliard 682b03731c comctl32: Fix text wrapping in syslink when an item starts in the middle of a line. 2011-12-01 20:30:16 +01:00
Alex Henrie d8906da528 comctl32: Update Catalan translation. 2011-11-30 12:22:12 +01:00
Frédéric Delanoy 954e6eba7e comctl32: Avoid hardcoding array lengths. 2011-11-22 10:53:33 +01:00
Alexandre Julliard e6cf9fbcc2 comctl32: Merge imagelist definitions into the C file. 2011-11-21 11:47:24 +01:00
Alexandre Julliard d0b1b4c7b0 comctl32: Avoid accessing imagelist internals. 2011-11-21 11:43:06 +01:00
Alexandre Julliard ee462a7801 comctl32: Take the total bitmap size into account when reading a bottom-up image list. 2011-11-21 11:42:48 +01:00
Frédéric Delanoy eae3c2ae27 comctl32: Avoid hardcoding array lengths. 2011-11-18 15:36:53 +01:00