6210c097a4
rpcrt4: Add missing LeaveCriticalSection. Found by Smatch.
2007-12-18 12:32:55 +01:00
bdc5a34196
rpcrt4: Add a stub for I_RpcGetCurrentCallHandle.
2007-12-18 12:32:55 +01:00
b9c92e9564
rpcrt4: Don't copy memory from the buffer in NdrConformantStringUnmarshall if we just pointed the memory pointer into the buffer.
...
(Reported by Dan Kegel.)
2007-12-18 12:32:55 +01:00
76d266cbb0
rpcrt4: Add an rpcasync.h header stub and fix the RpcErrorStartEnumeration() prototype.
2007-12-18 12:32:42 +01:00
737510eeb6
rpcrt4: Move association code into a separate file.
2007-12-17 11:59:18 +01:00
22f530c835
rpcrt4: Make a server association when a bind packet is received in the server.
...
Support handing out association group IDs.
2007-12-17 11:59:13 +01:00
2bda19c6b0
rpcrt4: Return an error from rpcrt4_conn_tcp_read if recv returns 0.
2007-12-17 11:58:57 +01:00
259879d1f5
rpcrt4: Fix NdrConformantStringUnmarshall to use buffer memory if possible.
2007-12-17 11:58:06 +01:00
b300189c43
rpcrt4: Add a FIXME for RPC_FC_P_ALLOCALLNODES in PointerUnmarshall.
2007-12-17 11:58:00 +01:00
68432dd339
rpcrt4: Clear padding inserted into the buffer during marshalling because of alignment.
2007-12-17 11:57:54 +01:00
c8a802eea8
include: Make RpcRaiseException DECLSPEC_NORETURN, like it is in the PSDK.
2007-12-14 12:28:03 +01:00
ba280fb1b0
rpcrt4: Fix a typo in rpcrt4_conn_tcp_read.
2007-12-14 12:27:09 +01:00
25bf0a409a
rpcrt4: Update TODO list.
...
Out-of-memory check is performed by NdrAllocate and so isn't required to
be done in the unmarshalling functions.
2007-12-14 12:24:34 +01:00
4a028589eb
rpcrt4: Document NdrAllocate.
2007-12-14 12:24:24 +01:00
c7261b732b
rpcrt4: Partially revert commit 18faf3184b2ea263d77c2a7ad92eef27bc4ba08f.
...
Tests show that NdrPointerFree (and hence NdrFree) don't check whether
the memory was allocated with NdrAllocate before freeing it. This makes
sense as servers don't need to use NdrAllocate to allocate memory being
returned and so this commit caused that memory to be leaked.
NdrAllocate hasn't been changed as the tests show it is correct and it
appears that the memory list is used to implement the RpcSs memory model.
2007-12-14 12:24:21 +01:00
ce220e2b5f
rpcrt4: Free the base pointer in PointerFree when freeing a pointer with RPC_FC_P_DEREF.
2007-12-14 12:24:03 +01:00
d5ff3467bc
rpcrt4: Fix the check in NdrPointerFree.
...
Add comments to justify why this is the only check that is needed.
2007-12-14 12:23:55 +01:00
9d8ebc1a24
rpcrt4: NdrStubGetBuffer shouldn't set BufferStart and BufferEnd.
...
These are supposed to point to the original buffer when the types were
unmarshalled.
2007-12-14 12:23:46 +01:00
ded4b86625
Revert "rpcrt4: Try to free every non-stack pointer in PointerFree now that NdrFree does the sanity checking for us.".
...
This reverts commit 6db648302ce43f625a073426a35a6f40b7869d8b.
Tests show the assumptions in a commit that this commit depends on are
not valid.
2007-12-14 12:23:38 +01:00
9642714d06
rpcrt4: Add tests for freeing non-NdrAllocate allocated memory blocks.
2007-12-13 14:30:40 +01:00
e12b487e26
rpcrt4: Try to free every non-stack pointer in PointerFree now that NdrFree does the sanity checking for us.
2007-12-12 16:02:53 +01:00
9c8c74f388
rpcrt4: Store allocated memory in a singly-linked list to keep track of what we should and shouldn't free in NdrFree.
2007-12-12 16:02:43 +01:00
33c4c25dad
rpcrt4: Make the NdrAllocate tests pass on XP SP2 and greater.
2007-12-12 16:01:33 +01:00
d458a599eb
widl: Add support for non-basetype return types.
2007-12-11 18:07:05 +01:00
766d8a17af
rpcrt4: Pass the USER_MARSHAL_CB structure into user marshal routines.
2007-12-10 12:04:28 +01:00
80b8743aa2
rpcrt4: NdrRangeUnmarshall is implemented so add it to the spec file.
2007-12-10 12:04:19 +01:00
a07afe7e06
rpcrt4: Implement NdrConformantArrayMemorySize.
2007-12-10 12:04:15 +01:00
41937c5756
rpcrt4: Add a missing break in DllMain.
2007-12-08 19:58:24 +01:00
417b9d80f2
rpcrt4: Save the buffer in EmbeddedPointerMemorySize, like EmbeddedPointerUnmarshall does.
2007-12-08 19:58:11 +01:00
d7a0de303e
rpcrt4: Fix the return value from NdrSimpleStructMemorySize.
2007-12-08 19:58:07 +01:00
3a13de3115
rpcrt4: Add a trace to NdrBaseTypeMemorySize.
2007-12-08 19:58:03 +01:00
7ae1d44816
rpcrt4: Implement PointerMemorySize.
2007-12-08 19:57:55 +01:00
8348f0413d
rpcrt4: Fix NdrConformantStructUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:46 +01:00
a5f9ed81e3
rpcrt4: Fix NdrFixedArrayUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:39 +01:00
abbceb137a
rpcrt4: Fix NdrConformantArrayUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:32 +01:00
c0b12351e0
Avoid size_t types in traces.
2007-12-07 18:49:18 +01:00
7092590c90
rpcrt4: Use an alertable wait in rpcrt4_protseq_np_wait_for_new_connection to fix a small memory leak flagged by Valgrind.
...
This is called only by the RPCRT4_server_thread so we don't have to
worry about application user APCs being run at improper times.
2007-12-07 17:06:33 +01:00
ba6aec70ca
rpcrt4: Implement NdrConformantStructFree.
2007-12-07 17:06:05 +01:00
2ebee18198
rpcrt4: Improve PointerFree to not free buffer memory.
2007-12-07 16:34:17 +01:00
1b79da8be0
rpcrt4: Fix a memory leak caused by NdrFullPointerXlatFree not freeing the entries in the full pointer translation table.
2007-12-06 12:08:10 +01:00
867cc3c05f
rpcrt4: Fix a memory leak when freeing an association by deleting the critical section.
2007-12-06 12:08:05 +01:00
5fb5fccac0
rpcrt4: Fix a memory leak in RpcAssoc_BindConnection.
2007-12-06 12:08:00 +01:00
13e47d762a
rpcrt4: Set the memory pointer in NdrBaseTypeUnmarshall to the buffer if we're unmarshalling on a server without memory being passed in.
2007-12-05 13:49:08 +01:00
17132f7e1f
rpcrt4: Set fMustAlloc to TRUE when unmarshalling an object pointer.
2007-12-05 13:48:59 +01:00
c866b06806
rpcrt4: Add tests for a pointer to a conformant strings.
2007-12-04 18:18:03 +01:00
2a9fae7565
rpcrt4: Set the destination pointer in PointerUnmarshall before calling the referenced type's unmarshalling routine.
...
When a pointer that is dereferenced is encountered then this can result
in a stale pointer (i.e. the one that is marshalled into the buffer for
the embedded pointer unmarshalling case) being used instead of the one
that was intended.
2007-12-04 18:18:01 +01:00
a016d7b335
rpcrt4: Handle all non-continuable exceptions in CStdStubBuffer_Invoke.
2007-12-04 13:33:10 +01:00
6dcc3fe62e
rpcrt4: Put the delegating stub thunks in an executable memory page, rather than on the heap.
2007-12-04 13:32:41 +01:00
341208bf1b
rpcrt4: Call IRpcChannelBuffer_GetDestCtx in NdrStubInitialize, just like we do in NdrProxyInitialize.
2007-12-04 13:32:29 +01:00
f191f59ee4
rpcrt4: Flesh out more of the IRpcChannelBuffer vtable to make the test_delegating_Invoke test succeed on Windows.
2007-12-04 13:31:59 +01:00
620fca405d
rpcrt4: Test that the string retrieved from get_name was actually unmarshalled correctly.
2007-12-03 13:10:21 +01:00
d8e467b0fd
rpcrt4: Reverse the conditions for which *pPointer is assigned base_ptr_val in PointerUnmarshall.
...
In one condition (fMustAlloc == TRUE), base_ptr_val may be uninitialised
and so cause a valgrind warning. Reversing the check is harmless and
doesn't result in a performance decrease.
2007-12-03 13:10:21 +01:00
eef207e3f1
rpcrt4: Initialise the memory in test_simple_struct_marshal before passing it to NdrSimpleStructUnmarshall.
...
Otherwise, the unmarshalling code will read from unintialised memory
when trying to reuse the embedded pointers in the memory block.
Also fix a couple of memory leaks.
2007-12-03 13:10:21 +01:00
c735a14788
rpcrt4: Fix NdrSimpleStructUnmarshall to cope with [in, out] embedded pointers.
2007-11-30 11:56:30 +01:00
b676309db3
rpcrt4: Improve PointerUnmarshall to cope with keeping the non-NULL source pointer of a client unmarshall.
...
This will enable various types with embedded pointers to handle [in,out]
parameters correctly by keeping the existing memory.
2007-11-30 11:56:21 +01:00
4e8f69ac2d
rpcrt4: Move forcing of fMustAlloc to NULL to the callers of EmbeddedPointerUnmarshall.
...
This will enable them to be individually fixed up to use memory if it
was provided by the caller.
2007-11-30 11:56:11 +01:00
43e0c67fe2
rpcrt4: EmbeddedPointerUnmarshall doesn't need to change the address of the allocated memory, so reduce the level of indirection of the memory parameter by one.
2007-11-30 11:56:04 +01:00
34522de870
rpcrt4: Errors in sending or receiving packets should result in RPC_S_CALL_FAILED being returned, not RPC_S_PROTOCOL_ERROR.
2007-11-30 11:55:50 +01:00
8668369b4f
rpcrt4: Fix an integer overflow in NdrConformantStructMarshall and NdrConformantStructUnmarshall.
2007-11-29 13:31:05 +01:00
074898ba2b
rpcrt4: Fix some more potential buffer overflows.
2007-11-29 13:30:58 +01:00
5a3c34eb89
rpcrt4: Check there is enough space in the buffer and that the size doesn't cause an overflow when copying data to it.
2007-11-29 13:30:21 +01:00
d0223ecc0e
rpcrt4: Check for integer overflows when increasing the buffer length.
...
Rename safe_buffer_copy to safe_copy_from_buffer.
2007-11-29 13:30:04 +01:00
4171309731
rpcrt4: Fix the tests for up_enum16.
...
It is different to the other base types as it has a different size on
the wire to in memory, so it can't just be set to the buffer when
unmarshalling.
2007-11-27 16:42:17 +01:00
61ed0c99e6
rpcrt4: socket() returns -1 on error so check the return value against that.
2007-11-27 12:29:45 +01:00
046f24a0e7
rpcrt4: Raise an exception if a NULL ref-pointer is passed in to PointerMarshall or PointerBufferSize.
2007-11-21 12:03:35 +01:00
8a15423ab7
rpcrt4: Hold the thread-data's critical section while cancelling a call.
...
Check that there is a connection before trying to cancel it.
2007-11-19 13:53:22 +01:00
4fddc5e726
rpcrt4: Add some missing prototypes and better match the PSDK types.
2007-11-13 23:28:06 +01:00
3634dc1b1c
rpcrt4: Fix a copy and paste mistake in declaring threaddata_cs_debug.
...
Reported by Hans Leidekker.
2007-11-13 23:28:05 +01:00
b6ad7b5ef7
rpcrt4: Add an API documentation stub to make winapi_check happy.
2007-11-13 13:37:24 +01:00
a51486c657
rpcrt4: Implement RpcCancelThread for the ncacn_ip_tcp protocol sequence.
2007-11-13 13:34:50 +01:00
7ad36eabfc
rpcrt4: Add stubs for RpcMgmtSetCancelTimeout and RpcCancelThread.
2007-11-07 11:57:25 +01:00
ebe885d782
rpcrt4: Add a stub for RpcErrorStartEnumeration.
2007-11-07 11:57:20 +01:00
a0ac63961d
widl: Don't rely on type_memsize to return 0 for all conformant arrays.
2007-11-06 13:02:56 +01:00
04dc115b54
rpcrt4: Handle FC_IGNORE in the base type functions.
2007-11-05 15:06:06 +01:00
8d15820f79
widl: Handle pointers to conformant arrays (e.g., "[size_is(, n)] int **p; ").
2007-11-05 13:24:37 +01:00
8caa325eb7
rpcrt4: Initialize allocated pointers to NULL in PointerUnmarshall.
...
This patch initializes allocated pointers in PointerUnmarshall since later
code checks the value for NULL (specifically, NdrConformantArrayUnmarshall).
2007-11-05 13:24:36 +01:00
eaffc0a0da
rpcrt4/tests: Initialize memory in the get_name test.
...
This initializes the memory for an [in] parameter.
2007-11-05 13:24:36 +01:00
c4a1a081a9
rpcrt4: Factorise out the argument processing from NdrStubCall2 into two functions.
2007-11-05 13:24:36 +01:00
83bc80ada0
rpcrt4: Move some type definitions from ndr_stubless.c to ndr_stubless.h.
2007-11-05 13:24:36 +01:00
3eac5b4e59
rpcrt4: Add a small bit of documentation as to what NdrStubCall2 does.
2007-11-05 13:24:36 +01:00
18c16a8027
rpcrt4: Add a test for the pointers in [in,out] pointer structs not changing when the pointers aren't NULL.
2007-11-02 12:37:35 +01:00
826a6d09d4
rpcrt4: Initialize variable to avoid compiler warning.
2007-10-25 12:48:01 +02:00
ff8930f2bf
widl: Fix problems with variable-size user types.
2007-10-22 13:47:56 +02:00
1d0f9378bc
widl: Detect conformant arrays of user types correctly.
2007-10-18 12:09:23 +02:00
e219087c65
rpcrt4/tests: Free memory from one of the tests.
2007-10-15 16:55:31 +02:00
acfde97b9e
rpcrt4, widl: Make pointer layouts compatible with windows; fix conformant array tests.
2007-10-11 16:24:28 +02:00
d00ff2ed58
widl: Make structs containing user types bogus; fix square_test_us test failure.
2007-10-09 11:39:26 +02:00
e0b209815d
rpcrt4/tests: Make server.idl compatible with MIDL.
2007-10-09 11:39:21 +02:00
b7df430831
rpcrt4/tests: Remove static keywords that hide test failures.
2007-09-27 20:13:21 +02:00
723c8bacfa
widl: Fix string codes in pointer descriptions.
2007-09-27 10:09:38 +02:00
347f2a2da2
widl: Fix top-level conformant arrays with pointer attributes.
2007-09-27 10:09:32 +02:00
767a1f26f6
widl: Handle top-level conformance for complex arrays.
2007-09-20 14:27:29 +02:00
dbfabf68a2
widl: Respect pointer attributes better.
2007-09-20 14:27:25 +02:00
132f06cd48
widl: Implement complex arrays.
2007-09-19 11:39:09 +02:00
8df79f0c99
widl: Implement pointer descriptions for complex structures.
2007-09-19 11:38:28 +02:00
f67a6adf4e
rpcrt4: Implement RpcSmDestroyClientContext and RpcSsDestroyClientContext.
2007-09-19 11:36:41 +02:00
5191498564
rpcrt4: Fix a copy-and-paste error in RpcAuthInfo_Release that caused a double free of memory.
2007-09-19 11:36:28 +02:00
5e84eb9a47
widl: Add padding to the end of complex structures.
2007-09-14 14:43:13 +02:00
2eb0e1ce21
rpcrt4: Fix a trace in RPCRT4_SecurePacket.
2007-09-12 11:33:11 +02:00
e0e27e4dfb
rpcrt4: Correctly handle the failure of RPCRT4_SecurePacket in RPCRT4_Receive.
2007-09-12 11:33:10 +02:00
ba54c455fb
widl: Allow size_is on strings.
2007-09-10 15:29:46 +02:00
62fb623e14
widl: Implement NDR for struct field alignment.
2007-09-10 15:29:46 +02:00
3d036da6d3
widl: Fix top-level and callback conformances.
2007-09-10 15:29:46 +02:00
04e0986d60
rpcrt4: Constify some variables.
2007-08-22 11:58:13 +02:00
fa3d623882
rpcrt4: Constify some variables.
2007-08-20 11:56:05 +02:00
8a87d916b4
rpcrt4: Convert bind ack and nack reject reasons into RPC status codes when binding.
2007-07-23 11:48:13 +02:00
12d3905427
rpcrt4: Fix the buffer bounds check.
2007-07-19 12:03:50 +02:00
d212adbf10
rpcrt4: Add some more RPC to NCA status code mappings.
...
Add RPC_S_SEC_PKG_ERROR to the list of "hard" errors.
2007-07-18 12:56:16 +02:00
2703059933
rpcrt4: Never allocate memory for the discriminant in union_arm_unmarshall as the memory is part of the union and has already been allocated.
2007-07-16 22:46:59 +02:00
b44c16cc8d
rpcrt4: Check to make sure there is enough data in the buffer during unmarshalling, so that the code doesn't try to read beyound the end of the buffer.
2007-07-16 22:46:55 +02:00
686c0f094c
rpcrt4: Even though FC_ENUM16 is an unsigned type, the highest allowable value that can be marshalled is SHRT_MAX, not USHRT_MAX.
2007-07-16 22:46:47 +02:00
c6dc14d81b
rpcrt4: Make binding to an interface a function of RpcAssoc instead of
...
binding handles, since binding requires information from the
association and not from the binding handle.
2007-07-13 12:27:17 +02:00
69eeb8b1b7
rpcrt4: Return a fault packet if the proc num exceeds the index of the last function available for the interface.
2007-07-05 19:53:53 +02:00
234b8cbe0a
rpcrt4: Call RPCRT4_Send directly from PKT_RECEIVE handler in server.
...
Remove the WINE_RPCFLAG_EXCEPTION hack to pass exception information to
I_RpcSend.
2007-07-05 19:53:47 +02:00
9c77d7ac1f
rpcrt4: Translate between NCA and RPC status codes.
2007-07-05 19:53:29 +02:00
67c8fa58ec
rpcrt4: Store the assoc_group_id in the connections.
2007-06-27 12:32:43 +02:00
9787f12589
rpcrt4: Make pointers to RPCRT4_BuildBindHeader and RPCRT4_BuildBindAckHeader const.
2007-06-27 12:32:43 +02:00
680e35643d
rpcrt4: Remove the unused AuthInfo field from the RpcAssoc structure and Used from RpcConnection.
2007-06-27 12:32:42 +02:00
46222aee6e
widl: Allow enums as union switch types.
2007-06-26 11:59:53 +02:00
ea7b1694de
rpcrt4: Allow enums as union switch types.
2007-06-26 11:59:43 +02:00
076a6206ff
rpcrt4/tests: Wrap a try/except block around tests.
2007-06-26 11:59:32 +02:00
512c36cae6
widl: Get simple enums working.
2007-06-26 11:59:02 +02:00
545c2a95f6
rpcrt4: Dereference the pointer passed to the marshaling/unmarshaling/sizing routines in complex types for interface pointers.
2007-06-25 23:21:55 +02:00
fc124eca6e
rpcrt4: Implement marshalling, unmarshalling and buffer sizing for the context handle type.
2007-06-25 23:21:55 +02:00
d36f02eaa9
rpcrt4: Implement marshalling/unmarshalling for the range NDR type.
2007-06-25 23:21:54 +02:00
4174255e0c
rpcrt4: Set PointerBufferMark to the buffer location immediately after the non-pointer data in complex struct and array marshaling and unmarshaling to keep to the DCE/RPC specification.
2007-06-25 23:21:54 +02:00
cbafe663b0
rpcrt4: Try a lot harder to resuse existing connections by comparing inside the RpcQualityOfService and RpcAuthInfo objects.
...
Store a copy of the SEC_WINNT_AUTH_IDENTITY structure passed in to
RpcBindingSetAuthInfo(Ex) to enable us to do this for RpcAuthInfo objects.
2007-06-25 23:21:54 +02:00
0ebcacca39
rpcrt4: Store the assoc_group_id field returned from the bind_ack packet and use it when creating further connections in the association group.
2007-06-25 23:21:53 +02:00
62c49bdd18
rpcrt4: When an exception is raised, return the stored exception code instead of the generic RPC_S_CALL_FAILED.
2007-06-25 23:21:53 +02:00
2de3d31a7a
rpcrt4: Translate STATUS_ACCESS_VIOLATION exceptions caught whilst executing the stub function to ERROR_NOACCESS to prevent confusing exceptions occurring in the client.
2007-06-25 23:21:53 +02:00
c411d95e20
rpcrt4: Close the connection if a protocol error or certain other kinds of errors occur, instead of returning it to the connection pool.
2007-06-25 23:21:53 +02:00
0d05685b68
rpcrt4: Return a fault packet if the interface/object pair in a request packet aren't registered.
2007-06-25 23:21:52 +02:00
903fb72b21
rpcrt4: Add a STUBLESS_FREE phase for freeing the allocated memory in the server function.
2007-06-25 23:21:52 +02:00
a1dca20dd7
rpcrt4: Add support for ServerAllocSize parameters.
2007-06-25 23:21:52 +02:00
73c31ed309
rpcrt4: Don't use add on the sizes of array elements to an open-ended structure; use FIELD_OFFSET with the array index instead.
2007-06-25 23:21:52 +02:00
4e8c8d03e5
widl: Add tests for arrays of pointers.
2007-06-21 13:10:46 +02:00
0f826e7cc1
rpcrt4: Use the offset to array data in embedded pointer format descriptions.
2007-06-20 13:08:30 +02:00
d2c15ed01b
rpcrt4: Fix typo in union buffer size calculation.
2007-06-19 11:46:02 +02:00
6fd05b1dc7
rpcrt4: Fix bug calculating union switch type.
2007-06-19 11:45:51 +02:00
b09b917a5c
rpcrt4: Remove inaccurate comments.
2007-06-19 11:45:44 +02:00
08c846a9da
rpcrt4: Add encapsulated union tests.
2007-06-19 11:45:11 +02:00
0871ab9130
rpcrt4: Implement encapsulated union NDR functions.
2007-06-18 13:58:09 +02:00
3325020636
widl: Handle wire_marshal pointer attributes.
2007-06-14 11:36:05 +02:00
2bc8808be1
widl: Test structure argument marshalling.
2007-06-14 11:35:55 +02:00
c0982b42c5
widl: Handle wire_marshal types.
2007-06-14 11:35:44 +02:00
88c8128704
widl: Simplify correlation descriptor code.
2007-06-12 11:13:30 +02:00
8f689ee023
widl: Implement conformant structure handling.
2007-06-06 12:13:35 +02:00
978b4d4f4e
widl: Represent arrays with type_t.
2007-06-06 12:13:16 +02:00
e5c8a6eb5d
rpcrt4: Fix build of test on Solaris by renaming a variable.
2007-05-31 13:07:13 +02:00
8d7ad785e3
rpcrt4/tests: Fix a Visual C++ double to float conversion warning.
2007-05-29 13:46:19 +02:00
Michael Stefaniuc