Commit Graph

877 Commits

Author SHA1 Message Date
Eric Pouech f158558d19 regedit: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-04 11:20:33 +01:00
Eric Pouech acdbe6c296 regedit/tests: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-03 17:19:41 +01:00
Alexandre Julliard f0cd33c69e include: Add support for defining Win32 types as 'long' where possible.
Add -DWINE_NO_LONG_TYPES to modules that still have compilation
warnings with long types.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-27 20:38:22 +01:00
Alexandre Julliard 8667b8d124 regedit: Use the standard va_list instead of __ms_va_list.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-25 11:01:38 +02:00
Alexandre Julliard 088a787a2c makefiles: Make -mno-cygwin the default.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-20 22:45:48 +02:00
Zhiyi Zhang 190467d6af regedit: Add system DPI awareness settings to the application manifest.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-07 10:16:56 +02:00
Zhiyi Zhang f623608f9f regedit: Enable visual styles.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-06-10 23:04:03 +02:00
Hugh McMaster c1733540d6 regedit: Allow deletion of selected values without focus.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-06-08 22:28:44 +02:00
Alexandre Julliard 8f2f59eee1 regedit: 64-bit regedit.exe is in c:\windows.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50933
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-06 12:39:28 +02:00
Hugh McMaster b8b7979f9c regedit: Stop parsing REG_SZ values containing NUL character sequences.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-03-12 12:49:39 +01:00
Hugh McMaster 7eb77bef05 regedit/tests: Add tests for escaped null characters.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-03-11 13:13:35 +01:00
Hugh McMaster d1fbb6b999 regedit/tests: Remove elevated user checks from the Windows 3.1 test sequences.
The tests only run if regedit.exe is started with elevated privileges.
This is determined when the test suite is invoked.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-25 08:57:02 +01:00
Hugh McMaster bedd54c968 regedit/tests: Comprehensively check for elevated privileges before starting tests.
Calls to regedit.exe on user accounts with standard privileges trigger a UAC
prompt. Not responding to the prompt eventually causes a test timeout, so
use registry API calls to determine if the tests are running with elevated
privileges.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-25 08:56:59 +01:00
Hugh McMaster ee579a0f1d regedit/tests: Add tests for forward and back slashes in key and value names.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:58 +01:00
Hugh McMaster 704bd45da5 regedit/tests: Add additional tests with embedded NUL characters.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:56 +01:00
Hugh McMaster 294be8b7a2 regedit/tests: Use delete_key() and delete_tree() where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:53 +01:00
Hugh McMaster a3b1743ced regedit/tests: Replace RegCloseKey() with the helper function close_key().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:49 +01:00
Hugh McMaster c86e62442f regedit/tests: Ensure test key is fully removed before each sequence begins.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:42 +01:00
Hugh McMaster 8a43d29ef4 regedit/tests: Check for elevated privileges before cleaning up the Windows 3.1 test key and running unit tests.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:34 +01:00
Alexandre Julliard d9884c930f regedit: FormatMessage() now reports ERROR_NO_WORK_DONE error for empty string.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-05-13 22:07:31 +02:00
Piotr Caban f11a740266 regedit: Fix double free error in GetValueName.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-31 17:44:51 +01:00
Alexandre Julliard a58f4abc08 makefiles: Allow using EXTRADLLFLAGS instead of APPMODE.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-24 11:27:39 +02:00
Zebediah Figura a41c73d43e regedit: Use an I-beam cursor in the hex edit dialog.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-22 11:15:47 +02:00
Zebediah Figura cf274c6f0c regedit: Use the default implementation of WM_ERASEBKGND.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-19 12:02:14 +02:00
Alexandre Julliard 9b63daca51 include: Default to the standards-compliant version of swprintf().
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-11 16:46:41 +02:00
Alexandre Julliard 0b18409cfc regedit: Use C runtime wchar functions instead of wine/unicode.h.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-01 11:48:30 +02:00
Alistair Leslie-Hughes 75d8081dc6 regedit: Grow the buffer when modifying a DWORD value.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=19098
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-21 08:23:57 +01:00
Michael Stefaniuc 73a997c6ba regedit: Remove redundant NULL check before heap_free().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-29 21:40:00 +01:00
Alexandre Julliard d84de4ca00 makefiles: Support specifying installed files in the top-level makefile.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-27 14:48:04 +01:00
Alistair Leslie-Hughes 006d3f3365 regedit: Don't expand items on initial tree creation.
The Message TVM_EXPAND is captured in treeview_notify, then passes
g_pChildWnd->hTreeWnd on to OnTreeExpanding which hasn't been
initialized yet.  The function get_last_key is already called after
the hTreeWnd has been assigned to select the previous selected
item (if it exists).

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:02:31 +02:00
Hugh McMaster 6b620e6d61 regedit: Do not overwrite a hex data type with REG_BINARY when modifying a value.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster a131cff7a8 regedit: Replace Hungarian notation used with struct edit_params members.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster 32f487bdb2 regedit: Always display DWORD values in hexadecimal when initializing the editor dialog.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster a7a08e2927 regedit: Free allocated memory after calling GetValueName().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster 1291c6ded4 regedit: Don't check if heap_xalloc() succeeded in the caller.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:44 +02:00
Hugh McMaster 2686166cc1 regedit: Remove array already present in main.h.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:44 +02:00
Michael Stefaniuc 962b31c80b include: Add a generic available ARRAY_SIZE().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 10:39:15 +02:00
Zebediah Figura 2831fe2f84 regedit: Print Latin-1 characters.
This makes spot-checking differences with Windows a little easier.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-03 11:28:03 +02:00
Hugh McMaster c7718d31c7 regedit: Pass NULL instead of the address of an empty WCHAR.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-28 22:08:23 +02:00
Hugh McMaster cc200d0a50 regedit: Confirm whether to delete a registry value from framewnd.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-28 22:08:23 +02:00
Hugh McMaster 5bc81188fe regedit: Do not directly include resource.h anymore.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-23 17:33:57 +02:00
Hugh McMaster 5509d84e9a regedit: Sort function declarations alphabetically by source file.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:29:10 +02:00
Hugh McMaster 3526746b06 regedit: Remove implicit extern keywords from function declarations.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:29:07 +02:00
Hugh McMaster a926e05446 regedit: Do not directly include stdio.h any longer.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:28:07 +02:00
Hugh McMaster 20e5b9e82f regedit: Simplify boolean comparisons in edit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:27:58 +02:00
Hugh McMaster b24ee836bd regedit: Simplify the detection of existing registry values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:27:19 +02:00
Hugh McMaster a20f99b548 regedit: Use the ARRAY_SIZE macro.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:26:27 +02:00
Hugh McMaster 73220a3d6f regedit: Remove regproc.h.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:26:01 +02:00
Hugh McMaster f6476c79e3 regedit: Move regedit.c functions from regproc.h to main.h.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:23:09 +02:00
Hugh McMaster ff1f664d08 regedit: Move regproc.c functions from regproc.h to main.h.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:22:58 +02:00