Commit Graph

1893 Commits

Author SHA1 Message Date
Alexandre Julliard bc8e70c089 ole32/tests: Make some variables static. 2010-10-01 13:37:14 +02:00
Michael Stefaniuc 620ca68d01 ole32: Allocate a small temp variable on the stack instead of the heap. 2010-09-29 10:07:54 +02:00
Andrew Eikum 91d91afb7d ole32: Create a FORMATETC if one is not given in OleCreate. 2010-09-28 17:33:20 +02:00
Huw Davies 250b55c41d ole32: Call the draw_continue function. 2010-09-28 17:33:17 +02:00
Huw Davies 6c7dd939cf ole32/tests: Mark the draw_continue callbacks as optional. Win9x can skip calls under low-load conditions. 2010-09-28 17:33:17 +02:00
Alexandre Julliard 81b8ee863e makefiles: Add a standard header for all makefiles to replace the common variable initializations. 2010-09-19 12:36:48 +02:00
Marcus Meissner 8d25534613 ole32: Check for interface NULL which happens with e.g. Abiword. 2010-09-16 13:37:32 -05:00
Vincent Povirk 2752c3bcd0 ole32: Don't fail if the file ends during a big block.
Apparently, it's valid for the last block in a file to be incomplete.
2010-09-08 13:30:46 +02:00
Alexandre Julliard dd84876c3e ole32: Use int64 in the spec file for 64-bit integers. 2010-08-31 14:23:48 +02:00
Vincent Povirk 89646084ba ole32: Cache data and block locations in BigBlockStream objects. 2010-08-26 13:59:31 +02:00
Vincent Povirk 101de22a1a ole32: Flush before returning from any storage API call that writes. 2010-08-26 13:59:28 +02:00
Huw Davies 127260bb62 ole32: Pass a real IUnknown ptr to CoMarshalInterface. 2010-07-28 16:28:21 +02:00
Michael Stefaniuc ffac31da09 ole32: Use IsEqualIID instead of memcmp to compare REFIIDs. 2010-07-23 11:46:29 +02:00
Huw Davies 6d1ef3a6a6 ole32: Implement cross-process drag and drop. 2010-07-22 16:11:59 +02:00
Huw Davies a2e1dd29dc ole32/tests: Relax the reference counting tests a bit. We only care whether references are held or not. 2010-07-22 16:11:51 +02:00
Nikolay Sivov 1b0182f9bb ole32: Use IsEqualIID() instead of memcmp(). 2010-07-21 17:38:37 +02:00
Nikolay Sivov 114510801f ole32: No need to test for interface pointer being null. 2010-07-21 17:38:37 +02:00
Nikolay Sivov 2f61e19156 ole32: Fix assumption about HRESULT failure code value. 2010-07-21 17:38:37 +02:00
Nikolay Sivov 5185409144 ole32: Remove redundant variables. 2010-07-21 17:38:37 +02:00
Alexandre Julliard b86d515ed6 dlls: Remove explicit imports of kernel32 and ntdll. 2010-07-21 17:38:36 +02:00
Vincent Povirk 5116b979b2 ole32: Flush the ILockBytes object of a storage on commit and final release.
Some ILockBytes objects will not really write changes until their Flush
method is called. Also, further optimizations to the storage implementation
will involve caching writes, which will have to be flushed at times.
2010-07-19 14:38:16 +02:00
Vincent Povirk b7dbfcbd48 ole32: Remove an unused variable. 2010-07-19 14:38:16 +02:00
Vincent Povirk d0e6e4aa82 ole32: Use ILockBytes_Stat to get the filename of a storage. 2010-07-19 14:38:16 +02:00
Vincent Povirk 14f8f9d5b5 ole32: Remove the BigBlockFile abstraction and always use an ILockBytes. 2010-07-19 14:38:16 +02:00
Vincent Povirk 4171499411 ole32: Don't map storage files in memory. 2010-07-19 14:38:16 +02:00
Vincent Povirk 7f3c92b2a0 ole32: Update storage header saving code based on the latest MS spec.
These fields are needed for the MS storage implementation to load
files that were created by Wine with a block size of 4096.
2010-07-19 14:38:16 +02:00
Vincent Povirk 9c95761d9e ole32: Always check the size of the small block root chain.
In some storage files, the size of this stream is not a multiple of the big
block size. This means that we may need to enlarge the stream even when we
don't really have to allocate more space for it.
2010-05-28 16:22:24 +02:00
Vincent Povirk d64ee9ff11 ole32: Fix seeking backwards in hglobalstream. 2010-05-27 14:46:43 +02:00
Vincent Povirk ff4292c229 ole32/tests: Add more IStream_Seek tests for hglobalstream. 2010-05-27 14:46:42 +02:00
Michael Stefaniuc 162e420f0e ole32: Avoid potential NULL pointer dereferences in a TRACE. 2010-05-26 10:11:05 +02:00
Alexandre Julliard 78d1686b90 ole32: Implement the IAdviseSink call_as proxies and stubs.
Based on a patch by Rob Shearman.
2010-05-25 12:49:19 +02:00
Juan Lang c94b2687d2 ole32: Only read known format ids when attempting to read summary information. 2010-05-25 12:02:47 +02:00
Juan Lang b4c3a04165 ole32/tests: Test creating an IPropertySetStorage with an unknown format id. 2010-05-25 12:02:37 +02:00
Andrew Nguyen 07325c7d7c ole32/tests: Add tests for output parameters in MkParseDisplayName. 2010-05-21 18:58:05 +02:00
Andrew Nguyen 7bdf023e69 ole32: Validate pointer parameters in MkParseDisplayName. 2010-05-21 18:58:05 +02:00
Nikolay Sivov 2c80e14eec ole32: Use window property to store registered drop target. 2010-05-18 08:53:08 +02:00
Vincent Povirk 57ddceea34 ole32: Use a temporary variable in TransactedSnapshotImpl_EnsureReadEntry.
CreateStubEntry can change the value of This->entries, in which case the
assignment can go to the wrong place. So instead, assign to a temporary
variable, and copy the data back after all CreateStubEntry calls are finished.
2010-05-13 11:51:07 +02:00
Marcus Meissner bf1e9a2e93 ole32: Fixed 2 uninitialized variable use (Coverity). 2010-05-10 10:03:43 +02:00
Vincent Povirk dbf123ba0d ole32: Fix reads past the end of streams. 2010-05-07 12:46:50 +02:00
Vincent Povirk 4ad114cfae ole32: Use the cached information in BlockChainStream_GetCount. 2010-05-07 12:46:39 +02:00
Vincent Povirk e40afcb2b6 ole32: Always move unmodified streams instead of copying on commit. 2010-05-06 17:55:43 +02:00
Vincent Povirk d07a4868a1 ole32: Rewrite transacted storage to be more lazy.
When creating a new transacted storage object (or reverting an
existing one), rather than copy the original storage, we simply create
a "stub directory entry" for the root. As stub entries are accessed,
we fill in their data from the parent and create new stubs for any
linked entries. The streams have copy on write semantics - reads are
from the original entry until a change is made, then we make a copy in
the scratch file.

When committing transacted storages, we have to create a new tree with
the new data so that the storage entry can be modified in one step,
but unmodified sections of the tree can now be shared between the new
tree and the old. An entry can be shared if it and all entries
reachable from it are unmodified. In the trivial case where nothing
has been modified, we don't have to make a new tree at all.
2010-05-06 17:55:34 +02:00
Nikolay Sivov 56fdbc226e ole32/ole2: Use W calls for registry access. 2010-05-06 14:22:23 +02:00
Vincent Povirk 42550953a6 ole32: Store the location of all blocks in a big block chain in memory.
A big block chain is a linked list, and we pretty much need random
access to them. This should theoretically make accessing a random
point in the chain O(log2 n) instead of O(n) (with disk access scaling
based on the size of the read/write, not its location). It
theoretically takes O(n) memory based on the size, but it can do
better if the chain isn't very fragmented (which I believe will
generally be the case for long chains). It also involves fetching all
the big block locations when we open the chain, but we already do that
anyway (and it should be faster to read it all in one go than
piecemeal).
2010-05-05 10:41:57 +02:00
Vincent Povirk 93cc582a8d ole32: Remove some assumptions about the internals of BlockChainStream. 2010-05-05 10:41:26 +02:00
Nikolay Sivov 286c5f8816 ole32/marshal: Compare with S_OK instead of keeping in mind that it's zero. 2010-05-03 15:43:01 +02:00
Gerald Pfeifer c6f74e386b ole32: Fix return value for CoRevokeMallocSpy. 2010-05-03 15:40:20 +02:00
Gerald Pfeifer 889900f020 ole32: Fix return value of DefaultHandler_SetClientSite. 2010-05-03 15:40:13 +02:00
Nikolay Sivov f3ab3d971a ole32/ole2: If no effect action selected use ::DragLeave() instead of ::Drop(). 2010-05-03 13:58:59 +02:00
Nikolay Sivov 9c44ed8a6b ole32/ole2: After IDropTarget::DragEnter() failure target doesn't count as valid. 2010-05-03 13:58:54 +02:00