ff0f2b35e1
msi: Add tests for MsiLocateComponent and make them pass.
2010-06-14 14:41:45 +02:00
b4674a3c2b
msi: Don't trace the contents of an output buffer.
2010-06-14 14:41:42 +02:00
67f15e7149
msi: Implement MsiGetFeatureCostA/W.
2010-06-11 15:54:54 +02:00
6b1a1579f6
msi: Update an existing record even if the low bit in the transform mask is set.
2010-06-11 15:54:47 +02:00
73774b3ef8
msi: Disable an optimization in the execution of WHERE clauses.
...
There's no guarantee that the condition strings are in the string table.
2010-06-11 15:54:35 +02:00
15f5b9dca3
msi: Compare file versions as numbers instead of strings.
2010-06-11 15:54:24 +02:00
04a6a14c1f
msi: Don't allow entering text in a scroll text richedit control.
2010-06-10 14:48:28 +02:00
b8ac327e7e
msi: Display the directory identifier instead of the full path in standard actions.
2010-06-09 16:15:52 +02:00
5ecbc4f8ca
msi: Directly pass the disk id to installfiles_cb.
...
The MEDIAINFO structure is modified by the cabinet_next_cabinet
callback if there's a continuous cabinet in the installer.
2010-06-09 16:14:24 +02:00
dcb501decd
msi: Create directories right before installing files.
2010-06-09 16:12:44 +02:00
1a159dfddc
msi/tests: Testcases for CREATE TABLE.
2010-06-07 15:15:49 +02:00
c99c5a41e9
msi/tests: Fix install tests for Win9x.
2010-06-07 13:44:20 +02:00
761ce56643
msi: Update Korean resource.
2010-06-02 16:01:57 +02:00
e1a63fd5c2
msi: Pass the control name to ControlEvent_SubscribeToEvent instead of uninitialized memory.
2010-05-31 12:46:08 +02:00
35a0461baa
msi: Improve parsing of patch summary information.
2010-05-31 12:46:08 +02:00
d17ebc4032
msi: Advance to the right cabinet in ACTION_MsiPublishAssemblies.
2010-05-31 12:46:08 +02:00
8bfc08771c
msi: Don't keep handles open to the patch database in MSI_ApplyPatchW.
2010-05-31 12:46:08 +02:00
beb0b2bc05
msi: Publish icons into the correct directory.
2010-05-31 12:14:27 +02:00
c35856dd09
msi: End the search for a directory signature if the parent cannot be found.
2010-05-25 13:29:56 +02:00
c2ce561469
msi: Add a test for properties updated by a patch.
2010-05-25 13:29:35 +02:00
c815432a50
msi: Get rid of the goto in MSI_ApplicablePatchW.
2010-05-25 13:29:22 +02:00
598a25de82
msi: Ignore min/max versions if their values are null.
2010-05-24 20:33:28 +02:00
23f9b07d6a
msi: Update Dutch translation.
2010-05-24 11:14:52 +02:00
cc9e357ecf
msi: Fix English translation.
2010-05-24 11:14:44 +02:00
5395c999d2
msi: Add more tests for feature overrides.
2010-05-20 16:25:44 +02:00
e16f187791
msi: Test the reference count on the installer object retrieved from a session object.
2010-05-20 16:25:44 +02:00
2e24d34b22
msi: Fix some leaks in the tests.
2010-05-20 16:25:44 +02:00
7a370c8d7b
msi: Consistently use the allocation macros.
2010-05-20 16:25:44 +02:00
57a6b6fb38
msi: Release the package in MsiGetMode and MsiSetMode.
2010-05-20 16:25:44 +02:00
e5dd509901
msi: Release the package in MsiGetProductPropertyW.
2010-05-20 16:25:44 +02:00
a4c25196b0
msi: Fix memory leaks in deformat_string_internal.
2010-05-20 16:25:44 +02:00
2ba53f476c
msi: Update French translation.
2010-05-13 19:44:59 +02:00
e60bf536eb
msi: Improve some traces.
2010-05-12 18:46:35 +02:00
6475c11c1f
msi: Only extract a file when its disk id matches the media disk id.
...
This makes sure that an updated file is extracted from the cabinet stream
included in the patch, instead of the original source.
2010-05-12 18:46:32 +02:00
376c2fd02b
msi: Store the disk id in the MSIFILE structure.
2010-05-12 18:46:28 +02:00
dd305c3700
msi: Set the SourceDir property to the registered source if the product is installed.
2010-05-11 16:28:18 +02:00
41a7f025e4
msi: Avoid A->W conversions in msi_publish_install_properties.
2010-05-11 16:28:12 +02:00
347bb13fc7
msi: Set install properties just once.
2010-05-11 16:28:07 +02:00
4d2fb55e4e
msi: Add a test to show that the InstallSource property is unchanged after an upgrade.
2010-05-11 16:28:02 +02:00
715a506fac
msi: Add more patch registration tests.
2010-05-11 16:27:56 +02:00
06a8cc2a06
msi: Add a test to show that patches are not committed to the local package database.
2010-05-11 16:27:49 +02:00
acd9732ffe
msi: Fix the return value of msi_copy_outval in the error case.
2010-05-10 10:10:24 +02:00
aa2542bfcd
msi: Update Lithuanian translation.
2010-05-10 10:05:32 +02:00
2a9b4e0142
msiexec: Use resource in msi for a help dialog to allow translation.
2010-05-06 17:56:44 +02:00
82d7b04c2c
msi: Apply registered patches in MsiOpenPackage.
2010-05-05 15:27:12 +02:00
881ef98479
msi: Forward MsiDetermineApplicablePatchesA to MsiDetermineApplicablePatchesW.
2010-05-05 15:27:08 +02:00
920fc345ba
msi: Register more patch details.
2010-05-04 13:15:00 +02:00
74641ab8db
msi: Handle non-null product code in MSI_ApplyPatchW.
2010-05-04 13:15:00 +02:00
25460075cc
msi: Add some tests for patch registration.
2010-05-04 13:15:00 +02:00
23eabb44c8
msi: Make a local copy of patch packages.
2010-05-04 13:15:00 +02:00
be8d0bbb1e
msi: Remove variable product_code which is not really used from MSI_ApplyPatchW.
2010-05-03 15:38:47 +02:00
effda58ad3
msi: Fix return value for ITERATE_RemoveFiles (in the error case).
2010-05-03 15:38:39 +02:00
2d2823ae44
msi: Fix Dutch translation.
2010-05-03 13:55:21 +02:00
1cc32247e0
msi: Update Dutch translation.
2010-05-03 13:54:41 +02:00
162780d112
msi: Support multiple patches per package.
2010-04-29 10:19:40 -05:00
df6b195a1a
msi: Simplify msi_set_context.
2010-04-29 10:19:40 -05:00
c6f281fcf7
msi: Make sure to only open a patch database in msi_apply_patch_package.
2010-04-29 10:19:40 -05:00
73f1294431
msi: Test the contents of some of the system tables before and after patching.
2010-04-29 10:19:40 -05:00
319465831c
msi: Store a copy of the file extension in the MSIMIME structure.
...
Fixes a crash that occurs when the extension foreign key points to nowhere.
Reported by Vincent Pelletier.
2010-04-29 10:19:39 -05:00
7d9d6707c1
msi: Fix some test failures on Windows.
2010-04-29 10:19:39 -05:00
82fdc926a2
msi: Move all file comparisons to CostFinalize.
...
File costing can't be done correctly on upgrades unless we know
which files are going to be overwritten.
2010-04-28 15:04:40 -05:00
9af488d236
msi: Always evaluate component conditions.
...
Fixes a regression caused by 0d770c96fe
2010-04-28 15:04:40 -05:00
43f7bc8687
msi/tests: Use a unique product code when testing MsiConfigureFeature parameter validation.
...
This is to avoid ERROR_INSTALL_ALREADY_RUNNING errors on Windows.
2010-04-28 15:04:39 -05:00
d9510f5962
msi: Only set the property in the Reinstall event.
2010-04-28 15:04:39 -05:00
f23bf7a460
msi/tests: Return INVALID_FILE_SIZE from get_pf_file_size if the file can't be opened.
...
So we can distinguish a zero-sized file from a file that doesn't exist.
2010-04-28 15:04:39 -05:00
a5a58910b6
msi: Try to apply a patch to each product it is targeted for.
...
A patch may target multiple products but only one of them needs to
be installed for the patch to succeed. Fixes an Acrobat Reader 9 patch.
2010-04-21 11:57:33 +02:00
e31ee69f37
msi: Rename MSI_GetPropertyW and MSI_SetPropertyW.
...
For consistency with related functions msi_dup_property and msi_get_property_int
and because there is no ANSI version of these functions.
2010-04-21 11:57:33 +02:00
44b7983913
msi: Make MSI_SetPropertyW take a pointer to a database instead of a package.
2010-04-21 11:57:33 +02:00
186f4efa3f
msi: Make msi_get_property_int and friends take a pointer to a database instead of a package.
...
They only operate on a database and this way we can use them before a package is created.
2010-04-21 11:57:33 +02:00
031d2c63e8
msi: Add a test to show that MsiOpenPackage must apply any existing patches.
2010-04-21 11:57:33 +02:00
80878d00da
msi: Sync combo control value with associated property.
2010-04-19 15:13:30 +02:00
857f979468
msi: Fill combo control with items from database.
2010-04-19 15:13:19 +02:00
2793a4fd52
msi: Use standard window class for combo control and add error checking.
2010-04-19 15:12:48 +02:00
9c892430ba
msi: Fix crash when calling MsiGetActiveDatabase with invalid remote handle.
2010-04-19 15:12:41 +02:00
d8504e0550
msi: Handle MSIDBOPEN_PATCHFILE properly in MsiOpenDatabase.
2010-04-19 14:57:49 +02:00
9a9faeffd8
msi: Don't assume unversioned files are present.
2010-04-19 14:57:43 +02:00
f08c355e09
msi: Add beginnings of a test module that concentrates on patches.
2010-04-19 14:57:35 +02:00
8f53405544
msi: Remove the string index parameter from msi_addstringW.
2010-04-19 14:57:02 +02:00
fc15e565d3
msi: Make the name parameter of create_storage and create_stream constant.
2010-04-19 14:56:58 +02:00
111d33b393
msi: Remove unused and redundant name field from STORAGE structure.
2010-04-19 14:56:53 +02:00
109ffd0f97
msi: Make the string reference count a short.
...
This is safe because the reference count is stored in 2 bytes on disk.
(This is commit ff2f89488888214a72ce
2010-04-14 18:00:39 +02:00
33299faae4
msi: Move application of substorage transforms out of msi_parse_patch_summary.
2010-04-13 11:48:30 +02:00
bcc0ad9b07
msi: Release summary information on error in msi_parse_patch_summary.
2010-04-13 11:48:25 +02:00
a0ba56b3bd
msi/tests: Run the RemoveODBC action to unregister the fake drivers.
2010-04-13 11:48:20 +02:00
88214a72ce
msi: Make the string reference count a short.
...
This is safe because the reference count is stored in 2 bytes on disk.
2010-04-13 11:48:14 +02:00
ff2f894888
msi: Make the string reference count a short.
...
This is safe because the reference count is stored in 2 bytes on disk.
2010-04-13 11:46:14 +02:00
d4303865e8
msi: Display a MessageBox in MsiMessageBoxEx.
2010-04-12 11:31:12 +02:00
55fbf84d26
msi/tests: Remove temporary files.
2010-04-09 11:53:58 +02:00
dd1bef3498
msi: Reset the MsiEnumPatchesExW index on failure.
2010-04-02 15:22:50 +02:00
7aad77ae58
msi: Add tests for registering and unregistering MIME info.
2010-04-02 15:22:49 +02:00
3050cde95e
msi: Implement the UnregisterMIMEInfo standard action.
2010-04-02 15:22:49 +02:00
a7ef96f97f
msi: Add tests for registering and unregistering extension info.
2010-04-02 15:22:49 +02:00
17d7effd2a
msi: Implement the UnregisterExtensionInfo standard action.
2010-04-02 15:22:49 +02:00
3bdfa1f624
msi: Implement the UnregisterProgIdInfo standard action.
2010-04-02 15:22:48 +02:00
90158af2dc
msi: Add tests for registering and unregistering class info.
2010-04-02 15:22:48 +02:00
cf75d40dad
msi: Set the action taken in the RegisterExtensionInfo and RegisterClassInfo actions.
2010-04-02 15:22:48 +02:00
843968c056
msi: Implement the UnregisterClassInfo standard action.
2010-04-02 15:22:47 +02:00
86f76d2b48
msi: Fix compiler warnings with flag -Wcast-qual.
2010-03-29 12:14:44 +02:00
f930c87fd6
objbase.h: CLSIDFromString: Add constness to the parameters declaration in accordance with MSDN.
2010-03-29 12:11:02 +02:00
5a08c9ed6f
msi: Improve the SetODBCFolders action stub.
2010-03-26 15:35:37 +01:00
2c5e1f686b
msi: Implement the Reinstall control event.
2010-03-26 15:35:32 +01:00
e5869d5d5c
msi: Keep source directory and cabinet file separate.
2010-03-26 15:35:24 +01:00
1407f1ee36
msi: Return the right error when a cabinet cannot be extracted.
2010-03-26 15:35:20 +01:00
129161fec5
msi: Update the UI in the StartServices and StopServices actions.
2010-03-26 15:35:17 +01:00
4a88562ec7
msi: Reset the MsiEnumProductsW index on failure.
2010-03-26 15:34:48 +01:00
d495fa1e68
msi/tests: Fix test failures on W2K with Windows Installer 3.0.
2010-03-25 13:01:29 +01:00
114aa43a54
msi/tests: Fix test failures on W2K with Windows Installer 2.x.
2010-03-25 13:01:24 +01:00
05d0787d08
msi/tests: Fix test failures on W2K with Windows Installer 2.x.
2010-03-24 21:53:05 +01:00
1d453a1ff0
msi: Search network sources in addition to disk sources.
2010-03-23 13:24:27 +01:00
faf750f2f7
msi: Remove stream from streams cache before destroying it.
2010-03-23 13:24:27 +01:00
367c2048a1
msi: Don't crash on null last parameter in MsiDecomposeDescriptor.
2010-03-23 13:24:27 +01:00
d0856c0ac5
msi: Display REG_EXPAND_SZ values too in the WriteRegistryValues action.
2010-03-23 13:24:26 +01:00
18a85caa3c
msi: Update the UI in the UnpublishFeatures action.
2010-03-23 13:24:26 +01:00
706c4f77e8
msi: Implement a second cabinet extractor on top of IStream and use it to extract embedded cabinets.
...
Currently a cabinet stream is read into memory and then written to a file,
which is then extracted like an external cabinet file. This uses more time
and disk space than necessary and fails if the cabinet is too large to fit
into memory.
2010-03-23 13:24:26 +01:00
27e90274b5
msi: Set the action taken in the ProcessComponents and InstallFiles actions.
2010-03-23 13:24:26 +01:00
8722d0c44a
msi: The AppSearch and CCPSearch actions must be run only once.
2010-03-23 13:24:26 +01:00
a4be941df9
msi: Display the file identifier instead of the filename in the SelfRegModules and SelfUnregModules actions.
2010-03-23 13:24:26 +01:00
ba51763f4a
msi/tests: Remove temporary files.
2010-03-22 10:42:48 +01:00
fbef7217b9
makefiles: Remove the no longer needed explicit dependencies for bison files.
2010-03-16 13:28:24 +01:00
bef5645eb1
makefiles: Remove the no longer needed explicit separators for dependencies.
2010-03-16 13:28:19 +01:00
5c6de7957e
msi: Convert IWineMsiRemoteDatabase BSTR parameters to LPCWSTR to avoid typecast.
2010-03-15 14:18:06 +01:00
e5c182f0df
msi/tests: Remove a key after running tests.
2010-03-15 13:17:38 +01:00
73d316c58d
msi: Also update the UI when removing files listed in the RemoveFiles table.
2010-03-05 13:14:46 +01:00
ab9a181326
msi: Update the UI in the RegisterUser action.
2010-03-05 13:14:41 +01:00
4341f18c7e
msi: Update the UI in the RegisterProduct action.
2010-03-05 13:14:36 +01:00
c547fb3629
msi: Display the product code in the PublishProduct action.
2010-03-05 13:14:32 +01:00
e90fbf09c7
msi: Update the UI in the MsiPublishAssemblies action.
2010-03-05 13:14:27 +01:00
a358c7f6d4
msi: Update the UI in the MoveFiles action.
2010-03-05 13:14:23 +01:00
aba6afc85e
msi: Move the implementation of the MoveFiles action to files.c.
2010-03-05 13:14:19 +01:00
a5549305de
msi: Update the UI in the RemoveODBC action.
2010-03-05 13:14:11 +01:00
eff0503f64
msi: Update the UI in the InstallODBC action.
2010-03-05 13:14:06 +01:00
bb9451adae
msi: Display the product code in the FindRelatedProducts action.
2010-03-05 13:14:01 +01:00
2666294f64
msi: Properly update the UI in the DuplicateFiles and RemoveDuplicateFiles actions.
2010-03-05 13:13:57 +01:00
3c36d9d1f9
msi: Update the UI in the DeleteServices action.
2010-03-05 13:13:52 +01:00
a70d86d3c9
msi: Display directory identifier instead of the full path in the CreateFolders action.
2010-03-05 13:13:47 +01:00
868e6f2bc8
msi: Update the UI in the AppSearch action.
2010-03-05 13:13:42 +01:00
31d0664ebd
msi: Update the UI in the AllocateRegistrySpace action.
2010-03-05 13:13:37 +01:00
353035fadd
msi: Initialize a couple of variables.
...
Found by Valgrind.
2010-03-04 12:30:29 +01:00
aaf5ffb2b5
msi: Add tests for removing environment strings.
2010-03-03 15:23:28 +01:00
f62211198a
msi: Implement the RemoveEnvironmentStrings standard action.
2010-03-03 15:23:23 +01:00
7b6858546c
msi: Strip leading text style label from control text before lookup in binary table.
2010-03-03 15:23:15 +01:00
0270f18e11
msi: Correctly set the process working directory in custom action type 34.
2010-03-03 11:52:37 +01:00
75ec82bbaf
msi: Add tests for removing values from .ini files.
2010-03-02 16:12:23 +01:00
b891d0888a
msi: Implement the RemoveIniValues standard action.
2010-03-02 16:12:17 +01:00
1fe30e0015
msi: Skip the FindRelatedProducts action when product is already installed.
2010-03-02 16:12:08 +01:00
e637839a83
msi: Improve a trace.
2010-03-02 16:11:57 +01:00
6c6b2a7a18
msi: Look at the requested action when publishing assemblies, not the action taken.
2010-03-02 16:11:53 +01:00
ff3ed5f051
msi: Look at the requested action when moving files, not the action taken.
2010-03-02 16:11:49 +01:00
c13d84fffc
msi: Look at the requested action when deleting services, not the action taken.
2010-03-02 16:11:44 +01:00
2d3676d912
msi: Look at the requested action when stopping services, not the action taken.
2010-03-02 16:11:40 +01:00
87448dcaeb
msi: Look at the requested action when installing services, not the action taken.
2010-03-02 16:11:36 +01:00
c8308ef99d
msi: Only create environment strings when the component is set to be installed.
2010-03-02 16:11:31 +01:00
a64372ca44
msi: Improve a trace.
2010-03-02 16:11:24 +01:00
930b5e1c68
msi: The table for isolated components is called IsolatedComponent.
2010-02-26 14:20:53 +01:00
fd5887e5a9
msi: Remove empty directories as part of the RemoveFiles action.
2010-02-26 14:20:48 +01:00
b2c8f35107
msi: Add tests for removing registry values.
2010-02-25 16:00:58 +01:00
342f866044
msi: Implement the RemoveRegistryValues standard action.
2010-02-25 16:00:51 +01:00
5c59617121
msi: Add tests for creating and removing duplicate files.
2010-02-23 13:31:04 +01:00
253a7fa73c
msi: Implement the RemoveDuplicateFiles standard action.
2010-02-23 13:31:01 +01:00
587e107398
msi: Allocate sufficient memory in ITERATE_InstallODBCDriver and ITERATE_InstallODBCTranslator.
...
Found by Valgrind.
2010-02-22 13:15:22 +01:00
a620a84f4c
msi/tests: Free exception information.
...
Found by Valgrind.
2010-02-22 13:15:16 +01:00
ba090ede7b
msi: All stream names starting with 0x0005 are unencoded.
...
Fixes a regression caused by 1ff9923148
2010-02-22 13:15:09 +01:00
ec5ae81c8d
msi: Make msi_reset_folders static.
2010-02-22 13:14:35 +01:00
6164ce2d82
makefiles: Use the standard C_SRCS variable as the list of test files.
...
This enables it to be auto-updated by make_makefiles.
2010-02-22 10:47:11 +01:00
1ff9923148
msi: Add summary information stream to the streams table.
2010-02-19 13:06:53 +01:00
ddb2091623
msi: Fix a memory leak.
2010-02-19 13:06:46 +01:00
9f68142118
msi: Encode stream name in the callers of db_get_raw_stream.
2010-02-19 13:06:41 +01:00
d9e40b8219
msi: Destroy streams cache when applying a transform.
2010-02-19 13:06:36 +01:00
f80f1cc2db
msi: Accept '\5' and '-' in SQL identifiers.
2010-02-19 13:06:32 +01:00
f4bcb105d2
msi: Include run mode in fixmes.
2010-02-19 13:06:27 +01:00
65c68efc8d
msi: Implement MSIRUNMODE_MAINTENANCE and MSIRUNMODE_REBOOTATEND for MsiGetMode.
2010-02-18 14:39:11 +01:00
a11882fc0f
msi: Implement MsiSetMode.
2010-02-18 14:39:06 +01:00
7b660bb3d8
msi: Add tests for publishing and unpublishing components.
2010-02-17 10:57:45 +01:00
0f0e81d14a
msi: Implement the UnpublishComponents standard action.
2010-02-17 10:57:40 +01:00
d95e3eb4d2
msi: PublishComponents must look at the requested install state of the feature, not the component.
2010-02-17 10:57:35 +01:00
9cbb80d984
msi: Only run the CreateFolder and RemoveFolder actions when the component is set to be installed or removed, respectively.
2010-02-16 12:29:08 +01:00
c32d9d7004
msi: Get rid of ACTION_VerifyFeatureForAction.
2010-02-16 12:29:01 +01:00
598c542607
msi: Get rid of ACTION_VerifyComponentForAction.
2010-02-16 12:28:56 +01:00
54391a11c0
msi: Update the UI when registering or unregistering type libraries.
2010-02-16 12:28:48 +01:00
438ad93b22
msi: Implement and test MsiGetPatchInfoA/W.
2010-02-15 16:36:39 +01:00
b4bdfe6746
msi: Add tests for creating and removing shortcuts.
2010-02-15 12:20:02 +01:00
2276c291fc
msi: Implement the RemoveShortcuts standard action.
2010-02-15 12:20:02 +01:00
983cff23fa
msi/tests: Fix a test failure on Win9x/WinMe.
2010-02-12 16:39:39 +01:00
f7879b43d5
msi: Fix a memory leak in ITERATE_StartService.
...
Found by Valgrind.
2010-02-12 14:49:38 +01:00
82d50fa675
msi: Return the right error from ITERATE_RegisterTypeLibraries.
2010-02-12 14:49:38 +01:00
98761037ab
msi: Implement the UnregisterTypeLibraries standard action.
2010-02-12 14:49:38 +01:00
bbfaf6af75
msi: Add tests for installing and removing ODBC drivers.
2010-02-11 14:38:45 +01:00
28bf8e1f0d
msi: Implement the RemoveODBC standard action.
2010-02-11 14:38:45 +01:00
2568e5ec65
msi: Make sure attrs variable is properly double nul-terminated in ITERATE_InstallODBCDataSource.
2010-02-11 14:38:45 +01:00
4742dfba98
msi: The File_Setup field in the ODBCDriver and ODBCTranslator tables is optional.
2010-02-11 14:38:45 +01:00
312e4f6b23
msi/tests: Run the 'in_use' tests again.
2010-02-10 17:31:28 +01:00
068cb1291b
msi: Add a partial implementation of the ValidateProductID standard action.
2010-02-10 14:31:49 +01:00
7331b3ca98
msi: Implement the UnregisterFonts standard action.
2010-02-10 14:31:15 +01:00
5df62d0c42
msi: Add stub implementations of the DisableRollback and InstallAdminPackage standard actions.
2010-02-10 14:31:05 +01:00
9644d1dcd7
makefiles: Generate a general catch-all dependency on .tab.h files to replace the manually maintained ones.
2010-02-08 20:58:00 +01:00
f5af1ca399
msi: Implement the SelfUnregModules standard action.
2010-02-05 15:33:11 +01:00
3864ddf9f2
msi: Implement the RemoveFolders standard action.
2010-02-05 15:33:05 +01:00
5c4a3bd61b
msi: Handle some error returns (Coverity).
2010-02-04 17:27:34 +01:00
9fab263d39
msi: Call Custom function via wrapper.
2010-02-04 14:06:34 +01:00
b9da31f112
msi: Implement the DeleteServices standard action.
2010-02-04 13:39:29 +01:00
3d38c07706
msi: Add tests for the _Streams table implementation.
2010-02-04 13:39:29 +01:00
19b50cff34
msi: Fix an off-by-one error in STREAMS_find_matching_rows.
2010-02-04 13:39:29 +01:00
95a21c27da
msi: Give the Name field from the _Streams table a valid type.
2010-02-04 13:39:29 +01:00
24dd10c6b0
msi: Make room for the new row in STREAMS_insert_row.
2010-02-04 13:39:28 +01:00
c1940c1c5f
msi: Allow overwriting an existing stream in STREAMS_set_row.
2010-02-04 13:39:28 +01:00
dcbe0fdff2
msi: Encode the stream name before trying to open it.
2010-02-04 13:39:28 +01:00
b833ae0263
msi: Improve error handling in STREAMS_set_row and add_streams_to_table.
2010-02-04 13:39:28 +01:00
5741df2e58
msi: Implement STREAMS_get_row.
2010-02-04 13:39:28 +01:00
74d6fe35a2
msi: Remove unused and redundant name field from STREAM structure.
2010-02-04 13:39:28 +01:00
aafcf1a536
msi: Remove function name from fixme.
2010-02-04 13:39:28 +01:00
643f55abab
msi: Don't print the function name twice in a WARN.
2010-02-04 13:39:28 +01:00
06e15ee9e6
msi: Copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl.
2010-02-04 13:39:26 +01:00
9a0020ade9
msi: Move some helpers to the module where they are used.
2010-02-03 11:31:48 +01:00
29f47299c2
msi: Implement the ScheduleReboot standard action.
2010-02-03 11:31:48 +01:00
552a9c9b85
msi: Add a stub implementation of the SetODBCFolders standard action.
2010-02-03 11:31:48 +01:00
743ead45c8
msi: Test duplicating files from a nonexistent component.
2010-02-02 11:47:19 +01:00
3299bfd471
msi: Fix crash with access to component.
2010-02-02 11:47:19 +01:00
086711818b
msi/tests: Fix some test failures on Win9x up to W2K.
2010-02-02 11:47:19 +01:00
2197da7770
msi: Fix Italian translation.
2010-02-01 12:48:13 +01:00
246f9305e9
msi: Don't fail if the service to start is already running.
2010-02-01 12:11:18 +01:00
a0774cabab
msi: Avoid using HIWORD() on string pointers.
2010-01-29 17:25:49 +01:00
0ee3836844
msi: Add Ukrainian translations.
2010-01-29 13:30:04 +01:00
1d0db2b19b
msi: Don't create all directories in the CreateFolders action.
...
The CreatFolders action should create only the directories listed in the
CreateFolder table, the rest will be created during the InstallFiles action.
Fixes the EndNote 8 installer.
2010-01-28 15:30:26 +01:00
aa19638cb9
msi: Improve some traces.
2010-01-28 15:30:25 +01:00
7c9cb1e1be
msi: Name and arguments in the service control table are formatted strings.
2010-01-28 15:30:25 +01:00
4d14ea47f7
msi: Add a test for MsiSetTargetPath.
2010-01-28 15:30:25 +01:00
0d770c96fe
msi: Don't evaluate the condition table when there are overrides.
2010-01-27 18:46:08 +01:00
36b654e695
msi: Add tests for updating rows in join tables.
2010-01-22 13:09:15 +01:00
882e4fb233
msi: Add support for updating rows in join tables.
2010-01-22 13:09:11 +01:00
de3fa09cb2
msi: Add a partial stub for the ValidateProductID control event.
2010-01-20 15:36:00 +01:00
06c45a8d59
msi: Correct the setting of environment variables.
...
Contrary to the MSDN, you can 'create only' whilst using a previous value
(ie +-variable and [~];value). This breaks the install of an application
I was debugging who uses that throughout for all their variables. In
addition whilst adding some tests I've also cleaned up invalid prefix
syntax handling and semicolon removal if the original string is empty.
2010-01-20 15:34:19 +01:00
72393c55e9
msi: Add a test to exersize the code to retrieve rows from join tables.
2010-01-19 16:50:56 +01:00
2bfce6cfdc
msi: Fix parsing of feature overrides.
2010-01-18 14:39:23 +01:00
1423ef9923
msi: Support retrieving rows from join tables.
2010-01-18 14:39:17 +01:00
0c437f558c
msi: Queue dynamically allocated strings in cond.y.
2010-01-08 17:03:15 +01:00
2e339c471e
msi/tests: Remove dead url.
2010-01-06 09:52:52 +01:00
d1a916a614
msi: Implement recursive INSTALLSTATE updates for msi treeview selector.
2010-01-06 09:51:17 +01:00
dcf1a0c891
msi: Fix some pointer cast warnings on 64-bit.
2009-12-31 12:12:15 +01:00
e2f7946bbc
msi: Removed unnecessary NULL check.
2009-12-22 13:48:26 +01:00
4749b079b5
msi/tests: Fix test failures on Win9x/WinMe.
2009-12-21 15:01:24 +01:00
839e487c84
msi: Propagate errors from IStorage_OpenStream again in db_get_raw_stream.
...
Fixes a regression introduced by ef522c5ef0
2009-12-18 11:47:46 +01:00
699cfc915a
msi: Avoid a crash in STREAMS_delete.
2009-12-18 11:47:39 +01:00
d9c52bfa70
msi: Free the current filename if we choose to not extract the file.
2009-12-18 11:45:30 +01:00
178ebae4c0
msi: Reset the ALLUSERS property from to 2 to 1.
2009-12-17 14:21:39 +01:00
ff2aa7e3a6
msi: Fix download of installer packages. Return errors from msi_download_file and copy_package_to_temp.
2009-12-17 14:21:32 +01:00
26d541b2a9
msi: Initialize type. If the value did not exist, type was uninitialized and passed to RegSetValueExW.
2009-12-17 13:09:46 +01:00
6b403d1a31
msi: Move MSITRANSFORM and MSISTREAM and associated methods to the dabatase implementation file as they are database objects/methods.
2009-12-17 12:53:34 +01:00
a2f5d0e270
msi: Free the cached streams when closing the database.
2009-12-17 12:53:27 +01:00
2102dbe854
msi: Remove an unused field from the string table.
2009-12-17 12:43:25 +01:00
2c526b7fe7
msi: Replace the string table hash with a sorted index.
2009-12-16 13:04:35 +01:00
ef522c5ef0
msi: Clone the open stream instead of trying to open a stream again.
2009-12-16 13:04:35 +01:00
8ed06175a0
msi: Free the temp buffer if we haven't assigned it to *appValue.
2009-12-16 12:42:39 +01:00
b530f38baa
msi: Refactor freeing the import sql strings.
2009-12-16 12:42:33 +01:00
1b7238a969
msi: Simplify ITERATE_WriteEnvironmentString.
...
Now we only allocate enough memory to exactly match the size of the
constructed string. Before, we were leaving some memory uninitialized
and overwriting the allocated memory in certain circum.
2009-12-16 12:27:11 +01:00
be1b1605f9
msi: Free the columns view if check_column_exists fails.
2009-12-16 12:26:59 +01:00
1a4a112d76
msi: Fix a leaking record handle.
2009-12-16 12:26:51 +01:00
b93c2c3544
msi: Free the join view if we fail to create the table view.
2009-12-16 12:26:45 +01:00
1692e1fe67
msi: Keep track of the current view in the sql parser.
...
This allows us to free said view in the case of a syntax error. This
also allows us to get rid of a few places where we tried to clean up
the view ourselves in the parsing code.
2009-12-16 12:26:38 +01:00
6df6332198
msi: Reject greater than and less than string comparisons in WHERE clauses.
2009-12-15 11:45:04 +01:00
8fe8a100c8
msi: Free the enumeration data returned by IEnumSTATSTG_Next.
2009-12-14 12:20:48 +01:00
7abb42a994
msi: Free each table object when deleting the join view.
2009-12-14 12:20:43 +01:00
ee2cf9a597
msi: Free the Streams and Storages view object in their respective delete methods.
2009-12-14 12:20:39 +01:00
f45db6eee7
msi: Implement DROP_delete that deletes the drop view. We were leaking the view before.
2009-12-14 12:20:33 +01:00
37a058208d
msi: Fix a record handle leak.
2009-12-14 12:20:25 +01:00
d2fe01aa32
msi: Free each storage name when deleting the storages view.
2009-12-14 12:20:20 +01:00
3188792a30
msi: Store the number of types we queried. We were leaking these types because we didn't have the correct count.
...
This change also fixes weird 8-space indenting in free_merge_tables.
2009-12-14 12:20:14 +01:00
12134243c3
msi: Free each stream name when deleting the streams view.
2009-12-14 12:20:03 +01:00
a7fe36b327
msi: Don't free str until the last instance of its use.
2009-12-14 12:19:58 +01:00
f4829063bc
msi: Make sure we don't access pcchValueBuf when szBuffer is NULL, as pcchValueBuf is not required to be initialized in this case.
2009-12-14 12:19:52 +01:00
8b50188f57
msi/tests: Fix a handle leak.
2009-12-11 20:20:30 +01:00
350cdd2fe5
msi/tests: Remove some barriers to running msi tests in parallel.
2009-12-11 17:47:30 +01:00
50833f0780
msi: Wine fails the test and passes us a Session object back, so free it in this case.
2009-12-11 12:16:27 +01:00
e38c36a1f9
msi: Refactor the Installer.RelatedProducts method into InstallerImpl_RelatedProducts.
2009-12-11 12:16:27 +01:00
105933f202
msi: Refactor the Installer.Products method into InstallerImpl_Products.
2009-12-11 12:16:27 +01:00
9f09d47be3
msi: Refactor the Installer.ProductInfo method into InstallerImpl_ProductInfo.
2009-12-11 12:16:27 +01:00
fd2884a155
msi: Refactor the Installer.ProductState method into InstallerImpl_ProductState.
2009-12-11 12:16:27 +01:00
11b4fe743a
msi: Refactor the Installer.RegistryValue method into InstallerImpl_RegistryValue.
2009-12-11 12:16:27 +01:00
138d5f1f6c
msi: Refactor the Installer.Version method into InstallerImpl_Version.
2009-12-11 12:16:27 +01:00
96c480b880
msi: Refactor the Installer.InstallProduct method into InstallerImpl_InstallProduct.
2009-12-11 12:16:27 +01:00
851e4779be
msi: Refactor the remaining Installer object stub methods into respective functions.
2009-12-11 12:16:27 +01:00
dc0889752a
msi: Refactor the Installer.UILevel method into InstallerImpl_UILevel.
2009-12-11 12:16:27 +01:00
18ba830ff8
msi: Refactor the Installer.SummaryInformation method to InstallerImpl_SummaryInformation.
2009-12-11 12:16:27 +01:00
554e1318c0
msi: Refactor Installer.OpenProduct and Installer.OpenDatabase into respective functions.
2009-12-11 12:16:27 +01:00
b33d47e773
msi: Refactor the Installer.OpenPackage method into InstallerImpl_OpenPackage.
2009-12-11 12:16:26 +01:00
b73389b6bf
msi: Refactor the Installer.CreateRecord method into InstallerImpl_CreateRecord.
2009-12-11 12:16:26 +01:00
ae58e29e5e
msi: Stub out a few more Installer object methods.
2009-12-11 12:16:26 +01:00
9ab7d9e21a
msi: Close the original record before copying new data into it.
2009-12-11 12:16:26 +01:00
a44b653d53
msi: Fix a handle leak in the record tests.
2009-12-11 12:16:26 +01:00
d90aca35c4
msi: Add a NULL terminator to file->dest after reallocation.
2009-12-08 12:36:51 +01:00
b13803ea40
msi: Free the column info data when updating the table column info.
2009-12-08 12:36:36 +01:00
c20902314b
msi: Make sure to free the extra row data when deleting a row.
2009-12-08 12:36:28 +01:00
3840de5b1e
msi/tests: Loosen check on kernel32 language version.
2009-12-07 14:18:29 +01:00
25ab693008
msi: The second parameter to Installer.OpenPackage is optional, so set a default value of 0 if the parameter is not provided.
2009-12-07 09:49:06 +01:00
1ff6c08621
msi: Verify that the first parameter to Installer.OpenPackage is a VT_BSTR.
...
It seems ugly to open up the parameters in pDispParams, but
DispGetParam will happily convert a VT_EMPTY to a VT_BSTR and not
return an error.
2009-12-07 09:49:06 +01:00
4687604356
msi: It's possible to send in more than two parameters to Installer.OpenPackage, but sending in zero parameters should return DISP_E_TYPEMISMATCH.
2009-12-07 09:49:06 +01:00
b614052895
msi: Add more tests for the Installer.OpenPackage method.
...
The following series fixes a few leaks reported by valgrind. We were
leaking exception info caused by Installer.OpenPackage failing when we
didn't expected it.
2009-12-07 09:49:06 +01:00
7d3e664312
msi: MsiSetMode returns a UINT system error code, not a BOOL.
2009-12-04 14:34:57 +01:00
6b8b82ef13
msi: ExpandEnvironmentStringsW returns the required size in characters, so multiply the required size by sizeof(WCHAR) when allocating the buffer.
2009-12-03 10:22:40 +01:00
fd8620f6c0
msi/tests: Don't check more bytes than written to the file.
2009-12-01 13:16:30 +01:00
abb23d8bd5
msi: Support _Streams, _Storages tablename prefixes in SELECT.
2009-11-24 15:54:06 +01:00
f7ba4b2ec0
msi/tests: Test for SELECT table.column FROM table.
...
Make sure that mixing table columns returns the expected
data. eg: SELECT t1.action, t2.action FROM t1, t2
should return distinct data.
2009-11-24 15:54:00 +01:00
5c56e1f440
msi: Add support for table names in select statements.
...
Propagate tablename from 'SELECT tablename.column from tablename' queries
into VIEW_find_column(). Previously, the tablename had been dropped.
2009-11-24 15:53:53 +01:00
d28eabda5c
msi: Shedule rename operation also for ERROR_USER_MAPPED_FILE.
2009-11-20 14:37:09 +01:00
83e7a1214a
msi: Sign extend the value when converting from a small integer.
2009-11-19 11:50:36 +01:00
1f7a07ebe3
oleaut32: Ignore milliseconds in VarDateFromUdate implementation.
2009-11-19 11:35:40 +01:00
bd4bc16147
msi: Don't set the ALLUSERS property.
2009-11-17 16:05:27 +01:00
fd549aa25d
msi: Set the LogonUser property.
2009-11-17 16:05:15 +01:00
84ddfd8739
msi: Test more variations of environment string prefixes.
2009-11-13 13:35:58 +01:00
e52531ab1d
msi: Handle environment strings without a value.
2009-11-13 12:21:46 +01:00
b960b967c9
msi: Improve stub for MsiGetFeatureCost{A, W} and hook the stub into the VolumeCostList dialog control.
2009-11-09 19:43:23 +01:00
97619affe5
msi/tests: Make the handler_xxx() functions static.
...
Also remove extraneous semi-colons.
2009-11-09 19:40:44 +01:00
0839ae88ca
msi/tests: MsiSetExternalUIRecord not present before Installer 3.1.
2009-11-05 11:57:21 +01:00
808343fb5b
msi: Implement MsiSetExternalUIRecord.
2009-11-03 22:23:08 +01:00
90fa4fe155
msi: Unicode and ANSI global UI handlers are mutually exclusive.
2009-11-03 22:23:01 +01:00
4b5248c9e0
msi: Add support for the Unicode version of the global UI handler.
2009-11-03 22:22:54 +01:00
0513f3c4e6
msi: Add support for msidbControlAttributesProgress95.
2009-10-29 15:48:38 +01:00
df8780356b
msi: Limit the progress to its maximal value, use MulDiv for better results.
2009-10-29 15:48:27 +01:00
07c321ba73
msi: Test that a query on a join of two tables returns data from the correct table.
2009-10-27 14:01:50 +01:00
cc366e1282
msi: Add tablename tracking to VIEW_find_column.
...
This fixes the bug where multiple columns of the same name, but
different tables are members of a join. Any attempt to refer to these
columns will resolve to the first available column with that name,
irregardless of any tablename modifier.
2009-10-27 14:01:23 +01:00
2eb33f5bcb
msi: Avoid accessing uninitialized memory in ACTION_AppSearchReg.
...
Found by valgrind.
2009-10-27 10:53:56 +01:00
3f70b07870
msi/tests: Fix a couple of user SID string leaks.
...
Found by valgrind.
2009-10-27 10:53:42 +01:00
e58ebbf3e0
msi: Fix calculation of required buffer size in MsiSummaryInfoGetPropertyW.
2009-10-23 12:04:38 +02:00
394a437723
msi/tests: Free the string returned from ConvertSidToStringSid.
...
Found by valgrind.
2009-10-23 12:04:06 +02:00
483590a3c5
msi/tests: Avoid accessing uninitialized memory.
...
Found by valgrind.
2009-10-23 12:04:00 +02:00
a15e6cbb1a
msi: Avoid accessing uninitialized memory.
...
Found by valgrind.
2009-10-21 17:05:54 +02:00
47ec8ab0f3
msi: Remove table_find_insert_idx().
...
The function table_find_insert_idx() is replaced by the more generic
function find_insert_index().
2009-10-20 15:57:25 +02:00
f6ae2507ef
msi: Fix table rows order.
2009-10-20 15:57:09 +02:00
efacff81d6
msi: Add function get_table_value_from_record.
2009-10-20 15:57:01 +02:00
9dddb94b99
msi: Fix merging string type checks.
2009-10-20 15:55:43 +02:00
925fb3b408
msi/tests: Add tests for rows order.
2009-10-20 15:07:07 +02:00
8d49633275
msi/tests: Add test for merging string types.
2009-10-20 15:03:39 +02:00
a3214c978d
msi: Fix a failure with merging existing tables.
2009-10-20 15:03:33 +02:00
6aad5cb307
msi/tests: Add tests for merging existing tables.
2009-10-20 15:03:24 +02:00
afcd2c5358
msi: Open the database read/write in MSI_OpenPackageW.
...
Fixes transforms that add binary streams.
2009-10-20 14:40:01 +02:00
8dd3d389b0
msi: Create the local copy before opening the database.
2009-10-20 14:39:55 +02:00
33d9f37f4a
msi: Always create a temporary copy of the package.
2009-10-20 14:39:47 +02:00
534f20bc49
msi: Get rid of some redundant initializations.
2009-10-19 15:02:42 +02:00
b7a81df452
msi: Allocate MSISCRIPT structure at package creation time.
2009-10-19 15:02:36 +02:00
a187b43ddd
msi: Eliminate the last parameter from ACTION_PerformActionSequence.
2009-10-15 14:17:24 +02:00
e3aa2f33d9
msi: Use a function to test the UI level instead of passing a boolean around.
2009-10-15 14:17:18 +02:00
796eed1dc7
msi: Reorder functions to avoid forward declarations.
2009-10-15 14:17:06 +02:00
55b89f4a66
msi: Add some tests for MsiGetTargetPathW.
2009-10-15 14:16:57 +02:00
843382f284
msi: Define common strings only once.
2009-10-15 14:16:50 +02:00
fe935e8d50
Assorted spelling fixes.
2009-10-08 12:17:31 +02:00
fa6ffb4d5d
Fix empty function prototypes.
2009-10-07 12:24:53 +02:00
35df8f2d69
msi/tests: Skip some tests on Win9x/WinMe.
2009-10-02 11:51:23 +02:00
9c8b83ce01
msi: Schedule a rename operation when the file to overwrite is in use.
2009-10-01 12:04:02 +02:00
f8ec47d5c6
msi/tests: Remove trailing '\'.
2009-09-29 18:08:30 +02:00
c0c6daeb5a
msi: Test installing over in-use files.
2009-09-29 16:06:23 +02:00
46ac59f988
msi: Don't set the Installed property twice.
2009-09-29 16:06:23 +02:00
Hans Leidekker