Commit Graph

62 Commits

Author SHA1 Message Date
Alexandre Julliard 1110d62752 shell32: Grow the file list dynamically in SHFileOperation.
This avoids searching the same directories twice, once to count the
files and then once for real.
2006-03-06 17:47:57 +01:00
Alexandre Julliard 23cb632be2 shell32: Store only the file attributes in the file list for SHFileOperation.
We don't need the rest of the WIN32_FIND_DATA structure.
2006-03-06 16:44:31 +01:00
Alexandre Julliard b222001def shell32: Fixed handling of null-terminated file list in SHFileOperation. 2006-03-06 16:42:34 +01:00
Aric Stewart c29b7c3524 shell32: Skip dot directories in SHFileOperation.
In ShFileOperation when generating a file list with * wildcards, for
example for deletion, do not include the dot directories (. and ..) in
the list, because that cause the operation to spiral out of control.
2006-03-06 15:57:22 +01:00
Alexandre Julliard d37a119ee6 shell32: Fixed a couple of FindFirstFile handle leaks. 2006-01-27 15:48:29 +01:00
James Hawkins 1be970d485 shell32: Reimplement a factored SHFileOperation. 2006-01-23 11:22:59 +01:00
Markus Amsler 671738d5c1 Improve c2man Documented-Total count. Changes:
- add missing description
- add missing returns section
- complete missing A/W pairs
- reformate comments, to match c2man requirements
2005-11-10 11:15:22 +00:00
Francois Gouget f5c9da6860 Assorted spelling fixes. 2005-05-06 15:44:31 +00:00
Troy Rollo 98d336c363 Fix SEGV for non-fully-qualified destination paths.
Don't fail ShFileOperationW if FOF_ALLOWUNDO is passed.
2005-04-19 09:49:05 +00:00
Hans Leidekker 2294e30dd4 - Revert wrong -noname markup for Drag*, DoEnvironmentSubst and
SHGetNewLinkInfo{A,W}.
- Also mark stub exports -noname when they are exported by ordinal
  only on win98/2k.
- Implementation level stubs for SheChangeDirA, SheGetDirA,
  SHHelpShortcuts_RunDLL{A,W}.
- New spec file stubs for Control_RunDLLAsUserW,
  FixupOptionalComponents, OCInstall, SHChangeNotifySuspendResume,
  SHCreateProcessAsUserW, SHExtractIconsW,
  SHInvokePrinterCommand{A,W}, SHIsFileAvailableOffline,
  SHLoadNonloadedIconOverlayIdentifiers, SHPathPrepareForWrite{A,W},
  ShellExec_RunDLL{,A,W}, SHGetIconOverlayIndex{A,W}.
2005-02-21 18:37:33 +00:00
Joris Huizer e889f71269 - renamed file_operation_delete and to shfileops_delete
- renamed file_operation_checkFlags to shfileops_check_flags
- added helper function shfileops_do_operation()
- added helper function shfileops_get_parent_attr()
- added helper function shfileops_get_parent_attr2()
- various cleanups in SHFileOperationW using these functions
2005-02-17 11:50:25 +00:00
Joris Huizer 2d58a624dd - add file_operation_delete
- add file_operation_checkFlags
- use these in SHFileOperationW replacing inline code
2005-01-14 16:51:14 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard 758b2887e9 Remove some no longer needed AW functions. 2004-12-17 19:20:07 +00:00
Rolf Kalbermatter 87fb440e71 Fix bad memory allocation for unicode buffer. 2004-10-27 21:18:35 +00:00
Francois Gouget 3bb5b093e8 Assorted spelling fixes. 2004-10-22 22:27:51 +00:00
Rolf Kalbermatter eb883577e4 - SHCreateDirectory should create intermediate directories if
necessary.
- Remove extra boolean parameter in SHNotifyMoveFile as it is not
  used.
- Use in SHFileOperation the function SHNotifyCreateDirectory instead
  of SHCreateDirectoryEx as it does not anymore what is needed here.
- Fix several unsigned/signed mismatch warnings.
2004-10-21 22:29:42 +00:00
Rolf Kalbermatter 20952a5d23 Modify ANSI functions to allocate intermediate Unicode strings on the
heap instead of stack.
2004-10-18 21:45:16 +00:00
Rolf Kalbermatter 29d4ec4f85 Added SHFreeNameMappings implementation. 2004-10-18 19:33:45 +00:00
Rolf Kalbermatter 18514ca547 Fix bug found by Piotr Caban, where our function tried to delete a
directory eventhough the user canceled the operation.
2004-10-06 00:04:39 +00:00
Mike McCormack 22442cd880 Clean up messy comment in SHFileOperation.
Reduce the number of goto labels in SHFileOperation by one.
2004-08-16 19:57:05 +00:00
Francois Gouget f8e01efb3d Assorted spelling fixes. 2004-07-23 23:02:09 +00:00
Ge van Geldorp c390bb2aea Match prototypes to Platform SDK. 2004-06-28 20:32:53 +00:00
Ulrich Czekalla d886064101 Implemented RealDriveType. 2004-06-14 16:56:39 +00:00
Francois Gouget 52c0832161 Make Unicode strings static const. 2004-04-20 01:12:17 +00:00
Patrik Stridvall ede82e3055 Fixed some issues found by winapi_check. 2004-02-20 20:19:23 +00:00
Francois Gouget 6b6ed724ae Add missing '\n's to debug traces. 2004-01-27 00:01:43 +00:00
Martin Fuchs c0a5a27c15 Correct return type of SHFileOperationA/W. 2004-01-05 21:13:37 +00:00
Rolf Kalbermatter c4bba67a9a Fix a return value in SHFileOperation and add some extra tests to
internal helper functions necessary to deal with shortcomings of
kernel32 functions for the time being.
2003-09-27 03:47:35 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Rolf Kalbermatter 514521bfaf Make the different helper functions all return actual error codes.
Avoid code duplication between ANSI and Unicode variant of those
functions.
2003-09-02 18:12:44 +00:00
Mike McCormack c2bd211b4c Remove useless comments that clutter the code. 2003-08-21 21:26:23 +00:00
Patrik Stridvall ba78aac406 Fixed some issues found by winapi_check. 2003-08-08 21:07:23 +00:00
Mike McCormack bd69422ca8 Clean up SHFileOperationA/W debugging a little. 2003-05-11 03:31:08 +00:00
Rolf Kalbermatter b74beada5a Fix some typos and a memory leak in SHFileOperationA. 2003-04-26 02:05:39 +00:00
Rolf Kalbermatter a25967c92a Reimplement SHFileOperation in Unicode, based on the work of Dietrich
Teickner.
2003-04-19 20:09:09 +00:00
Rolf Kalbermatter 830d3d778f Implement some more Win API functions and add support functions for
coming changes to SHFileOperation.
2003-03-21 21:23:33 +00:00
Jon Griffiths cd4234aa49 Documentation updates. 2003-03-18 18:35:48 +00:00
Rolf Kalbermatter d11efe88b9 Change SHCreateDirectory and Win32DeleteFile to be Unicode or ANSI depending
on OS version. Add ShCreateDirectoryEx API.
2003-02-01 00:41:30 +00:00
Rolf Kalbermatter 49e1b69172 Change SHChangeNotify to be Unicode and ANSI indifferent, as the type
of parameters is really defined by uFlags parameter.
2003-01-21 19:36:24 +00:00
Rolf Kalbermatter 7df7cdb6e2 Introduced some declarations and resources needed for a more complete
implementation of SHFileOperation.
2002-12-19 04:11:22 +00:00
Rolf Kalbermatter e56d618613 Make some shell32 files compile in MSVC. 2002-12-16 22:40:34 +00:00
Andriy Palamarchuk 686e46b43f SHFileOperationA: improved, implemented FO_MOVE action, added more
conformance tests.
2002-09-04 18:46:29 +00:00
Andriy Palamarchuk 5b5bea0362 SHFileOperation: Implemented the FO_RENAME action, fixed FO_DELETE,
implemented unit tests for these two actions.
2002-08-27 01:34:33 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Rein Klazes 6748e6992c In SHFileOperation() when requested to copy files, figure out when the
destination is to be treated as a directory and handle those cases.
2002-02-15 18:20:18 +00:00
Guy Albertelli aafec98803 - Define rest of URL_ESCAPE... and other flags.
- Define implemented interfaces for reg.c and url.c.
2001-11-06 22:31:19 +00:00
Alexandre Julliard 3954117ce4 Moved undocshell.h to dlls/shell32. Removed shell16.h. 2001-08-16 18:49:56 +00:00
Patrik Stridvall 8b216b3d02 Documentation ordinal fixes. 2001-06-19 18:20:47 +00:00