Commit Graph

3946 Commits

Author SHA1 Message Date
Piotr Caban ddcab8acea comctl32: Set listview focus in WM_LBUTTONDOWN.
This patch reverts commit 098dc7b330 and
moves focus setting after LVN_ITEMCHANGED notification is sent. Writing
tests for it is tricky because native blocks inside WM_LBUTTONDOWN message.

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:04 +09:00
Vincent Povirk 45e706a2a7 comctl32/tests: Accept touchscreen-related messages in button tests.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-26 00:12:51 +09:00
Nikolay Sivov 1d19eb15d4 comctl32: Item with negative cChildren acts as if it actually had children.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-24 00:25:04 +09:00
Nikolay Sivov 8d0f060f3b comctl32/treeview: Use consistent format for hex values in traces.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-24 00:25:03 +09:00
Bruno Jesus 2f5c0b9321 comctl32: Respect an assert in TREEVIEW_RemoveAllChildren.
Signed-off-by: Bruno Jesus <00cpxxx@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-24 00:25:02 +09:00
Dmitry Timoshkov acc1092ea9 comctl32/tests: Add a test for system class properties.
This is basically a copy of user32/class.c test.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-23 23:35:17 +09:00
Aric Stewart bcefe114e8 comctl32: ILC_COLORDDB imagelists can be created with 0 sizes.
Negative values are still invalid.

Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-20 22:19:29 +09:00
Hugh McMaster 11669fa5e2 Assorted spelling and grammar fixes.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
Nikolay Sivov eb6a872273 comctl32/tests: Enable visual tests in interactive mode, fix build failure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-16 17:13:40 +09:00
Nikolay Sivov 1b5aaa1639 comctl32/tests: Test more return values (Clang).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-12 11:29:19 +09:00
Jacek Caban 67819d6ee9 comctl32: Don't use comparisons to FALSE.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-10 11:53:20 +09:00
Nikolay Sivov 60fedd23f9 comctl32: Protect TVM_GETITEM from invalid item pointers.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-05 00:03:34 +09:00
Piotr Caban 7d6ca63154 comctl32/tests: Flush events in listview tests after setting foreground window.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-04 14:41:38 +09:00
Stefan Dösinger 4e2d25c7cd comctl32: Re-enable the parent before destroying the dialog.
Prevent 1602 AD from minimizing when the multiplayer dialog is
closed. When DestroyWindow is called, user32 tries to find a window to
activate, finds the main game window disabled and decides to go to the
desktop. Wined3d will help this process by minimizing the game out of
the way.

Signed-off-by: Stefan Dösinger <stefan@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-02 23:02:23 +09:00
Nikolay Sivov 7a59b27f4d comctl32/listview: Fix printf format (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-28 22:31:32 +09:00
Dmitry Timoshkov 59cca65ce0 comctl32: Always call BeginPaint/EndPaint when handling a WM_PAINT message for the button.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:35 +09:00
Nikolay Sivov e0c421ff62 comctl32/syslink: Simplify conditional expression (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
Nikolay Sivov 83a652a9d4 include: Add a couple of documented Toolbar messages definitions.
Thanks to Alan Feldman for pointing this out.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:20:56 +09:00
Nikolay Sivov 490b4eec4b comctl32/tests: Fix function prototype (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-14 12:46:13 +09:00
Nikolay Sivov 680ba9330e comctl32/imagelist: Use proper type for return variable (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-14 12:45:43 +09:00
Michael Stefaniuc 88531272ce comctl32/tests: IDI_APPLICATION is already an INTRESOURCE (PVS-Studio).
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 22:24:56 +09:00
Michael Stefaniuc a16a270751 comctl32/tests: WC_DIALOG is already an INTATOM (PVS-Studio).
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 22:24:52 +09:00
Piotr Caban 9c87c7e76d comctl32: Don't use uninitialized LVITEM fields in LISTVIEW_InsertItemT when LVS_EX_CHECKBOXES was specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Alex Henrie c565145b0e comctl32: Remove redundant if (button) statements.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Piotr Caban aa39614e77 comctl32: Test TrackMouseEvent flags when LVS_EX_ONECLICKACTIVATE style is used.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Piotr Caban 4dd26ee814 comctl32: Don't ask for WM_MOUSEHOVER messages when LVS_EX_TRACKSELECT was not specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Michael Müller 1e2c0a3029 comctl32/tests: Add tests for LoadIconMetric function.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
Michael Müller 088eb87e3b comctl32: Add implementation for LoadIconMetric.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
Michael Müller c098c13ee2 comctl32: Add semi-stub implementation for LoadIconWithScaleDown.
Thanks to Nikolay Sivov and Alistair Leslie-Hughes for various comments
and ideas for improvements.

Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:54 +09:00
Huw Davies 4f06425a03 comctl32: Set the item size after LISTVIEW_ScrollColumns().
LISTVIEW_ScrollColumns() increments the item width by the scroll
delta, so we need the original width to still be present.
2015-09-08 14:48:09 +09:00
André Hentschel 80f887a064 comctl32/tests: Add ARM and ARM64 arch strings. 2015-08-12 22:52:24 +09:00
Francois Gouget f8a7d6ed74 Assorted spelling fixes. 2015-08-07 23:50:48 +09:00
Huw Davies f6653a93eb comctl32/tests: Extra WM_PAINT messages are occasionally sent on Vista and Win 7. 2015-07-06 20:08:21 +09:00
Huw Davies 2a71d13b6b comctl32: Implement the legacy notifications during restore. 2015-07-02 16:54:01 +09:00
Huw Davies 6c95445559 comctl32: Set the default separator width when notifying a -ve cmd id. 2015-07-02 16:53:58 +09:00
Huw Davies eddfefa54f comctl32: Reset the string and lparam fields between notifications. 2015-07-01 19:18:27 +09:00
Huw Davies 96a6184c30 comctl32: All negative entries in the toolbar save state are special cases. 2015-07-01 19:18:27 +09:00
Huw Davies 77ed3733af comctl32: The number of buttons is set by the first TBN_RESTORE notification. 2015-07-01 19:18:27 +09:00
Huw Davies 063c7866f5 comctl32: Implement toolbar saving. 2015-07-01 19:18:26 +09:00
Huw Davies 199f51ff78 comctl32: Don't leak button text. 2015-07-01 19:18:26 +09:00
Huw Davies 01cd45cce1 comctl32: Add a helper to free button text. 2015-07-01 19:18:25 +09:00
Huw Davies a29b6958e1 comctl32: Add helpers to set the button text. 2015-07-01 19:18:25 +09:00
Nikolay Sivov 035d0a1594 comctl32/monthcal: Fix title to use properly localized year/month format. 2015-06-18 21:41:02 +09:00
Bernhard Übelacker ccf2ea6179 comctl32/tests: Free memory used by property sheet page (Valgrind). 2015-06-18 21:41:02 +09:00
Nikolay Sivov b7969dfd94 comctl32/toolbar: Remove always true condition (Coverity). 2015-06-03 19:29:49 +09:00
Mark Harmstone bae599092a comctl32: Use DPI settings for checkbox size. 2015-05-25 14:34:07 +09:00
Huw Davies a1d54447b8 comctl32/tests: Skip the hover tests if the listview's parent is not the foreground window. 2015-05-21 20:01:29 +09:00
Huw Davies 5c4dc9fc56 comctl32: Fix a typo in the TB_SAVERESTOREA handler. 2015-05-20 22:10:07 +09:00
Huw Davies 0634f3b409 comctl32: If necessary add the width of a dropdown arrow while wrapping.
This also fixes the layout code for the BTNS_WHOLEDROPDOWN case.
2015-05-19 22:57:36 +09:00
Huw Davies 797f42699e comctl32: Wrap the buttons inside the toolbar's client rect.
The toolbar need not be the same width as the parent.
2015-05-19 22:57:27 +09:00